office-gobmx/basic/source/sbx
Stephan Bergmann 16e3b84d2e Improve loplugin:dyncastvisibility to check for non-inline key functions
This would have caught the issue discussed in
709b1f3ddb "Make sure VCLXPopupMenu has unique
RTTI".  (The commit message talks about RTTI there, while what Clang actually
compared for an optimized implementation of a dynamic_cast to a final class is
vtable pointers, but the overall picture remains the same.  Both RTTI and
vtables are emitted along the key function, and if that is missing or inline,
they are emitted for each dynamic library individually, and as internal symbols
on macOS.)

This commit also addresses all the issues found by the improved
loplugin:dyncastvisibility on Linux.  See the newly added TODO in
compilerplugins/clang/dyncastvisibility.cxx and
86b86ac87e "Give DocumentEventHolder (aka
EventHolder<DocumentEvent>) a key function" for an issue with key functions for
class template instantiations.

Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
2024-11-14 12:49:22 +01:00
..
sbxarray.cxx
sbxbase.cxx
sbxbool.cxx
sbxbyte.cxx
sbxchar.cxx
sbxcoll.cxx
sbxconv.hxx
sbxcurr.cxx
sbxdate.cxx
sbxdbl.cxx
sbxdec.cxx
sbxdec.hxx
sbxexec.cxx
sbxform.cxx
sbxint.cxx
sbxlng.cxx
sbxobj.cxx
sbxres.cxx
sbxres.hxx
sbxscan.cxx
sbxsng.cxx
sbxstr.cxx
sbxuint.cxx
sbxulng.cxx
sbxvalue.cxx tdf#163486: PVS: Identical branches 2024-11-12 01:35:14 +01:00
sbxvar.cxx Improve loplugin:dyncastvisibility to check for non-inline key functions 2024-11-14 12:49:22 +01:00