office-gobmx/sd
Stephan Bergmann b512ce255f Make upcasting css::uno::Reference ctor require complete types
The main reason for the "home-grown" UpCast introduced with
904b3d1fce "Up-cast conversion constructor for
css::uno::Reference" in 2013 was probably that we could not yet rely on C++11
std::is_base_of back then.  A (welcome) side effect was that the derived class
could be incomplete.

However, specializations of UpCast relying on whether or not T2 is incomplete
are obviously an ODR violation if the type is incomplete in some TUs and
complete (and derived from T1) in others.  And even if UpCast had internal
linkage, it would still be brittle that its behavior depends on the completeness
of T2 at the point of the template's instantiation, and not necessarily at the
point of use.

That means we should better base that ctor on std::is_base_of (which we can do
now since 39a1edd6fe "Make css::uno::Reference
upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on
Clang and GCC if the completeness requirements are not met.  This change fixes
all the cases where types need to be complete now, plus any resulting
loplugin:referencecasting warnings ("the source reference is already a subtype
of the destination reference").

Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27 07:19:30 +02:00
..
inc update pches 2020-04-26 15:34:06 +02:00
qa Fix typo 2020-04-26 16:35:23 +02:00
res tdf#131870 Update elementary & Sukapura buttons 2020-04-23 02:09:23 +02:00
sdi
source Make upcasting css::uno::Reference ctor require complete types 2020-04-27 07:19:30 +02:00
uiconfig weld custom animation panel 2020-04-06 21:24:40 +02:00
util
workben
xml
xsl
AllLangMoTarget_sd.mk
CppunitTest_sd_activex_controls_tests.mk
CppunitTest_sd_dialogs_test.mk
CppunitTest_sd_export_ooxml1.mk
CppunitTest_sd_export_ooxml2.mk
CppunitTest_sd_export_tests.mk
CppunitTest_sd_filters_test.mk
CppunitTest_sd_html_export_tests.mk
CppunitTest_sd_import_tests.mk
CppunitTest_sd_import_tests_smartart.mk
CppunitTest_sd_misc_tests.mk
CppunitTest_sd_svg_export_tests.mk
CppunitTest_sd_tiledrendering.mk
CppunitTest_sd_uiimpress.mk
CppunitTest_sd_uimpress.mk
IwyuFilter_sd.yaml
JunitTest_sd_unoapi.mk
Library_sd.mk weld custom animation panel 2020-04-06 21:24:40 +02:00
Library_sdd.mk
Library_sdfilt.mk
Library_sdui.mk
Makefile
Module_sd.mk
Package_opengl.mk
Package_web.mk tdf#131870 update button icons add elementary and sukapura 2020-04-07 11:28:26 +02:00
Package_xml.mk
README
README_REMOTE
UIConfig_sdraw.mk
UIConfig_simpress.mk
UITest_impress_tests.mk
UITest_sd_findReplace.mk

The core directory for the impress/draw applications.

Think of impress as a hack on top of draw.


sd module contains impress/draw specific code, non-shared UI and part
of ppt and pptx filter, few other filters too.

the slideshow UI lives here as well, the slideshow engine is in
slideshow module though (including the 3D transitions engine
slideshow/source/engine/opengl).

the most used filters are ODF's odp, binary ppt and OOXML's
pptx. their locations are listed below:

 * odp import and export filters are in xmloff module (mostly xmloff/source/draw)

 * ppt import is in sd/source/filter/ppt (big shared chunks are also in svx)
 * ppt export is in sd/source/filter/eppt (big shared chunks are also in svx)

 * pptx import is in oox/source/ppt (and uses a lot of
   oox/source/drawingml and oox/source/*)
 * pptx export is in sd/source/filter/eppt (mostly in pptx-* source
   files) and shared part is in oox/source/export

== PPTX export/import filters ==

PPTX export filter is split into 2 parts. Impress related part is in
sd/source/filter/eppt/pptx-* and the other part is in
oox/source/export/ because it contains mostly code related to
DrawingML, which is shared with writer and calc ooxml export.

The export filter was written in 2009 IIRC and was not much extended
feature-wise lately.

FUTURE work: add custom shapes export (see below). enhance text
output, we don't write text style for indentation levels now, need to
export a:lvl1pPr, a:lvl2pPr, ... elements.

PPTX import was written by Sun/Oracle and then extended in LibreOffice
a lot during bug fixing. It is located in oox/source/ppt and
oox/source/drawingml. The areas with most bugs (at least until today)
were shape placeholders and text style inheritance.