3901e029bd
Communicate Kashida insertion positions in an explicit way. Rest of LibreOffice communicate adjustments to character widths (e.g. for justification or spacing) using so-called DX array. DX array is an array of absolute character positions (e.g. DX[n] is the position after character n from the start of the lines, and its widths is DX[n] - DX[n-1]). This DX array is modified also when Kashidas are inserted after a given character for Arabic justification, by expanding its width. VCL would use this to know where to insert the Kashidas and how many ones. But because DX array is used for both widths adjustments and kashida insertion, this turns out to be a source of bugs since VCL has tosecond guess the DX array to find which is pure width adjustment and which also involves Kashida insertion, and the heuristics it uses are fragile. This change adds a second array of booleans that records where Kashida is inserted and communicates it all the way from where Kashida insertion is decoded in Writer and down to VCL layout. This change passes the Kashida array only when it seems necessary (e.g. during drawing but not when measuring text since the DX array is enough in this case). Hopefully no places where Kashida insertion needs to be passed down were missed. A couple of glyph and layout flags that were used for old heuristics and no longer needed and are removed. This also fixes: tdf#87731 tdf#106309 tdf#108604 tdf#112849 tdf#114257 tdf#127176 tdf#145647 tdf#146199 Change-Id: I4ed0850ef2fdc3e9143341afac649e7e7d463c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> |
||
|---|---|---|
| .. | ||
| inc | ||
| langsupport | ||
| qa | ||
| source | ||
| uiconfig/ui | ||
| util | ||
| AllLangMoTarget_svt.mk | ||
| CppunitTest_svtools_dialogs_test.mk | ||
| CppunitTest_svtools_graphic.mk | ||
| CppunitTest_svtools_html.mk | ||
| Executable_langsupport.mk | ||
| IwyuFilter_svtools.yaml | ||
| JunitTest_svtools_unoapi.mk | ||
| Library_svt.mk | ||
| Makefile | ||
| Module_svtools.mk | ||
| README.md | ||
| UIConfig_svt.mk | ||
Tools on the Top of VCL
Common dialogs, file and print dialogs, wizards, vcl filters, lots of helper code.