Without this, the app crashes with exotic locales.
Change-Id: Ia0e4ffe6e8ed512c2a0402819b84d9563d17b0f6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87786
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
The mobile wizard would not perform any actions
if opened when the mobile keyboard is visible
Change-Id: Id8722b551ea6c13f3fe22b78c996e2bb4b2db2f8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87712
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
The document object has already prevented default actions
Change-Id: I4d60ec0c6915ca266f3e2c24f0958127186ca970
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87752
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
They are no longer used instead of the Hammer recognizer library
Change-Id: Ied076c5731dcaeca37e1a15b6b637cbb62250b20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87751
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Unfortunately the emulate 'context menu' conflict with the default
horizontal scroll behavior
Change-Id: I3cd45520a6f1e00460031b78e4963db59bc9ae59
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87750
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Change-Id: If137e015930f3918d230a86b6e2940747389ec5d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87746
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
This renaming will allow the mobile wizard to be able to find the
svg images/icons corresponding to the uno command
affected context menu/Mobile wizard:
Row header
Column header
Sheet tabs
Change-Id: I94198096085ebe1f482a70d84c8399c34f9e0ea0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87713
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This now failed under sanitizers due to a timeout. Double the limit;
asan typically causes a 2x slowdown.
Change-Id: I943c6f900371ff4c05c760d3d993829d54264941
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87716
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
By now, we only emulate mobile layout, but we are using
simple mouse events (click, rightclick), not touch events.
Later it might worth to investigate, how to emulate touch
events.
Change-Id: Ib7d032933c50221173bbc749f0653d7d777884b1
- realign plus icon
- readjust top elements' position
- avoiding changing border from #toolbar-wrapper as this would affect readonly mode
Change-Id: I010aaa7b3bd25bce1fe386854c0a7cd0b9c7331e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87675
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
select any row/column now try to open the context menu
by right-clicking row/column header and perform some action
Action will be performed on the originally selected row/column
(same goes with the mobile wizard)
Change-Id: I2d2a7f871b1562d4706e9ea1e4382968a4502583
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87658
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
This patch fixes non-showing character properties
on calc, also a bit improved the related function
in terms of performance.
Change-Id: Iba3f32ec5322225dd0d34bb56173151c52156564
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87610
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Under Cell Appearance properties, cellbordertype, borderlinestyle,
borderlinecolor items are removed due to not working properly.
Change-Id: I56fd71355051a0b1dc20f6dc86090e2f35520b3a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87608
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
This reverts commit 2f861612e9,
which caused the formula bar to be hidden, and rows to get
misaligned on tablets.
Change-Id: I14826fccb23283e3f7462eee7aeb43fb6d2eaeaa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87568
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
On mobile, we now do not show the keyboard by default
when the user taps the cell in Calc or a text-area in Impress.
Instead, the user should double-tap. This is especially useful
when the user selects the cell on first tap, then double-tap to edit.
As for Impress, editing-mode is enabled only by double-clicking,
so showing the keyboard on mobile on single tap is not helpful
as the user can't edit just yet. So it makes sense to show
the keyboard only on double-tap, when the slide is in text
editing mode.
On desktop and for other document the behavior is unchanged.
Change-Id: I4206291f60656391d061387f7bbad1b6e3caf80d
Impress toolbar now reflects the state of the sidebar.
All sidebars now show correctly for Impress docs,
except for the properties deck, which conflicts with
the sidebar button.
Change-Id: I8802e5e35b388df20ca21c4f756b4d95197de570
Cookies may be passed from the client to the storage,
in which case each user may have its own unique set
of cookies. These cookies are now preserved in the
ClientSession, which is per connection, and are then
passed to the storage to use when communicating with
the WOPI-like backend.
(cherry picked from commit 6022faf3cc9b622b490c3f8ca91efbff8e542414)
Change-Id: Ic2e13fa541a5ee01b7383939bbbf7d46ea75684b
Use the clipboard code to generate the HTML of
the selected text, so we can check the font properties
in the document.
Change-Id: I43e5325b7fe0a9fda073c43335231e014374d6c2
- Add exeption
- Even if there is no image passed add it manually and adjust HTML sctructure so to be consistent with other menu-entry-with-icon elements
- Add inserttable monochrome icon
- pass optional argument data.id
Change-Id: I34536272d3ef5742895c4db5a52058fe6558f837
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87633
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
In mobile view context menu replaced with wizard for calc column header
Change-Id: I3ea1dfc79815d9fde61d5d22e7a8b09a98a8bc63
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87287
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
In mobile view context menu replaced with wizard for calc row header
Change-Id: Id85eefacbe598a3a041dd92dbe6b3c85e8997b4a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87286
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
only the image button was clickable which was
confusing where to tap on mobile. This patch
changes the hit area to surrounding div instead
Change-Id: Idfa2533b5daaa9df8f288eab5f9bb4b9e861d822
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87609
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Change-Id: I095c23c086c026995d1433e9f3efc1adfef2a8cd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87601
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
after new callback function route for the mobile wizard,
noneexisting images were being added to menu
Change-Id: Iec3f817cc218d7a4cb9b92370f092fdf6dc18d70
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87228
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
