On non-Linux systems we should default to std:🧵:id
which needs to be serialized using ostream interface.
While Util::getThreadId does specialize for Linux, the
code using it doesn't always handle the different return
types.
While std:🧵:id is the standard interface to the
thread ID, using such abstraction has proven to be costly
when converting the thread ID on each and every log via
ostringstream (due to the cost of memory allocation).
In practice Linux is the primary and so far only platform,
so the getThreadId is optimized for it. Other systems
can either use the default std:🧵:id, or can also
specialize as necessary.
Change-Id: I91cf279a8fdff12636a534957db5069dee51bd65
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This is not allowed by the standard and libc++ is more stricter than libstdc++ on that matter.
Luckily, the conversion is used to turn it into a string, so just use stringstream to convert the thread::id directly.
Signed-off-by: Gleb Popov <6yearold@gmail.com>
Change-Id: Iea1a844a086b7fe7ed4703fd06e1d538d5d0bc43
We use simple cy.click() on mobile, we might
get a better result to use a different way for
tap on document in the future.
Change-Id: I4b0c6989aaf105ae79be930ffc54898414efb92a
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It is possible for the jail directory cleanup
to fail, if there are still references to at
least one file in the jail. In those cases we
keep the jail path around so we can retry the
next time we cleanup a jail. This reduces
the chance of leaking jails until restarting
the service.
Change-Id: If6116ef598afc91063de71c66870bd6426a971ba
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Instead of hard coded test file, we use the admin
console to find out which test document we should
open with the interfering user.
Change-Id: Iedaea07eb558ca6335d8768ab23799bf02d7f4a7
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We have more users running already for one test, better
to avoid side-ffects coming from running more multi-user
test in parallel (they are using the same loolwsd).
Change-Id: I1cbed36a3ffe2825c384b525da361c4cfe781b38
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Create an alias for the iframes, so we don't need
to find them every time, but we can use the
reference to them. It make the log more clear
and also makes things faster.
Change-Id: I6ca21f951568e46cec3d6a574ce1798b522067ea
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It does not work correctly in NC environment.
Change-Id: I1358f0f80aa05ddb118fc1cfd4237a5fac875fcc
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
One is used in Debian-based installs, other is used in the rest.
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: If21c5d70cb8bb738931c3cd05bd4c5c732f394f7
- Fix redundant values and declarations
- while keeping the style the same across different platforms (desktop, tablet)
- while account for different parent's background (notebookbar)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I501cb0137282682980864d980571429ded8cf6c1
It was a mobile only helper method originally
and I forgot to update the name when moved in
into a bigger scope.
Change-Id: I818cbebadba4152afb8e0261015734a232b0e211
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Calc helper methods were improved in the
meantime.
Change-Id: I9c464cd9d23ce4a70fa63d376619458f38cc1389
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This patch will apply for Chromebook cases and also
other keyboard connected android devices as well.
Change-Id: I4d88a65ec49935640be6513498b87718b50977f5
Signed-off-by: mert <mert.tumer@collabora.com>
This will enable notebookbar for tables
smaller devices will continue on classic mode
Change-Id: Ib74b8a0ad161d83300d807fff1fd8b3ffba11399
Signed-off-by: mert <mert.tumer@collabora.com>
There's no built in detection for tablets and
the suggested way to to it by adding resource values
for large screen and checking it.
Change-Id: Ic4a949033e04d244dbb6d441df516203639d5c48
Signed-off-by: mert <mert.tumer@collabora.com>
Change-Id: I387d19a33c5682eef890cc9a9fb0283238ecbde9
Signed-off-by: mert <mert.tumer@collabora.com>
(cherry picked from commit 1bda946b1c48608026ed07848a05ced664cc61e8)
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I2447d2662c4c092ae938794c3bbfff134df02710
Signed-off-by: mert <mert.tumer@collabora.com>
(cherry picked from commit cc163ee0ce252459ed7244c6b27b28d4cea259f1)
Signed-off-by: Tor Lillqvist <tml@collabora.com>
