Commit graph

15612 commits

Author SHA1 Message Date
Gökay Şatır
469b18877e Draw Comments: Run show/hide comments for drawing.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I3a1a85f8623d26f7a195fd2dba9dcc73facc3568
2021-07-09 21:05:40 +03:00
Gökay Şatır
f65fcce2e1 Impress Comments: Bugs solved.
Show & hide comments function is improved.
onlostfocusreply function is improved.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ie63dc27a8cf5754a094ce14c2446a758848fb197
2021-07-09 21:05:40 +03:00
Gökay Şatır
353f866f08 Calc Comments: Improvements.
Scroll to comment's position.
Solve "content not shown" bug.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id62d7407bc66c5fd17590c37f3fdd01246cbe245
2021-07-09 21:05:40 +03:00
Gökay Şatır
c7a1adfd44 CommentListSection: Hide when unnecessary.
When file type is spreadsheet or there or no comments or it is mobile
view.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I54e02b644ae62efeb5bd9917f99e86d3e90f1bea
2021-07-09 21:05:40 +03:00
Gökay Şatır
eabbb8c553 Calc: Adjus Column header width.
According to commentList section.

CommentListSection will not be shown on Calc, if it was shown it would
be ok.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I362d2ad490712b3958ed7c6fe3c04816d0e7a48f
2021-07-09 21:05:40 +03:00
Gökay Şatır
6e16068b1f Writer: Bugs related to comments solved.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ifcf3b53c1fc106cb412f953008aa0666bccaf51c
2021-07-09 21:05:40 +03:00
Gökay Şatır
a71276fcc4 CanvasTileLayer: Remove unused functions.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I9624c161f667a184bd9fc4b2463a755284a0754b
2021-07-09 21:05:40 +03:00
Gökay Şatır
036c12e182 Writer: Use the same svg for highlighting.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ife94ce6fb342543552177cb3a22b7f3b8e33e824
2021-07-09 21:05:40 +03:00
Gökay Şatır
6e83f0ffa8 Remove AnnotationManagerImpress and AnnotationManagerBase files.
They are replaced by CommentListSection.ts.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I85f9ae49e487fa621376a79812774c1ea2615e9e
2021-07-09 21:05:40 +03:00
Gökay Şatır
fa6a84bb40 Annotation.js: Remove.
It is replaced by CommentSection.ts.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I02338b56e788188c55a1254a69f21943624e5d43
2021-07-09 21:05:40 +03:00
Gökay Şatır
534facef7a Comments: Rename files.
CommentSection => CommentListSection
Comment => CommentSection

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib90120059330b6969d608be4f4db2a7fe302adc5
2021-07-09 21:05:40 +03:00
Gökay Şatır
3a362f68ce Calc: Activate comment section for mobile.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I0dcc6edfd33209d031e1ff20d81aaedaee6f9016
2021-07-09 21:05:40 +03:00
Gökay Şatır
d77ac3e050 CanvasSectionContainer: Enable opacity for background.
Sections can set opacity for their background colors.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I04a0d7e84fc66e4757e4f4053effd8b843acaf94
2021-07-09 21:05:40 +03:00
Gökay Şatır
1e42791ba7 Calc: Activate commentList section for desktop.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I80fab4624770a89fb742c1cffaf96edc24d5963e
2021-07-09 21:05:40 +03:00
Gökay Şatır
bc54b1d12c Calc: Add cellCursor global variable.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I8314367ed87742cedd02f0c60cee1ad9b748b4ec
2021-07-09 21:05:40 +03:00
Gökay Şatır
a9472bd06b CommentSection: Disable doLayout for Calc.
And remove unused variable.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I979cf084fa8169789d4a32684ccc0c7de046b911
2021-07-09 21:05:40 +03:00
Gökay Şatır
5267a4ba25 CommentSection: Enable mobile view for drawing.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id49b6243a3662dcdb1ba909b86213eb3a3c07a5a
2021-07-09 21:05:40 +03:00
Gökay Şatır
ac4fec12a4 Comment.ts: Remove commented code.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I75747144e4949de7f1a2e9605d7bfba08bda9e25
2021-07-09 21:05:40 +03:00
Gökay Şatır
7b471f70fd Mobile wizard: Adjust for flex view.
Scroll bar wasn't visible on hamburget menu.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I204b8a60d5b813de5735dbe741b861460a039f30
2021-07-09 21:05:40 +03:00
Gökay Şatır
2bb25ed742 Comments mobile: Hide them while wizard is closed.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I2d42a765a106605c5b6b1582ea4929b59aae7d06
2021-07-09 21:05:40 +03:00
Gökay Şatır
bf9abab883 ImpressTileLayer: Remove unused function.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: If8489bd00924e426179d52a1055b1edf53df4b0a
2021-07-09 21:05:40 +03:00
Gökay Şatır
2f4e4553b1 Impress: Activate comments on mobile.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id4faf1f5acecae49854adb6687377b73e70555e6
2021-07-09 21:05:40 +03:00
Gökay Şatır
78fe4887e1 CanvasTileLayer: Remove redraw call.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I92930e3590ecade0dac3340e5476317b03910d09
2021-07-09 21:05:40 +03:00
Gökay Şatır
37ef68aa43 FileBasedView: Solve flickering.
Deciding to remove a tile needs a different approach in file based view.
Because viewed tiles are not sync with core side.

Also, while refreshing a tile, clearing the target part was causing
flickering.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I7067fb014fedb571440c545b3b5358922325ed7c
2021-07-09 21:05:40 +03:00
Gökay Şatır
6f28cf574f CanvasSectionContainer: Remove debugging color.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I67d524569208ef124b78d209d168d7e8129083a9
2021-07-09 21:05:40 +03:00
Gökay Şatır
8131ea6463 FileBasedView: Set part before deleting a comment.
The comment to delete is searched inside the selected part on the core
side. We need to indicate the comment's part before we delete it.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I248aa375ca6bcb6a1ff6b0456bd1943319147e00
2021-07-09 21:05:40 +03:00
Gökay Şatır
eaf3772489 CanvasTileLayer: Scroll to part when needed.
For file based view.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I4902090ccf96dc834d8792c1637dd1a8833cc20f
2021-07-09 21:05:40 +03:00
Gökay Şatır
e6ea17e1a0 FileBasedView: Refresh the tiles.
There is an issue due to invalidation of selected part of the file,
we will refresh the view when needed.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ifd6d183d04497d86930ae16ab96f322defbdfef6
2021-07-09 21:05:40 +03:00
Gökay Şatır
70ed83f615 CanvasTileLayer: Calculate most visible part.
When using fileBasedView, multiple parts are drawn on the screen.
If user wants to add a comment into the file, we should find the part to
which add comment into.

In this case, the part with most visible tiles is chosen for adding the
comment into.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I22768f25717f2d2d87b31dda7a87ab801cc8964b
2021-07-09 21:05:40 +03:00
Gökay Şatır
f0a14a820e ImpressTileLayer: Remove unused code.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ided63eebe912f1d346737ccddbd3c03c96e5ca41
2021-07-09 21:05:40 +03:00
Gökay Şatır
b8a3c8bff9 Draw: Improvements for comments in fileBasedView.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I8c00e7b6267f06a956ff8df42812cb49b4e37b8b
2021-07-09 21:05:40 +03:00
Gökay Şatır
597f8defa5 AnnotationManager.js: Remove.
It was used for Writer. We now have CommentSection.ts and Comment.ts
files.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ia2dcf98c17260126c8fb0d4888b3e08efb4639d9
2021-07-09 21:05:40 +03:00
Gökay Şatır
c1c1ea9fbc Comments: Finalize for mobile writer.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic5e24635fb4a83d314c521cb7650e7d18668550d
2021-07-09 21:05:40 +03:00
Gökay Şatır
8261b4228e MobileWizard: Comments.
Reuse same html element for mobile wizard and desktop view.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic2843832b55686ca013f5f115759277dbab2e118
2021-07-09 21:05:40 +03:00
Gökay Şatır
ffd7cd03a0 Writer mobile: Activate comment list.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I5e52a2d979a8fe5ef93d281cdfa103a2c21e20a6
2021-07-09 21:05:40 +03:00
Gökay Şatır
a7f57fd926 CommentSection: Remove map.layer commands.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ifd19d2a7d395602e72f371bcbaa912b6f33b00b2
2021-07-09 21:05:40 +03:00
Gökay Şatır
3510e38958 Comment Writer: Use pixels for commented text rectangles.
SVG elements were bound to map element, which we are removing slowly.
Now svg elements are bound to document-container for consistency.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I04bed2042d9751ac14080952251ae7e5fb68892b
2021-07-09 21:05:40 +03:00
Gökay Şatır
b264076450 CanvasSectionContainer: Don't send position as an object reference.
Sections may play with them, so sections that come next, may get wrong values.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I737aa4fbcfe8f1e8dc8cf117f474d7de5b3682ad
2021-07-09 21:05:40 +03:00
Gökay Şatır
afd741456e WriterTileLayer: Clear comment list before filling.
Sometimes core side sends the comment list twice at start.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I85e615a3d6a6ebc874eacebb36ef0f66ce85247d
2021-07-09 21:05:40 +03:00
Gökay Şatır
66990c906d PolyUtil.js: Allow using non-converted coordinates.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I5f04b007ecb24b0116c99947cd801775e1e46fc0
2021-07-09 21:05:40 +03:00
Gökay Şatır
3352f58021 WriterTileLayer: Remove unused & commented code.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ibc702d6d42c7f3399f08c959a1f59ccad314ab1f
2021-07-09 21:05:40 +03:00
Gökay Şatır
13ec252d13 Comment Section: Activate for writer desktop.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic4816da3ff80bd09aa421164012e69e97dc00dd2
2021-07-09 21:05:40 +03:00
Gökay Şatır
fad260f015 CanvasSectionContainer: Add a new getter function.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I63820143b5ff0a16346e758c670e0e3f409385b8
2021-07-09 21:05:40 +03:00
Gökay Şatır
fa1ce22846 Redesign scroll section for view.size.pixels.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I62116f99650465c0634aadd0ae57147c9d5c0269
2021-07-09 21:05:40 +03:00
Gökay Şatır
463bb1fca7 Ruler.js: Remove unused code.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Iac7a9c018d97a19c488f63b4346a175f7022c7cb
2021-07-09 21:05:40 +03:00
Gökay Şatır
e8dd0a10a0 global.js: Remove wrong comment from file.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I50641161171879b6a44a4179f93853562be5603f
2021-07-09 21:05:40 +03:00
Gökay Şatır
fbb180c2c3 Style: zIndex adjustments for comment list.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I4eafe53d0879e278c48e9168163cad91227aea0c
2021-07-09 21:05:40 +03:00
Gökay Şatır
35c9cd9f27 Implement Comment.ts file.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id452509de5426392e95d36c40ce4bbb5882f9175
2021-07-09 21:05:40 +03:00
Gökay Şatır
2b8f9e1b45 Implement CommentSection.ts
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id943cadff3527b3938f4fc96dfe438e25288fcd7
2021-07-09 21:05:40 +03:00
Gökay Şatır
adadf3da8e Add comment document object.
This will be worked on. This is just the initial commit.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I6fa3449c4191b63a4ec058a27beda742881dd7cb
2021-07-09 21:05:40 +03:00