strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
15612 commits 1 branch 0 tags 244 MiB
Commit graph

15612 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gökay Şatır
0a6f7cbee2 Writer: Update top toolbar spec for comments. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Icc314e6e0936016102f1f98bb80067e733ff1279
 2021-07-09 21:05:40 +03:00
Gökay Şatır
978ed661b1 CommentSection: Update onRemove function. 
There is a buggy behaviour. Needed this workaround for now.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: If9be41ee5b0a9d8a636d078bd764ea9bbf6c1946
 2021-07-09 21:05:40 +03:00
Gökay Şatır
53027b4c40 Writer Mobile: Integrate comments with cypress tests. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ie6878c9ec606103e25afde1b60145e6b50291c7b
 2021-07-09 21:05:40 +03:00
Gökay Şatır
f82f70ad0b Calc Mobile: Integrate with cypress tests for comments. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: If18ad7fa42b5323370a7451444ae92cd3ef648c3
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
 2021-07-09 21:05:40 +03:00
Gökay Şatır
c16cbefbf3 Calc: Integrate cypress tests with comments. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I6c4e7075f2341ba546f50dd0523882a401af3f42
 2021-07-09 21:05:40 +03:00
Gökay Şatır
e059ede2ca Impress: Re-activate comment scrolling. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Iff75586ac9ccff05990e6f3b7091b4cad964b2ea
 2021-07-09 21:05:40 +03:00
Gökay Şatır
d96bdb3ed8 Cypress Impress: Use ids instead of class names. 
For testing comments.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I7124aac8f1f625db5e320483e1f72e0e6ada1ac6
 2021-07-09 21:05:40 +03:00
Gökay Şatır
3317c62ae8 CommentListSection: Adjust comment arrow's length. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I970f0802da7eaa3edf5d779805ff61f22e5670ac
 2021-07-09 21:05:40 +03:00
Gökay Şatır
0d57d960e6 CommentListSection: Sync tile pane size after resizing the section. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Icd4eaf198cd47581f2f19e76ef69848928a7d828
 2021-07-09 21:05:40 +03:00
Gökay Şatır
bbf28d7c6f PDF: Change the color of the selected part highlighter. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I2a8220f62ad20d813866ece083876f1ef1017db1
 2021-07-09 21:05:40 +03:00
Gökay Şatır
bc0a4c4341 Writer: Cypress test integration. 
Make cpyress tests for comments use ids instead of classes.

Increase the width of the comment section so comment menu is visible
while the sidebar is open.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I17a81d15c440cd198eb02086be3d9fc65487d9f8
 2021-07-09 21:05:40 +03:00
Gökay Şatır
9068c8d1ca CommentListSection: Hide arrow after a comment is deleted. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I011a9eb7bb2725e477b1b65d78ee9b7848db204d
 2021-07-09 21:05:40 +03:00
Gökay Şatır
8d069227a4 CommentSection: Remove unused Hammer event. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Iede0cc25f6abc018adf67093533567e3958063cf
 2021-07-09 21:05:40 +03:00
Gökay Şatır
0cbd7bf5da Comments: Show them regardless of selected part in fileBasedView. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I3d0a79041b816aa17fe5b07dd2f00ef189f4a92b
 2021-07-09 21:05:40 +03:00
Gökay Şatır
2f3974e1ee ScrollSection: Return real scroll size instead of minimum size. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I9ded22959d172a46c8d9f86cb7703824cd5cad72
 2021-07-09 21:05:40 +03:00
Gökay Şatır
8e24d03141 FileBasedView: Highlight current part. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: If03672eb440be8856892f91881215fb30cbc7c86
 2021-07-09 21:05:40 +03:00
Gökay Şatır
6db9771896 CanvasTileLayer: Use el instead of el.src. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ia582f56d33b27bd663d66c8d74dfb83e2e11bfdf
 2021-07-09 21:05:40 +03:00
Gökay Şatır
978b0e6ac6 CanvasTileLayer _onTileMsgFileBasedView: Use same function for coords. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I94ac6814bcb625a9cedd921725ff162cc2596263
 2021-07-09 21:05:40 +03:00
Gökay Şatır
34ff4f1ce3 Tile: Use .el instead of .el.src. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I3ed69b338a5fb57653befe355f93bb6da7d4800c
 2021-07-09 21:05:40 +03:00
Gökay Şatır
26c5720cc1 CommentListSection: Set initial width to zero. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I97c4bcd3e620f43b0c89affb06d4b841ab314523
 2021-07-09 21:05:40 +03:00
Gökay Şatır
a583a3fef7 Remove test pdf files. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic875596fa13ed256b11ab5f864796011a72f57a7
 2021-07-09 21:05:40 +03:00
Gökay Şatır
3df738f308 CalcTileLayer: Handle commentPos event. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I48196be640fc06fcb2ec5fb9bbda51f0af1150e9
 2021-07-09 21:05:40 +03:00
Gökay Şatır
9cb746b684 updateMaxBounds: Use global variables. 
view.size and file.size.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I9d29e8d99ac5bc7d980984fd1ff34340856370b3
 2021-07-09 21:05:40 +03:00
Gökay Şatır
665f63869f app.view.size: Update when file size changes. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I39a64668cbf732201add7e7bee980c88356f6956
 2021-07-09 21:05:40 +03:00
Gökay Şatır
3c48490912 TilesSection: Remove debugging code. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I7c7c8833e599d68721b4a1ec9ef6588097900a4d
 2021-07-09 21:05:40 +03:00
Gökay Şatır
305ddf001c CommentListSection: Move comments closer to the document. 
When view width is small enough.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I10ad0a55ef4c694bf9e989ed9f1b0b528596b0c4
 2021-07-09 21:05:40 +03:00
Gökay Şatır
7c234a78d5 CommentListSection: Set background color. 
Same with CanvasSectionContainer.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib4002ddb534b0e81d67fd1c1e099c84c093eed4c
 2021-07-09 21:05:40 +03:00
Gökay Şatır
9fb8b1951f WriterComments: Remove svg from commented text. 
SVG was still being used for this document type. Now we use canvas for
drawing commented portion of the text.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ibf51b5fbc5862afcbd255a41fe8ec092e12e2531
 2021-07-09 21:05:40 +03:00
Gökay Şatır
db8adee6a0 ScrollSection: Apply windowSection changes. 
Improve sizing.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Iad3fbdb82acbaf2b561219fc57b3ac52b0e065f9
 2021-07-09 21:05:40 +03:00
Gökay Şatır
4eec421c0b CommenListSection: Correct view size calculation. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I977282eccb1a6d008f1b33a66cbd623383ba08d7
 2021-07-09 21:05:40 +03:00
Gökay Şatır
733663f077 CanvasSectionContainer: Improve debugging. 
Draw section borders when applicable.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I7d8494b3a9f5b0ce38518af2889fb7f5cdb03028
 2021-07-09 21:05:40 +03:00
Gökay Şatır
aeeb3cd512 CommentListSection: Remove unused variable. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I313a48c29ededaab3b39bde7365e220e9856f32c
 2021-07-09 21:05:40 +03:00
Gökay Şatır
2528f4c586 CanvasSectionContainer: Add windowSection property. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib5b5692e2bf57a8bd109c1338caf7b9dad7d6de1

Change-Id: Ib11e0cc7ded6bdc3c07b4431fc69b00fabcee5a9
 2021-07-09 21:05:40 +03:00
Gökay Şatır
cece2c0035 Calc: Comments on different tabs shouldn't prevent each other from being 
shown.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I50c4bf98ef3ba00ffbd77b595aacf2e5f92e5f53
 2021-07-09 21:05:40 +03:00
Gökay Şatır
0e987abcca Impress & Draw: Tablet view improvements for comments. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: If25d1262aa849b147782f7a6f547833a702eab27
 2021-07-09 21:05:40 +03:00
Gökay Şatır
213708eece CommentListSection: Cosmetic changes. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ica5f345cb42916f57ba302193c0b8a7669199411
 2021-07-09 21:05:40 +03:00
Gökay Şatır
f0d7cb40ef Calc Comment: Tablet view improvements. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib6fae1b675ac293044e3a829edeaf51648becd73
 2021-07-09 21:05:40 +03:00
Gökay Şatır
63eb3c29bb Comment: Enable click event for touch devices. 
Also, set position of the document object (comment) according to dpiScale.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I276150c4dc6acd05874616082f6baebff1c42666
 2021-07-09 21:05:40 +03:00
Gökay Şatır
5a15a4b827 CommentListSection: Add dpiScale to CSS positions. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I2fcc3f3845899dd7cedd042757a144d63ddbdb07
 2021-07-09 21:05:40 +03:00
Gökay Şatır
1cde8cae76 TouchGesture: Add unselect function. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib658e0ccda93498fc2daabfc9d663367eb17649a
 2021-07-09 21:05:40 +03:00
Gökay Şatır
e004ea3e33 CommentSection: Separate writer only part. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I755b37297a6b8db25b9918265c13bebdf1238d84
 2021-07-09 21:05:40 +03:00
Gökay Şatır
248e57eb33 Fixup for unselect function call. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ie40d9a6e32ed5327312d44af93c86acdcc2396ba
 2021-07-09 21:05:40 +03:00
Gökay Şatır
9bc9dcc0f9 Make dpiScale variable global. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I3405a4b2d03a7b0bc28cc6d6e2f36f62331003ff
 2021-07-09 21:05:40 +03:00
Gökay Şatır
c8f0e255b0 CommentListSection: Remove unrelated comment. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id222dd2f9889137fe96cd63d575f8f8645940a2b
 2021-07-09 21:05:40 +03:00
Gökay Şatır
507c42364f Impress mobile: Scroll to position when a comment is selected on mobile 
wizard.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic763ee890301c2c006073e08766358f98ae066e0
 2021-07-09 21:05:40 +03:00
Gökay Şatır
7df00fed68 Impress: Select command when marker is clicked. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib687080244194398753ee2effd33686041b7e69d
 2021-07-09 21:05:40 +03:00
Gökay Şatır
478907a883 Map: Remove unselect comment codes. 
Propagation is cancelled by the comment section. No need to handle it
inside map class.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I011982d3d8691f5d6ca47fa56f7c826538909e57
 2021-07-09 21:05:40 +03:00
Gökay Şatır
104bab1da9 PDF view: Don't show previews while comment wizard is open. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I7a1ebdb62d16afdd9abe2eb63a566eeee5471a04
 2021-07-09 21:05:40 +03:00
Gökay Şatır
347c857326 FileBasedView: Show all comments. 
Not only of the selected part.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Idb409c447e083cb76f124275e21f5ef4f87e72fa
 2021-07-09 21:05:40 +03:00
Gökay Şatır
34d5f4d519 PDF Scroll: Find most visible part. 
There was a bug in the function.

Also, onLostFocus function's bug is solved.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic793999c58e13c9a42d00a4c19e44285aad8c750
 2021-07-09 21:05:40 +03:00