- converted to TS
- will be later extended with additional functionality
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I883da61018808d79d616d7346e86dadf9fa7079e
That condition shouldn't be checked before scrolling to selection position.
This fixes "doesn't scroll to searched text" issue.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I9f901ba2fa15ade5416ad68f62e356e34163c641
- Toolbox: Remove height min-content as it's prone to problems and different
outcomes depending on the context. Plus we don't need it if we enforce
it via grid
- Center all elements
- Including unotoolbutton
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iadc55f0d253dd4a06c11ad8cd062c02863b1d12f
When editing formula buttons were misaligned
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1208656751d9d3238d5a980503fd07bb868fd374
Before this commit:
- Impress on tabbed and compact view didn't have the common (and in
used in the other apps) 'unoResetAttributes' css class
Set all with the same CSS class so integrators with customizations
are not force to single out special cases.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I82deb98a628b527470fcd2e54f1374df21380bfa
If we follow user who does editing on other part - we need to
switch to it first. Whitout that we failed with error in the
browser console due to missing marker on the screen.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3d4150f5c8f70240d3a386a8d5a7fdbc4e8d37d9
- avoid using fields manually, use helper functions
to keep correct state transitions
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iad466ab00b256c86eebf9da2609edc68513e988c
as if the pending one was launched with the new delay priority
initially
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie5553492c52baaedbd84dc1450328ce8c3b623bb
Button invokes the uno:InvertBackground command than user can
see the inverted document color even app is dark mode.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ie273ec4b3d26ffbc38384dc39943b8656e4364d4
- the label between Structure tab and TreeView was misaligned. This is corrected with this commit.
- label "Structure:" changed to "Functions in use and their validity:" with https://gerrit.libreoffice.org/c/core/+/168161 (6c15d246afa1774298e1438f2117b593a065bfe4)
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I197fb84154226709395f4f2789fc288367c00f05
The matrix saga seems to be solved now
- There were 3 rooms. I needed to remove both local and published
address from there (the old matrix.org room)
- Skyler helped by setting the local address of the active room to the
matrix.org
- Then we could set the published and the main address as #cool-dev:matrix.org
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7e73e0750dd94744eb0706230da40ab51bbad7f7
1) User1 start resizing row/column
2) User2 create a new annotation
3) User1 finish resizing row/column
4) Server update comment position
5) User2 new annotation is hidden
if comment is new, do not hide when updating new comment data.
Change-Id: I593dff167f75cc3dc451467a7d76a09f94a3a556
Signed-off-by: Henry Castro <hcastro@collabora.com>
Recent a failed jenkins job had a lot of output, the tail of the log
starts with: "Skipping 3,970,746 KB".
I guessed that the problem is that the fuzzer figured out what is the
protocol to change log levels, but it isn't there yet.
What seems to happen is that fuzzer/Common.cpp defines the log level to
be "none", but this is not handled at GenericLogger::mapToLevel(), so we
managed to enable trace level for known-broken input where we're not
interested in the errors/warnings.
The fix can be tested by adding assert(false); to Log::log(), previously
the fuzzer failed with an assertion failure for a simple input like "12"
(unknown command) and now it just exits silently.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ib5f4bedca706d7a0310a2eb9f661053a3095822d
increased jsdialog width to fit content when necessary.
removed margin from icon to make it look even spaced in listview (i.e: manage changes, zotero add citation)
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I225b5b5d42d573cb4afcdb428e2eb3b81aa99073
In case of misconfiguration (missing userInterfaceMode), deprecated "classic" or "default" userInterfaceMode, which is the default, use notebookbar.
Users can still use "compact" as documented to use the compact style
(formerly called classic).
Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: I00ee65edb21fcf80724bc83f947341dfdc5c8ed6
Previously, zooming using the +/- zoom buttons caused your view to jump
such that alternating in/out zooms would move you to the top left of the
document
Additionally, the zoom did not zoom around the correct position, so a
cursor in the frame would not correctly zoom around the cursor
This is now fixed
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I6d468795abbb972174774cf1620cb4a0959142f2
- we don't depend on OnMouseUp event of AutoFillMarkerSection.ts anymore
which makes the popup more stable in terms of open and close.
- requires: added LOK_CALLBACK_CELL_ACTIONS with
https://gerrit.libreoffice.org/c/core/+/168086 - 1cf2a23c7cb0a149562635432b003164059617b5
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I2294f6aa091231c2ddf1a448776f51a3a892b646
- undo uno calls are removed: no need
- unified the popup operations with _handleKeyDownForPopup()
- make popup entries translatable
- add explanation for AutoFill
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I69935150597c90851c3d731b42b1adf072ae29cd
- Esc key to close AutoFillPopup
- ArrowDown to focus elements inside AutoFillPopup
- ArrowDown/Up to cycle inside the popup
- also remove "this._map.fire('closeautofillpopup')" from
"Ctrl + Alt + PageUp/Down" since we don't need to close
AutoFill popup anymore here as we close the popup immediately
after pressing "Ctrl" key
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: Iac4bbd1104f3140bd47842daaae2eb3bfa87daef
(cherry picked from commit 6ab88d7bf32e6fcb64d891fe0458c21f12b7da87)
Added functionalities for "Copy cells" and "Fill series".
- Copy cells
this.map.sendUnoCommand('.uno:FillSeries?FillStep:string=0')
- Fill series
this.map.sendUnoCommand('.uno:FillSeries?FillStep:string=1')
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I77a3512627e35f2a176b147d3f54f08c7f5f7b08
(cherry picked from commit 77c1764fb399f48f18482ceec2d91c561af8d334)
close AutoFill popup when
- sheet tab is clicked
- new sheet is inserted
- sheet tab is switched using Ctrl+Alt+PageUp/PageDown
keyboard shortcuts
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I03711d202b47813d101bd066db1a3e8e106430e3
(cherry picked from commit 852906337810fc12d55be4e30c8c3467c407efed)
AutoFill popup has two options:
- Copy cells
- Fill series
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I08ad88afad1bb6bd2d746a9a8964f1b4446ae7c7
(cherry picked from commit 91f080976f4c1d643db1b217b605f59742f13bd0)
- this test will check input element getting set to it's right state after update on jsDialog
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ib22dd0c5d6c6ab95650617480c137b306b8a6e80
- Input elements in jsDialog does not change state after CORE update message
- this is because in previous commits we changed input element structure.
- we should Synchronize the child elements with parent.
- this patch will Synchronize disable state of parent with it's child elements
Change-Id: Ice94de732dc7392f3c79100e6a2d60480294eb0e
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
- if we switch to compact mode & server get reconnected some icons are visible in desktop which should be only visible in mobile view.
- in control.toolbar.js we call updateItem method for icon in mobile
- `toolbar.updateItem({id: 'closemobile', type: 'customtoolitem', w2icon: 'editmode'});`
- after this updateItem call we should also check all condition about that item like
- item should be visible in mobile or not
- item should be available in tablet or not etc etc
- this patch will do that checks
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I11adc3d94cacd4afe85e177d050ccc73f3112872
unblock CI from:
cy:command ✘ assert expected **<tspan.TextPosition>** to have attribute **y** with the value **'3286'**, but the value was **'3285'**
error
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0ccb209c12e15a829f99f8323bf7b1ee8ca39aa0
- Remove all the rules that are not longer active (better solutions
were implemented)
- Remove also #fontnamecombobox.notebookbar declaration. Not only top
and padding were not applicable but we were setting the width which in
turn was creating a different gap (bigger than the grid gap) and
moving icons out of place
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibf608f41d25beb3120b5b6d9f032673697f018b8
- This has no effect anymore since the id has changed
- Furthermore, the fix is not needed anymore since meanwhile impress
and draw has seen new button additions (shadow, fontwork) that renders
this obsolete.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id1990e9c6e227cf2f2567b18e7826fee81865a69
Snackbars will appear one after other now.
Add forgotten SnackbarController to Makefile.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf5ed98f8384c2688adc9653948137f23fb0ce3e
