Jan Holesovsky
0b2bf15ddd
loleaflet: Move the scrollbar to dist/.
2016-03-01 10:44:20 +01:00
Miklos Vajna
34fc0baacc
loolwsd: indentation fixes in httpwstest
...
This file had a consistent style up to recently, keep it that way.
2016-03-01 09:55:06 +01:00
Miklos Vajna
f46a43b5f5
loolwsd: fix -Werror,-Wunused-parameter
2016-03-01 09:53:37 +01:00
Miklos Vajna
a010c01bd7
loolwsd: fix -Werror,-Wunused-private-field
2016-03-01 09:51:09 +01:00
Tor Lillqvist
70b7ee6d65
Fix typos
2016-02-29 16:46:42 +02:00
Tor Lillqvist
9d655cbcc0
Don't pretend this will work on anything except Linux
2016-02-29 14:25:12 +02:00
Tor Lillqvist
29a3f58f1a
The loolwsd program does not need any capabilities
...
So don't give it any then.
Remove the --uid option and related attempts to handle running loolwsd
under sudo, to be able to debug it. Now with loolwsd not having
capabilities, it should work fine to just run it under a debugger
normally. (For the loolbroker and loolkit processes, attaching to an
already started process is the way to debug.)
2016-02-29 14:13:19 +02:00
Tor Lillqvist
f0d7438f88
Add one more thing
2016-02-29 13:06:08 +02:00
Tor Lillqvist
509314d559
Also chown the random devices to root:root and chmod to 666
...
Otherwise they won't work. Not that I know whether this helps
anything, really. At least the NSS crypto initialization still takes a
long time.
2016-02-29 12:15:22 +02:00
Tor Lillqvist
d489f69372
Log also capabilities before dropping
2016-02-29 12:12:18 +02:00
Tor Lillqvist
b75c6a34b0
Grammar
2016-02-26 16:53:58 +02:00
Tor Lillqvist
e7a0b4f524
Mention one more problem
2016-02-26 16:52:27 +02:00
Andras Timar
d14fccb67f
hide column headers of hidden columns
2016-02-26 15:31:35 +01:00
Tor Lillqvist
188ca79a6b
Always complaining
2016-02-26 13:27:20 +02:00
Tor Lillqvist
ab3169ecdc
Add some more Log::info() calls
...
We want to be able to see exactly when document loading and password
management is done and how long it takes.
2016-02-25 16:43:51 +02:00
Tor Lillqvist
3cad8c183a
Seems that 10 seconds is not enough
...
One has to love arbitrary retry counts and timeouts. Loading the
password-protected.ods in a loolkit process, with correct password
provided, takes 12 seconds on my machine. I think this slowness is
because the NSS code LO uses to do crypto wants to initialize its
crypto goodness in various ways that don't work so well inside a
chroot jail. Presumably it uses some wait with timeout when attempting
to do something which doesn't succeed. For instance it tries to run
netstat -in. (In an interactive LibreOffice the doc loads fairly
instantly.) Oh well.
2016-02-25 16:22:07 +02:00
Tor Lillqvist
ff7a0ac8ee
Add more verbose debug output...
...
Debugging this crack is really hard.
2016-02-25 15:57:55 +02:00
Tor Lillqvist
d88a798469
There is no setDocumentPassword() in ChildProcessSession
2016-02-25 14:36:50 +02:00
Tor Lillqvist
4b5e799a33
Split testPasswordProtectedDocument() into three
...
It does three separate things, and the first two intentionally result
in errors, and the server probably disconnects after errors. Not
sure. This is horrible, horrible.
2016-02-25 11:02:35 +02:00
Tor Lillqvist
bbcc2c43da
I think it makes more sense to output to std::cout here
...
Because that is where cppunit outputs, I am told, so less chance of
out-of-order mixing, maybe.
2016-02-25 10:31:36 +02:00
Tor Lillqvist
3f107ed8ca
Add snide comment
2016-02-24 17:48:03 +02:00
Tor Lillqvist
dbd5e3877d
Don't send "disconnect" frames here either
...
The JavaScript code does not either.
2016-02-24 17:45:20 +02:00
Tor Lillqvist
bc7decb6ca
No "disconnect" message is sent by our client JS code (and that is good)
...
Having a separate "disconnect" message is a disgrace. There should be
no need for it. WebSocket has a perfectly fine graceful disconnect
mechanism already (CLOSE frames). The code needs to be prepared to
receive a CLOSE frame at any time. The code also needs to be prepared
for the underlying socket being bluntly closed by the other end,
without sending any WebSocket CLOSE frame. The only sane thing is to
handle a "disconnect" message in the same way as those situations
anyway, so why is it needed?
2016-02-24 17:44:17 +02:00
Tor Lillqvist
46b43602fd
No colours in the log, thanks
...
The escape sequences just make the log harder to read in an editor.
2016-02-24 15:35:32 +02:00
Andras Timar
277f86b7e9
loolwsd: bump version after tarball
2016-02-24 14:13:56 +01:00
Andras Timar
f35e13a936
loolwsd: bump version before tarball
2016-02-24 14:10:49 +01:00
Andras Timar
2e6f401710
loleaflet: bump version after tarball
2016-02-24 14:10:18 +01:00
Andras Timar
b66a5f7987
loleaflet: bump version before tarball
2016-02-24 14:04:44 +01:00
Ozcan Esen
ded88d5e4c
loleaflet: allow manually entered font sizes bccu#1354
...
Change-Id: I137e6f3ad9fb84de6a9179f9d4e00ca4c10e9469
Reviewed-on: https://gerrit.libreoffice.org/22605
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2016-02-24 12:56:36 +00:00
Tor Lillqvist
c25f819e83
Yoda naming avoid
2016-02-24 09:46:53 +02:00
Tor Lillqvist
72c6cb8980
No LibreOfficeKit used in this file
2016-02-24 09:46:53 +02:00
Tor Lillqvist
07dc25641d
Increase stylistic consistency
...
Sort #includes and using statements. Use 'using' consistently for all
Poco:: types. (I am not 100% convinced that using 'using' like done
here in loolwsd was a good idea after all. But at least let's be
consistent now that we do use it.)
2016-02-24 09:45:52 +02:00
Tor Lillqvist
32dc0a3c87
Don't ever attempt to handle the payload of CLOSE frames
2016-02-23 20:03:52 +02:00
Tor Lillqvist
7320d8ca51
Bin unused 'using'
2016-02-23 20:02:54 +02:00
Tor Lillqvist
79037b687e
Log received messages to stderr
2016-02-23 20:02:29 +02:00
Tor Lillqvist
fbee03cae2
Minor clarification
...
No need to pass the value of a variable, initialised much earlier, to
a system call when one can pass the required constant value as
such. Much clearer.
2016-02-23 17:59:52 +02:00
Faruk Uzun
02f6f0d6fa
loleaflet: bccu#1456 fix spreadsheet tabs
...
Adds a custom navigation for spreadsheet-tabs
Change-Id: I57d9ef1ff9466c18c9edca849519bbe2af5826ab
Reviewed-on: https://gerrit.libreoffice.org/22610
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2016-02-23 15:56:44 +00:00
Miklos Vajna
7552fcd806
loolwsd: work around -Werror,-Wunused-private-field
2016-02-23 09:35:46 +01:00
Miklos Vajna
ae07c555bb
loolwsd: fix -Werror,-Winconsistent-missing-override
2016-02-23 09:32:25 +01:00
Tor Lillqvist
6af8a9bbc1
Avoid 'short' and 'signed'
2016-02-23 10:22:18 +02:00
Tor Lillqvist
674ceb90b9
Add comment
2016-02-23 09:28:48 +02:00
Tor Lillqvist
c9fef1eb7e
Add comment about weird use of condition variable
2016-02-23 09:09:22 +02:00
Pranav Kant
98fbc0c4a4
loleaflet: Handle password protected documents
...
Change-Id: Ife7923869710999de83365dc2c6be33ed42c2f3b
Reviewed-on: https://gerrit.libreoffice.org/21895
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2016-02-22 20:23:32 +00:00
Tor Lillqvist
00e3d6ca20
Cosmetics: add a space
2016-02-22 17:09:59 +02:00
Tor Lillqvist
819d5c23c0
Use all tokens
2016-02-22 16:31:24 +02:00
Tor Lillqvist
7ced4adc5e
Just use "" instead of std::string()
2016-02-22 16:30:42 +02:00
Tor Lillqvist
72ff491fb2
Cosmetics: avoid trailing space in 'disconnect' message
2016-02-22 16:27:12 +02:00
Tor Lillqvist
ef30af121a
Log a bit more information
2016-02-22 13:50:14 +02:00
Tor Lillqvist
5a69177f74
We are not interested in the payload of CLOSE frames
2016-02-22 13:50:14 +02:00
Marco Cecchetti
05c4a034c3
loleaflet - user view does not follow cell cursor - fixed corner cases
...
Change-Id: If6497d46c5d4457493864fdea04c28bb917865c0
Reviewed-on: https://gerrit.libreoffice.org/22519
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 27d4b4b75aeaddac550b5c2bdf04fcde744c87fe)
Reviewed-on: https://gerrit.libreoffice.org/22518
2016-02-22 10:47:40 +00:00