Commit graph

16634 commits

Author SHA1 Message Date
Pedro Pinto Silva
0efc785acb JSsidebar: Fix alignment options, too many in one row
This was affecting spreadsheet, presentation and drawing doc type

Make sure the alignment container does not contain too many
elements in one row.

- 1st normal alignment properties; 2nd left-to-right/left icons
- and then ensure the last parent goes into a new row

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iaa9f1fa12f577d5ae9dddb0597f060dd7f4019ae
2021-11-16 15:32:49 +01:00
Luka Trovic
cc205d2945 remove xss vulernability
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Change-Id: Iddb33be014b72824f7cab0763c391f2a8bae1558
2021-11-16 14:04:57 +01:00
Luka Trovic
ec2e5e1ec6 update idle document modal style
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Change-Id: I03ab8867f757da43b440019503c01e0feb0c3f51
2021-11-16 14:04:57 +01:00
Tor Lillqvist
09942e76c5 Strip shell string syntax quotes from the PRETTY_NAME line in /etc/os-release
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I5cb6f294d6d4bf62c2e16fc88bc6195695595ba5
2021-11-16 13:33:26 +02:00
Erik Habicht
cbe99ee874 Move adding the start script after running the install script.
This will speed up docker build if only something in start-collabora-online.sh has changed.

Signed-off-by: Erik Habicht <erik.habicht@gmail.com>
Change-Id: Iaa9566f6793b47877901522f1f0e7cb2acc530b6
2021-11-16 11:28:14 +01:00
Andras Timar
6e45fae6c5 rename coolstress to jsstress
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5d0346be60451699502f3723f781bc8488e114f5
2021-11-16 11:16:45 +01:00
Aron Budea
b92befff94 docker: Make Notebookbar the default again
...and user interface mode parametrizable.

Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: Id4538f27f5aef9190c546ec8dc1d505042837aeb
2021-11-16 10:13:14 +01:00
Michael Meeks
a00e80ed4c Default to automatically cleaning up high resource consumers.
Change-Id: I570d13e696e7e2dc01dd29751df26eb532fa1a76
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2021-11-16 09:12:47 +00:00
Andras Timar
41f15348c5 rpm: Package symlink loolconfig->coolconfig
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I08305890d2f6d0d866e3ab75cdf207316eab780c
2021-11-16 09:43:37 +01:00
Mert Tumer
b17dc4c789 Unit test for X-WOPI-Lock
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I68ce373390a71d4df31716a8a2aa98c96dcb9647
2021-11-15 23:18:37 -05:00
Ashod Nakashian
6932691cd8 Fix wopi-lock release problem
If the last session is readonly on a document that
is already locked by a edit the file stays locked.

Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ia48e73fffd7962da2e18acfa0f1259d237c72fa8
2021-11-15 23:18:37 -05:00
Andras Timar
604286f40b document 'anonymize' command of coolconfig
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie43b31dab36002010cc23a8d9e3408dc8e8bddf2
2021-11-15 22:55:04 +01:00
Andras Timar
cde4d9322e add compatibility symlink 'loolconfig' for 'coolconfig'
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4715b4469d5f11f63eff4b76651eee549000c1c2
2021-11-15 22:07:53 +01:00
Mert Tumer
78ccaa845e rename: loolconfig -> coolconfig
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ied23cb46a668f754931fc125745b674b546a0195
2021-11-15 22:07:53 +01:00
Szymon Kłos
50ab7c21fa comments: show resolved comments on start
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If0ea8c1e74581dacb1461af549336a8ae676230e
2021-11-15 19:46:41 +01:00
Pedro Pinto Silva
eb7156061e Nb: shortcuts: increase savemodified contrast n simplify CSS
The status for unsaved documents was lacking contrast and was solely
relying on color which can be a problem for some people (deuteranopia).

Improve this by:
- Increasing color contrast
- Adjusting hue rotation and make sure it only affects img elements
- Adding visual element (red dot) as an extra visual difference between
	saved/unsaved status
	- Use shadow to increase legibility between one and the other
- Instead of adding .savemodified class to img add it to its parent
	(#save.unotoolbutton)
	- So we can style more stuff (including the new ::after element)
	without extra work
	- So we can simplify all the rules for the 3 apps (unsaved status) to
	one simple one
		- Bonus: we are then sure everything is consistent on that front

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I557a8cd9a5207d44ed3d380f96644f4ec1e99f6f
2021-11-15 19:46:11 +01:00
Szymon Kłos
48d62bcf8a jsdialog: prevent errors in closePopover
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia2fc78d06b54f0011d168ae769f11cbd137676a0
2021-11-15 12:30:51 +01:00
Pedro Pinto Silva
c2b5c6190b NB: Adds Character spacing to home tab
- Fixes #2149

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib10ebe68fa46d170787d11b06e07a5641f7e7990
2021-11-15 12:28:17 +01:00
Henry Castro
4784ca2afe browser: rename 'loleafletframe' -> 'coolframe'
in html/debug.html

Change-Id: I7e14bf9deb140090fbb39c8facfaf9360e5a1a7d
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-11-15 12:21:59 +01:00
Ashod Nakashian
36c12dd49c wsd: always subscribe when proactively rendering tiles
When issuing tile render requests proactively (upon
getting invalidatetile event), if the registered
request has no subscriber, TileCache::saveTileAndNotify
simply drops the tiles!

New call sequence:
ClientSession::handleTileInvalidation
    docBroker->handleTileCombinedRequest
	tileCache().subscribeToTileRendering //< fix

The end result was that we rendered tiles only
to discard them, potentially leaving the clients with
stale tiles (unless they requested new tiles themselves).
If they do request them, we still benefit from the cached
copies of the internal requests we had issued (and dropped).
The issue is that we are wasting an opportunity for efficiency
and relying on the client to request tiles when we normally
push on invalidation, adding latency and being inconsistent.

Change-Id: I4d3aa3739c5324ffca15c80b20dce29ac03eef73
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-11-15 11:40:05 +01:00
Andras Timar
953419bf01 small cleanup around "Last saved:" label
* remove old, unused code
* String.locale respects the language requested by the integration

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I799856bdd721427e7d58be0a8fcddba866b726ea
2021-11-14 19:01:27 +01:00
Andras Timar
c70947d4d0 Update l10n files for Weblate
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I27b3ca352318348b09913d0940a683b06a2bcfad
2021-11-14 18:03:01 +01:00
Andras Timar
d6048591e6 Translated using Weblate (Hungarian)
Currently translated at 57.3% (262 of 457 strings)

Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/hu/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7e6cc7136e92413299ca3df8c267b0a8bc8bd45c
2021-11-14 17:58:22 +01:00
phlostically
bc982ff6ed Translated using Weblate (Esperanto)
Currently translated at 96.6% (399 of 413 strings)

Co-authored-by: phlostically <phlostically@mailinator.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/eo/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic4d5780165d61a25ba936626cfbb05d08e23be6b
2021-11-14 17:58:22 +01:00
Weblate
4864d7f964 Added translation using Weblate (Norwegian Nynorsk)
Added translation using Weblate (Frisian)

Co-authored-by: Weblate <noreply@weblate.org>
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id36f202c1c8ce2199f91b701f98172b43136f305
2021-11-14 17:58:22 +01:00
Pedro Pinto Silva
480814dd93 Spinfield: improve input number (webkit)
On webkit based browsers spinfield controls (up an down) are hidden by
default and only appear on hover on top of that they look a bit wonky
(too small and not well positioned)

This improves that by sill using the same web native control while
styling those pseudo (vendor) classes. Extras:
- Mouse cursor change
- Different opacity values (so we retaining that visual difference
	between hover and normal state)
- Increase size of those arrows

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I07aacfc387cbf42efec1d302094bbfdfae4da4ed
2021-11-13 17:03:39 +01:00
Gleb Popov
b88708aac3 Don't enable SECCOMP by default on !Linux systems.
Signed-off-by: Gleb Popov <6yearold@gmail.com>
Change-Id: Ib971a94d3ff18353cdb2a2024f78875e9ff6d8b5
2021-11-13 17:02:02 +01:00
Szymon Kłos
913ba9318a notebookbar: don't lose focus on tab change
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibb40f8f6cd0c379b53271249dabe2c989640af09
2021-11-12 16:50:46 +01:00
Szymon Kłos
8bb47a187a sidebar: fix resizing
- apply new height limit when window was resized
- remove leftovers after pixel-based sidebar

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I76d9e7d259501ca55ee255d0cbbd883750db45e5
2021-11-12 16:49:52 +01:00
Szymon Kłos
75c5ddda49 jsdialog: mobile-wizard: handle standard buttons, hide close
- setup standard responses for buttons in mobile-wizard
- by default hide close or cancel buttons in mobile-wizard
  because it can be closed using 'v' button or by tap on document

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I38cfbbec1cba0c76d1adfd98c43e8d0c572d3735
2021-11-12 16:49:44 +01:00
Henry Castro
e0046c51df wsd: rename 'docisdisconnected' -> 'docdisconnected'
Otherwise, the Integrator will not receive the document
disconnection on client side.

Change-Id: I2280d90df7b915838462f119e962b0420b5cf41f
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-11-12 09:51:23 -04:00
Rash419
ba92424ff4 cypress: fix: calc/scrolling_spec.js and disabled image_operation and annotation_spec
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ibc65ca6668e59e6d348c8c3167e6fd4e5959c43a
2021-11-12 18:47:41 +05:30
Pedro Pinto Silva
ef976d3a49 NB: fix contrast n blurriness in the selected tab
The title of the selected tab is not crisp.

- Do not use colorful text shadows since it does not help with contrast
	and in turn makes it blurry
	- Instead use gray just as a way to
		increase contrast and visually make it look like it's semi-bold (since
		that font doesn't have anything in the middle between normal and 700)
- Also help user understand which tab is selected by increase the
	contrast between the selected tab (rectangle) and the background via
	box shadow

Resolves issue #3609

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4140a789df6418fed3484d96625bbbe3a99ab98f
2021-11-12 12:27:52 +01:00
Szymon Kłos
1e7a189264 jsdialogs: fix units extraction
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaebf172570c332a98944949a6733bdc5ca685c04
2021-11-12 10:21:56 +01:00
Pedro Pinto Silva
ba9feca725 About Dialog: Increase structure flexibility
- Allow for dynamic resizing (flex box)
- Set sub elements with id so we can use less background images
in the main parent element and use it directly in its own element
- Also make integrator logo optional and easy to switch on/off via
flex-grow: 1 | 0 respectively

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I837b26d77e0bfa722c6ff3d4a247a36ef8944797
2021-11-12 09:25:28 +01:00
Szymon Kłos
c49fb297ff comments: when zoom is used close popup with preview
if comment is a bubble with opened preview and we zoom out
so bubbles will become full comments - we need to hide old popup

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I14ce5a6a816ed28c81b855fd2e39d745a10eedb4
2021-11-12 09:22:30 +01:00
Aron Budea
92e1860011 loleaflet: Make buttons in password entry dialog translatable
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I72e716ae343e08d6e7a028aacbfcedb6f5859404
2021-11-12 08:02:51 +01:00
Andras Timar
ff528a729f Update debian/copyright
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If4fd4313e73dab4aaca3e1a1717115d2dfcc2cac
2021-11-11 22:56:53 +01:00
Jan Holesovsky
0eb950513d codeql: Limit the project building only to the C++ checking
This is not needed for JS or Python.

Signed-off-by: Jan Holesovsky <kendy@collabora.com>
Change-Id: I6aba438b9646283659b31f6db40f10e224859d9a
2021-11-11 16:42:03 +01:00
Jan Holesovsky
14d1a82144 codeql: Move the paths-ignore to the correct place
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
Change-Id: I1b9d53611def0adb4be2057d224661ee29c824e4
2021-11-11 16:42:03 +01:00
Jan Holesovsky
d264fa61eb Change some unwanted renames
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
Change-Id: I9ab7c701470ca9b81e5a71812683860175e18542
2021-11-11 16:42:03 +01:00
Andras Timar
a8bb765eaf Bump version to 21.11.0.1 (RC1)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5c2ec902a507e3ffbc8c219f2b4e79bc8e2fedcb
2021-11-11 16:26:06 +01:00
Andras Timar
e1c1946afb more descriptive name of a config setting for debugging: browser_logging
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I175e5256fcae42477cb2c84fc2b4048aca40bed7
2021-11-11 13:26:37 +01:00
Gleb Popov
2716cc7155 Set --disable-setcap as default for !Linux platforms
Signed-off-by: Gleb Popov <6yearold@gmail.com>
Change-Id: I67e211a94870e46b19426c68d599e7048543a8f5
2021-11-11 12:42:09 +01:00
Gleb Popov
b948e431f3 Use more portable shebang for loolwsd-generate-proof-key script
Signed-off-by: Gleb Popov <6yearold@gmail.com>
Change-Id: I986bbacf224a1058aeb27fd3835dbc91b6b5c6d6
2021-11-11 12:42:09 +01:00
Luka Trovic
4d22123fc3 update last modified time label & translation
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Change-Id: I76b945c1405479a9094ea8443e61671910261524
2021-11-11 12:40:37 +01:00
Andras Timar
e58053621a Remove config option loleaflet_html
This means that we will no longer read loleaflet_html from old config files, which is
a good thing in 99.9% of the cases, because it contains a wrong default: loleaflet.html
For those integrators, who used this setting, we will offer an alternative slution later.

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia82f812a5d3e522a9d33e7fcafcaa45130312d60
2021-11-11 12:22:41 +01:00
Andras Timar
2720d0be91 remove obsolete X-Pootle-Path and X-Pootle-Revision headers
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iadb3c843da284493827bc576a7a979a1feeb204c
2021-11-10 22:50:32 +01:00
Andras Timar
e2bb417b88 remove Provides/Obsoletes sections from RPM spec
Rename loleaflet->cool did not make sense here. In ancient times
we had separate loolwsd and loleaflet packages. But maybe now we
can get rid of this, because probably nobody would upgrade from
COOL 1.0 to COOL 21.11.

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I48a566e8bcb47a00147d436d055617f412978cf5
2021-11-10 21:45:58 +01:00
Andras Timar
456343e952 Update l10n files for Weblate
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I65750736df7bc56f432c47b3a8379a903df8d237
2021-11-10 21:30:54 +01:00