Tamás Zolnai
0bb96131c4
Cancel tiles also in wsd's senderqueue
...
Change-Id: I683b3cacee2f87d0dc0f28ad9ac3e122bcd043f1
2018-07-31 13:18:44 +02:00
Andras Timar
199b32fc0f
loleaflet: fix Keyboard Shortcuts help localization
...
Change-Id: I1bbe88a37127fb13cba7c065ce03cb6799c6b7fa
2018-07-31 09:24:50 +02:00
Miklos Vajna
6f3fd44c03
wsd: make these a const reference instead of copying for each invocation
2018-07-31 09:19:03 +02:00
Andras Timar
33f0e7e893
loleaflet: updated UI pot file
...
Change-Id: I31fb03a771cd802416250d9dad29ccadd8fd1631
2018-07-30 11:37:05 +02:00
Henry Castro
3e3857e1c7
loleaflet: fix tile debugging mode
...
Change-Id: I73a9d9c449a89540a057f68d2a5536f18b0ee931
2018-07-29 19:48:07 -04:00
Henry Castro
42823fcafb
loleaflet: mobile: fix delete with backspace
...
Change-Id: I36eddf8b81849592982d01f3a4c7f3be0f0c0ee3
2018-07-29 15:03:57 -04:00
Henry Castro
57940acb06
loleaflet: mobile: check tolerance when the move event occurs
...
Change-Id: I9e1d28e1b198e81f876a323c978478e4ccea7474
2018-07-29 14:50:24 -04:00
Michael Meeks
fabd928366
Mark LOOLWebSocket as deprecated, and dung it out a bit.
...
Change-Id: I4e1daff8a10092b8845971375ce83e09b78354ea
2018-07-26 09:23:37 +01:00
George Wood
be3a3d2028
added mode lines to all the javascript files without them
...
Change-Id: Iea2b216d988496a60fc5ca043014d4d4c09eb99a
Reviewed-on: https://gerrit.libreoffice.org/57919
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-26 08:07:14 +02:00
Tamás Zolnai
c2a5f6acb0
Store number of tiles sent to kit for rendering
...
and use that info also to avoid sending to much tiles on the network.
Change-Id: Iab2d7af64693047a3c1cfe9f73de80a7100bbc13
2018-07-24 20:52:53 +02:00
Tamás Zolnai
b014804ce2
Trace sent tiles when they are actually sent
...
SenderQueue might drop some tiles, so we were waiting for
tileprocessed message for a tile which was not sent at all.
Change-Id: I7c502966f656e46df7c22002dee19aeabbf97774
2018-07-24 20:52:45 +02:00
Henry Castro
03a29a1699
loleaflet: mobile: handle long click
...
Change-Id: I3c3ecce737e5c2457e922e2e612f0312dfab72dd
2018-07-24 14:03:10 -04:00
George Wood
594348b6fe
enables debug mode to be turned on from the about screen by pressing d.
...
Also fixes focus issue with map after closing dialog.
2018-07-24 12:27:35 +01:00
George Wood
73b8da4ab0
Cleanup error reporting.
2018-07-24 12:27:35 +01:00
George Wood
e8235e50c8
A more attractive 404 page.
2018-07-24 12:27:35 +01:00
Henry Castro
dd9aefd5d8
loleaflet: mobile: do not zoom out when edits a document
...
Change-Id: Ic5b78df16c8ac0ccfb7334e6809b58665cd04494
2018-07-23 16:06:39 -04:00
Henry Castro
f5de78f920
loleaflet: fix when document window zooms out until it disappears
...
Change-Id: If0f7234429130aed47dbc9156fde2e125680638f
2018-07-23 16:05:53 -04:00
Henry Castro
276a9713c2
Revert "loleflet: disable the document is automatically zoomed ..."
...
This reverts commit dfab8731a9
.
Change-Id: I20ab8eee97b9d6934ea33a1cbb24030d3d5b5a7e
2018-07-23 16:04:04 -04:00
Miklos Vajna
ec008efd73
tools: remove unused Poco::Util::Option include / using decl
2018-07-20 10:23:48 +02:00
Tamás Zolnai
33a0cb1ee7
Fix failing unit tests after latency changes
...
With the new code, wsd is waiting for tileprocessed messages
if the upper limit of tiles-on-fly limit is reached. To avoid that
send canceltiles message.
Change-Id: Iadf16c834f12d14000d630078882dfa8e11a99a0
2018-07-19 14:19:07 +02:00
Tamás Zolnai
fe5507f134
Add some additional comment related to latency changes
...
Change-Id: I3ece60ce8a66730a8f8a93757412bcaa2b02a77d
2018-07-19 14:18:11 +02:00
Tamás Zolnai
3215ddfe48
Set back debugging code removed by latency related code changes
...
Change-Id: I6634029bc8c36dfea7219e7e48e1c010b274e687
2018-07-19 14:17:59 +02:00
Tamás Zolnai
8d92b0809d
Store wiredIDs on the server side
...
So we can use this information in tile requests.
Change-Id: I87ba420ec0fd699353d48a228268e546ace21921
2018-07-19 14:13:03 +02:00
Tamás Zolnai
e1b22eaac3
Calculate TilesOnFly limit based on visible area
...
Use 10 as a minimum value.
Change-Id: I9442a427fd25e1a7a32c3d1d06aa34d2c4ca2472
2018-07-19 14:12:52 +02:00
Tamás Zolnai
2fda5f7d92
Use an upper limit for number of tiles we push to the network
...
I used number 25 as this limit. It's an approximate value. It's enough
to handle the first 5-10 character input without waiting for tileprocessed
messages. After the first 5-10 characters the tileprocessed messages are
arriving continuously (same frequency as the typing speed), so for the later
character inputs we always have some tileprocessed messages arrived so
we can push new tiles to the network again.
This 25 upper limit also seems enough to send all tiles when a whole page is
requested (e.g. zoom os scroll).
We store the requested tiles in a list, used as a queue. I don't use std::queue
because sometimes we need to do deduplication (replace older versions of the
same tile with a newer version).
Change-Id: I22ff3e35c8ded6001c7fc160abdc1f1b12ce3bae
2018-07-19 14:12:41 +02:00
Tamás Zolnai
4e2b50dc0f
Check whether tile rendering request was already sent
...
Change-Id: Iceb559106dcd95d6ff7db67df76cdfb04f9fb7e0
2018-07-19 14:12:27 +02:00
Tamás Zolnai
6c4e4440e8
Handle part number a bit more robust in case of Writer
...
Change-Id: I7390f1c5f4289be67deacf3540068c040b230584
2018-07-19 14:12:15 +02:00
Tamás Zolnai
7428c46efe
In Impress setpart message's syntax is a bit different.
...
Two alternative sytnax:
"setpart part=1"
"setpart 1"
Change-Id: I42683ca46d642d56cfc3dcc52a10d69a3f00462b
2018-07-19 14:12:02 +02:00
Tamás Zolnai
1aa8f3b17b
Send new clientvisiblearea and clientzoom messages
...
when something is actually changed.
Change-Id: I56983f5700cb9cbd0b660155a4dd0a2396b22e2a
2018-07-19 14:11:49 +02:00
Tamás Zolnai
29df46219c
Need to extract the initial part id from status message
...
Change-Id: Ia0651d93fedb71d3ca1e24d0356ac179e95e907e
2018-07-19 14:11:36 +02:00
Tamás Zolnai
85f96bc281
Store sent tiles's id instead of using a simple counter
...
Change-Id: I8cbf84923a53fb6b294bd4039eb7382326f8c445
2018-07-19 14:11:18 +02:00
Tamás Zolnai
464dd72e1c
We might need to rerequest tile rendering when we are at sending them
...
Change-Id: I0551e51c5f5023931dad13435b4ac3517fc48931
2018-07-19 14:11:02 +02:00
Tamás Zolnai
30f4cafd37
Reduce code deduplication
...
We can request tilecombine even if client needs actually one tile only.
Change-Id: Id897f219885be4cb93635d727d4ee871a4b55cb7
2018-07-19 14:10:48 +02:00
Tamás Zolnai
1f2982cdc5
Send the right visible area to the server
...
Change-Id: I036dfaa566fa7d4e370386d839bd2397cbf929f8
2018-07-19 14:10:36 +02:00
Tamás Zolnai
a9c5ea9022
Add a timeout for tileprocessed message handling
...
For debug purposes.
Change-Id: Icc9dfc05b18f9da96b29b7cadeb57f7218832295
2018-07-19 14:10:22 +02:00
Tamás Zolnai
15afe2c0fb
Wait tileprocessed message from client to send new bunch of tiles
...
We always one bunch of tiles (e.g. all tiles invalidated) and we
are waiting until client send tileprocessed message back for all
tiles before sending the new tiles.
By canceltiles message we drop every previously requested tiles and
make wsd ready to send new tiles, which will be requested by the client
in theory.
Change-Id: I9901420ada549e962ffaf5e6bd58e52b86bd129d
2018-07-19 14:10:08 +02:00
Tamás Zolnai
57cdd68fcf
Request new tiles in wsd by invalidateTiles message
...
And don't wait for the client to send back a tilecombine
request.
Change-Id: I9ea5de0f6b12dfaaf61992d34735d5b78ea382ed
2018-07-19 14:09:49 +02:00
Tamás Zolnai
161695eb66
Store client's visible are information in wsd
...
Change-Id: Iec3c146181b7db2e76247d5775076e6ac90eed2c
2018-07-19 14:09:33 +02:00
Tor Lillqvist
3352603011
Avoid cast that causes gcc warning
...
gcc 8 warns: cast between incompatible function types from ‘void
(*)(int, siginfo_t*, void*)’ to ‘__sighandler_t’ {aka ‘void (*)(int’}
[-Werror=cast-function-type].
The struct sigaction already has an appropriately typed field
sa_sigaction in a union with the sa_handler field, so use that. (If
that is not present in some older Linux and/or glibc that we still
need to support, this commit will have to be reverted then.)
Change-Id: I67667073c89b7b22e7de1933ccaaa60868685866
2018-07-19 12:46:54 +03:00
Tor Lillqvist
eae43a262b
Drop unused LogPrefix variable
...
Also gets rid of a potentially problematic strncpy() use that causes a
gcc warning: specified bound 256 equals destination size
[-Werror=stringop-truncation].
(Whether that would have caused a problem or not depends on how
LogPrefix would have been used, and whether it ever would have been
filled completely, without any terminating nul character, by that
strncpy().)
Change-Id: I92dba3726e3f46777d9b4c8cf88f557c02788fe0
2018-07-19 12:16:19 +03:00
Tor Lillqvist
ff31f2dba1
Avoid potential confusion by not using the term "packet" in a comment
...
It confused at least me for a while into pondering whether the code
thinks TCP is packet-oriented.
Change-Id: I143fc7821abd6b4023d551cdcb42a00e1613e466
2018-07-19 11:39:45 +03:00
Tor Lillqvist
6b96c73f46
Don't log binary data as such, use Util::stringifyHexLine()
...
Also, log the cases with still incomplete data in the buffer
separately.
Change-Id: Idfa915378c2823dd898789d6a63a0cd71a817b8a
2018-07-19 11:36:11 +03:00
Tor Lillqvist
1e7a56ddc6
Add FIXME: Do we really want to log binary data as such here?
...
Change-Id: I386d3c377d698f25da5094d87cd82183fc36aee4
2018-07-18 21:16:49 +03:00
Tor Lillqvist
86a20fc927
Allow also the IPv6 loopback address ::1
...
Change-Id: I4e079095d0a599f36b1d48d7a1311db75e3d79bf
2018-07-18 17:54:45 +03:00
Pranav Kant
5521af3826
loleaflet: use larger savemodified icon
...
otherwise it doesn't match exactly, in size, with save icon resulting in
ugly transition.
Change-Id: I0ce25253b1436d6e4343c61e83a8a06941964eba
2018-07-16 15:55:37 +05:30
Pranav Kant
a5c58228c6
loleaflet: switch all icons to colibre
...
Change-Id: Id13c9a8c726c8b99849b6be201dcc2a1e7ea36ef
2018-07-16 15:55:37 +05:30
Pranav Kant
4691eb32d7
loleaflet: rename image file names as they are in core.git
...
use the original file name from the links.txt file for currencyfield.svg
Change-Id: Ib28b4aa82705b83145dd4e2cc2c6ec6ad9fa8a9f
2018-07-16 15:55:37 +05:30
Pranav Kant
a2de2713b8
loleaflet: switch to colibre svgs for shapes
...
Change-Id: Iba42bcea55b3b172d21139352347c0bfbb59e7e6
2018-07-16 15:55:37 +05:30
Andras Timar
3719faf5e9
loleaflet: remove latin access keys in parentheses (in case of CJK, Indian, etc. langs)
...
Change-Id: I15763165535771511a4871882dd067fc689baaa3
2018-07-16 09:04:05 +02:00
Andras Timar
d239a3b373
adjust paths of toolbar.js and unocommands.js
...
Change-Id: I0373f1a05d18a85d5e351fd11bf3b81c43367279
2018-07-16 09:04:05 +02:00