Commit graph

3041 commits

Author SHA1 Message Date
Andras Timar
17abf005a8 loleaflet: Collabora Office version x.y-z style in About box
LibreOffice is unaffected
2016-06-22 23:35:10 +02:00
Pranav Kant
10a5f8c08b loleaflet: l10n: Placeholder for product name
Change-Id: I883ff7e42cf37cd457b6cfcc065fff47b3dc469d
Reviewed-on: https://gerrit.libreoffice.org/26573
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2016-06-22 20:36:36 +00:00
Pranav Kant
55ead88236 loleaflet: Kill simplemodal library
Its use has been superceded by vex now

Change-Id: I4b032dd6e5de61548b76b56e946ced6fc86734d3
2016-06-22 20:09:35 +05:30
Pranav Kant
a789cff8e8 loleaflet: Migrate about dialog to vex
Change-Id: Id853ec14d817b2f4312dee70a087a4ac526e951b
2016-06-22 20:09:32 +05:30
Pranav Kant
1a46db62bd loleaflet: Workaround for an upstream bug in vex
https://github.com/HubSpot/vex/issues/43

Change-Id: Id26be54a3a1120119bddad442e30b5f71f1e2605
2016-06-22 20:00:26 +05:30
Pranav Kant
c632cf5716 loleaflet: Migrate keyboard-shortcuts dialog to vex
Change-Id: I82324405ee1205becea00fc1de97c248988ab378
2016-06-22 20:00:23 +05:30
Pranav Kant
42ebabb3a9 Update bundled headers
Change-Id: Ifa69fec15df328d97d5d2c207dcd47c0d3ff660d
2016-06-22 14:52:07 +05:30
Pranav Kant
e48a36816e loleaflet: Remove Help button from toolbar
... as we have this as 'Keyboard shortcuts' in menubar now.

Change-Id: I01f3735c6b1ac07d8bced2f98fc9dd514a178ce0
2016-06-22 14:43:47 +05:30
Mike Kaganski
47a17fa8d0 testCloseAfterClose: don't hang on bytes==0 && flags==0
At least in some versions of Poco (namely, 1.7.3),
WebSocketImpl::receiveBytes may return both bytes and flags equal
to zero. It makes the HTTPWSTest::testCloseAfterClose() loop
exit condition to never happen, thus test hangs.

According to WebSoket.h, "A return value of 0 means that the peer
has shut down or closed the connection".
Thus, this modification makes this loop robust.

Change-Id: I5dd4f30936dd8246c966f094f2fdae9a45b89ff9
Reviewed-on: https://gerrit.libreoffice.org/26547
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-21 23:07:35 +00:00
Pranav Kant
8bba9da761 Make new version string as a JSON string
... easy to differentiate on client side among various version
info parts, especially for LOKit version information.

Change-Id: I4ba18c60367fb9166462b535bc46953a82a8435d
2016-06-21 22:12:48 +05:30
Andras Timar
9e7b978f9f loleaflet: bccu#1901 Control.RowHeader.js and Control.ColumnHeader.js for l10n 2016-06-21 16:44:20 +02:00
Andras Timar
bc4633a2a1 loolwsd: avoid NotFoundException when per_document.max_concurrency is missing (old config) 2016-06-21 16:15:53 +02:00
Pranav Kant
b460769eed loleaflet: 'Keyboard shortcuts' in new 'Help' menubar item
Change-Id: I0a924505970e9ed13ea45ebc85ef14a618646b2d
2016-06-21 19:16:20 +05:30
Pranav Kant
31009fa9c1 loolwsd: Handle document URIs with spaces
DocumentBroker stores encoded docKey, when child answers with
dockey in its query params, Poco::URI::getQueryParameter gives
decoded docKey -> mismatch -> document load failed.

Change-Id: I53d7cf9d932b9193f15f56ec74db24e279cf3b94
2016-06-21 16:06:12 +05:30
Pranav Kant
90aee41c70 loleaflet: Dialog to show loolwsd, lokit version information
Change-Id: Ie05f0597d3464b5e7705bd1d1ff4ab5c03af013f
2016-06-21 15:05:11 +05:30
Pranav Kant
b83ac269fa loolwsd: Send LOKit version information to clients
Send as a response to 'loolclient' message received from the
client

Change-Id: I3d33f9fd087489aa9bf5a94f591ab04e208cbf13
2016-06-21 00:30:36 +05:30
Pranav Kant
e271995ed2 loolwsd: Restructure version information functions
... so that version information can be sent to clients.

Change-Id: Icc90f31fabb501f816ff1dca0c618a73660c88bc
2016-06-21 00:29:41 +05:30
Pranav Kant
7701de1e48 bccu#1894: Don't show any outline for menubar selection
Change-Id: Ifa3095247a0c18c599c2c294a473add8f6d48104
2016-06-20 14:11:52 +05:30
Pranav Kant
76178f22e5 loleaflet: bccu#1887: Enable keyevents on menubar
Make it focusable. This also enables ESC key to reset the opened
menu.

Change-Id: Ia7be49af45b25ae7d29a5ba95b83591af0d82dca
2016-06-17 09:10:12 +05:30
Pranav Kant
3de264c3fd loleaflet: Hide its submenu when clicked over highlighted menu
Change-Id: Id1249e5d4a0d2013e1dd2a5f8833b3b787b1a137
2016-06-17 09:10:12 +05:30
Pranav Kant
50a237dd29 loleaflet: bccu#1867: Do not scroll first time after doc resizes
This was removed in c7588f0e8c in
an effort to fix calc row/col offset where it must not be ignored to
have aligned row/col offset without any side-effects that one can
have in single-part documents like writer.

Earlier approach using a timer of 200 ms for 'scroll ignore' also
doesn't seem very effective, so change it to: ignoring the first
'whileScrolling' invocation.

Change-Id: Ic3a6868a279fc200b8f9fee74bb40aebad5d9646
2016-06-17 09:10:12 +05:30
Pranav Kant
be6acfcd4e loleaflet: Remove superfluous call
Option 'updateOnContentResize' is true by default, which means
this method is called automatically when scroll container is
resized, so no need to manually call it again.

Change-Id: Ie80e90239752acb119e3a92c09a1f77dd61b2ad4
2016-06-17 09:10:12 +05:30
Andras Timar
69924630cf loleaflet: Pull translations from Pootle 2016-06-18 13:38:31 +02:00
Ashod Nakashian
d1d9ec6168 loolwsd: max_concurrency setting added
Change-Id: Iae3789d26ed2e1aba3806a6f99511fa6c7097988
Reviewed-on: https://gerrit.libreoffice.org/26449
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-17 23:59:47 +00:00
Ashod Nakashian
bf66f7a908 loolwsd: Calc tile rendering test with editing
Change-Id: Ib02a079bf1e4e90c7dfb65b6038b3ca1423a673c
Reviewed-on: https://gerrit.libreoffice.org/26448
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-17 23:56:26 +00:00
Miklos Vajna
5e1b210891 Util: pass by const ref 2016-06-17 09:18:26 +02:00
Miklos Vajna
75db2dd33b loolwsd: disable unit-fonts for now as it's unstable 2016-06-16 13:45:20 +02:00
Miklos Vajna
3c32bc1724 LOOLKit: fix loss of callback during initializeForRendering()
Impress deletes the current view and creates a new one during that call,
so make sure at the end our registered callback is not lost. With this,
the order matches how it's done in gtktiledviewer.

This fixes the HTTPWSTest::testInsertDelete() test when per-view
callbacks are enabled.

Also remove the assert from TileCacheTests::testTileInvalidateWriter()
that would assume something is invalidated right after load: the hope is
that it's possible to load a document without invalidating anything...
:-)
2016-06-16 12:15:11 +02:00
Miklos Vajna
70f5b914f6 TileCacheTests: assert before possible nullptr deref / div by zero 2016-06-15 18:04:57 +02:00
Miklos Vajna
afb6a7ebb0 Util: turn TerminationFlag into an std::atomic<bool>
Running unit-fonts under helgrind points out missing synchronization
there.
2016-06-15 15:31:41 +02:00
Miklos Vajna
9ac53ef5f5 TileCacheTests: disable testTileInvalidateCalc for now
It fails for me and Ashod as well.
2016-06-15 15:30:37 +02:00
Miklos Vajna
f64534404c loolwsd: document setclientpart command
At least I guess this is the purpose of it, based on commit
b9884a470a (loolwsd: be aware of the
client's current part, 2015-07-21).
2016-06-15 14:31:52 +02:00
Mike Kaganski
9ef285cc33 loolwsd unit test: invalidate tiles while typing
This test simulates characters and combined characters being
typed to loolwsd, and verifies that each causes tile(s)
invaliations

Change-Id: I670659de3a9eb71e94c366c96e69e6efd4338c38
Reviewed-on: https://gerrit.libreoffice.org/24928
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-14 22:20:36 +00:00
Andras Timar
cd67dc7022 loleaflet: update translations from Pootle 2016-06-12 16:06:13 +02:00
Andras Timar
445f97a0c7 loleaflet: hide context menu after pressing ESC key 2016-06-10 23:42:11 +02:00
Andras Timar
ec15d9e9ff loleaflet: l10n of src/control/Toolbar.js 2016-06-09 15:26:08 +02:00
Pranav Kant
257b95f01f bccu#1871: Add url prefix, lool, to post requests
All post requests will now have to be prefixed with /lool/

This is necessary to ease proxy url redirection setup.

Change-Id: I04fbc211879722f6433cb9eb17786f394187a1b9
Reviewed-on: https://gerrit.libreoffice.org/26091
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2016-06-09 11:22:05 +00:00
Pranav Kant
8cc367638f bccu#1871: Add url prefix to websocket urls
Normal websocket connections are now :
/lool/ws/filename

Admin websocket is now :
/lool/adminws/

Change-Id: If39382cb852d89ed0394adbd7fe168fe4767a075
Reviewed-on: https://gerrit.libreoffice.org/26029
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2016-06-08 14:06:20 +00:00
Andras Timar
c5198fa855 loleaflet: unclosed tag in loleaflet/spec/loadtest.html 2016-06-08 14:56:08 +02:00
Pranav Kant
2e2373dfa0 loleaflet: Fix loadtest
Change-Id: I6307a12858478b42d3a3253e7d01a52b7ea42282
2016-06-08 15:47:53 +05:30
Miklos Vajna
f209773f0a loolwsd: fix naming style of static members
README suggests not using an initial underscore for those. Rename the
few cases which don't respect this recommendation.

Change-Id: If36a36da9374597f6b9090e7f81a1b3fb2f23647
2016-06-07 09:18:49 +02:00
Pranav Kant
b230dcb26f loleaflet: Kill modules.zip
... and save ~3MB of space.

Change-Id: Iaa5cb62936d66044b657e6a507237a90f1d0a537
2016-06-06 16:28:57 +05:30
Pranav Kant
a32ded9752 loleaflet: Move websocket module to devDependencies
This module is only used from tests. These are not hard
depedencies.

Change-Id: I9b63562de827f9d2e12fa108555cc783a5689db2
2016-06-06 16:24:54 +05:30
Pranav Kant
3ec6c6b662 loleaflet: Reduce z-index of auxiliary toolbar
Otherwise, when the screen becomes inactive, it is the only
widget to shine separately.

Change-Id: Idf22e2cece3fd465ff37e7304f4776dbfdef66a8
2016-06-06 11:50:59 +05:30
Ashod Nakashian
3b6009fa56 loolwsd: fixed testLoad12ods
Change-Id: Iec0bb481da7af71b210463613617a7272209bfb3
Reviewed-on: https://gerrit.libreoffice.org/25947
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-06 01:55:18 +00:00
Ashod Nakashian
6b1a57c9eb loolwsd: improved random directory generator
Change-Id: I611debe9cd33b8b15c2fab3c49ad19cc6ad6a995
Reviewed-on: https://gerrit.libreoffice.org/25946
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-06 01:54:45 +00:00
Ashod Nakashian
d73167b734 bccu#1826 writer: jump to top when switch editor
Change-Id: I9d6f64d1e17f9dd5fb4e7d1b3ac8416be4623822
Reviewed-on: https://gerrit.libreoffice.org/25944
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-05 23:58:01 +00:00
Andras Timar
7e625d5f42 loolwsd: respect server_name setting 2016-06-05 16:38:48 +02:00
Andras Timar
c3fe386dc0 loleaflet: enable l10n of Color picker widget 2016-06-03 12:25:54 +02:00
Pranav Kant
3042580873 loolwsd: Increase timeout for admin test
... to 60 seconds. This one contains a lot of sub-tests. Further,
loolwsd shutdown is consuming approx. 15 seconds out of this
limit. The default 30 seconds, hence, is not enough for this one.

Change-Id: I0c29c92f6be0140cb62b58dacb57392e264d7f30
2016-06-01 21:58:07 +05:30