Avoid lots of indirection and complexity based on the new,
simplified sidebar JSON hierarchy from the core.
Change-Id: I73d5c6af30d40e9a430e0f3df3b78b620f425e39
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86510
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Possibly a good idea for Android, too? See bug report for description
of what this fixes.
Change-Id: I6b70f431ced09044756c2edc3fcc2542428b62e1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86484
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
So that they are in-process, which means it's easier to debug when they fail.
Change-Id: Icb3d7a7d0ffa7371eb3056b5de7144137c0acb8a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86463
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
rm -rf of the assets was newly introduced, done after copying the
templates to their place. So missing templates => crash; fixed.
Change-Id: I53d243b4f44c2c38843336e38e603ae0bd4b3c89
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86449
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
It has been added an attribute 'disabled' when permission is
'readonly', otherwise it is removed
Change-Id: I64a4cf9a7a754d66862e55805202358b9f83caf8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86442
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
The mobile and desktop prevents default 'contextmenu' action
Change-Id: I89171c955c153b2fceaad92970e2eaf039cb8527
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86373
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Insert Shapes dialog opens on the right
side of the screen and can be too
narrow on desktop
Change-Id: I8f9fe8f00989b504d05282fcd5332bf1a1b94ad0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/85747
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
By implementing mobileapp: false in the panel builder.
Change-Id: Id518fb4b02598511403eac4cef53e94317042fd4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86370
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Also add option to enable/disable on-line spell-checking to the menus too.
Change-Id: I1ba2a68c7d410041b6710f598a7c7fc60511ffee
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86371
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Amazingly more time was spent allocating, wiping and freeing these
vectors on Android than the actual rendering of pixels in a profile.
Change-Id: I49ea093816eba0f4187613ab6c8dc24d8dcba75b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86335
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
- Enable and adjust elements when on mobile so they are visible but discreet (without covering icons)
- Make them not clickable when on mobile (thus avoiding unwanted scrolled due to users mistaps
- Make their parent aware of the ongoing scrolling and call w2ui resize on it (thus making the left and right indicator showing and hiding as we please)
- Test and adjust so this changes do affect affect the click listening on desktop etc
Change-Id: Ic35dadb71e7fd6ae3ff2fad3e52d5219e7520c55
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86364
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Horrible hack, but works for the specific case described in the bug at
least.
Change-Id: I55150d84dc892ece69540fdc0d06bc277891c1fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86328
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
There are global variables when the early websocket connection
is in progress while the bundle JS file is being downloaded,
so in order to not confuse it is preferable to move to another location.
Change-Id: I9fe144dea6bf36abd16fcf00259acca93674eff9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86308
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
There are global variables when the early websocket connection
is in progress while the bundle JS file is being downloaded,
so in order to not confuse it is preferable to move to another location.
Change-Id: I36b3e52c87666c5a805c2286af45ec5b44d79619
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86296
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
To identify Browser, it has a specific section in L.Browser object
that detects any type of browser, so let us be consistent and move
the global variable "isInternetExplorer"
Change-Id: I3f744ea21a2e051a0ad4255fcd280af4549b6ef7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86292
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
This fixes the annoying effect to blur and focus again
when the graphic is editing.
Change-Id: I3b26cf0a3aaa6418062121279f65df3753e179a6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86289
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The android browser application changes the orientation when the
soft keyboard pop ups, it has been given a heuristic number 2/3 screen height
to hide the slide sorter, this is because there is a header size
that show the URL bar and it can be improved to the equal screen size of the
native Android app.
Change-Id: I182795fe698bf191cd5b675c1768820ab78b1602
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/85333
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Happens with some close frames eg.
[ docbroker_001 ] TRC #21: Incoming WebSocket data of 6 bytes: 88 80 4a 2c 44 f9 | ..J,D.|
fin = true
OpCode is Close (= 0x8)
hasMask = true
payloadLen = 0
headerLen = 2 -> 6 after hasMask is taken into account.
Change-Id: I0e212e4589c3cc63db16f7065dc90cd0bd539ada
Use a fully reliable uniqueness check, rather than a hash, and get
simpler ids as a bonus. Fetch view data from the session itself
rather than passing it in too.
Change-Id: Ibcd625156b5a98eb280e35d6537b5c8c026d0197
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86150
Reviewed-by: Mert Tümer <mert.tumer@collabora.com>
Tested-by: Mert Tümer <mert.tumer@collabora.com>
This patch fixes the following issue:
- Open a spreadsheet.
- Enter a few chars in a cell, and press enter.
- Go back to the cell, and in the formula bar, enter more text.
=> Characters are inserted backwards.
Change-Id: I6930fab44c6cacdd4710d363ca3bf15d564b64e4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86100
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
- Remove specific id rules and swap them with class rules
- Decrease row's width
Change-Id: I058c2bd80070df1d238eb978e8e616081a4b3d8c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86187
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Previously clicking into the search input field did not hide the cursor
in the document.
Change-Id: Ia524d39de0825190c51257a3c9a0a4257ca45150
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/83353
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
It is necessary to trigger the system dialog to get the user's consent
to access the SD card, so let's show it right away instead of forcing
the user into the general provider settings activity.
Remove various sub-Android-5 code.
Various other details here and there to make it work.
Change-Id: Ic06ce39d17778c97e8e5c8f38b8ecf34338c3c28
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86137
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
We don't target anything below Android 5 any more.
Change-Id: Ic6bb8b0fbd64af6a061dba1422cafc144509c67a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86136
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
