And re-enable a number of previously
disabled tests. They seem stable.
Change-Id: I6d263708edbf1ca0411500a6876e110be8acb326
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Make sure that the logging subsystem is
already initialized before starting
unit-tests.
Change-Id: I2ce3ffdb2d3b0094ae7ed496d7cacfc02af89c21
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Better to make all error messages related to storage consistent and
avoid mentioning admin or administrator and respective %storageserver
link
- In some situations %storageserver domain is not the right place
to redirect users (integrator might have another support system in
place, etc)
This is a follow up from
- PR: Do not assume who the user needs to contact for storage space
- Commit: 2ace217813
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id49e4b7f775c1ded10fb02648c7525c6e9becf20
if the tile has a Canvas as tile element then it never gets cached.
All was apparently well at:
commit c812edc7d3
Date: Mon Jun 7 12:31:26 2021 +0530
fix avoid putting empty tiles to cache
where the change to cache only if tile.el.src is non-null was added.
But by now tile.el can be (usually is) a canvas and generally doesn't
get cached here.
It seems to work fine to just cache the Canvas directly.
note: This cache guard itself flip-flopped a bit in:
commit 6db9771896
Date: Wed Jun 9 15:45:07 2021 +0300
CanvasTileLayer: Use el instead of el.src.
where changed as:
- if (!(this._tiles[key]._invalidCount > 0) && tile.el.src) {
+ if (!(this._tiles[key]._invalidCount > 0) && tile.el) {
but reverted in:
commit 115d20082d
Date: Tue Jul 6 15:59:08 2021 +0300
CanvasTileLayer: Correct the check for the tile source.
back to:
+ if (!(this._tiles[key]._invalidCount > 0) && tile.el.src) {
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I1760f94c0aebd10b75f936f23460f96159c736af
Changed to open PropertyDeck as it does in tabbed mode.
Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: I39c0efe7428d2ff3240f16578c154be820374517
Added navigator button to draw, just like in writer, calc, impress.
Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: Iab06ff192357d9cfb47d373f0cf0dfd181f3e052
Added Desktop tests for calc and impress.
Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: I80616cc9e8a9dd7160e9b33fa50047db83911590
Added Desktop, and Multiuser tests for writer.
Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: I1bbb32303c66eb499cb837289a51caafdf2055a8
Somehow escaping was disabled for this safe text we generate.
Change-Id: I47fbf72b9d47a80975ca1b926ff2d27c248fac12
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
we didn't check if zotero was already initialized what caused
reload of the notebookbar when any new user joined to
collaborative editing
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5a518d579ccb9e73007131ba64fb8c7972360155
identfieldbox and box3 use the same css class see #6392
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I7a95fdd8ae3a9bfffbe676917cb412a99cb40818
This hard coded width is not needed and was imposing that width value
to #indentfieldbox even if there is other elements present resulting
in the whole container being bigger than the sidebar itself
This issue became more evident with
27fddae9c6 (even
though it's not related to the bug but rather exposed it even more)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I90e684b395b950e4cc25a96a9875d4702016411d
followup for:
commit 012b00d
linking-api: always response for thumbnail render requests #6229
in calc and impress we don't get cursor message when switching to
target (slide, range), so don't check if target was reached,
statechanged messages are good enough signal we are loaded already
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I63aa5aefeef153d4d6e2b483e1cdb7bf2c6268ac
Better to align everything to start so if the components differ in
width they will still be aligned (as opposed to be laid out in a staircase)
This is a follow up from 1bfbdf8072 coming with
the following PR https://github.com/CollaboraOnline/online/pull/6389
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic607567d30656cc122f9cbfd71bd3d910ebfe9bf
- Do not appear above color
- Re-use tooltip styles
This fixes https://github.com/CollaboraOnline/online/issues/6293
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idf67c23b2263e5eeabc70a7128087333856aa465
It seems the following commit
be04111173
had a typo 0px should have been 1px
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibf3b92964efd8a1a147abc853042fd70a406abaf
follow up for 25efeea0d8
missing const in modified function caused build error
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ic0f4ae39476e16a9a49904e06b44f26d2a5d4fe7
