Before opening the inactive dialog, we must check the existing of other
vex dialogs (for example when the user cannot open the file).
Change-Id: Iafa8684a02d444696e4d20e864cd3e68d1a59607
Reviewed-on: https://gerrit.libreoffice.org/78113
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
In case we fail to send the request, try again in 2 seconds (same value
as the session timeout) before giving up. This seems to be needed for
core.git dbgutil builds; but don't do that unconditionally, in case the
sleep is not needed for optimized core.git.
Change-Id: Ie9ad8c066b7988ca37729f797c4b8dbb0ae2cbd6
For now, add an entry "Save as PDF" to the File menu in the iOS app.
Handle in an iOS-specific way in ChildSession::downloadAs(). The PDF
is saved in the app's document directory on the device. The name of
the PDF is the basename of the document being edited with the "pdf"
extension.
Change-Id: Ib0059a86b03b978996eb4cadf230ba7f0abcba62
Reviewed-on: https://gerrit.libreoffice.org/77961
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
After commit 8e118889cb (wsd: leaflet:
support statusupdate: messages to sync clients, 2019-08-17), which added
a new hiddenparts= key, but forgot to adapt tests accordingly.
Change-Id: Ia5baefff37b88f5b173d65ae80a126f94b420cb0
Always log cipher list, and disable any chance of fallback
to deprecated protocols.
Change-Id: Ifdfc7a3e44e98b078a36fdda6f3c813354a79e60
Reviewed-on: https://gerrit.libreoffice.org/76465
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
StorageBase::_isExitSave was uninitialized:
wsd/Storage.hpp:181:38: runtime error: load of value 190, which is not a valid value for type 'bool'
#0 0xd02260 in StorageBase::isExitSave() const /home/vmiklos/git/libreoffice/online-san/./wsd/Storage.hpp:181:38
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior wsd/Storage.hpp:181:38 in
Seen during unit-wopi-temp.
Change-Id: I3284637d411450a35680f6499e9d29c6f94aa723
wsd/LOOLWSD.cpp:1034:14: error: ‘SSLEnabled’ is not a member of ‘LOOLWSD’
wsd/LOOLWSD.cpp:1049:14: error: ‘SSLTermination’ is not a member of ‘LOOLWSD’
Change-Id: I3e81431ef56f46a844733b797b4c443a77afeb6e
Reviewed-on: https://gerrit.libreoffice.org/77850
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
When the user pans with 2 fingers the document is moved in the
opposite direction. So we store the initial center point and invert
the offset to achieve the correct behavior.
Change-Id: Ief63aa39f56c3b812a90b392ddedc4ba21d813e4
Reviewed-on: https://gerrit.libreoffice.org/77846
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
When the leaflet.html is loaded, it fires the resize event, at that
instant the map does not exist nor the document layer. Once the objects
are properly initialized fire again resize to apply fit width zoom.
Change-Id: Ib8c149ca4ff20006884ad567f387d81d9d3086e1
Reviewed-on: https://gerrit.libreoffice.org/77845
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
No idea why window.mode.isMobile() did not work here - it does for me.
The previous code was causing a TypeError exception on the desktop.
Change-Id: I0108e2e4ac5d3ba487ac94b6459ea3f78032c606
Reviewed-on: https://gerrit.libreoffice.org/77839
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
_onDrag: function(evt) {
...
var first = (evt.touches && evt.touches.length >= 1 ? evt.touches[0] : evt);
var containerPoint = this._path._map.mouseEventToContainerPoint(first);
the result containerPoint.x is NaN and containerPoint.y is NaN
Change-Id: I0916df74b3f9179e7dcb937a1427d30a0ebbe61b
when selected on mobile.
Change-Id: Iee34ad4a878bacea1e11e754b41bf86734796b27
Reviewed-on: https://gerrit.libreoffice.org/77803
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(In the !ENABLE_SSL case.)
Possibly the SSL or not ifdeffery could be cleaned up a bit more.
Change-Id: I0c9b4e956dcd317d6622a7394044fed0c4f2d976
Reviewed-on: https://gerrit.libreoffice.org/77780
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
It seems that the _onPress function is sometimes called multiple times
in succession and then the toolbar got first added but immediately
removed again. Ugly hack to fix that.
But note that in this branch, copy/paste seems to be broken in the iOS
app at the moment anyway. Apparently the code that makes it use the
system pasteboard is missing, or does not get called.
Reviewed-on: https://gerrit.libreoffice.org/77574
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit c2956383b9f353ffa98ae4a3c8e21769d3f334db)
Change-Id: Id4f1569670e599a2b37afc9ae5d91f31661f72e2
Reviewed-on: https://gerrit.libreoffice.org/77789
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
In "real" Online, in a WOPI environment, it does something useful. But
not in the iOS app. So no need to have it at all.
Change-Id: I87a6b7badcba2899f850a1e15eae591e9ed8895c
Reviewed-on: https://gerrit.libreoffice.org/77742
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit c5d6c7dd402da6987cd01f3c0759b28b3503d85c)
Reviewed-on: https://gerrit.libreoffice.org/77788
As the menubar is now then always visible in that case, no need to
have the hamburger button in the toolbar either.
Change-Id: Iec1ae28858ad994d008c294e5fa4069c5e9bc7ed
Reviewed-on: https://gerrit.libreoffice.org/77740
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/77787
It will be superseded by the context menu, but that doesn't work even
in normal Online in this branch currently. Once it works, I can then
try to use the same styling for it in the iOS app as for the context
toolbar, to make it look like the native iOS "edit menu".
This reverts a3d9cf8999ac25bb2b2a5d6332d7ac6e2f7c7350, but for the iOS
app only.
Note that there are other problems related to copy and paste in this
branch in the iOS app. The copy/paste changes for normal Online have
caused regressions in the app.
Reviewed-on: https://gerrit.libreoffice.org/76192
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 5448916f98c1480cfbc64f58e6d4f1cdb3fd133f)
Change-Id: I5c13cd0a5ece9038aba774b229dd86ec9c6678fc
Reviewed-on: https://gerrit.libreoffice.org/77781
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Sometimes input event was not sent and dialog was not working.
Eg. spreadsheet -> menu -> Data -> Validation
Change-Id: I8d864fdd73866080df5dc0b9b84e8e39054f65e3
Reviewed-on: https://gerrit.libreoffice.org/75943
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 03ed7b6e6f109a1111ce1e566c15ff09cb4e5158)
Reviewed-on: https://gerrit.libreoffice.org/77777
Tested-by: Tor Lillqvist <tml@collabora.com>
This changes makes combo boxes in the iOS app work again. Unclear
what the situation for normal Online on a touch device is.
Change-Id: If84124d46ea015722e8079566fc04914ee2bc542
Reviewed-on: https://gerrit.libreoffice.org/75953
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 9e611b9398035ddb89a0dbc68f40388c2ec5cc4e)
Reviewed-on: https://gerrit.libreoffice.org/77776
for touch devices, it is not necessary to add mouse event listeners
Change-Id: Icc4ba5cacde47f79021d317af9b712ba17e84fd5
Reviewed-on: https://gerrit.libreoffice.org/77738
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
It is hard to debug the library if it is minfied,
it is preferable to non minified when --enable-debug is set
Change-Id: I7886d047d8aab90b68c12bb50964d263445d8afe
Reviewed-on: https://gerrit.libreoffice.org/77733
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Add 'View:Resolved Comments' menu item
Hide all comments in a thread when resolving them
Connect Show/Hide resolved annotations to the annotation manager
Change-Id: Ib646bdea3dfc30fde6a11aa13562db147afd7ae0
Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/76758
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Add 'Resolve' button to annotation context menu
Add 'Resolved' indicator to comments
Change-Id: Ie43e247635a14d3407535e02ec2012f0809d425c
Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/76757
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
This adds:
- support to freeze movement to x or y axis when dragging the
marker (depends on the marker type - column or row marker)
- change marker on hover, which uses a different image, which is
solved in css
- change cursor to col-resize / row-resize when howering over the
marker
Change-Id: I63bf5e82860ef75f2dfde31ee2ab7ede6f61ce70
Reviewed-on: https://gerrit.libreoffice.org/77652
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
WSD is responsible for checking permissions,
as we do with DisableCopy and DisablePrint,
but until now we allowed saving even on
read-only documents.
The reason, it seems, was that when we failed
to save a document due to disk space, we
set documents as read-only. So presumably
we still had to allow saving, so users
preserve their latest changes when the disk
has some free space. Meanwhile, we didn't
let users make further changes. At least
this seems to be a reasonable explanation.
Unfortunately this meant that we allowed
saving when the user had no permission,
or the document was loaded as read-only.
Now we no longer mark documents that fail
to save due to disk-space limitation as
read-only, and instead expect the client
to notify the user and (possibly) block
further edits. And read-only documents,
or users without write permission, are
no longer allowed to get saved.
This change makes sure that the ctrl+s
shortcut respects the read-only flag,
while we allow clients to disable
the default handler and decide what to
do (although now they cannot force saving
when the user has no permission, something
they could do previously).
Change-Id: I16c3b75fd3e54435d750948a25afd6f71c9f963b
Reviewed-on: https://gerrit.libreoffice.org/77594
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
