Commit graph

8664 commits

Author SHA1 Message Date
Tomaž Vajngerl
066a543902 tdf#124146 fixes for iOS
Change-Id: I67e596ba1f295556eac60c8cfa5b5c43e6273a34
Reviewed-on: https://gerrit.libreoffice.org/75071
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-06 12:54:32 +02:00
Miklos Vajna
c2c7982e5e Add TIFF load testcase
Fails with core.git commit ad8f4c4432e0c5c052b6f87977d1ad8663debe09 (vcl
lok: pre-load graphic libraries, 2019-07-04) reverted, which fixed TIFF
loading in the preload case (running in a chroot, no code available in
the chroot).

Change-Id: Ic46da0abcb13c4dd6fc1ce697b93e0b3062077d7
2019-07-04 17:57:01 +02:00
Tomaž Vajngerl
14275b837e tdf#124156 resize handle to header for resizing column/rows in calc
This adds a resize handle to calc column/row header, which is
enabled only on the currently selected column, which has a bigger
hit area, so it's easier to use - especially for resizing when
using touch devices.

Change-Id: Ia509fb61d0cc9161c585b17380f55034f77794ab
Reviewed-on: https://gerrit.libreoffice.org/74943
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-02 08:05:18 +02:00
Muhammet Kara
ca0196d02b Add TransformDialog dialog to Format and context menus
Change-Id: Ifdf5867f4ed5f5572f1c7a42fdb55bf2a8b17aee
Reviewed-on: https://gerrit.libreoffice.org/74895
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
(cherry picked from commit 0993b2c82fc9ec968cfbfdced72ea812cc7e2e2f)
Reviewed-on: https://gerrit.libreoffice.org/74898
2019-06-29 17:27:54 +02:00
Muhammet Kara
5f799639aa Add FormatLine dialog to Format and context menus
Change-Id: If3d100977b8bf81aa1cbf9ef15e17b47f8e23bc4
Reviewed-on: https://gerrit.libreoffice.org/74894
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
(cherry picked from commit 2cd7897cb20cbf927439585c6b24f44c58606e82)
Reviewed-on: https://gerrit.libreoffice.org/74897
2019-06-29 17:26:51 +02:00
Muhammet Kara
166ab80248 Add FormatArea dialog to Format and context menus
Change-Id: I16ed30306e717a8676b1b02b68a65805a497c791
Reviewed-on: https://gerrit.libreoffice.org/74893
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
(cherry picked from commit ec58a56ac8abad0111004e22cb789bdecf0cfaa2)
Reviewed-on: https://gerrit.libreoffice.org/74896
2019-06-29 17:26:04 +02:00
Samuel Mehrbrodt
16fcd37201 configure: Add support for custom icons
Change-Id: I573b4d7e745cdea6fdbecd2c3790078d1980bdf9
Reviewed-on: https://gerrit.libreoffice.org/74491
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-28 12:32:43 +02:00
Henry Castro
901ecca313 loleaflet: mobile: fix when the maker layer handler is dragging
Hammers library is used to recognize touch events, but when dragging a
marker it requires some tweaks to adapt it

Change-Id: I11d1be5a93a1e3c82f76c37dd7e0b754dbb0537d
Reviewed-on: https://gerrit.libreoffice.org/74701
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-25 16:19:20 +02:00
Henry Castro
ad711e458f loleaflet: use hammer.js library to handle touch events in Calc
Change-Id: I8cfd887e350f539bfa4617101b4d174f6d4ea8b0
Reviewed-on: https://gerrit.libreoffice.org/74700
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-25 16:19:00 +02:00
Samuel Mehrbrodt
3b9255bb41 Use pkill to kill process instead of killall
Using killall does not work, it gives 'no process found'.

Change-Id: I0e528ab8c0f6f0c4cb06ea5e6c436aecf2274688
Reviewed-on: https://gerrit.libreoffice.org/74679
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-25 11:35:50 +02:00
Andras Timar
82aeee991b typo: separeted -> separated
Change-Id: I962c1943a05d014e055093d30de9577d3360a280
2019-06-24 15:52:47 +02:00
Andras Timar
c5f5e7312a Allow Docker's 172.17.0.0/16 subnet in sample (default) net.post_allow.host array
Change-Id: I49ad6093e4f390ac2ae647615f81c2ebf1dcc469
Reviewed-on: https://gerrit.libreoffice.org/74620
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-24 08:56:14 +02:00
Aron Budea
2d182a3187 Make ODG view-only in discovery.xml
Change-Id: I09cc68f71ae432ba249dbf0940ea715fb6f8b7cf
Reviewed-on: https://gerrit.libreoffice.org/73692
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit a9aa9f316ddb085d88f7787034713665b65c73b0)
Reviewed-on: https://gerrit.libreoffice.org/74565
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2019-06-22 16:40:01 +02:00
Michael Meeks
38934525dd Cleanup sensibly on exceptions.
Otherwise atexit handlers can get very upset.

Change-Id: I693ff3ee43dd8eedc0838b633445ae81229b7fcf
Reviewed-on: https://gerrit.libreoffice.org/74516
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-21 17:06:43 +02:00
Jan Holesovsky
0ce797606c android: Create New File dialog rework.
Use a xml layout instead of ad-hoc creation of widgets for better look
(the widgets are not styled when created using 'new') and maintainability.

Update the label of the positive button based on whether the file will
be just created or overwritten (or hide it completely when the input is
empty).

Change-Id: I8cba88402dc4167ff053612b6101a3d7cf57b8c0
2019-06-20 14:15:25 +02:00
Jan Holesovsky
008b189cc8 android: Actually let's disable the obfuscation for the moment.
The rules apparently still need improvements.

Change-Id: I606a5c526df3500f964de5b3a9f2e2c577a0b25b
2019-06-20 14:15:13 +02:00
Jan Holesovsky
8f8e997e1b android: The JNI callbacks must not change names during obfuscation.
Otherwise they are not found when attempting to call them.  Particularly
problematic was the callFakeWebsocketOnMessage that is called from C++.

Change-Id: I9c99733d63583e7c568f0f708e7efbd92497b5fb
2019-06-20 14:14:59 +02:00
Jan Holesovsky
fe9b3d69d5 android: We also need to DetachCurrentThread().
And clean the exceptions too, otherwise we get failures in GetMethodID.

Change-Id: Id636002dd9d32cb7ea0db8ad906b11619f38ef36
2019-06-20 14:14:50 +02:00
Jan Holesovsky
297a4857ad android: Explicitly enable unipoll.
Change-Id: If48dc344bbe07a8633c05fc95c2e7ccd1719c288
2019-06-20 14:14:39 +02:00
Jan Holesovsky
5b10be08f2 android: Remove also the build/ subdir during make clean.
Change-Id: I62d3840f26f5a9be2fc5d02aece50813b7eda30b
2019-06-20 14:14:23 +02:00
Jan Holesovsky
f77c8cd967 android: make clean should clean the assets too.
Change-Id: I1cb2ddb1a7ed71234a5ffc9bdf3631d701df6e5c
2019-06-20 14:14:00 +02:00
Jan Holesovsky
22720ee7d1 Avoid a TypeError.
I've been getting this on Android, but suspect it can be a general
problem:

loleaflet.html?file_path=/storage/emulated/0/Documents/untitled.odt&closebutton=1&permission=edit:165 Uncaught TypeError: Right-hand side of 'instanceof' is not an object
    at global.FakeWebSocket.global.socket.onmessage (loleaflet.html?file_path=/storage/emulated/0/Documents/untitled.odt&closebutton=1&permission=edit:165)
    at <anonymous>:1:25

Change-Id: Ifa6a6b15843e0c8235b920cea07324db59282074
2019-06-20 14:13:29 +02:00
Jan Holesovsky
f485b2ea97 android/ios: Turn the --with-iosapp-branding into --with-app-branding.
This is needed for the Android app too, so generalize the switch.

Kill copying of the example documents into the APK when at that...

Change-Id: I5b575ade3e40cc0becd5c739077acff5299d3312
2019-06-20 14:13:09 +02:00
Jan Holesovsky
61f6189a99 android: Allow providing the package name via --with-android-package-name.
And when at that, tweak some settings for the release configuration.

Change-Id: Ib8dab481fb7734637076603347f8fde453455fda
2019-06-20 14:12:55 +02:00
Jan Holesovsky
8b349d589f android: Move versionCode to liboSettings.gradle.in.
Change-Id: I32ab573831d4b0d5ef08787ae6c8234b3caad0ee
2019-06-20 14:12:46 +02:00
Jan Holesovsky
9b7b2a7590 android: Use the full main.xcd and registry_en-US.xcd.
The current mobile-config.py filters out the sidebar-related entries
there.  Let's focus on the functionality first and optimize later...

Change-Id: Ia86d11ae1aea24c5ba7d7f1e238c9194e544508a
2019-06-20 14:12:36 +02:00
Jan Holesovsky
546f721699 android: Kill the extremely verbose FakeSocket logging.
This stuff seems to work fine, no need to spam the logcat this much.

Change-Id: I5e09ffe56f5b545fe755e06c17be1ef1c37ab7a1
2019-06-20 14:12:26 +02:00
Jan Holesovsky
001c8ee24c android: These have to be passed by copy too.
Without this, we get crashes later in GetMethodID when performing
send2JS().

Change-Id: Ia0d8a07d0a4f24dec17215a94c5bb3d0d77d19c8
2019-06-20 14:12:16 +02:00
Jan Holesovsky
2d2208e16d android: Copy images.zip into the APK too.
Will be needed for eg. the sidebar.

Change-Id: I4e39db8e593d5a4f52b23dcf70e4e791144f7470
2019-06-20 14:12:07 +02:00
Jan Holesovsky
29f981028e android: No initial spaces in the rc files.
Just a reformat, no functional change.

Change-Id: I516a4548ea3d188759a5eb37f273fafbc490df29
2019-06-20 14:11:58 +02:00
Jan Holesovsky
7a4290dc5c android: The BRAND_SHARE_SUBDIR is needed for the dialogs to work.
Change-Id: Ie65701e6ebe83f3f054c299c50327a2ae2ffe87f
2019-06-20 14:11:46 +02:00
Jan Holesovsky
bbab589ea0 android: Unload the document already in onPause().
So that it  doesn't end up running on the background.

Change-Id: I24386a2eecb740bfce7fcfb83c62aafadb36f7f9
2019-06-20 14:11:22 +02:00
Jan Holesovsky
92f83a84b0 android: Don't re-initialize LibreOfficeKit over and over again.
LOK is designed to be initialized just once, so avoid the
re-initialization here.

Change-Id: I7ad9235c36d5a4dee85437a95f358d13ca25a2a9
2019-06-20 14:11:13 +02:00
Jan Holesovsky
9794b85ff3 android: Re-create fakeClientFd for every loolwsd restart.
Also remember it in the thread itself, otherwise we are likely to close
the newly created one, instead of the old one (when loading the document
the 2nd time).

[This is the most important piece of the '2nd start crashes' puzzle.]

Change-Id: I3bb89882b6f3ac1493c47a27b4c4589b6996afab
2019-06-20 14:11:03 +02:00
Jan Holesovsky
9ea4f537d4 android: No need to have the loolwsd instance static.
When we don't treat it as static anyway...

Change-Id: I165c06390882cfb9870c338a361ec3c5216985c7
2019-06-20 14:10:55 +02:00
Jan Holesovsky
a742f95473 android: Initialize the LibreOfficeKit only once.
Change-Id: Ieeefaa94bc2eeb583fe0f815306c8fc76a02c327
2019-06-20 14:10:45 +02:00
Jan Holesovsky
834d6453c6 android: We avoid trace log level on Android, adapt accordingly.
Change-Id: I1d30e550fc22c70d7687a40ab0d1d853f099a232
2019-06-20 14:10:32 +02:00
Jan Holesovsky
2103cd39de android: Use the MobileTerminationFlag the same way as on iOS.
We have the same problems - lokit_main thread does not go away - so
let's get the code in sync.

For the actual MobileTerminationFlag background, see the "Introduce new
flag to speed up shutdown of the Online plumbing in the iOS app" commit.

Change-Id: I091a61472f2528971a7473e222bf79f6f33874a9
2019-06-20 14:09:59 +02:00
Jan Holesovsky
b2b3ccdee5 gtkapp: Avoid warning.
The gtkapp is to test functionality, not performance.

Change-Id: I357777f7bd5609af1e8b6658607c73b23b78e857
2019-06-20 14:09:37 +02:00
Jan Holesovsky
9f04503f34 android: Reduce the logging to 'debug'.
With 'trace', the logcat often ends up with 'Unexpected EOF' and nothing
else is logged until after you reconnect the device again.

Change-Id: Idd14a5100d49a4920be0a19b4d9b32e7fb158a12
2019-06-20 14:09:26 +02:00
Andras Timar
8b3d548747 force overwrite of ios-*.po when downloading from Pootle
Change-Id: Ib0184ebe1b7485af819979acf4df268a564772b8
Reviewed-on: https://gerrit.libreoffice.org/74437
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-20 12:12:28 +02:00
Miklos Vajna
9ec45224d3 WriterTileLayer: allow inserting comments when having a graphic selection
This requires core.git 351b9aefe3de7c68e907fdc7926d9b508560320e (sw:
implement inserting comments when an as-char image is selected,
2019-06-18).

Change-Id: I16142d949e97305adf692730bf697c7cd23d3ee7
2019-06-20 09:43:25 +02:00
Tomaž Vajngerl
fc8ab3fe7e tdf#124907 enable pan gesture for the dialogs
Also move panning the dialog to 2 finger pan, so that 1 finger
pan can send pan gesture event to the core.

Change-Id: I72e204d31ae12932bc18f63380475e45f0ccc065
Reviewed-on: https://gerrit.libreoffice.org/74088
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-17 12:19:58 +02:00
Samuel Mehrbrodt
8f029d972d Fix typo
Change-Id: Ib960a8b77ba293bbbe16b2ae91ed66d42364d64f
Reviewed-on: https://gerrit.libreoffice.org/74052
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-16 22:35:45 +02:00
kaishu-sahu
5a699dcf23 android: add slideshow support in the document viewer.
Change-Id: I33cb9b1591d98088bc8cf1fd13d710fa6ee131b3
Reviewed-on: https://gerrit.libreoffice.org/73727
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-14 20:39:27 +02:00
kaishu-sahu
3209a8c368 android: add print feature to the document viewer.
Change-Id: I9de03347bde73faac1e9285f775e9584bb48a08d
Reviewed-on: https://gerrit.libreoffice.org/73268
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-14 20:35:50 +02:00
kaishu-sahu
743f2e7bdb android: add rationale dialog for permission denial with "Don't ask again".
If the user denies the permission with "Don't ask again" ticked
in the permission dialog then the only way to allow the permission
is through android os settings.

Change-Id: I8f51ae7390a9565011d6172bcbd08b3666bd60e4
Reviewed-on: https://gerrit.libreoffice.org/73071
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-14 20:34:00 +02:00
Andras Timar
c13fe19667 docker: fix SSL cert generation with OpenSSL 1.1.1
Change-Id: I1534cd3d3da19ac17e65571e6e2f7e7b0a8e61ca
Reviewed-on: https://gerrit.libreoffice.org/73953
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-13 13:18:40 +02:00
Miklos Vajna
79133e7af1 test: avoid unnecessary copy in expectString()
Change-Id: Ic4d45b383d32e993cada3437f8af8599506a9692
2019-06-13 08:44:05 +02:00
Samuel Mehrbrodt
c52a951cd9 Remove remnants of insert footnote toolbar entry
The removal was snuggled in with

commit 63ecdd5d40
Author: Henry Castro <hcastro@collabora.com>
Date:   Thu Aug 30 15:59:29 2018 -0400

    loleaflet: update toolbar with new images
    
    ...and entries


Change-Id: Iaec8812f2944217ef996af25fa4f0ebec5874b2f
Reviewed-on: https://gerrit.libreoffice.org/73827
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-12 14:20:24 +02:00