If postmessage to insert custom button will arrive
early before we initialized notebookbar it could
fail in insertion into compact mode toolbar due to
not existing toolbar.
This prevents us from that error. It will be not added
at the time of postmessage execution
but we remember all the custom buttons in special
array, so when UI will be initialized it will be added there.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I07d86db49a50be70b0c091a66cf5e4be049211ce
Without that integrator doesn't know what happened.
We were silently ignoring messages.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I897a95b343a1b436745816ccbef7656f30981112
with the original 25 expected results from 25 requests
from cid#318925 Structurally dead code
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I236876fadd5b5c82ecdbcc52a13fc58e8513aa12
and
cid#318819 Uncaught exception
take a reference in the COOLWSD/DocumentBroker ctor, so indicating it
exists before the calls in the COOLWSD/DocumentBroker dtor, and so the
Admin ctor doesn't throw during the COOLWSD/DocumentBroker dtor.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I8190cc3594a5f81fedd355aeadcca45e532bda90
With this fix, user can open a new commen popup without closing a previous new comment popup.
Without this, a new comment section lingers at the background and new comment command fails until user refreshes page.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If7f151eb11d3f5d26dae2ca6331eb5dc0dfd9881
scraping the logs with:
if line.find('Backtrace ') != -1:
pid = re.findall(r'Backtrace ([0-9]+?) -', line)
if pid:
for file in os.listdir("/opt/cool/quarantine"):
if file.find(pid[0]) != -1:
...
shows an unexpected lack of hits
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I63b5e62a5d46627146763cb0f847b976017f6c4b
- Condition modified for getPrecision.
- it was not handling the cases for dot value less then 0.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I740f86e9477656d371ba3b8793bff99671444d7c
- jsdialog requires to create in the handler single root node
with id of the widget
- remove old style update by _refreshSidebar
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8ce6e832b2d27d25f54e9bf636572b8c97d3a7c1
queryselectorall('something').queryselectorall('something else') fails.
^ This JS error is fixed.
Also we don't have specific images for German help page. So we removed the "de" from that language list.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I69b56e8f4bd2b92835c4aca9c2284750f3df9455
for font selector and font size...
this makes us sure we initialize everything in Impress and Draw
too in case of reconnect
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I67ee15f470fa43965f6fbd91ae45cd330ea449aa
problem:
earlier restriction/lock status was sent to kit via browser,
now client session send this status directily to the kit.
this design will require less communication between server and browser
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I6b830f30fb326a5e6637e345250893cbba101de6
make -C cypress_test check-desktop
asserts seen in cypress_test/cypress/wsd_logs/coolwsd_output.log of:
coolwsd: wsd/DocumentBroker.cpp:3134: void DocumentBroker::sendTileCombine(const TileCombined&): Assertion `!newTileCombined.hasDuplicates()' failed.
If we check for, and don't reuse, an old request with a different
NormalizedViewId then we could end up with multiple requests with
different NormalizedViewIds that end up in the same final tilecombine.
similarly there was no check for different modes ending up in the
same tilecombine.
just split out the logic we have to see if two tiles have the same
properties that appear as a shared set of properties for tilecombine
and use that in the two relevant places.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ieb2ee0e85f124dd57c6b050e5b669dd808cf6bbf
TypeError was noticed where container was undefined.
This was case where snackbar was closed.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id465723e01bc2cec2e20056103a918e53abf6d09
problem:
this caused problem in autosaved comments,
when comment list is empty autosaved comments may be closed when focus is lost
partial fix: #7421
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I1fc2d087828ce44495001f97b5323dffb8adb2ef
- It logs activities like when admin logged in, authenticated
metrics endpoint accessed, external monitor getting connected
and admin actions like kill the document etc
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I059f6b6ee0d8269aec7e3f521622773e348304a3
for coverity always assert even if a previous test was to fail
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ic48654d828a5311e043f412d9c30139e25b40262
Also add a check for failed attempts of new comments.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I50a9981cf51475d6008e936e6e28573156a8383a
Set up accessible text through aria-description for describing how to
enable accessibility support for text content when it is disabled.
The description is reported by the screen reader on document load and
on explicit request to read current text content.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I439b7703c15d3b38c39181d27c11da438834c414
if we zoom in calc quickly that can result in still unfulfilled requests
for the first set of tiles from the earlier zoom in requestedTiles when
the new requests are compared with the existing one for duplicates, but
they are of different tilewidth/tileheight and shouldn't match as a
duplicate.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ifc3f905c5304feb6c05696835dcb4eaed7f1e546
AdminModel::cleanupResourceConsumingDocs uses SIGABRT as first
attept to kill misbehaving documents, we should give
DocumentBroker a chance to quarantine documents killed off by
SIGABRT as we do SIGSEGV/SIGBUS
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ic3a703572393050379b5a1444a5380bbeafcf2d3
we emit lots of warnings which are not important
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I59027c4d848a98ba3d9e8f4a3feafd3fcb62dec2
to make main JSDialogBuilder shorter and easier to read.
And move handler to mobile builder as control exists only
on mobile.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9a14c7050711658638d22f0fd7b47e038b5952a1
We only run one task in each thread when run() is called, then complete
the remainder of tasks in the main thread while the other threads wait.
https: //github.com/CollaboraOnline/online/issues/7374
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id4fc0a620d98b0bb55310b495eeff7411a4544b5
if we switch calc tabs quickly that can result in still unfulfilled
requests for the first tab in requestedTiles when the new requests are
compared with the existing one for duplicates.
It doesn't make sense to replace a request for a new tile with an old
request from a different part. But tilecombines are intended to share a
'part', so a single tilecombine shouldn't be synthesized from multiple
requests for different parts.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id8d40f0a7e7f9d32fed67a415756284d7f6a53d4
