Commit graph

9678 commits

Author SHA1 Message Date
Grzegorz Araminowicz
37eacf06ce Enable zoom animation for cursor
It prevents cursor from appearing in old position on large zoom level
difference (pinch to zoom).
It also provides nicer visual effect on desktop.

Change-Id: I9e2504dc54c47196441a1ea16e3422cce137d5a2
Reviewed-on: https://gerrit.libreoffice.org/83610
Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
Tested-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-11-25 16:12:32 +01:00
Miklos Vajna
5d3a2b3f56 wsd: fix -Werror,-Wmismatched-tags
Change-Id: I863c75c5af9a19dda306f574b4e90c5da3399d1d
2019-11-25 15:02:02 +01:00
Miklos Vajna
4358087be2 test: fix typo, unit-load should invoke code from UnitLoad.cpp
Change-Id: I47354f1d68075bc12a2e96832aeaa5f49ecb1d9a
2019-11-25 15:00:44 +01:00
Henry Castro
88a75e9a34 loleaflet: accept images encoded base64 for 'valueset' control
Now the LO Core server will send an image list encoded in base64,
these images are special because they were created by a function
in memory. I am referring to images of the "Table Design" panel.

Change-Id: Ia8660620729bb7f862505833ba197a6f3b68f184
Reviewed-on: https://gerrit.libreoffice.org/83539
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-25 14:33:20 +01:00
Tor Lillqvist
54e85d9cc2 Fix build without --enable-debug
Since c59bf4ed3a, $(ENABLE_DEBUG) is
eiher "false" or "true", not empty or "true". So we can't check it in
Makefiles with just $(if $(ENABLE_DEBUG),...), that will match also
the value "false".

Change-Id: I17c079f1c3a6346e9f0a0219f07f642673b55a98
Reviewed-on: https://gerrit.libreoffice.org/83663
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-11-25 13:49:29 +01:00
Michael Meeks
918d4ae150 Add quick link to check monitoring.
Change-Id: I069eeaf8464661aaff52f11523d70c40cc81cc46
2019-11-25 12:47:17 +00:00
mert
8ca7391f05 Added an option to override watermark texts
in loolwsd.xml. If set, watermarks will be the same
as entered for all the views instead of per view
watermarks sent in CheckFileInfo

Change-Id: I0943520423abc2567f44920f8679057b3cfbf01f
Reviewed-on: https://gerrit.libreoffice.org/83666
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-25 13:10:05 +01:00
Gabriel Masei
2164f5207c Add REST endpoint for admin metrics.
Change-Id: I701485631931334d27594c4907cb770f9888e5bf
Reviewed-on: https://gerrit.libreoffice.org/82492
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-25 13:06:01 +01:00
Tor Lillqvist
09f64252ab Ignore the ios/Mobile/Branding directory, set up by the configure script
Change-Id: Id320ea554ff74476699cb8bde399018aae9e6ee8
(cherry picked from commit 1aaceb02c5d9521298573fa7c554c4a76135fd21)
2019-11-25 11:19:31 +02:00
Miklos Vajna
2ce1a7f61c test: clean up not needed memset()
Use std::vector instead of a C array, where the elements are initialized
with zero values by default.

Change-Id: I3c69b588e2a2c3deba052eae35da87a3d085491e
2019-11-25 08:28:12 +01:00
Andras Timar
c59bf4ed3a ENABLE_DEBUG default value should be false and not empty
When the default value was empty, @ENABLE_DEBUG@ in loolwsd.xml.in
was substituted to empty string, not to "false" as intended in release
builds. As a consequence, in new installations, the loading of the
loleaflet.html gave 400 Bad request error with a not very helpful
error message:
wsd-00922-00928 2019-11-24 16:05:55.384859 [ websrv_poll ] INF  #23 Exception while processing incoming request: [POST /loleaflet/08aa7d914/loleaflet.html?WOPISrc=http%3A%2F%2F172.22.64.173%2Findex.php%2Fapps%2F...]: Syntax error| wsd/LOOLWSD.cpp:2244euex4o&title=About.odt&lang=en&closebutton=1&revisionhistory=1 HTTP/1.1

Change-Id: Ia8bb18914bb49af057c4618f99124b0f22737f20
2019-11-24 17:36:24 +01:00
Tamás Zolnai
d00d996607 Fix admin console.
PID became visible after this commit:
	87b95bb546

Change-Id: I55da1cbafaf4422576214d1b8ee1710605765e31
Reviewed-on: https://gerrit.libreoffice.org/83609
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24 14:31:22 +01:00
Tamás Zolnai
02eb585f83 Allow items for chart context menu
Change-Id: I5843aa884f6f0e2ad3f1e9817ebe24767c5777ff
Reviewed-on: https://gerrit.libreoffice.org/83608
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24 14:31:13 +01:00
Tamás Zolnai
19e576772a SpellingPopup: Handle sapces in suggestion.
Change-Id: I09db2cd1db67797a50bc2943200f97aabb004fc6
Reviewed-on: https://gerrit.libreoffice.org/83607
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24 14:12:42 +01:00
Tamás Zolnai
7041d5c5b0 Update conext menu code to handle Spelling Popup
* Use unique IDs for sub menus.
* Handle uno command's parameter.
* When there is any parameter, we use the menu text.
* Avoid to enable FontDialog on other conext menus
* Introduce the command ".uno:None" to indicate that the
menu item can't be executed.
* Whitelisted spelling context menu's uno commands.
* Add a black list in unocommands.py to list those uno
commands which have no text in xcu file. In this case,
we can use the text sent in the menu structure.

Change-Id: Ie84fcb7d6c7a2f4cd50c666dbcd8c77cf42731de
Reviewed-on: https://gerrit.libreoffice.org/83606
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24 14:12:30 +01:00
Corentin Noël
08aa7d9149 Seccomp: add ARM support
Change-Id: I6982c6e68da5e2211f9dad0eb88fccab27230ed9
Reviewed-on: https://gerrit.libreoffice.org/83511
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-22 18:49:00 +01:00
Corentin Noël
b2f893ae0e Allow ConfigValueGetter to be used with uint64 on 32 bits systems
Change-Id: I5d19c97c6900cea6476e85afd4cfe9885f6c8fa0
Reviewed-on: https://gerrit.libreoffice.org/83513
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-22 18:48:05 +01:00
Corentin Noël
db67c9239b WebSocketHandler: allow to build on 32bits systems
Change-Id: Id51df359d9c985e72e9186433ce5dcf98e4199a4
Reviewed-on: https://gerrit.libreoffice.org/83492
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-22 16:23:35 +01:00
Miklos Vajna
204cff5c19 Avoid UB in Session::setHash()
Ubsan says that signed integer overflow is happening here:

    #0 0xec344a in Session::setHash(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) common/Session.cpp:267:17
    #1 0x918b54 in DocumentBroker::load(std::shared_ptr<ClientSession> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) wsd/DocumentBroker.cpp:682:18
...
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior common/Session.cpp:267:17 in

(While running unit_wopi_watermark.)

Change-Id: Idcb1692f6d5d0df8be35dc557d2d72a345acbcf4
2019-11-22 14:11:00 +01:00
Mike Kaganski
c39645bed5 Fix comparison of integer expressions of different signedness
Change-Id: Idcbaf83cb5f953cb725e5b84c27bc00b2fc267d6
Reviewed-on: https://gerrit.libreoffice.org/83475
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-22 13:03:38 +01:00
Corentin Noël
62ed202e2d Fix issues with size_t and ssize_t on 32bits machines
Change-Id: I3859e12e234b0fec6b94736cacc7874cd8809476
Reviewed-on: https://gerrit.libreoffice.org/83449
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-22 11:20:57 +01:00
mert
ed2c34296b Fix watermarks overflow the document area
Change-Id: Ia767d0b4f935bc28e0fb0ed0f8c2ddcfb8093734
Reviewed-on: https://gerrit.libreoffice.org/83441
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-22 11:15:56 +01:00
Miklos Vajna
0580f51f85 Convert doc load tests to a new-style one
So that they are in-process, which means it's easier to debug when they
fail.

Change-Id: I2dcef46ec76e1f971172d1c29adf09103cfeaa7b
2019-11-22 09:07:33 +01:00
Ashod Nakashian
ddb697bfa5 test: validate ExtendedData sent to WOPI
Change-Id: Ib5da41e7f1ca7547ea6ac43daefa4b0259ba4c41
Reviewed-on: https://gerrit.libreoffice.org/83045
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-22 01:51:34 +01:00
Ashod Nakashian
7c4ba459ff Encode the ExtendedData to make it safer while embedding in messages
Change-Id: I1d4bdb2775d89e9a52a96d833228ca8577ee3561
Reviewed-on: https://gerrit.libreoffice.org/83044
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-22 01:51:11 +01:00
Andras Timar
bbaf010f4f add wsd/ProofKey.hpp to dist tarball
Change-Id: I99a018ad2194f124df9e7a373f9268ba33b0a5e1
2019-11-21 21:39:01 +01:00
Michael Meeks
3dbee6745b Log an error, and return failure on unhandled responses to save.
Change-Id: Ib241a88e53a11276b3837f49ea6d964d706919a4
2019-11-21 18:44:38 +00:00
Henry Castro
547ee95284 loleaflet: update translatable string for "DeleteRowbreak" and "DeleteColumnbreak" UNO commands
Change-Id: I8afd32379f00cec19955603d3c096f81a6455474
Reviewed-on: https://gerrit.libreoffice.org/83423
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-21 19:04:18 +01:00
Miklos Vajna
0077b4ae6a wsd: fix -Werror,-Wmismatched-tags
If it's a struct, then forward-declare as struct, not as class.

Change-Id: Ia78d7c1bee222bd1f499fe93aaf2dda9b81f423a
2019-11-21 17:42:08 +01:00
Michael Meeks
994f8993d9 Add proof for locking calls (and mend the build).
Change-Id: I4cbaf682a14316750a676a14d986ecf59045581d
2019-11-21 14:34:36 +00:00
Michael Meeks
cabd30a1b8 Initial wopi-like locking implementation.
Change-Id: I3e16cfc40dbd29a24016b09e62afc9ec488300c7
2019-11-21 14:24:58 +00:00
Pedro Pinto Silva
1b79f11e94 Add style class to Menubar depending on the currect doctype
Change-Id: I039027a95547edc4c7a6a91bea6ab4d1f2f5d1d6
Reviewed-on: https://gerrit.libreoffice.org/83401
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-21 15:18:33 +01:00
Andras Timar
2f71f5d67e Update translations from LO core
Change-Id: I18f2eb8e7556526f26fd6c03d4f8198d1de6284c
2019-11-21 14:53:43 +01:00
Mike Kaganski
a986aabeb1 Initial implementation of proof-key
Change-Id: I7ab79218ca2af268dd4573cb64c6353dc71b5f03
Reviewed-on: https://gerrit.libreoffice.org/82232
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-21 12:56:53 +01:00
Szymon Kłos
0cc438db64 jsdialogs: remove unnecessary print
Change-Id: I04e6fd0443b68dc0867cc08bab8133bc0b3300fd
2019-11-21 12:26:16 +01:00
Szymon Kłos
a672d064c2 jsdialog: use uno states for comboboxes, impl FillStyle
Change-Id: I81d8c3d333e8c65291198b010772c8de9d8eb065
2019-11-21 11:42:25 +01:00
Tor Lillqvist
bdc2777798 Require use of --with-vendor when configuring for the iOS app
You want something meaningful to show up in Help > About, not just
your account's login name.

Change-Id: I1f30516200552f2bbe70091efa3b7029954a681a
2019-11-21 11:30:18 +02:00
Tor Lillqvist
26860d8f35 Add public.content to the UTTypeConformsTo arrays of the exported UTIs
The Nextcloud app looks for that.

Change-Id: I91d26f7dced0b0ca35275db7ebabf322e50e734d
(cherry picked from commit 481f498dfb31ad364c4dfae179c1a2baef8118ab)
2019-11-21 10:24:17 +02:00
Ashod Nakashian
876897ce96 wsd: kill with SIGABRT now that SIGTERM cleanly shutsdown
Change-Id: I198795be0cc399703f3207456ef0bfd1e3c3c844
Reviewed-on: https://gerrit.libreoffice.org/83359
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-21 09:18:50 +01:00
Jan Holesovsky
78e3dd0ae6 Revert "killpoco: Remove StringTokenizer from LOOLWSD.cpp."
Blind fix - I've seen a report of a problem with a 'Syntax error' caught
around this code.  Unfortunately cannot reproduce this myself, but
better to revert for now.

This reverts commit f637f4a75a.

Change-Id: I41cfa2a97127c430b2dd8140ad3f20b7f0eb221a
Reviewed-on: https://gerrit.libreoffice.org/83349
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-20 19:41:03 +01:00
Tor Lillqvist
c6497bda19 No need to "rescue" the clipboard in the iOS app
Change-Id: I805c14f2405eeed39127bdac29d7c93374ddc942
Reviewed-on: https://gerrit.libreoffice.org/83340
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-20 17:26:09 +01:00
Tor Lillqvist
908c422964 Add the mobileappuno things to the "non-mobile" menu too
("Mobile" here means "mobile phone", and the mobile apps run on
non-phone devices (tablets) too.)

Also propagate the mobileappuno thing in _createMenu.

Sadly this is not enough to make the clipboard functionality work in
the iOS app when built from core:cp-6+2 + online:master, though.

Change-Id: I3fb5a643981780479679f252ec8927f49d2f4f48
Reviewed-on: https://gerrit.libreoffice.org/83327
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-20 17:21:15 +01:00
Michael Meeks
d4b71cb73d Share code for reuse_cookies handling.
Change-Id: I9e4d66f14b46284c8d4f33173f028f0bcea34be2
2019-11-20 15:41:06 +00:00
Michael Meeks
68d81dae49 Read and store SupportsLocks property.
Change-Id: Ic405dfa5f6e759937094835f41787fa2cbe29f49
2019-11-20 15:41:06 +00:00
Henry Castro
6142bf5ad3 mobilewizard: restore document focus when mobile wizard is hidden
The "activeElement" returns the current element that has the focus,
so when the mobile wizard is hidden ensure the document gets focus back.

Change-Id: Id801a9995a31766441f445e7c1180c1672cf8adf
Reviewed-on: https://gerrit.libreoffice.org/83306
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-20 16:12:45 +01:00
Henry Castro
4358d2a04e loleaflet: remove the function removeControls
There is no toolbarContainer element anymore, it is better
to remove dead code.

Change-Id: Iac401698ee06223c5af3a69ac18f4bdc8f8c71b4
Reviewed-on: https://gerrit.libreoffice.org/83321
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-20 16:12:24 +01:00
Henry Castro
69084bd214 loleafet: use DOM Util functions to remove an element
Change-Id: I33ed32cd475ec90f930c9d6e4e900fafc6519ea7
Reviewed-on: https://gerrit.libreoffice.org/83325
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-20 16:10:34 +01:00
Pedro Pinto Silva
e73c672149 impress: slide preview: add left margin
Change-Id: I380d4b5ca988247a0beede6fc427e83a48601169
Reviewed-on: https://gerrit.libreoffice.org/83320
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-20 15:40:31 +01:00
Michael Meeks
87b95bb546 IE11 - adminconsole, polyfill and HTML cleanup.
Change-Id: I1cbc24aeb3c0398f399702ac9749a204b1b59a56
2019-11-20 14:33:55 +00:00
Pedro Pinto Silva
11df151290 * Ensure that any rule from mobilewizard does not spill out from smartphone range
* Fix impress slide previewControl misalignments (on desktop)

Change-Id: I009b75ba95870e3bd051b299113c90abb584c189
Reviewed-on: https://gerrit.libreoffice.org/83317
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-20 15:32:31 +01:00