Miklos Vajna
3859ca3119
g review: check if 'gh' is authenticated already
...
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I689348489f89d74b10782302d7bea57a845e36d4
2020-10-26 11:03:32 +01:00
Miklos Vajna
eb5c86a4d3
DocumentBroker::saveToStorage: guard against nullptr _storage
...
This can happen on a 'savetostorage' which is after a failed load.
Change-Id: Iad26bf6415c772c8646a119b0454c202873d6860
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-26 10:57:23 +01:00
Muhammet Kara
83df998f56
Create CONTRIBUTING.md
...
As recommended by the GitHub Community Guidelines.
It is recognized by file name and featured to contributors
automatically in various ways.
Signed-off-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: Ic408627e39d565f006c6f8591e110bcc9e97c17e
2020-10-26 05:45:29 +03:00
Ayhan Yalçınsoy
c1b8a64fce
Remove Poco/TimeStamp.h left-over
...
Change-Id: I78f76266a50f799306dcfd8ec996db54784acfd8
Signed-off-by: Ayhan Yalçınsoy <ayhanyalcinsoy@pisilinux.org>
2020-10-26 03:30:32 +03:00
Ashod Nakashian
2785b13a13
wsd: temporarily avoid race-conditions when creating documents
...
As the comment describes, this is a temporary workaround.
The issue happens when nocaps is enabled, no doubt due
to the timing difference from the more common (and default)
caps-enabled case.
Change-Id: I742d7b9fd63f0babe8e1d45b968e09026d78debc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-10-25 12:20:58 +01:00
Ashod Nakashian
45a065399e
wsd: improve wopi upload logging
...
Change-Id: Iec6c6f2f491266bc2d0b919acc6514c2871a7b7e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-10-25 12:20:58 +01:00
Ashod Nakashian
4ce0bd9e3a
wsd: fix templates with no chroot jail
...
Change-Id: Id47211e9e20173886af35ae92833f026354b2586
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-10-25 12:20:58 +01:00
Ashod Nakashian
d0dc93d910
wsd: better file size utility
...
std::ifstream's tellg() returns -1 on error.
This is handled very poorly and shows up as ULONG_MAX.
Luckily, we have Stat class that does the same
both more safely and more efficiently.
Without opening the file, we now get the necessary
information unambiguously.
Change-Id: I2448bc71e01b0f166a9dd66aa38a88ea97a50cdd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-10-25 12:20:58 +01:00
Ashod Nakashian
11c73db905
wsd: announce the log file location
...
And set the LOOL_LOGFILE envar only when
we have a path.
Change-Id: Ide5144c7e5aec5ddb9a5a6c32538e9e0a3a6ed0b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-10-25 12:20:58 +01:00
Ashod Nakashian
abf017ee5e
test: tabs -> spaces
...
Change-Id: I8a9a98b84babf1100a8526e5a08c3f22e81c8d1e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-10-25 12:20:58 +01:00
Ayhan Yalçınsoy
1ef9ad4f56
Remove Poco::LocalDateTime left-overs
...
Change-Id: Ia847ec0f1b5602cfa0790b8702aa70e74ecec160
2020-10-24 23:52:11 +03:00
Michael Meeks
e37856fefe
Add a Developer Certificate of Origin.
...
Change-Id: I55b33d92da8c04db3bd23746982993f56e10c935
2020-10-24 21:21:23 +01:00
Jan Dageförde
7aae0ddc4f
Simplify another Util::getHttpTimeNow() in headers
...
Change-Id: Ib2718e1dbcff20cd3fa1e6463287ca512f39efc8
2020-10-24 21:29:28 +03:00
Gleb Popov
8aaebf9e17
Add FreeBSD case to autogen.sh
...
Change-Id: Ib0e1cb3f34099a46e34e17a23e38d1c4bdb7dec9
2020-10-24 17:51:15 +01:00
Ezinne Nnamani
97d657699d
Created the cypress test for font-style attribute
...
Change-Id: I80de963384fe6c2fe50607083fefe3ea1eb46af2
2020-10-23 18:02:51 +02:00
Tamás Zolnai
5b0676bc3a
cypress: protoype an interference test.
...
The idea it to run an existing cypress test while
the same document is opened by a second user. The second
user does some activity (e.g. moving cursor, clicking, etc)
and we check whether it makes any interference with the first
user's view. The first user is doing the actual test's steps,
so we can see if interference breaks the assertions.
Now it's just a prototype for testing it in the CI setup.
Change-Id: I3e02c037754862d628c73bbb4b2d82ea84b8a719
2020-10-23 16:09:00 +02:00
Szymon Kłos
32b1ab0f67
Don't show comments switch if we don't have many of them
...
Change-Id: Iec0d83d2cc4423953cde6b677bb0b59b24176e77
2020-10-23 14:56:06 +02:00
Szymon Kłos
90f2251b8e
Switch comments also between pages #321
...
Change-Id: I59f5a9a9a44cd4d2bc5b1df9323b34890e1b673f
2020-10-23 14:56:06 +02:00
Szymon Kłos
7c7fe41f3a
Autosave annotations in pdf
...
Change-Id: Ic4fb2da63e761b78dedf9f67e0612e90e6d4be87
2020-10-23 14:15:50 +02:00
Tamás Zolnai
d401101833
cypress update: 5.1.0 -> 5.3.0.
...
Fixes this issue:
https://github.com/cypress-io/cypress/issues/8621
Change-Id: Ied225391e7e72dfd9df852481ad29b6368c194cf
2020-10-23 12:58:18 +02:00
Tor Lillqvist
58dd58c67d
Mention the iOS and Android app READMEs
...
I tried to add actual links to them, but my Markdown-Fu is too weak.
Change-Id: I7787bf9dcd661239588d2f4d1f36e8f610bf8856
2020-10-23 13:36:40 +03:00
Tor Lillqvist
0ad957a548
Even better app name suggestion
...
Change-Id: I3aa266342f20754cd26bedc4f0744eda7b7390cc
2020-10-23 13:15:49 +03:00
Tor Lillqvist
5de91a9707
Use correct branding
...
Change-Id: I3eda38c27e809dd73fa3d39b5e704a211b66fd6c
2020-10-23 13:14:12 +03:00
Ezinne Nnamani
a3b7a7c356
Created a cypress test for Clear direct formatting
...
Change-Id: I54ebe7fb81ca6598ba45f3cbed62474d103d055a
2020-10-23 11:52:52 +02:00
ihristova11
d6dfd80ee8
chore: bump eslint version to 5.0.0
...
Change-Id: I156d6a560130e232378dc3c6804a95f0ba03418d
2020-10-23 01:40:50 +03:00
Pranam Lashkari
0759ed7da3
leaflet: Shift+Enter will create a new line, not paragraph
...
Change-Id: I6a3f6ac133ccdccb0e208b283b09f818cfe321cd
2020-10-22 21:28:11 +01:00
Tor Lillqvist
0633b571eb
Don't show jsdialog tooltips in the Android app, either
...
Change-Id: I4cf0434a1a1f8c6f8ab8e963f2c0881d0df2f173
2020-10-22 23:05:34 +03:00
Nicolas Christener
be98e41c2b
Fix #391 , Add "Actual behavior" to GitHub issue...
...
* add the "Actual behavior" section
* fix usage of colons
Change-Id: Ie5c11ac096d8f88e1e7985943edc58b8883b635f
2020-10-22 22:06:55 +03:00
Tor Lillqvist
1c63b4a236
In the iOS app, avoid tooltips for items created by the JS dialog builder
...
Change-Id: I6418a359fd5e1d263a8663ff27e82b05eff5c396
2020-10-22 15:50:30 +03:00
Ashod Nakashian
8190cf7869
wsd: allow some time between retrying saving
...
Change-Id: I9d923582057467141a3f4d0b260b982464b60511
2020-10-22 14:40:40 +02:00
Ashod Nakashian
c71998438d
wsd: document forced storage saving and remove default args
...
Change-Id: Ic7fde18f07dfe848e219b4ebba30426277ae1287
2020-10-22 14:40:40 +02:00
Miklos Vajna
85e51bbb53
g review: update list of remote branches before checking for branch existence
...
This helps in case you deleted a remote branch using the GitHub web UI,
so the local view is outdated.
Change-Id: I98be33ea5712c66589f42b64e3462b76b84fbcc5
2020-10-22 14:32:55 +02:00
Jan Holesovsky
5999a5b7cc
Action_Paste postMessage to work around the pasting mechanism.
...
In some cases, the integration needs to paste the data directly to the
document, outside of our mechanism that detects whether we should use
the internal paste, or not.
Change-Id: I5e5de09a990ed68451af34dd208a81391a0e9cfa
2020-10-22 09:25:22 +02:00
Jan Holesovsky
2602146342
android: Paste images copied from Chrome using Copy image.
...
Change-Id: I3a33ec610769bc4e33c4b0ce3c1c465fca07b44f
2020-10-22 09:25:22 +02:00
Tor Lillqvist
481a14dabc
Avoid TypeError: undefined is not an object (evaluating 'w2ui[editbar].disable')
...
Change-Id: I5a9b3f2dd10e7bf3a384f54e36930e49a0a36493
2020-10-22 09:24:44 +02:00
Tor Lillqvist
a115168f46
Remove the ca-VALENCIA localisation for the Settings.bundle in the iOS app
...
It leads to the app being rejected when uploaded to App Store Connect.
The rejection email says:
ITMS-90176: Unrecognized Locale - The locale names used in
localization directories at ('Payload/Mobile.app/Settings.bundle/ca-VALENCIA.lproj')
are invalid. iTunes supports BCP47 but not the UN M.49
specification. Refer to the Language and Locale Designations guide
at https://developer.apple.com/library/content/documentation/MacOSX/Conceptual/BPInternational/LanguageandLocaleIDs/LanguageandLocaleIDs.html
for more information on naming your language-specific directories.
Change-Id: I0ede85c5cc65c203e93ff4b75e898a3faaef20e2
2020-10-22 09:24:29 +02:00
Tor Lillqvist
a57df6387f
Use the notebookbar in the iOS app on iPad
...
(But not on iPhone.)
Change-Id: I0589fd914b2ccdd7a62981ab76c02363d7dcf114
2020-10-22 09:24:20 +02:00
Szymon Kłos
f8ab117de5
Add missing tooltip for clear direct formatting icon
...
Change-Id: I20a30e7a37f98cd35d5dfb5086fa7617e433314f
2020-10-21 21:23:45 +02:00
Ezinne Nnamani
2d3c3f02c4
Created the cypress test for font-size attribute
...
Change-Id: Id80b03625717e5061cb58449eab532536cc9fb50
2020-10-21 18:16:10 +02:00
Tor Lillqvist
2067220c70
Make two identical warnings non-identical
...
Change-Id: I824275d99ea0342f1e704b4ca987d5470b6fb939
2020-10-21 17:07:57 +03:00
Andras Timar
949b7477c6
Update UI po files (Weblate does not do msgmerge itself)
...
Change-Id: I8daaeba36404cb37f19c4a88da2131207b595c97
2020-10-21 14:44:28 +02:00
日陰のコスモス
d8fd91da86
Translated using Weblate (Japanese)
...
Currently translated at 100.0% (5 of 5 strings)
Translated using Weblate (Japanese)
Currently translated at 23.5% (4 of 17 strings)
Translated using Weblate (Japanese)
Currently translated at 19.6% (21 of 107 strings)
Co-authored-by: 日陰のコスモス <baffclan@yahoo.co.jp>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ja/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/ja/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ios-app/ja/
Translation: Collabora Online/Android app
Translation: Collabora Online/Android lib
Translation: Collabora Online/iOS app
Change-Id: I254a098eef9a19da19ebec759459a93f7b6a9034
2020-10-21 14:38:32 +02:00
غادة الذياب
3267ad4b2e
Translated using Weblate (Arabic)
...
Currently translated at 47.1% (197 of 418 strings)
Co-authored-by: غادة الذياب <ssggg2015@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ar/
Translation: Collabora Online/Help
Change-Id: I3dd7e86599c7ed472f3efd9794cacf73d51c631f
2020-10-21 14:38:24 +02:00
PhD. Ayhan YALÇINSOY
5b40db4e8b
Translated using Weblate (Turkish)
...
Currently translated at 73.4% (307 of 418 strings)
Translated using Weblate (Turkish)
Currently translated at 72.9% (305 of 418 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (348 of 348 strings)
Co-authored-by: PhD. Ayhan YALÇINSOY <ayhanyalcinsoy@pisilinux.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/tr/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Change-Id: Icc7881a189d9277c9d51e37d9416e50a27f0ae0a
2020-10-21 14:38:16 +02:00
Andras Timar
e8b94dd3e9
Translated using Weblate (Hungarian)
...
Currently translated at 59.0% (247 of 418 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (418 of 418 strings)
Translated using Weblate (Danish)
Currently translated at 99.7% (417 of 418 strings)
Translated using Weblate (Basque)
Currently translated at 100.0% (348 of 348 strings)
Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/da/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/el/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/hu/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/eu/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Change-Id: Ib956a76747475075c6daa26ff4f16d9a43af6aea
2020-10-21 14:38:02 +02:00
Adolfo Jayme Barrientos
33511bfade
Translated using Weblate (French)
...
Currently translated at 100.0% (418 of 418 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (348 of 348 strings)
Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/fr/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt_BR/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Change-Id: I3cc51e257ac1939943d0102c030f9d41fc2a79bc
2020-10-21 14:37:29 +02:00
Andika Triwidada
b7e89abdcb
Translated using Weblate (Indonesian)
...
Currently translated at 100.0% (17 of 17 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (107 of 107 strings)
Translated using Weblate (Indonesian)
Currently translated at 59.0% (247 of 418 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (348 of 348 strings)
Co-authored-by: Andika Triwidada <andika@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/id/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/id/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/id/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/id/
Translation: Collabora Online/Android app
Translation: Collabora Online/Android lib
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Change-Id: I28494f21b769e4a53eec571a792e9608bb9a4015
2020-10-21 14:37:17 +02:00
Joan Montané
907821f14e
Translated using Weblate (Catalan)
...
Currently translated at 100.0% (107 of 107 strings)
Translated using Weblate (Catalan)
Currently translated at 100.0% (418 of 418 strings)
Translated using Weblate (Catalan)
Currently translated at 100.0% (348 of 348 strings)
Co-authored-by: Joan Montané <joan@montane.cat>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ca/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ca/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ca/
Translation: Collabora Online/Android app
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Change-Id: I5f289c9c2e64a024b9d66ed00348abc5d5729279
2020-10-21 14:37:02 +02:00
Andras Timar
b820e9991d
Updated UI pot file
...
Change-Id: I262ac7f5cce317ec9229fc7654562ad83b2cf89c
2020-10-21 14:30:42 +02:00
Pedro Pinto Silva
e15c62dee6
Notebookbar: selected btn: restrict declarations and
...
remove unnecessary rules
Change-Id: Ifd8510da237f56be16c46dd208df0613a956d7db
2020-10-21 11:23:03 +02:00