In compact view we have insert current date and time actions but in
tabbed view we don't have them. To be equality we need to add in tabbed
view too.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I5498f47a8dc96a5403cdf17be52ef3a7ad66862c
The QuarantineMap is shared between DocBroker
instances, which makes it subject to concurrent
access and modification. As such, it must be
protected via a lock.
Change-Id: Id62587b33123748f848110a5427da3e296725de9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Since we need both the PID of the kit process and
the document name, it's easier to construct the
quarantine instance only when we have downloaded
the document.
Change-Id: I8b537122c4b10ae6e822a82fa6a75456d0eaaaff
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We now use the timestamp in the quarantined
file, not the modified time on disk. Since
we have the timestamp, we should use it.
Change-Id: Iaf4a9cab2203da3e3842d7fe46b4578a031f0958
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
No need to encode/decode docKey,
since it is always encoded already.
Change-Id: Icd9c6d24ca57e9f0ffb06efc7052df175d5d383d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
config.h should only be included in .cpp files,
never in headers. The reason is to avoid having
it accidentally included, which would also
allow for it being effective only in subsequent
code, not those included earlier.
To avoid these problems, each .cpp includes
config.h at the top, so the configuration
directives would be effective throughout
the translation unit.
Change-Id: Idae87e5ee51abe454cc2a53d6f60dc07f64d0c35
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Utility classes/functions should not re-implement
any logic external to their function. The
path to the file to be quarantined is controlled
by other bits and QuarantineUtil is simply told
to quarantine the given file.
Change-Id: Iab351ccbf78953bb63f18c451321d34fe61f59b5
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Historically, isUpToDate was created and used
in jail setup. But since in other cases we
might also need to compare files, we break
it into two functions. A new member called
isIdenticalTo, which simply does the comparison
and returns the result, and isUpToDate, which
calls isIdenticalTo and logs the result, as
expected by the jail management.
Change-Id: I6581970ad3e97e3fc0728055e6b57647baedf968
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
There is no good reason to check the config
repeatedly, especially that once we initialize
we should have the state.
Also, we should be able to disable quarantining
when we hit an error during initialization.
(As an aside, reading the config is slow and
throws exceptions that are caught internally,
which makes debugging for exceptions frustrating
when we repeatedly read config entries.)
Change-Id: I44a7800df96a370ef4d4cc1d6bb171f60f1499a0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The clang linker doesn't need -pthread and
warns of unknown command-line option.
This detects clang and forgoes the -pthread
flag to the linker.
Change-Id: I658cd887c567a5beeeae0e6e1b6d596231894c1b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Use 'position: absolute' in jsdialog-window and jsdialog-container
so we don't stretch the dialog. It will use minimal needed size.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7b38b9200e190cfc184bf4bfe8b7bd814c60d5a6
when html document has <form> and inside <button> with
id=style, instead of having map with properties in
style attribute, the form has reference to the button!
that caused not working dragging and updating the position
in writer format -> page style dialog
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic3e35c096f537e6f3cdd4bd7b1a06af1302e7c9e
this uses css grid to position all the tabs stacked
on each other at row 1 col 1. then when tab is hidden
we use 'visibility: hidden' instead of 'display: none'
so we hide content but leave white space needed for it.
this way we don't change dialog's size on tab switch when
tab has different size requirement, but we match dialog
to the size of biggest content
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I634e9f610c4e6dda4df38b85ee15cd58b3b18432
We'd like to build distro independent rpm packages.
Distro specific macros and other code were removed.
The empty environment file for systemd was removed, it can be
easily created by the user, if necessary.
The obsolete trigger for rebuilding the systemplate was removed,
because we no longer copy system libs to systemplate.
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0ac9be8f72a7089e38349abc1dff0d39b0410e44
Draw: We should use uno:InsertPage* commands instead of uno:InsertSlide same
like compact view. We should use "Page Count, Page Number" instead of
Slide count Slide Number as button text. "Slide" word should be used for
only impress.
Impress: We should use InsertPage* commands instead of InsertSlide* same
like compact view.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I91989d4d61b65bd3b719753300a14a5177ca9e95
