test with eg. &lang=he
after position of a dialog was changed to absolute position we
had regression causing the dialogs to appear outside view in
RTL mode. this patch uses margin-inline-start instead of margin-left
what is more generic
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3e70ced1b790d4af751f34d54c880135a3af21bb
This fixes regression from popups rework.
Run collabora online, try to open not existing document.
You should see error: "Well, this is embarrassing..."
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic3fc0dfd05e5ad16d11b07f4f7f3e36851483c1a
and move all navigator css rules into one place
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf00bbd25bf111c5817621f4a72ac95aeb307786
when we request target which doesn't exist or it is the first
character in the document, we receive only one cursor invalidation
in that case we didn't respond at all for the request because we
were waiting
this patch added fallback, so when we receve statechanged messages
we know we already loaded document so we don't need to wait more
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib25ab4f4d68809e3ef97ccb826ba44aeee2f71dc
This is the product name served by hosting/capabilities
endpoint. Also, it is used by update checker.
It can be defined --with-app-name build time, but if
we would like to configure it run-time (e.g. with the
brand package), then we need a config setting for it.
E.g. brand package could execute
coolconfig set product_name "foo bar"
in postinstall script, if necessary.
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8e72d3a3735e3a77c7aaac9a88b2c0fc6a957c0e
Previously the help root URL was defined in coolkitconfig.xcu,
but it was inconvenient to change. Now we have this setting in
coolwsd.xml, therefore it can be changed more easily. For
example a brand package can disable the Help buttons on
dialogs by executing the following command in postinstall
script:
coolconfig set help_url ""
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I6d0bdd71ca908df3d2dd20bd321aff9e93896f52
When we detect document change in storage, we have to
either prompt the user(s) to either reload from storage,
discarding their own changes, or force saving their
changes and clobber the version in storage.
However this implies that the loaded document was
modified. Because otherwise, we do reload the
document from storage, automatically.
This change improves the detection logic to take
into account not just the saved state of the
document, but also the upload state. That is,
if a previous modification was not uploaded yet,
then the user does have changes that they need to
consider to discard or save.
Change-Id: I5f03593bebc5b565fc19e78562896bcdcb6112e2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The +[NSString string...] selectors won't be released until
an enclosing autorelease pool is released. But since we use
ARC, we don't know where the compiler has inserted the
autorelease pool so JS messages may not be released until
after a very long time potentially causing an out of memory
crash. So, use the -[[NSString alloc] init...] selectors
instead.
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: Iff0be8ee5b322347e746dc030948b82d117c43a1
Also, don't set webView.configuration.userContentController to nil as it
generates a "nil not allowed" compiler warning.
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: Ibb49228a65f102fa6d97d4e5affafae8ad528c0d
This avoids an excessive number of reallocations. This is overkill
for non-binary messages, but most non-binary messages appear to be
under 1K bytes in length. In contrast, it appears that binary
messags routinely use at least 75% of the maximum possible length.
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: I522fe74bc355a78b6b561ec9475a1afb27cf54b2
Many .png tile messages are very large so avoid using
-[NSString stringByAppendingString:] calls to create the JavaScript
string.
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: I8163ef93da315122f938c9ed2b66b49a443f283f
The fix for issues #6103 and #6104 changes the name of these
icons so map the new names to the old names.
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: I96b2678534827ce94c11edfa00718eab2a6a9eb8
LANG values such as en_US.UTF-8 trigger an assert in the LibreOffice
code so replace all "_" characters with "-" characters.
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: Icba29a8e647eaf0887cc801d4b8763ffd821ffbf
The normal path is now streamlined and error handling
is at the end. We also now always set the disposition
to closed and fire onDisconnect() when disconnected
or hit an error.
Change-Id: I984ad71601b92b8042dc7984e7339f0804c8083b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This corrects the ending of renaming by
moving that logic only after we get the
async upload results (either success,
failure, or timeout).
It also cleans up a few cases, such as
not needing to special case renaming with
identical names. This ensures that
subsequent attempts are not ignored.
Change-Id: Ib7a432d8a3b6ef5448291763cd31cc844c997e7e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
