Commit graph

18392 commits

Author SHA1 Message Date
Michael Meeks
3f13cd7fc6 delta: saveDataToCache should handle the no-cache case properly.
We need to return a real Tile for _dontCache, and an empty one
if we want to ignore the canceltiles race.

Change-Id: Iad57fc1e3a2718aec34c0eeff97d5f58e215d174
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-16 19:12:05 +01:00
Michael Meeks
892474104b delta: document the function of the version property.
It ensures that we pair un-subscription for a tile change with the
request - since we can have multiple tile requests in flight at a
given time.

Change-Id: I3a00ff7f43fc8ef203b8e38c169938438286d75f
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-16 19:12:05 +01:00
Michael Meeks
e8caabbc0b remove unused method.
Change-Id: I79839a819426a3f0eff9db4fa3864512de0e95f0
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-16 19:12:05 +01:00
Michael Meeks
7ff4c9ffcd delta: don't clear keyframes from the cache that have deltas coming.
These will get newer wids later of course.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I906f47255854eb065d41e629508867ffa6e9f953
2022-06-16 19:12:05 +01:00
Michael Meeks
3f17e5e502 delta: force a keyframe render we don't have a tile in the cache.
Change-Id: I4d553830b3f39fa33b509a2ad347cb22cd9d237e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-16 19:12:05 +01:00
Rash419
b27cf37801 contentcontrol: use polygon to draw indicator
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Id6ffb0de53f3fa386ffe13c7680b48d8e104bc8b
2022-06-16 17:33:38 +02:00
Rash419
22e168031d mobile: contentcontrol improvements
add: form icon in insert menu
fix: datecontentcontrol icon in form menu, jsdialog: options for all content control types were shown

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Id3f425f3a80cb09f58b3f83224bb19ebb365e8f3
2022-06-16 17:33:38 +02:00
Michael Meeks
d8482ea7d6 Catch a second location to de-duplicate JS tilecombined requests.
Change-Id: Iec8d5a76b7add535a640aa5940fba50fea03527f
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-16 14:00:00 +01:00
Michael Meeks
b3f654e940 check for duplicates should not itself assert.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Idac84099ef3f857367ee508a5e64bb2297b0e451
2022-06-16 14:00:00 +01:00
Michael Meeks
04a8462043 deltas: debug dump the state.
Change-Id: Id35f68a108c151de5d2c27800510d17de60faa4c
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-16 10:48:55 +01:00
Michael Meeks
bef4b1ec5a delta: have own delta cache mutex, and size cache for session count.
Change-Id: I1f970a5f9045df11444f6fec8ce7e8eeb0a71bf5
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-16 10:48:55 +01:00
Michael Meeks
935715309a deltas: switch cache to unordered_set and manage size & lifecycle.
We should have a larger delta-cache with more users eg.

Change-Id: Idc3075636df2e7705950fcf6762e40546792a285
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-16 10:48:55 +01:00
Pranam Lashkari
123f9b5c41 introduce user stats
now logs can provide stats for the users each time they access a document

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I75d1637864b97c553285bc5d1850a8f75cd50d9f
2022-06-16 09:39:14 +01:00
Pranam Lashkari
e9d441c490 introduce unconditional logging method
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I590ade9d6687a8b0d364a257f107559db4d81b03
2022-06-16 09:39:14 +01:00
Michael Meeks
3d2418d5f8 Ensure splitpanes cannot generate multiple tiles in a tilecombine.
Change-Id: Ic2e431c82c1a0875503064d4c01efc0ddbb41259
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-15 18:34:58 +01:00
Michael Meeks
25de4d898a Elide duplicate tiles in tilecombine at the perimiter of coolwsd.
Needs a run-time check to avoid breaking concurrency assumption
during compression.

Change-Id: Icc959693e19b3506497eb1aa198477445085aeb8
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-15 18:34:58 +01:00
Michael Meeks
05f9f2aaff elide duplicate tiles in JS created tilecombine requests.
Change-Id: Iefce276c2a44159d8f177e31dcaae8987343eacd
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-15 18:34:58 +01:00
andreas kainz
365b70b0bc Sidebar padding-inline instead of -left -right for RTL support
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ib694d2acf60b2f0058f5ef0633e19aa086498c77
2022-06-15 17:19:45 +02:00
Szymon Kłos
822bc435c3 jsdialog: formulabar: handle keyboard arrows, multiline selection
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia65f49d578cf0a2a184ab583fb7a9694918e6e93
2022-06-15 13:40:29 +03:00
Szymon Kłos
79cc9ae23f jsdialog: formulabar: send key modifierwith all key events
This will allow to create multiline cell content using Shift+Enter

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie1b8497063fc59e29d010c62724b88c4ad8972a0
2022-06-15 13:40:29 +03:00
Gökay Şatır
fe8500681c wsd: add query parameter product name & version.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ia8dbc16024e8f9970d45df16550328fa8c196563
2022-06-15 11:06:40 +02:00
Rash419
45891d0ded wsd: alias: handle a case when regex is added in host tag of alias_group
if host has regex and group has no aliases, when we receive first request from host pattern we considered it as original host and all the host following first request which matches the pattern are considered as aliases
for example:
<group>
	<host>https://.*:80</host>
</group>
if we receives first request from asustuf then behaviour will similar to the following config:
<group>
	<host>https://asustuf:80</host>
	<alias>https://.*:80</alias>
</group>

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I70fb91a4bb7bf38ed79db9efd9fe4bc46db325e1
2022-06-15 11:04:36 +05:30
Pedro Pinto Silva
31b67e9b93 NB: Form tab: Move Properties to last position
Content control properties is not always an active button, it only
takes affect once a content control is selected thus best to place it
at the end.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie13bdc81a84730380d8462241661775d1abd1699
2022-06-15 11:04:18 +05:30
Pedro Pinto Silva
f5e7f6b247 NB: promote all toolitem elements in form tab
Currently there is no plans of adding more content controls. In total
there are 5 content controls toolitems and one for accessing its
properties.
 - Make it easier to pick content controls by increase toolitem size
 (bigtoolitem)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I86d8c1025cb4ff82fe45654076800057e17e9ea6
2022-06-15 11:04:18 +05:30
Pedro Pinto Silva
9b7970a441 Fix missing icon date picker for content control via iconURLAliases
No need to duplicate the icon, use the existent one.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I22ad3f99778051d6b663207ad229e808a34c0e3e
2022-06-15 11:04:18 +05:30
Rash419
1efbf290dc contentcontrol: mobile added content control option in form menu
rich text, checkbox , dropdown, picture picker work correctly now
css: fix: MacroSelectorDialog rules applied on normal jsdialog

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib6db879e968d45604d737cc5ee2b522fa45218af
2022-06-15 11:04:18 +05:30
Rash419
b54466a97b contentcontrol: updated protocol.txt
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I1c2b7b446d72782d987ee3a952731b78fcfc4caf
2022-06-15 11:04:18 +05:30
Rash419
080a46d2fa browser: contentcontrol: add date type
add uno command to insert date in form tab
renamed 'Content Control Properties' -> 'Properties'

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib4a439cd349bb79430d590e0b80c825372c629d3
2022-06-15 11:04:18 +05:30
Szymon Kłos
8d238eb990 sidebar: css: calc area, line, shadow, possize panels
context: shape

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I791c766a91d4ce50fc2f27e4dfe6adc01583a64e
2022-06-14 22:46:23 +02:00
Szymon Kłos
4d622e044d sidebar: css: calc number format and alignment panels
- removed not needed direct position rules

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I462b04bc64dbcf989f04cbc36c3ecc11be08113b
2022-06-14 22:46:23 +02:00
Mert Tumer
58ebdb5041 LanguageTool Grammar checker settings to enable it
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ifc494d5e9f17fc4459556ae809ef3ca12a6b7307
2022-06-14 17:14:26 +03:00
Szymon Kłos
52e703e67a notebookbar: retry to activate when needed
Don't generate spam in the console log with warnings about not
activated notebookbar in apps where we don't use any welded widgets.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I48c2d843752058923242d6678f08ec0791d08e4c
2022-06-14 10:49:52 +03:00
Szymon Kłos
87e0280a43 Allow to send view mode command when dialog is opened
We automatically send notebookbar activation command in some cases.
Allow this command when dialog is opened and don't blink.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iac068cfca49ce6dbfe241bde752a475560d3445e
2022-06-14 10:49:52 +03:00
Andras Timar
e99afdf83d serve lokit-extra-img.svg with integrator theme, too
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia79a607ba244df56c3db1892376dce2372d127df
2022-06-13 14:23:56 +02:00
andreas kainz
7c3bd732d5 Impress add context: MasterPage
Fix #4808 by add SlideMasterPage to impress view tab
and add a context related MasterPage tab.

Update the icons to use the master*.svg colibre icons from core

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ibbd24d1c20a48e26591d217311c5989794aa841e
2022-06-13 11:20:11 +02:00
Szymon Kłos
b371ff23ff cursor: hide current not all
when other view moved cursor outside out view - all of
them were hidden because we used selector for all the
elements matching cursor class - instead of current
instance

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If97606f33e44ce59f747ad0b015048deacbe8657
2022-06-13 09:02:24 +02:00
Szymon Kłos
abff2c7388 jsdialog: combobox is not a container type
add combobox to list of non-containers and cleanup

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I657038c960d7c606a0e437b0c24e74e83f2c2b00
2022-06-10 15:35:42 +02:00
Ashod Nakashian
758ae15e5a wsd: test: add multi-language views test
Change-Id: Idbe1ab22caa4218ead6a8598f6b2990383291dbd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Ashod Nakashian
7e7c2131cf wsd: test: support loading arbitrary docs in wopi tests
Change-Id: I8e707d16b456eb39ac134577db24fe4120da4b2c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Ashod Nakashian
ecda47edd9 wsd: test: handle save notifications in tests
Change-Id: Ic6b0abcd2ad2f2a895ff81acaf875147d9990c8b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Ashod Nakashian
26f7d95f67 wsd: test: WopiTestServer now loads contents from test files
Change-Id: I4daf14d01654517e18145500ed01099e350e63ac
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Ashod Nakashian
5095da017a wsd: test: simplify UnitWOPISlow
Change-Id: Ibb75531284654aa185a21820b1701ac5282064c2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Ashod Nakashian
cb6383fae2 wsd: test: simplify and unify parsing of test URI
Change-Id: Idf26ac62695a1cfe067a9ddecc1cda7d07891c82
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Ashod Nakashian
6a01fc9bb7 wsd: test: refactor WopiTestServer
Change-Id: I7a3219f09250109f936cfadfe559c7f064ee0f94
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Ashod Nakashian
2be50b7e17 wsd: test: refactor test filename
Change-Id: Ida6c181afc98928e6a5dca5b6928f900668a5ea7
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Ashod Nakashian
9fee4ef9fa wsd: test: make WopiTestServer and UnitWOPISlow consistent
Change-Id: Ifcf36de81a2a500c6c0ef128901c53b540345dc9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-06-10 13:14:35 +01:00
Aron Budea
63c3560213 browser: adjusted Field submenu in menu bar
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I50decd1f84dd6e91ba268dabdca2d579e8d229ec
2022-06-10 11:50:19 +02:00
Michael Meeks
0ae5a8ae5e MessageQueue: don't insert duplicates of tiles into TileCombined.
Apparently for some subset of messages (presumably on busy queues)
we have been double compressing the same tiles ...

Change-Id: I79aea4f2162caa8a5b5660c13ae2cae855d90755
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-10 10:10:05 +01:00
Michael Meeks
4478d2b083 Delta: add checks for bad memory usage across threads.
Change-Id: I09f5ad5b0af44399f92ccc0b62056172f1a0b220
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-10 10:10:05 +01:00
Michael Meeks
a5aeac6eeb stress: dump connection count.
Change-Id: I3a1a4202d8f3cbabaf46794fa1c3452af1470016
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-10 10:10:05 +01:00