Currently the presentation and drawing menu entries use the same
definition, but as drawings are different with different terms,
it is best to separate the presentation and drawing entires
instead of handling the exceptions all the time.
Change-Id: I078eb4ebb5014a04614d20363042b3cd75e9a36d
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Separate the toolbar from presentation and remove icons that are
valid for presentation only.
Change-Id: I0dd74f396326b838c9a65352978a771bdb5da13d
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
It fixes a hang related to retries. It might be useful
in our case too. I've seen hangs on Jenkins, which might be
related.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8320f9b38c59074d2b5dd3d7b0cad0c5828b0849
It crashes if the mobile wizard is closed before exiting
chart editing mode.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I47143543220aaebf474e1d1aa560c7df2c2a14f5
This method needs to be called with having the correct view activated.
It caused a crash in writer/simultaneous_typing multi-user cypress test.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I57dd58a635ce7ea127200a6a3f0cadc8c0861aaf
Crash trace:
at NewClass.getViewColor (/src/map/Map.js:702:33)
at NewClass._onUpdateCellViewCursor (/src/layer/tile/TileLayer.js:1466:55)
at NewClass._onCellViewCursorMsg (/src/layer/tile/TileLayer.js:1450:8)
at NewClass._onMessage (/src/layer/tile/TileLayer.js:710:9)
at NewClass._onMessage (/src/layer/tile/CalcTileLayer.js:394:37)
at NewClass._onMessage (/src/core/Socket.js:916:24)
Caught by calc/sheet_operations multi-user test.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I56b686e8d9f27a407f1fef54808e4f65c99173f0
With chrome tests sometimes fail on starting
the chrome binary.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id5c6af71efad8622b3885b8904f2ef3ede82d631
We are drawing things from different files onto the same canvas.
CanvasSectionContainer is organising them. When they are too many, it is difficult to know about sections' important properties.
CanvasSectionProps keeps sections maintainable.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I9e81104c30f30a47c02625ce9d6716a98958317c
Bugs related to ordering of sections are fixed.
addSection and createSection functions are separated.
contextMenu event is added.
Sections' drawing orders are updated for future uses.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I89127c97ad7b7dac4b293c4108c44cb6c4427134
by resetting the isLocated flag for each section.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I0ad41f20219afd8b90050bd43223843ca280587d
Sections which are not yet expanded via locateSections() can interfere
with the hitLeft() and hitTop() for sections of same z-index depending
on order of addition. So lets skip the sections for computing hitLeft()
and hitTop(). This also avoids redoing locateSections() for all sections
everytime a new section is added.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I7595f5b5cfaa61d8fcfe177edd4c605d3fb7b122
when there are no freeze-panes active.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Id5b651d4b1e76cd14b725d125f813d93ed031ff8
I don't recall if simply ifdeffing is the proper way to bypass UnitKit
stuff (that I don't understand) for the mobile apps, but at least it
helps.
Signed-off-by: Tor Lillqvist <tml@iki.fi>
Change-Id: I85d477e4ee7d11c597d95a9b0b42af7e5f7ad122
We had an issue with loading two views to the same document
at the same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8b1ba92eca5e59bfa50cbcd637f1076d5e15c664
The issue is that we passed viewinfo messaged to do _docLayer
in wrong order because of the too simple delaying mechanism.
Wrong scenario steps:
viewinfo-1 arrives: _docLayer is not initialized yet -> 100 ms delay.
viewinfo-2 arrives: _docLayer is initialized now -> pass to _docLayer.
viewinfo-1's timeout: _docLayer is initialized now -> pass to _docLayer
Better to use the more sophisticated delaying method.
See _tryToDelayMessage() and related methods. They keep the order
of the messages.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I335b350b1553cfdee573f7d2e57c86c4b8f9af84
This reverts commit f6bf6f49ed. I did not
consider that this makes it harder to do a local developer setup with
reverse proxy + make run; also that if you don't read the doc to set up
a reverse proxy, then the default now serves http content and advertises
https, which is not helping sysadmins.
This needs more thinking how to improve one scenario without hurting
others.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ic789faa2dc5bb19a79d651dc81d4eaaf0b48607a
Before this commit failure logs were gathered inside an error log
file and they were displayed after all tests are finsihed.
After this commit we print this failures logs when the error occurs
and also at the end of the test run. Sometimes Jenkins does not finish
the whole build because of timeout abortion. In this case, it would
be helpful to see some failure logs.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ibe7cb6aa2c9f99912d604c4b642cda363352ffcd
Move the connect function into the NetUtil
translation unit to aid using it for the
upcoming async socket logic.
The NetUtil should also come in handy for
the miscellaneous network helpers we have.
Change-Id: I2ee0c6e3e1769fd87572d7407d3b4979b59ffe6a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
When we simulate socket error it's hard to understand
what is going on, since there is no real errno to
explain the -1 return value. This is at least true
in the SSL case where we don't set errno (perhaps
we should?). At any rate, it's good form to log
that we are messing up with the return value and
that the real socket API hasn't been even invoked.
Change-Id: Ib76f0259dbdcfe0cfae97343c11ca45461079fa1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This code is executed regularly, at every poll.
The config getter internally throws exceptions,
catches and handles, before returning. While
this isn't performance sensitive, it is noisy
to have such poor-behaving code executed
frequently and regularly.
But the real motivation is the pain this exception
causes when debugging an exception. GDB ends up
catching this rogue exception, which is hardly
useful or helpful.
At any rate, we don't need to get a config entry
more than once, as they can't change during the
lifetime of the process.
Change-Id: Ic69fb94674b74b298987131d44d9baa27e9fa4aa
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
- iconview fix layout without using hard-coded margins
- fontwork: make sure the elements start at the same left position as the title and that they occupy the dialog evenly
- hide unnecessary label
- space-around when on mobile
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia92acf1cbf09a3e7c6e996f9a846163835b115af
cy.click() will grab the focus to the textarea.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I20f0df2fd8a31d3ff4b85ba38fdc503c10987dbb
Add support for configuring the SSL certificates
when running the test binary as well as setting
up the SSL context.
Also adds the SSL socket headers with proper
compile-time guards for when SSL is disabled.
Change-Id: I99992639a66a64871f8ff8a2b2105279ead63ca1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Technically, the poll interval should be
irrelevant because the tests should wakeupWorld
when they need to break the poll. However, it
turns out that many tests implicitly rely on
the poll interval to be large, and if for
any reason the poll wakes up, the tests either
advance their phase too soon, or assert, causing
random failures and reliability issues.
As the tests should now be more robust (at
least the ones that were non-deterministic
in this way), we can now lower the interval
to catch other cases (either extant or in the
future).
Change-Id: Id0d472e70875db8669bb21c6582b0d5052b19bfb
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
