Commit graph

286 commits

Author SHA1 Message Date
Miklos Vajna
d11056deaa test: use the more effective overload accepting a character for find_last_of()
Instead of the one that takes a string literal consisting of a single
character.

Also remove the clang-tidy target, 'run-clang-tidy' does a better job of
doing the same today.

Change-Id: I58f55a0e64af42694d55f9588f25618164275852
2019-01-23 09:06:04 +01:00
Ashod Nakashian
30fb30cff4 wsd: use same method to parse json
DynamicStruct is also more recent and is missing
from older distros and versions of Poco, so avoid
using it just for that.

Change-Id: I465fbbc4350101d382877bd42a1704e4e7827102
2019-01-22 14:52:40 +01:00
Tamás Zolnai
b007656e6a Add a test case of SVG export of Writer image
Change-Id: Ic81754d965a89106f50866a148c7ced0be4a3e9a
2019-01-22 14:52:39 +01:00
Tamás Zolnai
e394999caa Add test case for SVG export of selected shapes in case of Writer
Change-Id: I96e4e4bb098ea37974d6cc684c9b8170ad72869e
2019-01-22 14:52:39 +01:00
Miklos Vajna
05e409fb94 Remove unused 'Timestamp' using decl
Change-Id: If71dd6ef849c530b3c39ab55e0640d597f5a0b2f
2019-01-22 09:19:39 +01:00
Tomaž Vajngerl
7137c953d8 add export, sign and upload as one function for PDF signing
PDF export, signing and upload needs to be done in one operation
as PDF doesn't change the current document. The workflow is just
a bit different to the ODF / OOXML that it needs a change in
behaviour.

Change-Id: I752b293494a2d677fa7f12f2317954cfcf47859b
2019-01-13 23:50:18 +01:00
Andras Timar
9200c0afdf Remove empty Configuration2/ from ODT, it's better for testing signing
Change-Id: I1a10d57ea10c8006b2cdbbe4a674f9177fb35246
2018-12-28 13:10:16 +01:00
Miklos Vajna
1dd2f823e9 UnitFuzz: avoid manual std::move()
std::move() is implemented with release + reset in fact.

Change-Id: If5f0dc8f10066a7ee1ca37f7c5039fcd0affb755
2018-12-18 09:14:43 +01:00
Tamás Zolnai
209e1cd7ee Handle Special character toolbar item state correctly
The toolbar item should have the same names as the UNO command in lower case.

Change-Id: I68264e7d58cca829084965fb5ea9686a85ccd9cd
2018-12-14 17:59:00 +01:00
Miklos Vajna
f38ac3d8ba UnitWOPIDocumentConflict: no c_str() when it'll be converted back to std::string
Change-Id: Ia87598c35f5c8423b22cab0fe8e39fbd1e0818ff
2018-12-14 09:07:22 +01:00
Miklos Vajna
b773f11bdb WopiTestServer: make members private
Change-Id: If042fab5b69faf7c7dff975a95810cb96d8f02b0
2018-12-13 08:49:09 +01:00
Miklos Vajna
d390d646a6 WhiteBoxTests: clean up redundant member initialization
Change-Id: I7b9a4453a94df0a9311bfdb6c0ea3bf8c8e74208
2018-12-12 09:03:15 +01:00
Miklos Vajna
e9e1db61cc HTTPWSTest::testRenderShapeSelection: this test expects an SVG generated by core 6.0
So avoid the test with newer core, which generates a slightly different
SVG.

Change-Id: I9357530735640a40a176140e26ddeb334cd7e89f
2018-12-11 09:10:43 +01:00
Tamás Zolnai
406ae1be86 Update test SVG after export was optimized a bit
Change-Id: I40f402105e603ba793abdff95219319ed92df5ba
2018-12-07 12:39:27 +01:00
Tamás Zolnai
bdab8184a8 Remove unneeded lines from rendershapeselection test
SelectAll does the selection.

Change-Id: I2642b9c1eef1398fa78f39a1a6645e0cf7d266bb
2018-12-07 12:39:27 +01:00
Ashod Nakashian
e5723a22d7 wsd: update bundled headers and improve renderShapeSelection test
Unfortuantely it still fails, but this is not regression. Now
with the new patch in Core the exception is caught and so at least
the binary survives (and the API returns 0).
New unit-test added in Core to help track the issue down and fix.

Also, free the memory allocated by the API.

Change-Id: I5d788a2ee0383de1c323af4cd6b39b8615a35baf
2018-12-07 12:39:27 +01:00
Tamás Zolnai
4df9fd41a3 Update test SVG
Change-Id: I55a3ae676c6eb71e8e34f98f3361f9046e0a4a2f
2018-12-07 12:39:27 +01:00
Tamás Zolnai
b34b1242d6 Remove unneeded include used for debugging only
Change-Id: I82efb9b6d0a0e6ffdca4b9205804446bc871ef84
2018-12-07 12:39:27 +01:00
Tamás Zolnai
31f99bf9f5 Introduce client-server message for requesting the selected shape as SVG
It works for Impress only now.

Change-Id: I130707d8e96e0c633f2531b1cb81ce74dc6ec6e1
2018-12-07 12:39:27 +01:00
Ashod Nakashian
33aff0ce61 wsd: utility to parse integer lists
A quite common logic that is best moved to a utility
and optimized for best performance.

Includes unit-tests.

Change-Id: Id63a388690c17355eb2fac529070c38e9b082fd0
2018-12-07 12:39:27 +01:00
Miklos Vajna
c04fd49d42 TileCacheTests: these writes are never read
They are written again inside the do { ... } while (...) which runs at
least once.

Change-Id: I9ff07d7cb68b73bccf1bd38490fcba615b87a6ba
2018-12-05 09:14:50 +01:00
Andras Timar
25a177db93 typo: capabilties -> capabilities
Change-Id: I44c84d01a2ef6addf7efd5a6cd7fc1778a752c4b
2018-11-30 14:50:15 +01:00
Miklos Vajna
84d224d995 test: no need to copy procEntry
Change-Id: Iac7bca9ebcf104975d01bcd1cdfe8e0f4d2a742e
2018-11-30 08:38:00 +01:00
Tomaž Vajngerl
73c8fa9d09 Extract Authorization out of Auth and put it into common
This is needed so we can use this inside ChildSession.

Change-Id: I88f2cc767412fd52dbb242938f0f9897d4277639
Reviewed-on: https://gerrit.libreoffice.org/63836
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-11-29 21:47:13 +01:00
Miklos Vajna
54e4147887 httpwstest: 'emplace_back' is called inside a loop
Pre-allocate the vector capacity before the loop to avoid realloc waste.

Change-Id: I78370d79728ae66446d2b979d376cb50ba3ae864
2018-11-26 09:43:17 +01:00
Miklos Vajna
d52cf35418 MessageQueueBase: make members private
Change-Id: I65360bc23475b25b2c626ea75186e8863fc74b8f
2018-11-16 09:06:17 +01:00
Miklos Vajna
596f3d14db test: fix HTTPWSTest::testInactiveClient() 2018-11-13 09:12:03 +01:00
Michael Meeks
fa74404019 Add a time limit for badly behaved / huge document load / conversions.
Also improve debug printing of load times in dumpstate.

Change-Id: Ib3fd70dffb57588cd90bd928c4be9890cee8bc65
2018-11-08 01:27:40 +00:00
Tor Lillqvist
f8a0fb4c32 WaE: -Werror=unused-parameter
Change-Id: Icadfcb19ce1fff2b5009d42acf33297cda6e36f2
2018-11-01 21:34:16 +02:00
Tor Lillqvist
60ee631a9e More FakeSocket tests
Actually, I should expand on this and write a test that makes sure the
FakeSocket API semantics does in fact match that of the real socket
API... A fakefakesockettest. Later.

Change-Id: I5cf885a956d6d795976a4369448be04e88837c19
2018-11-01 16:52:06 +02:00
Tor Lillqvist
781162fddd Fix my misunderstanding of Cppunit exception use
I had no idea that the CPPUNIT_ASSERT* macros work by throwing
exceptions. They do, so one should thus not catch them, but let the
Cppunit code take care of that.

Also, make the tests a bit more specific and add some
fakeSocketAvailableDataLength() checks.

Change-Id: I9291822114331c21b774bb41116e8b2ff709dae2
2018-11-01 12:53:47 +02:00
Andras Timar
c50cd3b550 take hello-world.ods and hello-world.odp out of version control
Change-Id: I108e1a0e0981a50f35c7637f00fa15f8cf9d33c3
Reviewed-on: https://gerrit.libreoffice.org/62725
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-11-01 11:39:43 +01:00
Andras Timar
455cd4092e chmod -x on test data files
Change-Id: I398d75b298c86a231a76b7903f792b886450b128
Reviewed-on: https://gerrit.libreoffice.org/62724
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-11-01 11:39:30 +01:00
Tor Lillqvist
856965db9f Return correct exit value, 0 for success, 1 for failure
Change-Id: Ie3454cac318ce6a0e8c2c59ae9d3ae3c6658c0b8
2018-11-01 12:12:26 +02:00
Tor Lillqvist
3d408d4338 Actually run the fakesockettest
Sad that this Makefile.am is so complicated, and that this needs to be
added explicitly like this.

Change-Id: I8b1b25761eb723e124cab96479f49478d3a75194
2018-11-01 12:10:47 +02:00
Tor Lillqvist
02d3ac47ee Add a Cppunit test for the FakeSocket API
Based on Mobile/TestFakeSocket/TestFakeSocket/main.mm. Needs work,
does not really test the interesting semantic corner cases that have
been fixed only recently.

Change-Id: Ie2f3dbd2b478ab3acb4bfef0e0d3031c817d0f37
2018-11-01 11:51:34 +02:00
Tamás Zolnai
b4b0e9c6d4 Handle X-Forwarded-For with more secure
Check all pariticipating IPs to be allowed to use convert-to
functionality. In a simple use case it means the reverse-proxy's
and the actual client's IP.

Change-Id: I4ef9cb14a1c3003cba6c66f6e99d5b54b2c3b2b8
2018-10-25 10:48:52 +02:00
Tamás Zolnai
318f0629bb Handle X-Forwarded-For header for convert-to feature
Extract the client IP from the X-Forwarded-For value
and use that one to allow / deny the usage of convert-to
feature.

Change-Id: I363c0931df5a0538236cae12f943fffd65086ee6
2018-10-24 12:50:03 +02:00
Tamás Zolnai
4ff506425f Enable convert-to test
Change-Id: I7c2bf333bb4bcb803cd926bfb1d669f89d100615
2018-10-20 13:41:43 +02:00
Tamás Zolnai
ec65ecd0f1 Revert "Revert "Enable convert-to features for wopi hosts""
This reverts commit 343ba48d27.
2018-10-20 12:57:53 +02:00
Tamás Zolnai
343ba48d27 Revert "Enable convert-to features for wopi hosts"
This reverts commit 8dd28ed664.
2018-10-20 12:55:55 +02:00
Tamás Zolnai
683cedb17a Delta test: avoid dumping out useless data
Change-Id: I05bbd05b3ee1e0a5b0687b7b6c981938a1493946
2018-10-19 18:15:22 +02:00
Tamás Zolnai
8dd28ed664 Enable convert-to features for wopi hosts
Change-Id: I8aa37c61f3df5356fb7a14d93cda6279e7ec3cf1
2018-10-19 18:15:22 +02:00
Tamás Zolnai
0bb8b7c7a8 Add /hosting/capabilities endpoint to advertise online features
Add an entry to discovery.xml with the urlsrc where capabilities end
point can be found. Use json format to send back the feature list.

Change-Id: I390a53d956d53ca79e5a8090aead7f4131ec4ca0
2018-10-19 18:15:22 +02:00
Ashod Nakashian
0bf78a3ce7 wsd: fix saveas test
It didn't expect the trailing xfilename which
is used for anonymization.

Change-Id: I169253c567583f43ce870bbf5dfcebee9c94cd1d
2018-10-17 19:29:08 -04:00
Miklos Vajna
8316a650d6 test: avoid some unnecessary value parameters 2018-10-17 09:34:18 +02:00
Ashod Nakashian
ff6f49c598 wsd: more string split tests
Change-Id: Idd6e99954b11238eaf64e11e7969d0aee1612557
Reviewed-on: https://gerrit.libreoffice.org/57648
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit f64e0fba92ad80776572255951b2e0d76bc76e73)
2018-10-16 20:12:23 -04:00
Ashod Nakashian
b6333ada8d wsd: anonymization improvements and unittests
Also support anonymization of downloadas documents
and renaming of documents.

Reviewed-on: https://gerrit.libreoffice.org/57541
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 78248a542c9ca31bf9ad4cad9b55d78690384395)

Change-Id: I81a80e6290217659987d73f625e5f0fb81cb7ef2
2018-10-16 20:12:23 -04:00
Ashod Nakashian
053161b3f5 wsd: move string utilities into Util
Reviewed-on: https://gerrit.libreoffice.org/57539
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit fb2671c4145edd4d4e359f0dcf5cc84835487cd4)

Change-Id: Idc578dff4e8ee5e48c1b7780d3feb2d21c6a9b13
2018-10-16 20:12:23 -04:00
Ashod Nakashian
6c18aa7e88 kit: anonymize usernames and filenames in Kit
Change-Id: Id7928136db71ded7bf6b1a5e8e387db7251f8a35
2018-10-16 20:12:23 -04:00