This fixes bug in Android app where progressbar
was added without any condition.
Change-Id: I535001fce4ae37da4f5dc87031d9c15db043d655
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99731
Tested-by: Jenkins
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
We can enable video recording with this flag,
during a headless test run, so we can see what
happend on the UI.
Change-Id: I4558563a3de71742d8d6b1ca67f0c518d543afc7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99787
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We need to introduce separate rules to dump
the log and to dump out the error message.
Otherwise GNU make evaluation breaks the workflow.
It evaluates $(wildcard $(ERROR_LOG)) before the
test were actually executed. So first run the tests,
then dump the error output and then go into error state.
Change-Id: I0f8e5de6800f0691cca14019819972437a741382
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99781
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Sometimes this text contains an additional end line character.
Change-Id: Id58eab9ea3b082781cdd8ec341fa2b058ba3b17e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99770
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Changed the gestures:
1st tap to select the slide
2nd tap will open the mobile wizard
long press and then drag and drop the slides
Change-Id: I44a874f69eed4586667f7fbe825d5da943565071
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97345
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
To run multi-user tests only.
- make check-multi runs all multi-user tests.
- make check-multi spec=sidebar_visibility runs
only the test pair with the specified name.
Change-Id: Idada04960a6a2d33c7f36ef57bc1d6a1d1cffa99
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99682
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
if there are things to be save change class from save icon
Change-Id: Iaacc48a62d7626b8cfc489efd80141b209039b2a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99677
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
Code update allows to search in all toolbars not
only main one like in the past.
Change-Id: I76c9cdbbdade287748ec19d537b564206d52eab5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99671
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
touch screen will ask for tap instead of click to resume
Change-Id: Ie5cb3db33de606beba9e9f1841f9171647aa02ac
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99122
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
follow up to complement but on desktop : edaea8a389
Change-Id: Ic33bd0216d163872c42d8742d821c319c41e0ce6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99630
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
Sometimes using Chrome browser close button is not
shown after calling show(): replace it with css
modification which seems to be more reliable.
Also don't show close button on mobile devices where
we have hamburger menu.
Change-Id: Id354374f18e24fcbdd9afb3894c40cccfe2811ea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99594
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
... since these are required in proof-key element as per [MS-WOPI].
Change-Id: Ie770271ee911e3f7822375c00a83c6a32cd5f2fc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88743
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
adding these classes help in pasting text in comments in calc and impress
Change-Id: Id94e6017d1db5f024f4ebfa287051c799c225ec9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98860
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Before we used the GNU make implicit parallelization
which triggered by recipe structure.
Instead of that we use linux's bakcground process
feature and run one client in the background and
the other one in the foreground.
Change-Id: I9de899686ae67b47eee005f157b6622ae4c5fe33
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99484
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We used to grep for error messages in the output, but
it can change what is written out. Better to catch if
the command fails directly.
Change-Id: I8c3cba212b262227551876bfb23629a243424c39
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99365
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This should be initialized when html is loading
Change-Id: Ief99d3a613ddaa86caaf5285795a97e3f56787b5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99511
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
This adds a "view_comment" in addition to "view" and "edit" state
into discovery.xml. In case it is enabled, the filters let the
comment commands through to core.
In addition add "Save Comment" menu action to allow saving the
comments, which is enabled when in "read-only" with "view_comment"
mode.
Change-Id: I3ab3dbee93ee2167ae96adea7025fc0b385f8201
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99473
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* Some rules from mobile were affecting notebookbar layout (e.g.: writer: tab table)
* Fix paddings in every .unolabel
* Adjust .unoarrow and add hover state
* Remove duplicated selectors (mobilewizard.css)
* Add rules (from mobilewizard.css) that are needed uin the notebookbar to notebookbar.css with proper parent: .hasnotebookbar
Change-Id: I22282c53ede39d7952bde1ea9625b4d928aaaea0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99477
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
Added dialogs are already converted to be async
and are present in the notebookbar interface.
Change-Id: Ia15f9a5f5524cef20948b45d0d465620091f12ec
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99475
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
When window was small arrow was moved to the next line
and notebookbar layouw was broken.
Change-Id: I7532a25b1a684aaaba70cfd28f9a3ee891f1d446
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99481
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
