Ashod Nakashian
4254ddad77
loolwsd: consistently set HTTP status and reason everywhere
...
Change-Id: Ie538e4907e3a3a514918000bb585d2aaf182e468
Reviewed-on: https://gerrit.libreoffice.org/24132
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-16 17:29:35 +00:00
Ashod Nakashian
fe952794f0
loolwsd: don't expose private members
...
Change-Id: I049c92d0ddb296058fad283fffc291348b4608b1
Reviewed-on: https://gerrit.libreoffice.org/24131
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-16 17:29:11 +00:00
Ashod Nakashian
93d3f806e1
loolwsd: logging and cosmetics
...
Change-Id: I413a2e40f480ba41e37c7442724c3f037528f89b
Reviewed-on: https://gerrit.libreoffice.org/24130
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-16 17:28:45 +00:00
Ashod Nakashian
c2560725db
loolwsd: admin uses config for ssl key
...
Change-Id: I38b0f59c158698a6eb89d4b671001e1d8cb61673
Reviewed-on: https://gerrit.libreoffice.org/24129
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-16 17:27:43 +00:00
Ashod Nakashian
8eedd9dfd3
loleaflet: gitignore branding files
...
Change-Id: I78df82004999938e2c9b7aa9935896fd8c195318
Reviewed-on: https://gerrit.libreoffice.org/24128
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-16 17:24:50 +00:00
Michael Meeks
69816395d5
Re-enable verbose tracing during unit testing.
2016-04-15 22:04:15 +01:00
Michael Meeks
448e25f6d8
Make logging signal safe again. snprintf: simpler, safer, faster.
2016-04-15 21:53:10 +01:00
Michael Meeks
65ee749ce1
Move new unit tests to custom test driver.
...
Cleaner, and avoids bogus warnings during compile.
Merge run_test.sh.in into a mode of run_unit.sh - gives the
chance for nice debug output etc.
2016-04-15 21:52:39 +01:00
Michael Meeks
ebfa339da0
Cleanup symlinking and add realpath symlink if necessary.
2016-04-15 16:17:04 +01:00
Tor Lillqvist
b1aa059bc3
I don't have any ~/.fonts
2016-04-15 17:19:04 +03:00
Tor Lillqvist
947f8bcf13
Test number of loolkit processes also before and after the HTTPPostTest suite
2016-04-15 17:13:47 +03:00
Michael Meeks
a49f642801
Tolerate --version, and add git hash version, print on default start.
...
Should help diagnosing issues - to have this in our logs.
2016-04-15 15:07:24 +01:00
Michael Meeks
7376b7475e
Font bits: create symlink in jail at OS instdir path, to point at /lo
...
This ensures that bundled fonts in instdir/share end up resolved to
the same path that they were in when the forkit font config was setup.
It may also help locate other pre-inited resources.
Also copy in ~/.fonts in debug mode - can't hurt.
2016-04-15 14:35:57 +01:00
Michael Meeks
ab6cc4135b
Copy fonts into systemplate from libreoffice install.
2016-04-15 14:23:44 +01:00
Michael Meeks
b5e37448a8
looltool: get argument array copyies right.
2016-04-15 13:55:34 +01:00
Ashod Nakashian
7df929cb77
loolwsd: use SocketProcessor in kit
...
SocketProcessor doesn't need to take response
instance, since by the time it is called we
are already upgraded to WebSocket and it's
too late to set a request-level status.
Change-Id: Id95087e60354a50148c88427130613356679cf82
Reviewed-on: https://gerrit.libreoffice.org/24110
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-15 11:54:30 +00:00
Ashod Nakashian
df47ff1b2f
loolwsd: .gitignore updated
...
Change-Id: Ica74b3f6f2fd9e3f9d75f41f2f780010b9b9bc55
Reviewed-on: https://gerrit.libreoffice.org/24109
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-15 11:53:57 +00:00
Ashod Nakashian
cf85f51850
loolwsd: tabs -> spaces
...
Change-Id: I581346970321446378ff135e0227e06a2092b39f
Reviewed-on: https://gerrit.libreoffice.org/24108
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-15 11:53:42 +00:00
Tor Lillqvist
5782e0b04c
TileCache::lookupTile() already returns non-null only if the stream is open
...
No need to test at call sites. We can assert() as a sanity check
though.
2016-04-15 14:12:35 +03:00
Tor Lillqvist
ecaaab6e90
Default values for bool parameters make the code harder to read
...
In this case we always passed the parameter anyway.
2016-04-15 13:17:20 +03:00
Pranav Kant
cca858732a
loolwsd: Allow admin console to kill documents (again)
...
Change-Id: I30405854e9ebdc56ab3477758e9008963d4b8efa
2016-04-15 15:25:01 +05:30
Tor Lillqvist
6ca6bf0da6
Rant about over-use of variables where literals would work
2016-04-15 12:26:56 +03:00
Pranav Kant
382da839e0
Add documentation about takeedit
...
Change-Id: I600046111d2478f1c02552d3caa60d2a50fa7c98
2016-04-15 14:48:58 +05:30
Pranav Kant
91c6154fc0
loolwsd: Use docKey as key for Admin instead of PID
...
Also change some variable names to be consistent with rest of the
coding style.
Change-Id: Icca9a9aec9bfb34c1edd5b6533d7646b05fe814f
2016-04-15 14:42:14 +05:30
Pranav Kant
61914208bc
loleaflet: Adapt to new changes in admin console
...
Change-Id: I0761bd6c5b3650795a318a077eb50d0a8bd161da
2016-04-15 13:28:42 +05:30
Pranav Kant
7bf5e84a90
loolwsd: Make admin console work (again)
...
Change-Id: Ib51f33c60b5e42e154795357a7a787cb8691ad51
2016-04-15 13:28:42 +05:30
Pranav Kant
4f9eef9324
loolwsd: Be consistent, and use unique_lock
...
Change-Id: Idfc14bb7dd82827493865241f6d04cf9ae4a88fc
2016-04-15 13:28:42 +05:30
Pranav Kant
9669470d09
loolwsd: Admin doesn't need its own thread now
...
The timers are cancelled upon destruction of the static Admin
instance.
Change-Id: Ie43dc9d3ec96b002e12685ec997ad83c29b684d0
2016-04-15 13:28:42 +05:30
Tor Lillqvist
5c41d4c5ed
-Werror=maybe-uninitialized
2016-04-15 10:53:06 +03:00
Miklos Vajna
0a92e811dc
Storage: const auto -> const auto& where it would create a tmp copy
...
Change-Id: I0ec42200e19654ee2e1c9b0fc293668847a5b965
2016-04-15 08:49:35 +02:00
Henry Castro
8fac7d59b4
loleaflet: friendly messages when socket is closed
2016-04-15 00:10:43 -04:00
Henry Castro
39180a0e22
loolwsd: test: add connectLOKit
...
Connecting to a Kit process is managed by document broker, that it does several
jobs to establish the bridge connection between the Client and Kit process,
The result, it is mostly time outs to get messages in the unit test and it could fail.
connectLOKit ensures the websocket is connected to a kit process.
2016-04-14 21:54:36 -04:00
Ashod Nakashian
0b4b3c73d5
loolwsd: tile cache cleanup
...
Change-Id: Ib2abec83fd4866c09b30507c11a809d682c2f819
Reviewed-on: https://gerrit.libreoffice.org/24100
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-15 01:08:37 +00:00
Ashod Nakashian
322a3c1afe
loolwsd: logging moved to own files
...
Change-Id: Idf1dd91cf37675e1bea8aeb5d9e8cf6d2ac9a725
Reviewed-on: https://gerrit.libreoffice.org/24099
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-15 01:07:13 +00:00
Ashod Nakashian
e5595509fd
loolwsd: cosmetic cleanup
...
Change-Id: I02f3ab1778db462376b7563e7e8b0abeebd2e8a1
Reviewed-on: https://gerrit.libreoffice.org/24098
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-15 01:04:47 +00:00
Michael Meeks
fe684cc71d
looltool: implement destdir, and fix parallelism.
2016-04-14 21:41:09 +01:00
Michael Meeks
444adc976d
looltool cleanup add --no-check-certificate option too.
2016-04-14 20:44:02 +01:00
Michael Meeks
53c60b2842
Magic to cleanup autotools module linking of unit tests.
2016-04-14 18:58:18 +01:00
Michael Meeks
688d1ab6e6
Remove confusing ChildProcessSession include on LOOLWSD.
...
Move the ClientPortNumber into both Kit and WSD.
2016-04-14 18:58:18 +01:00
Michael Meeks
d817fc2c69
Simple command-line tool for file format conversion.
2016-04-14 18:58:18 +01:00
Michael Meeks
349e2a5a49
Add SEGV and trace hunter, and update log parser a little.
2016-04-14 18:58:18 +01:00
Andras Timar
1f7da1f5a2
loolwsd: install and package SSL key and certs if SSL is enabled
2016-04-14 18:47:50 +02:00
Henry Castro
bea5963aa7
loolwsd: avoid time out exception
2016-04-14 12:00:32 -04:00
Henry Castro
d11bd69c26
loolwsd: wait prison session until the peer is assigned
...
Some messages are not forwarded to the client session, this is caused
by the time the client session is assigned, the prison session,
it is already forwarding to not assigned peer session.
2016-04-14 11:41:15 -04:00
Pranav Kant
0597a1873d
loleaflet: Disable toolbar buttons without editlock
...
Change-Id: I18b067e99ff04073a4065536534fdb0db00285dd
2016-04-14 21:04:56 +05:30
Pranav Kant
c56ef84129
loleaflet: Disable (graphic)selection markers without editlock
...
Only session with 'edit' permission can move selection handles
and graphic selection handles.
Change-Id: Idc5cf634a13e201016eb4e4135392b917b622ad5
2016-04-14 20:53:54 +05:30
Andras Timar
8f93a5f526
merge loleaflet and loolwsd rpm packages
2016-04-14 17:08:52 +02:00
Tor Lillqvist
fe5f238c08
Exit when receiving an *unexpected* CLOSE frame
...
Otherwise we will just keep waiting for a line on input from stdin,
which is unhelpful.
2016-04-14 17:45:51 +03:00
Tor Lillqvist
066b48688a
Use the 'expected' and 'actual' parameters of CPPUNIT_ASSERT_EQUAL() correctly
2016-04-14 17:07:55 +03:00
Tor Lillqvist
2edf15a18b
Use CPPUNIT_ASSERT_EQUAL() to get expected and actual values into output
2016-04-14 17:05:09 +03:00