Commit graph

21243 commits

Author SHA1 Message Date
Caolán McNamara
42c9f54a98 osCanvasExtraSize is unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I96d74a5a9f6ae86ab4c33f58b60988f62afda417
2023-07-10 17:50:13 +01:00
Caolán McNamara
d5c7306a16 halfExtraSize and extendedOffset are newly unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ia2a51478ad674d0b10eeebdfb7e4bc4eb4614984
2023-07-10 17:50:13 +01:00
Caolán McNamara
d842d39cb2 extendedPaneBounds is now unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0f1f37ee096f9e0e765effea23139d6a7a6bf456
2023-07-10 17:50:13 +01:00
Caolán McNamara
04acabbe87 oscCtxs and offscreenCanvases are write only
as far as I can see they are only written to, they are
not read from anywhere.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0faf8f2b087c4b4228ac40e6804694be0f83eb54
2023-07-10 17:50:13 +01:00
Pranam Lashkari
f56694ef96 scroll: avoid selecting elements while dragging scroll bar
problem:
In safari and gnome web when you scroll using scroll bar,
DOM elements on the slidebar and documents would get selected

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I222d246148d5d84a5c0b3cfdb1890350f428e696
2023-07-10 23:48:00 +07:00
Henry Castro
8773e0e050 cypress: cypress logs for cool.html iframe
Also logs unhandled exceptions from iframe cool.html

Change-Id: I6f7b7d1340c8818d3f81916d42d6d9ed2920e35c
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
3c0731bf2c cypress: add emacs mode lines
Change-Id: I2cb19d34639ea6af55c693fad7bef8855a0ccba3
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
aa6be258fa cypress: upgrade version 12.17.0
Change-Id: I1464063e5149143f9a0aa4a1f5a433f5171b1d8e
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
fc791bbf37 cypress: fix missing package 'semver'
Change-Id: Ica5bd8d562127b9369b7b1fdf19a0dad3a861ef0
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
6ea782103f cypress: logging 'npm install'
Change-Id: I6b188bae89f2389124946c0fda497c9f9744e6b4
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
95436dcb3f cypress: fix missing dependencies
Change-Id: I5439d769dce043b8fc33416d0aa618a371314c26
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
a396c91886 cypress: check if NODE_PATH env exits
Change-Id: I69b64f1ad29e2ddd09663444922e8c1dc16411f2
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
9bcc79b266 cypress: add option baseURL
Setting a baseURL cypress verify if the server is
running and prevents to refresh when command cy.visit()

Change-Id: I1cffc0932d6a1ec4ee9793eb3935f60e02ca2545
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
f3787c85e8 cypress: install package 'cypress-terminal-report'
https://github.com/archfz/cypress-terminal-report

Change-Id: I242e421aeb02ee3861b16af78af87c6a9db22ad5
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
e69969a07b cypress: install package "@cypress/webpack-preprocessor"
"https://github.com/cypress-io/cypress-webpack-preprocessor"

Change-Id: Id261c7d1675c6f6c30d5f1661b4988511528b0d7
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
1ac16a13f1 cypress: remove plugin package 'cypress-failed-log'
It has a bug, it executes twice beforeEach function
if fails or unhandled exception.

Change-Id: I005815d440af0309cf797e52fbfb3693896418a9
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
2ec6bd70a2 cypress: disable screenshot
not useful for C.I. for now.

Change-Id: I1940d617b6b7c5f0a7dcae7e38c58dc5bd57f2e4
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
51ae4a836e cypress: logging stack traces of the unit test failing
Change-Id: Ic06c62b1cbd467abe17a5ff859848ca10673b4a4
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
a32cbb311d cypress: logging unhandled exceptions
Change-Id: I82bd3552fbf0b844492340762899b5c492148eca
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
a2048ce70d cypress: fix "loadTestDoc" remote server
If it is a remote 'coolwsd' server,
there is no way to rename or copy files.

Change-Id: Ic38302de5ecf3fa08fedd485d6060ede320867bc
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
119eee8036 cypress: fix work folder if remote server
If it is already running remote "coolwsd"" server,
there is no way to create a remote work folder.

Change-Id: I17932fcca321e2f7e0cdfcab2ad678dbcffc56ed
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
54e79ce289 cypress: add option "verbose=1"
To debug and trace command executions

Change-Id: I5e458c2db4cedef32b24e5925b38c1ee2aaaa4cd
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
ffb0bb8f7e cypress: add option "coolwsd=server:port"
It is useful inspect logs and run unit test
with an already running coolwsd instance.

Change-Id: I6b01316d552e3d12bf63db9cc7e813adb33a20c0
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
dec0fe5a83 cypress: fix missing config file, builddir != srcdir
"Could not find a Cypress configuration file in this folder""

Change-Id: I7d5b2094d6cd10ca3da2a099650f830bee31dfb1
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
a2920949d0 cypress: fix eslint error, buildir != srcdir
11:26  error  'process' is not defined  no-undef

Change-Id: I637bda97d3ba360a095c04a1987c9c64eef1349c
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Marco Cecchetti
ff34b16947 cypress tests for accessibility toggle ui
Helper functions:
checkAccessibilityEnabledToBe
  check accessibility state independently from current desktop ui
setAccessibilityState
  set accessibility state independently from current desktop ui

Both helper functions check that ui state and a11y support in text
input element are in sync.

Enable/Disable Accessibility Support
  test state toggling and state preservation when switching ui

Typing after switching accessibility state
  check editable area content after toggling accessibility support

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Icce5ae148024a8abf9b65a90229915f28f720554
2023-07-10 16:02:18 +02:00
Marco Cecchetti
d69de71094 remove dup code: A11yTextInput inherits from TextInput
Now A11yTextInput inherits from TextInput.
Added hasAccessibilitySupport to both TI and ATI

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ic296afb840824e7901202c9c089c4025c6bb8ab2
2023-07-10 16:02:18 +02:00
Marco Cecchetti
d5cd0c67e3 TextInput: gecko: fixed not working delete key
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I01ebbfb6c0d64fba044ae211d81b58a2f3ef06f9
2023-07-10 16:02:18 +02:00
Marco Cecchetti
6be9a99c0d remove dup code: A11yTI: _sendKeyEvent uniformed to TI version
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I09dd4d1667c8075cc859a6b96a1da025d5b196ea
2023-07-10 16:02:18 +02:00
Marco Cecchetti
b750d6e93b remove dup code: A11yTI: _onInput mentions part uniformed to TI version
Pulled in changes performed by commit:
24c83b9e Rash419 refactor: consolidate mentions-related code in
TextInput.js

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I37577163ec2a8abf0131e276df83d6710dec4f73
2023-07-10 16:02:18 +02:00
Marco Cecchetti
32298f08f6 remove dup code: A11yTI: _onKeyDown uniformed to TI version
Pulled in changes performed by commits:
847ade24 Szymon Kłos Mention popup focus fix
a006c917 Gökay Şatır Focus on the selected comment with keyboard.
02616ed3 Gökay Şatır Don't auto show the comment on Calc.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Icdc510f6d90af1b6f2379b6cbd4317940f0ac0ad
2023-07-10 16:02:18 +02:00
Marco Cecchetti
24727deee3 remove dup code: TextInput: uniformed code fragments to A11yTextInput
Uniformed code:
  getValueAsCodePoints
  _setupStyles
  _setPos
  _onInput: this._deleteHint
  getValue
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>

Change-Id: I6b5424e0afe3202d65abaf2d5b785b95cc9346c9
2023-07-10 16:02:18 +02:00
Marco Cecchetti
bc782c6b71 remove dup code: TI: _onCommandResult: clear content in desktop case too
TextInput:
undoing something does not trigger any input method
this causes the editable area content not to be a substring
of the document text

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I803c32d243c6331dc21685a6d2ee03919e21a8cf
2023-07-10 16:02:18 +02:00
Marco Cecchetti
b2c8cb32e5 remove dup code: TI: keep _hasWorkingSelectionStart for logging only
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Id8de738846a796be37184ecbc083fbd796620739
2023-07-10 16:02:18 +02:00
Marco Cecchetti
73c10a1d08 remove dup code: A11yTextInput: removed unused code
A11yTextInput:
_tabHint: removed unused property
_isTextContentEmpty: removed unused method
_onComposingContent: removed unused properties
_onCommandResult is no more used since on undoing editable area
content is updated by core through some accessibility message
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ifc31a994661827d4f53891f85c6f7229bea758a5
2023-07-10 16:02:18 +02:00
Marco Cecchetti
abca8e5dd3 Adding support for enabling/disabling a11y support from the ui
Added toggle button/menu entry for enable/disable accessibility support.
This ui feature is available for Online Writer only.
The button/menu entry is added only when accessibility is enabled at
server level.
That allows to enable/disable accessibility per view.
By default, the accessibility support is disabled.
Anyway the accessibility support state is saved to local storage
if available.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: If5968a47f17922038b9da3d320cbed84ebb7688b
2023-07-10 16:02:18 +02:00
Alexander Gabilondo
2ec2f7bcce Translated using Weblate (Basque)
Currently translated at 99.5% (461 of 463 strings)

Translated using Weblate (Basque)

Currently translated at 99.3% (460 of 463 strings)

Co-authored-by: Alexander Gabilondo <alexgabi@openmailbox.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/eu/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic84fed0a093017e8eb3d9b8669ea4c772d3d10bb
2023-07-09 15:07:12 +02:00
Sebastiaan Veld
3dfa51a234 Translated using Weblate (Dutch)
Currently translated at 100.0% (507 of 507 strings)

Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2aa565735b80609e557e2c6e3cdbb081a7f83968
2023-07-09 15:07:12 +02:00
gallegonovato
f030eec328 Translated using Weblate (Spanish)
Currently translated at 100.0% (507 of 507 strings)

Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ibf47f5ccf709c8458ac6e37836fc8bbb103529b5
2023-07-09 15:07:12 +02:00
Michael Meeks
e6c7bf7dc1 tile debug: cleanup and make more consistent tile debugging.
Remove rather bogus timings per-tile; instead in future we should
track how long a tile has been invalid for I suspect, which we
can do more helpfully.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I790ad324b2dba2bc253e4c37c42ddb487666e455
2023-07-08 21:11:25 +02:00
Michael Meeks
b1b35b3a5e tile debug: render directly on the canvas - avoid popup overlay.
Popup overlay performance is far from great, and they can leak too.

Change-Id: Id84391d702e20d067a98349fa96e7a495f02752c
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 21:11:25 +02:00
Michael Meeks
343fcf0306 tile debug: improve alignment and cropping handling.
various offset problems fixed.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I15a039d192353c172a6e88563f791c334731c0eb
2023-07-08 21:11:25 +02:00
Michael Meeks
ebdfc61341 calm down debugging verbosity with debug overlay.
No need to dump entire delta / keyframe content as hex.

Change-Id: I2e3e1bed693a8d33f1cc1f49ddf9f082b5d458b5
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 21:11:25 +02:00
Michael Meeks
02701df2b6 tile debug: remove blue calc grid overlay & re-layer.
Grid is all done on the client side by default now anyway, so
no need to have this anymore.

Change-Id: I92966cbd2953a404575cb71575e3e782acccd694
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 21:11:25 +02:00
Caolán McNamara
902aba1fb7 Extend what we request to include enough to populate a page scroll
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id961b362dec5ce0a9b362dc8ee5a73ceb9eaa1dc
2023-07-08 18:18:46 +01:00
Caolán McNamara
bbc7f2af12 factor out _getMissingTiles as a standalone thing
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I08c2c4f34b2a2114c2906453ee9daeac04b6f441
2023-07-08 18:18:46 +01:00
Caolán McNamara
357f7cf2db bump to latest fzstd release
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I79bcfce90a858ad5a6f432ba8e36b0936c505bf3
2023-07-08 17:20:24 +02:00
Michael Meeks
b963cde3c7 FileServer::LocalFileInfo re-work local file-list management.
Calling a PUT before a GET would cause a SEGV around managing the
internal list of files.

Re-factor to ensure we always have a valid LocalFileInfo to
work with, and simplify and cleanup code-paths.

Change-Id: I2b206bb8bdebc3c44cd55c61048da9b0dc30dbd5
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 13:08:59 +01:00
Michael Meeks
a7d7eeead9 Having an empty canvas doesn't mean a tile has content.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4b568570e0028ea07127acdceb4cb148042e436e
2023-07-08 13:08:59 +01:00
Michael Meeks
d48e332fb0 Render tile debugging on top of tiles + traffic light & delta chart.
top-left rectangle should give a state of the tile:
	green - up-to-date
	amber - present but stale
	red - not present.
Next bar-chart shows the number of deltas applied.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4968a0b23bf34b888eb1de0a960f33d7bc2e8076
2023-07-08 13:08:59 +01:00