Commit graph

14120 commits

Author SHA1 Message Date
Gökay Şatır
1c147de68f Calc: Minus & plus sign hairline drawings.
Row and column group controls' plus & minus signs were not hairline. It is fixed.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I964f0e3916df91b110ba17e819c24d589c6bd3cd
2021-02-08 12:01:09 +03:00
Gökay Şatır
969ddc0927 Calc: Fix document-container position.
When column groups is used, document was badly aligned.
This commit fixes it.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: If572735a935fae1db2a94b66711b0a9080490a37
2021-02-08 12:00:52 +03:00
Aron Budea
c4faeb049b wsd: tweak SSL logging
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I4e1e4f99cd2ac3d21b9426602de11e10bdd47a61
2021-02-06 21:43:03 +01:00
Henry Castro
d75a40317b loleaflet: set last cursor position with server side ...
coordinates.

Record the last cursor position before any transformation
to (lat,lng) coordinates

Change-Id: I183c55da5cd0f9e3338c411382708afc4b945c01
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-02-05 17:33:11 -04:00
Tamás Zolnai
384d5692a1 cypress: update eslint: 7.12.0 -> 7.19.0.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I4d23f5aba844e9398543a7763543098be4e8fb12
2021-02-05 17:31:09 +01:00
Tamás Zolnai
44272f6d01 cypress: update wait-on: 5.2.0 -> 5.2.1.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ifc0fa803dd16aa2381578919bd9c313aa19d4535
2021-02-05 17:31:09 +01:00
Tamás Zolnai
3d1b7a7d58 cypress: update cypress-select-tests: 1.5.8 -> 1.5.9.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ia7ed3f4519872aba6c44181bb768110a29be10b3
2021-02-05 17:31:09 +01:00
Tamás Zolnai
7eac3a62c2 cypress: update cypress-file-upload: 4.1.1 -> 5.0.2.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1cf3841763958bccc7f1f6f0b98e81802e181da8
2021-02-05 17:31:09 +01:00
Tamás Zolnai
c89440b369 cypress: update cypress-failed-log: 2.7.0 -> 2.9.1.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I24279fd77c51bc7c4cbd04e46bb97da060d55861
2021-02-05 17:31:09 +01:00
Tamás Zolnai
8cb2e53761 cypress: document some extra run option in the README.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I49597e73d675ab9e916f7f73e740d5a89d2884b8
2021-02-05 17:04:36 +01:00
Szymon Kłos
904ceed516 jsdialog: remember scroll position on update
Change-Id: I81daf2f33982b596637501590aaa111f084fad81
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-05 16:44:12 +01:00
Tamás Zolnai
c8c96a76f2 cypress: fix some typos in helper method documentation.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I098ee52a5ca03b58399a1c81690b0521f3d91743
2021-02-05 16:38:23 +01:00
Tamás Zolnai
6ba82fa3c0 cypress: split canvasShouldBeFullWhiteOrNot() method.
So we have separate canvasShouldBeFullWhite() and
canvasShouldNotBeFullWhite() methods, which might make
the code more readable, then having it controlled by
a bool parameter.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I0932a7615c84c35293c2cc8dade0db6468de8224
2021-02-05 16:38:23 +01:00
Tamás Zolnai
f4c4b7091a cypress: split imageShouldNotBeFullWhiteOrNot() method.
So we have separate imageShouldBeFullWhite() and
imageShouldNotBeFullWhite() methods, which might make
the code more readable, then having it controlled by
a bool parameter.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2ada6b9e6f6d93b8a48e9ddd3c851ef3e6fcd632
2021-02-05 16:38:23 +01:00
Tamás Zolnai
53642adf96 cypress: remove getLOVersion() method.
By now, we don't run the same online branch against more
core branches, so this code is obsolete.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I90768d16628e735129880cc4cf823bf0b7d9ad1e
2021-02-05 16:38:23 +01:00
Tamás Zolnai
fcaff1a32e cypress: simplify clearAllText() helper method.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I595e3594a9e624249cbb039e509fe12772ef904e
2021-02-05 16:38:23 +01:00
Tamás Zolnai
9ec53994f2 cypress: simplify selectAllText() helper method.
We use this method in various contexts, where it's not
necessary that we have the cursor of the focus. Focus can
be tested in focus related tests.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic27de45917657d4ac1734565d81d5bbf190ad333
2021-02-05 16:38:23 +01:00
Tamás Zolnai
cc37bd5786 cypress: helper: add some documentation to helper methods.
Also do some renaming.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1796181085ff245090589d3680fa3d90bb085d3f
2021-02-05 16:38:23 +01:00
Tamás Zolnai
aa7bcc0490 cypress: make: generate better error message for interference tests.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ie6347999debc6be0c11672dda29afed0c05e4059
2021-02-05 15:14:45 +01:00
Tamás Zolnai
cd1095028f cypress: make: replace some duplicated paths.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Iec87086864938203169fba0460cd216438221b28
2021-02-05 15:14:45 +01:00
Szymon Kłos
ec556113ea mobile-wizard: disable ExtrusionToggle
Change-Id: Idb68f59f4bb25a57a2cee17df61a2e5945d50cf9
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-05 14:27:54 +01:00
Szymon Kłos
64e97e5661 mobile-wizard: justify fontwork shapes
Change-Id: I2adfc059669fc4dbe73293d6024839857f77abd3
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-05 14:27:54 +01:00
Szymon Kłos
b48d215a18 mobile-wizard: fontwork property panel
Change-Id: I5279eba27ee6848a5bde539dc30f4e7a37e0eb89
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-05 14:27:54 +01:00
Szymon Kłos
3919d19b5d Support special characters in uno translations
Some uno commands have '.' or '-' in the name.
eg. .uno:FontworkShapeType.fontwork-inflate

Change-Id: I027aa3b6302280101c0f7cb51ef9809d023ea91d
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-05 14:27:54 +01:00
Szymon Kłos
3d0000c09a Check for _UNO also in MobileWizardBuilder
Change-Id: I3ab70770a79acc1c4e107b83474fdd96c7ffa3ec
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-05 14:27:54 +01:00
Tor Lillqvist
4bb6363b35 Bin unused STD_EXTRA_WIDTH
Change-Id: If436fba45bbd6669a414c20579f13ac0dadd8241
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-02-04 19:28:13 +02:00
Tamás Zolnai
efdda663e4 cypress: rename run_iteratively.sh -> run_repeatedly.sh.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ida3f90fb01893c13de2086cf6ba0ec95c67a3bef
2021-02-04 17:45:16 +01:00
Rizal Muttaqin
c03940312a Add download as csv icon
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id77468703bb941e853a7c1419b386d5a8c91fde7
2021-02-04 13:23:57 +01:00
Pedro Pinto Silva
069684ca97 Expose CSV as an additional download option...
* on classic
* on notebookbar
* allow it in readonly mode

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I29ed6ed40810ba0e59cdb4d55b9898d016653678
2021-02-04 13:23:57 +01:00
Jan Holesovsky
c23502926b CheckFileInfo: Report mis-spelled CheckFileInfo properties as errors.
To be able to locate them in the logs more easily; this is likely to
catch mistakes early in the development of new integrations.

Change-Id: I11c528d11e4a4e1d13f8d32085fa1bf1a163b779
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2021-02-03 16:14:57 +01:00
Tamás Zolnai
bb7af8b733 cypress: throw and Error object here to get backtrace in cypress log.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8bb36da750f6bb0855d0118b139e2090e2dbcc85
2021-02-03 14:56:32 +01:00
Tamás Zolnai
ca65e63da6 cypress: dont mention video recording option for multi-user tests.
It does not work when two cypress instances running at the
same time.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Iae7fe4c4dcc4bb0a970763001e4f966b60f988f2
2021-02-03 14:56:32 +01:00
Tor Lillqvist
c999c5c86d Also save cellviewcursor: messages for handling when we are ready
Without this, when joining an editing session of a spreadsheet, you
don't see the cell cursor of another participant until they move the
cell cursor.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I87b8ad584d57bce52b39706fa9f0bbf56a59082a
2021-02-03 15:54:11 +02:00
Jan Holesovsky
efd9b93652 Trivial script to find unused functions in JavaScript
I haven't found any more advanced approach to finding unused JS
functions, but this seems to produce at least some results, so better
than nothing.

There is nothing new to remove though, the last round of cleanup has
removed what was there to remove.

Signed-off-by: Jan Holesovsky <kendy@collabora.com>
Change-Id: If39fecb7781cc78b30cb95da354c71d3547b7ae7
2021-02-03 13:54:46 +01:00
Gökay Şatır
18c4ad5584 Calc: GroupBase.js is added for shared functions.
Row and column groups share some of the functions. They are moved into a file.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I268daf2c293f0cac150587a23001f873e23b4dfc
2021-02-02 20:31:37 +03:00
Gökay Şatır
06293d3530 Row & Column Groups: Some fixups.
More comments are added.
Early exits are used.
Unused functions are deleted.
Some functions are renamed for better explanation.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: If835fbb9bbae6898c4847b2c428a3e36f042b60a
2021-02-02 20:31:37 +03:00
Tor Lillqvist
cd1a0c8d27 eslint is pickier in the co-6-4 branch, so cherry-pick fix here, too
Change-Id: I47d09ea9e3da0c60f07821dee9197cbefc7080dc
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-02-02 19:14:45 +02:00
Tamás Zolnai
0b8973696d cypress: interfer: we can enable retries for the test user.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I40172946709fc50290b568be26d510b4cbb12531
2021-02-02 16:00:46 +01:00
Tamás Zolnai
81dda79b94 cypress: interfer: move cell cursor instead of text cursor in calc.
It's not necessary to have any text in the first cell, so
double click won't work for every test document. However the
spreadsheet is always there so we can move the cursor through
the different cells.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Icea63a971fb77d915e027569a80c9a8a8b855a01
2021-02-02 16:00:46 +01:00
Tamás Zolnai
e0421d5090 cypress: reenable master view related tests.
Now that it was fixed in core branches.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Iaccc994b0e58402dc173941357af43517dd0178b
2021-02-02 16:00:46 +01:00
Tamás Zolnai
df8144d44c Revert "cypress: make sure the cell selection is visible before run test steps."
This reverts commit 129ae61684.

This is actually undefined, whether the cell cursor would be there
or not. We get cell cursor messages after loading the document,
so if we step into editing mode before these messages, then we
will have the cell cursor, but if we wait some seconds after
opening the document, then the cell cursor won't be displayed.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I7a4e9e5adbbbe312f21789fe872726bbf67565e6
2021-02-02 13:49:50 +01:00
Tamás Zolnai
0671c687a1 cypress: update writer field tests.
There is no more span inside the HTML representation
of a text field. After this commit:
b982d0e6f94ca70765231ff4242c829f5bec5def

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic64a20dcb0534876af062a1fb40cb0e39fd27f10
2021-02-02 12:10:21 +01:00
Gökay Şatır
f9ebb450ab AutoFilter DropDown: Replace div reference with section reference.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I82ac56f320083f3fe0ba3ee6104cad341c69120b
2021-02-02 09:49:48 +01:00
Gökay Şatır
855c7aaf7c Cypress: Make column & row header tests work with canvas sections.
CanvasSectionContainer has now capability of creating divs below sections, for testing.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ia735758ce27af558718da50935502723112e838e
2021-02-02 09:49:48 +01:00
Gökay Şatır
1fdcc0baa5 CanvasSectionContainer: Enable creating test divs for automated tests.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: If735aa39fc98959578904e3ea86b893449a119b5
2021-02-02 09:49:48 +01:00
Gökay Şatır
8a8f9f4e6d CanvasTileLayer: Set canvas border for Calc column groups.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I87bd288436cdbdcf866dead00d47bc6aa5f72f4f
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
2021-02-02 09:49:48 +01:00
Gökay Şatır
ad7a01ac93 CanvasSectionContainer: Add onRemove function.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I2bc45c36a104b6b76f9a18e18dcda39b8b3d2072
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
2021-02-02 09:49:48 +01:00
Gökay Şatır
1413ee6768 Calc: Adjust header and group font sizes.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I09b0146abd1d16305978c212f5cf5446e1b2ec54
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
2021-02-02 09:49:48 +01:00
Gökay Şatır
5f1090dcb1 CanvasTileLayer: Position canvas on mobile, tablet and desktop.
Remove "spreadsheet-row-column-frame" div. Since row & column headers and groups are drawn onto the same canvas with tiles, that div shouldn't exist.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
2021-02-02 09:49:48 +01:00
Gökay Şatır
d576895c57 Calc: Add Row Group and Column Group sections.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ib44e5e6a9e047c347a239a155b86f091467f5149
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
2021-02-02 09:49:48 +01:00