Commit graph

14120 commits

Author SHA1 Message Date
Gökay Şatır
2d8df66167 Calc: Draw Column & Row Headers on tiles canvas.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
2021-02-02 09:49:48 +01:00
Gökay Şatır
e2dbff061a CanvasTileLayer: Give id to tiles canvas.
Centralize re-painting event.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Idc37a4ce2206627f1a30162652169fbc7ae0ce03
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
2021-02-02 09:49:48 +01:00
Tamás Zolnai
3b05151641 cypress: move formulabar related check into beforeAll() helper method.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I46b05c8533b4f323e181d3d4fd2acc1e4626e164
2021-02-01 22:11:32 +01:00
Szymon Kłos
969f9f9860 Revert "Don't block handling of touch events"
This reverts commit 284e8ce308.

We have to disable panning handler to avoid panning when resizing
the selection using handles.

Change-Id: I9994b3e9ba32bc3e43567d43e547eada311c050e
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-01 17:43:27 +01:00
Tamás Zolnai
0cd14ef422 cypress: use checkDialogAndClose() helper method here.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Iec8be699d10640154d711b47a9d11400e2aefa1b
2021-02-01 16:07:15 +01:00
Pedro Pinto Silva
b0a38ebe21 loleaflet: server recycling: Improve message
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4cecb72acc927707b68711478c5474326d456d82
2021-02-01 15:01:07 +01:00
Tamás Zolnai
c69b163c38 cypress: let's be more specific here about the cursor.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: If9d475374fb27a727f5cf7f38f3a0b4b47f142f6
2021-02-01 13:28:54 +01:00
Tamás Zolnai
64a22ea2dd cypress: make dblClickOnFirstCell() method closer to real mouse events.
It causes an issue for calc to use cypress's dblclick() method
and it will select the wrong cell. In the log, I see only a
double click when we simulate user events with cypress, however
when I do double click manually, first I see a single click and
then a double click in the log. So let's do the same with cypress
simulation too.


Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I18e92fc354558e09bb5cb3a12e45cbb669ac97bc
2021-02-01 13:28:54 +01:00
Henry Castro
71c595ca4b loleaflet: do not update cursor from other views
Change-Id: I5e0cd6cfa6c5a5db61dcfbfa557c9ec3bc4c8977
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-02-01 07:19:45 -04:00
Tamás Zolnai
02e22e20f3 cypress: make dblClickOnFirstCell() more stable.
Visibility of the blinking cursor is not good enough
on dekstop, beacuse it changes position after it is
displayed. So let's wait some time to step cell editing
mode.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I86fe7fd5be68f36126ba3d390b29740b33cf3d8e
2021-02-01 11:59:43 +01:00
Tamás Zolnai
6d62c32950 cypress: add a selector parameter to cursor related methods.
So we can specify which cursor we need here. The default is
the document cursor, but this methods can be used for
formulabar cursor or dialog cursor too. More cursors might
exists at the same time, that's why simple '.blinking-cursor'
selector does not work.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1fd04e188ab53e70d0e8303fd7502f183c18bef3
2021-02-01 11:59:43 +01:00
Ashod Nakashian
2304b52587 wsd: correct assertion on storage and not tilecache
We already access _storage before the assertion,
so it must move before the first use.

Also, we have no use for _tileCache when uploading,
so no point in asserting its validity here.

Change-Id: I4196d0719e6750cfd2dba8d5f449a1b76286bde9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-31 22:20:59 -05:00
Ashod Nakashian
8a37738fdb wsd: documentation of DocumentBroker states
This details the design of the DocumentBroker
states and state-machines as they are to be
eventually implemented. Not everything described
is current, but the goal is to document what
the design ought to be, not what it is.

Change-Id: I938177812777af058b46c41a396407d0a083cbc4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-31 22:20:59 -05:00
Ashod Nakashian
aba6d5b6c5 wsd: log at info level when we force uploading
Change-Id: Ic6da7e2c0f29ddbf5884b75866794609f69f8a8f
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-31 22:20:59 -05:00
Ashod Nakashian
523cfec790 wsd: save -> upload
Change-Id: I08445bd9f726225809c443f4bdfc611bbfc03bf6
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-31 22:20:59 -05:00
Ashod Nakashian
30f7ea2e9a wsd: remove default arguments of uploadToStorageInternal
Only the last argument (force) was implicit, and only
in one call (of total two calls). Explicit is better.

Change-Id: Ic26f4dd265f48156d1730f1b95bb70145ca47873
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-31 22:20:59 -05:00
Ashod Nakashian
2b96bf3fd6 wsd: move the loaded flag into DocumentStatus
The loaded flag is used to track whether or not
the document was ever loaded. It does *not* reflect
whether or not the document is currently loaded,
rather it is used to save the document, if necessary,
before unloaded.

This is why we need to track it as a separate boolean,
rather than implicitly tracking this state via the
DocumentState enum, which would not be able to
differentiate between a failed-to-load state and
one of a normal end-of-life, after loading.

Change-Id: I1fc3fb09c31cadf7ebb6b0123e462e78dd0af356
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-29 09:22:36 -05:00
Ashod Nakashian
048c468caa wsd: move the markToDestroy flag into DocumentStatus
The markToDestroy flag tracks whether or not the
document is in the process of being unloaded.

Change-Id: I8f2339f75ed6d7c5d318eb1d467d6a9cbc1d61c2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-29 09:22:36 -05:00
Ashod Nakashian
1041346928 wsd: move the closeRequested flag into DocumentStatus
The closeRequested flag tracks owner termination.

Change-Id: I91d7491396cd8db6ca493ba8015a5310c361a2f3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-29 09:22:36 -05:00
Ashod Nakashian
ca0c2a24cc wsd: introduce DocumentState class
DocumentState is responsible for tracking
the state of the document, properly documenting
the different stages of the document lifetime
and encapsulating all the relevant members.

DocumentState is still unused in this commit.

Change-Id: Ic2c8de3a9f2d42c5550c5f4ad5f889040f697890
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-29 09:22:36 -05:00
Ashod Nakashian
190141e942 wsd: test: disable external http regression tests
These are not needed to be executed on an ongoing
basis, only when modifying the http code.

As the external service is only used to verify
the initial implementation, it will also get
replaced with an internal (loopback) one.

Disabling for now to avoid noise when randomly
failing, due to network or other reasons.

Change-Id: I54f5203c39e48ba442313698d519b035200b41e5
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-29 09:09:58 -05:00
Tamás Zolnai
129ae61684 cypress: make sure the cell selection is visible before run test steps.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I3ce151f8ebe9405c5830630e941c94ab9ef2f7ae
2021-01-29 12:42:46 +01:00
Yunusemre Şentürk
f69448898a Bring kubernetes proof-of-concept setup with just collabora-online
Signed-off-by: Yunusemre Şentürk <yunusemre@collabora.com>
Change-Id: I5daeeea3746bb107b3c4e0b3b68efa0adacb773f
2021-01-29 11:17:28 +01:00
Tor Lillqvist
989d57b580 In Cypress tests throw error if dialog image cache is inconsistent wrt server
We have a dummy spreadsheet document with a column of cells each in a
different font size. The font size of the current cell is displayed in
the sidebar.

In the test we step through the cells first downwards and then back.
Thus the sidebar image that contains the font size will be updated as
we step through the cells. At first nothing will be found in cache,
but when returning, the images should be found in the cache. If the
cache in the JS client is not consistent with that in the server we
will throw an exception.

Change-Id: I439263c7923d985679fafa0125cd2d7f635e0995
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-01-29 12:08:58 +02:00
Tamás Zolnai
18169d795b cypress: mention video recording option in failure log.
It's a useful option to create a video during headless run.
It's much closer to the headless build wrt. timing, than
interactive test runner.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic9889209ac07b9fe0a9b6e326e60513412950780
2021-01-29 11:04:49 +01:00
Gökay Şatır
1df8fc91d2 Revert "Disable Freeze panes menu & notebookbar entries on tablets."
This reverts commit 6c2d725c58.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I50c248e3d2dfc7b06a9d0d2c1da3fe8a52d26560
2021-01-29 10:25:45 +03:00
Pedro Pinto Silva
3b398d8e9d dev doc: postmessage-api: Favicon and styling
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I469051b3bd4fd8371ab3d0593922c71d15272445
2021-01-28 19:41:41 +01:00
Miklos Vajna
b04f498ff4 test: avoid http status 512 and higher when interacting with poco
The last enumerator in Poco::Net::HTTPResponse::HTTPStatus is 511.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Id183916729c8d13f63fe0d6e0d7ca7e84c8afaeb
2021-01-28 16:40:00 +01:00
Marco Cecchetti
445fe41118 cleanup dev doc: loleaflet and postmessage references in separate files
references.html has been replaced by 2 files with content LOLeaflet
and PostMessage setions respectively.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Id095da5f1ab11c96d090bceab921d74b4fe68482
2021-01-28 15:29:12 +01:00
Tamás Zolnai
0db412ccf0 cypress: add new Save/Print test to php-proxy/NC blacklists.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id494a522e0961894cdf9e5ce56b19b781a724974
2021-01-28 15:27:51 +01:00
Tamás Zolnai
c2620ce5cf cypress: update 'Check disabled elements in master view.' test.
In master view, the 'Master Slide' list should be empty and so it's
not shown on mobile wizard. No, I disable this test, because
it needs the core code to be updated.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I12562c453673ac85e050303ebb5803fee6f1892a
2021-01-28 13:47:59 +01:00
Tor Lillqvist
ffa940933d eslint is pickier in the co-6-4 branch, so cherry-pick fix here, too
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I06d49a56853fe391c4d137208865498a36c7a1e3
2021-01-28 14:14:03 +02:00
Marco Cecchetti
d869144abb cleanup doc: further cleanup reference.html: small fix-up
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I031535af28470a66824db6c04f9693e6f6ee1771
2021-01-27 15:42:57 +01:00
Marco Cecchetti
b0315c7c20 cleanup doc: further cleanup reference.html
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I031535af28470a66824db6c04f9693e6f6ee1771
2021-01-27 15:42:57 +01:00
Marco Cecchetti
b60f48d94a dev documentation: removing misleading leaflet API documentation
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: If417805d7c0620921b2b8e35101b6489caafaf2f
2021-01-27 15:42:57 +01:00
Tamás Zolnai
cb62773468 cypress: make chart test more stable.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I621538e1a6d17eb1ec10f13f2559a0b48a8e6918
2021-01-27 14:08:09 +01:00
Tamás Zolnai
d18d3a5381 cypress: update 'Enable text wrapping.' test.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Iac566958e3820376a991d06c1ad5c03f81efd36a
2021-01-27 14:08:09 +01:00
Ezinne
6490e45131 Created cypress tests for the Save and Print features on the Calctop-toolbar
Signed-off-by: Ezinne <nnamani.ezinne@collabora.com>
Change-Id: I1a0424c5ddfc7714475818fba029c6bb238db1f1
2021-01-27 14:07:56 +01:00
Miklos Vajna
b74f26910d net: http version string may not be null-terminated
Limit its length, we know the version length anyway.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I0db2b9227baf3e10055082ad394c0f555b9898e1
2021-01-27 13:33:30 +01:00
Ezinne
4e96492041 Created a cypress test for Text Wrap feature in Calc top_toolbar
Signed-off-by: Ezinne <nnamani.ezinne@collabora.com>
Change-Id: I873654c21649f849739cd25461f3d52335ecba8b
2021-01-27 11:34:44 +01:00
Ashod Nakashian
b4dd9f82a3 wsd: saveToStorageInternal -> uploadToStorageInternal
Change-Id: I0273314d65ebee91092a883bebeb53ab31051194
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-26 21:40:59 -05:00
Ashod Nakashian
f14034584f wsd: saveAsToStroage -> uploadAsToStorage
Change-Id: I6edbff6da6b2c29000c0a66524266138aeb88b89
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-26 21:40:59 -05:00
Ashod Nakashian
ed1e08662a wsd: saveToStorage -> uploadToStorage
Change-Id: Ie00728ca81d481676ae3a3c44d8d79e80ee29278
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-26 21:40:59 -05:00
Ashod Nakashian
a176213750 wsd: lastStorageSaveSuccessful -> lastStorageUploadSuccessful
Change-Id: I71618e388f44ac7b74f295c8af5d0235b395fe87
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-26 21:40:59 -05:00
Ashod Nakashian
7a9dc03e46 wsd: DocumentBroker documentation
Change-Id: Iaacb2bb961719e23ef0e955587d70f38ef5ce464
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-26 21:40:59 -05:00
Ashod Nakashian
24edfa2b62 wsd: test: move HttpRequestTests to 'make check'
These tests require network setup and therefore
can be problematic for `make run`.

Change-Id: I8747a505e15edc91964b290a5476a24069b7d538
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-26 20:02:04 -05:00
Andras Timar
92f44a4695 On-disk cache was removed long ago, clean-up in packaging
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2eeaed12af6ac8789151b95a9c2a2aa1fd72573b
2021-01-26 21:10:50 +01:00
Tor Lillqvist
5cc5e19ed6 Add comment describing a way to intentionally induce cache inconsistency
Change-Id: I4dabc1e70b2bca6751a60e5655a530c0025b09c5
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-01-26 17:09:09 +02:00
Tor Lillqvist
944e831b3d Add sanity checks to the PNG cache code in loleaflet
If the client cache seems to be inconsistent with what the server
thinks, send an ERROR message to the server that will be logged.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ic7f9d7fb15b2c34f7a6cd2decbacaa7745ac9389
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-01-26 16:55:04 +02:00
Tamás Zolnai
227b5f64fa Fix ENABLE_SSL condition.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I0f6a4dac4aff05be65b5a0735b5ff0c67fc4f7a0
2021-01-26 14:40:46 +01:00