Miklos Vajna
46c0873c29
wsd: can avoid copying these in AdminModel
...
Change-Id: Id092585e93cca3bd4d52531cf628c1f205fcfe8b
2018-02-06 16:06:24 +01:00
Miklos Vajna
0a2df21501
wsd: remove unused using declarations in LOOLWSD
...
Change-Id: I6b656a1446b015430068e4b172cf98fe746f26d1
2018-02-05 17:11:58 +01:00
Marco Cecchetti
fec429ecdc
loleaflet: calc: double click on resize area freezes header handling
...
Change-Id: I05d758ed0cb6cafa5ab14418b82f23b607e4ea95
Reviewed-on: https://gerrit.libreoffice.org/49238
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-05 16:47:50 +01:00
Christian Glombek
51993b8990
Adds ENABLE_SETCAP build variable to avoid using env in build system.
...
Change-Id: Id38d2225238f8b3a48481a08e62cfa7544958cc9
Reviewed-on: https://gerrit.libreoffice.org/49097
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-04 22:27:09 +01:00
Pranav Kant
34aed93d83
loleaflet: Don't try to translate command names
...
Command names are sent to loleaflet in already translated form when
there are appropriate langpacks installed in the system.
Only translate when we can.
Change-Id: I92dc5865da85c76bd5a2529b0e6df994937c4c28
2018-02-02 21:39:34 +05:30
Pranav Kant
d837839449
No need of clearAnnotation function here; already there
...
Change-Id: I21a2b931bb120e4a127a14f6657f89110fb9b79f
2018-02-02 15:34:53 +05:30
Pranav Kant
39772015a1
loleaflet: Remove comments, changes on doc disconnect
...
Change-Id: Iccad2afe8a8ddf85fd83577c1d1b822724ce318a
2018-02-02 14:43:17 +05:30
Henry Castro
43cf95adff
loleaflet: propagate text selected events to parent element
...
Change-Id: I9b88c42b6bf40dfe856e92f345633855234c7a5d
2018-02-01 21:47:46 -04:00
Pranav Kant
5bd124499c
wsd: Bin superfluous public method
...
Passing the reason to stop() method also does the same thing.
Change-Id: I16b648495382c14f31839acca815835df76d8dca
2018-02-02 03:16:30 +05:30
Pranav Kant
28ea409a45
wsd: Don't save if document is unmodified
...
This also prevents saving the document back to storage.
Without this patch, in case of document conflict (when the document is
changed behind our back in the storage), the unmodified document end up
being saved to storage, hence overwriting the document which was changed
behind our back.
Change-Id: Ie027f5b49c37e7df3f36499e0fef3eca78173969
Reviewed-on: https://gerrit.libreoffice.org/49114
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-01 19:47:08 +01:00
Jan Holesovsky
b76b6a9861
Document the conflict handling.
...
Change-Id: I2291e4b085fcb6cac3280fdd2139afb909ada748
2018-02-01 14:17:07 +01:00
ozturkemre
1c8d8107b2
tdf#113142 added insert sheet to the sheet list
...
Change-Id: I7ec6a45bf7bc4e2daf545ab4f234c3a0c9fcbded
Reviewed-on: https://gerrit.libreoffice.org/49070
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-01 07:24:34 +01:00
Henry Castro
f269a9321c
follow up, avoid logging when closing file descriptors
...
Change-Id: I38432ae1d042094551d22c2512a416c3b345556b
2018-01-31 17:53:58 -04:00
Henry Castro
b1f1500b56
util: avoid logging when closing file descriptors
...
eventually the log file descriptor will be closed and unhandled exception it will throw it
"terminate called after throwing an instance of 'Poco::WriteFileException'
what(): Cannot write file"
Change-Id: I1d6ae3a4d4d4910f2ed2cdc80b162c27f93d55d9
Reviewed-on: https://gerrit.libreoffice.org/49055
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-01-31 22:06:57 +01:00
Samuel Mehrbrodt
00dc0658d3
Missing capabilities: Add hint to check mount options
...
Change-Id: I946df0082b385b2eaaad9c23b9e5e7ac508f64aa
2018-01-31 11:45:03 +01:00
Samuel Mehrbrodt
3ae85e20a6
Ignore errors when draw directory is not deletable
...
Change-Id: Iec3567129f96b69174421ca1ec652dccf6a6b56c
Reviewed-on: https://gerrit.libreoffice.org/48911
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-31 10:24:13 +01:00
Miklos Vajna
692d24213b
wsd: can avoid copying here FileServer
...
Change-Id: If194705eae76e81141df9c4e86f7e7bc94b250b6
2018-01-31 09:38:05 +01:00
Pranav Kant
497319834e
No context menu on dialog's floating window canvas
...
Change-Id: Ia6c8cc5d8d198862cf674d43de2937e4a72fdfbb
2018-01-30 22:00:14 +05:30
Miklos Vajna
222399e99a
common: avoid pointless copy in Util
...
Change-Id: I40097203eba6fede78a17caf057452f4704b2bd4
2018-01-30 16:09:33 +01:00
Samuel Mehrbrodt
e89584f933
Show info instead of error when linking is not possible
...
we still try to copy the file after this and fail if that doesn't work.
Change-Id: Ie37022b2454e71f4b1a92217e01e56e58070448b
Reviewed-on: https://gerrit.libreoffice.org/48907
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-30 14:33:51 +01:00
Michael Meeks
d3c17510ed
Implement an improved fork/exec wrapper.
...
* logs helpful messages for various error corner-cases.
* optimized file descriptor closing for large fd counts.
Change-Id: I8cba9ecb3d71ddc6e22e20d89368d8c6b9b5097f
2018-01-29 15:20:10 +00:00
Michael Meeks
fbc28b91b3
Avoid copying code into the chroot if LINK_NO_CODE is set.
...
Change-Id: Ibba7dfa87c779b4d809cc2ac53d0802bba1c37ef
2018-01-29 15:12:05 +00:00
Pranav Kant
cb6c9461e0
loleaflet: Don't try to paint if floating window has vanished
...
Change-Id: I9284c7ec73f6f0e900d3efa2d055eb8b7d5303b2
Reviewed-on: https://gerrit.libreoffice.org/48620
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 3e4a78ccc3410b16fe6b34eea23720f551f53383)
Reviewed-on: https://gerrit.libreoffice.org/48814
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-29 10:17:25 +01:00
Pranav Kant
1a4c8f8dd3
loleaflet: Ignore callbacks without an active dialog
...
Change-Id: Ie828309b8a3d9201f5e7071884ec7cadf2cacb21
Reviewed-on: https://gerrit.libreoffice.org/48621
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit de8974a8161f5acdcf08ddbf7bde55541b6d4bfb)
Reviewed-on: https://gerrit.libreoffice.org/48813
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-29 10:17:06 +01:00
Aron Budea
ce5bde20ee
Table row header: use correct uno command
...
Change-Id: I042b3ce495b77296f29d62899bb048e58f4d552c
Reviewed-on: https://gerrit.libreoffice.org/48747
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2018-01-29 01:09:38 +01:00
Jan Holesovsky
ba7825e63b
wsd: Support for configuration of the allowed languages.
...
Change-Id: I233619b89ac61aeaab4ba96f1f52773802cfd7ae
2018-01-26 20:57:54 +01:00
Jan Holesovsky
0039f3c041
Add run-strace target for easy stracing.
...
Change-Id: I554cfa3965784803430a4cc2c12e61002e2445cd
2018-01-26 20:40:17 +01:00
Pranav Kant
1d22f7bc54
kit: start spamming the logs when linking/copying is slowww
...
This is sometimes the case in docker when the link operation 'copies up'
things from lower layers to the working docker container's layer. In
such cases, let the admin know.
Change-Id: Ib72b67304a292c3832838379cc76bcb4a7268cb3
Reviewed-on: https://gerrit.libreoffice.org/48710
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-26 16:40:56 +01:00
Pranav Kant
9ea81e7921
wsd: Update client port number if default is unavailable
...
And print that on the console so that user knows what port the current
wsd instance is using.
Change-Id: I68fb7d23f46df4ad56ba444735b2888c410f7bd5
2018-01-26 20:10:36 +05:30
Pranav Kant
c16d198560
Print humanized bytes in the logs
...
Change-Id: I2ebdea0c3a360be1573ae13fa9cbe6f432436f29
2018-01-26 20:03:22 +05:30
Pranav Kant
f942e5a29e
loolconfig: Allow changing loolwsd.xml
...
eg: `loolconfig set-raw-config admin_console.password admin`
And while at it, stop processing all the arguments given to the command.
Regard the first argument (without any "--") as command and let the
specific-command handling routine handle the remaining arguments the way
it wants.
Change-Id: I6cc406c56701dba2b99e0a3c4a98c505df70ee60
2018-01-26 18:34:17 +05:30
Andras Timar
5448c0a7bf
Online docker: we need galaxy theme too as fallback
...
Change-Id: Iaa91f6c81b40ee3702e864dc283fe30317a80a85
2018-01-25 10:06:10 +01:00
Andras Timar
e53898bb06
Online docker: add thesauri
...
Change-Id: Ifad39a3d5cceb009e1d0c449b4bd239449b30a9a
2018-01-25 08:07:35 +01:00
Aron Budea
8f2477816b
wsd: increase preinit timeout 5-fold
...
Change-Id: I08ab74498ef9396edba5311a7e31b75c5932bbd6
Reviewed-on: https://gerrit.libreoffice.org/44495
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2018-01-25 06:22:49 +01:00
Michael Meeks
83cef0d0d7
Add the Thesaurus dialog.
...
Change-Id: I976ffd46e95dfa675150ee66650f211b2c9f5cdc
2018-01-24 12:02:03 +01:00
Andras Timar
a2e25cc7d3
Add PAM support
...
Possibilities are endless. With a simple /etc/pam.d/loolwsd config below,
the user which runs loolwsd ('lool' in production environment) can login
to admin console with normal linux password.
auth required pam_unix.so
account required pam_unix.so
Change-Id: I354a7e9b4705e8fe346d17d6b6041d1406198b37
Reviewed-on: https://gerrit.libreoffice.org/48307
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-23 11:03:45 +01:00
Aditya Dewan
30b44bf373
show/hide of document name on top right
...
Change-Id: I83ae0256c0fdd1c9f61495638ecf9d69f5473790
Reviewed-on: https://gerrit.libreoffice.org/46576
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-23 09:45:54 +01:00
Miklos Vajna
88487e23d3
loolkitconfig.xcu: add documentation how to disable thumbnails
...
But don't change the core.git default.
2018-01-22 17:34:31 +01:00
Ashod Nakashian
11cdfb7688
wsd: avoid misleading socket error logs
...
Change-Id: Ie70d8eb1ecc0442643f4b2a4757b95688b4cf1f7
Reviewed-on: https://gerrit.libreoffice.org/48284
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-01-22 10:14:17 +01:00
Henry Castro
dc0001e92f
loleaflet: impress: ensure to remove the layer annotation items
...
Change-Id: I660686c193f367ba22278fb2d1c8b2525572c3e0
2018-01-20 17:44:49 -04:00
Henry Castro
90cd7791fa
kit: remove unused debug code
...
Change-Id: Ibd69a2b451be0a075759524acff5f0e9fc820d05
2018-01-20 16:41:13 -04:00
Pranav Kant
0547507b67
wsd: Fix incorrect file size reported
...
Close/flush the file after copying into it so that we can calculate the exact
filesize later on.
Change-Id: I30aca9d0ac3702394a4465c30c61954a726eec39
2018-01-19 12:58:58 +05:30
Ashod Nakashian
c06376cc1d
wsd: cleanup logging and remove unused helpers
...
Now all logging is done after checking if the
level in question is enabled or not (thanks to
the macros LOG_XXX), which saves unnecessary
conversions and stringification when said level
is disabled.
Change-Id: Icde31e067f60269563896f04f8b0d65643720766
Reviewed-on: https://gerrit.libreoffice.org/47885
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-01-19 00:33:40 +01:00
Henry Castro
13e2868601
loleaflet: add page styles to header & footer
...
Change-Id: Iaea6edeb819e2b750148c9ebb62b1acda4d4c951
Reviewed-on: https://gerrit.libreoffice.org/47773
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2018-01-18 20:54:26 +01:00
Pranav Kant
63e089ec22
loleaflet: No native contextmenu options on dialog canvas
...
Dialogs can have their own context menu invoked upon right click. And
they already works (i.e. are tunneled properly); so, let's use them.
Change-Id: I7d504923c272227dca94058995456d89e1079c29
2018-01-18 12:29:02 +05:30
Andras Timar
947438852d
Updated Slovenian translation
...
Change-Id: Id3db1c3325e8f761ea4d82a4ca4e3f366a910420
2018-01-17 23:49:17 +01:00
Andras Timar
a721eac8b5
Online docker: get latest translations from LibreOffice
...
Change-Id: If6b15f23daab035c3332a68a7181c1829a886fbe
2018-01-17 23:45:25 +01:00
Andras Timar
a8f3876ea4
enable l10n of Control.AlertDialog.js
...
Change-Id: I841aa6b7ef02fd6681fc55f16976a38de69c54b6
Reviewed-on: https://gerrit.libreoffice.org/48061
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-17 20:52:17 +01:00
Andras Timar
44a5f820b7
fix l10n of this Oops message and use branding, if available
...
Change-Id: Iaaa3c93d7b025617059e2c8a55195eb67e23f399
Reviewed-on: https://gerrit.libreoffice.org/48063
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-17 20:51:35 +01:00
Andras Timar
4ec7fdb17e
These params are unsigned, Poco takes it seriously ([ERRFMT] was sent instead of number)
...
Change-Id: Ie0bbf5c5f5fb96231baa5425b6a38dcbb614f61e
Reviewed-on: https://gerrit.libreoffice.org/48060
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-17 20:51:17 +01:00