When using Nextcloud with source file with spaces in the name
eg. "file name.docx" and we tried to export as PDF
then error appeared.
In the logs we had "SaveAs produced no output in '<...>file%20name.docx', producing blank url.
We need to decode file name similar to convert-to case.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic60cefefc4e20b53feee28b86443090c147bb66e
Probably due to core side changes. I needed to comment out the property checks.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I26683265b827447e676a6463b19b5cb84a0040fc
Signed-off-by: ChrisGlad <chris.gladman2004@gmail.com>
This code fixes the problem that elements in the Notebookbar will
not be correctly displayed as "selected" after changing the UI
mode.
Change-Id: I4f889f8593029c375a06e17dbf1062bb9b9f5efc
This adds a dark mode toggle to both user interface views (compact and tabbed view).
In addition, this code fixes the problem that the initial theme did not load properly
based on settings. Equally, the Toggle in Notebookbar will now appear
"selected" when pressed.
Signed-off-by: ChrisGlad <chris.gladman2004@gmail.com>
Change-Id: I0e0c282cec24d9bb7fbfc4131ba3875976cea5fd
This reverts commit a864d41c09.
Because we can now work in this WIP feature in its dedicated
feature branch.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
- forcefully send unocommand when jsdialog popup is still open
- fix navigation using ArrowKeys in treeview
- fix console error ev.data is null
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I6dd75b8b576754513574749e1bd9675581caeabf
- instead of using /dev/[u]random devices, use
getrandom() and/or getentropy() to make direct
system calls if sys/random.h is available.
- if getrandom() fails, we need to fall back
to "/dev/[u]random" approach.
Signed-off-by: Bayram Çiçek <bayram.cicek@libreoffice.org>
Change-Id: Ied37d72feabf005725b615b02854912809236bbc
Behave the same as Contol.Menubar and never disable Paste toolbar
button. Native clients that run LibreOffice locally may send a
"statechanged: .uno:Paste=disabled" message when opening a document
if the system clipboard is empty, So, we ignore such messages or else
the current document's Paste toolbar button will never be enabled.
Signed-off-by: Patrick Luby <patrick.luby@collabora.com>
Change-Id: Ied2aaa49f1a9defe30541af49f4becda35df568b
Replace closeAll calls with uimanager.closeAll. It works for also mobile view.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ieaf11fc8f68390f789c18a29813a171d51c13a88
Mobile apps don't substitute these values so set them to zero length
strings.
Also, the iOS app sets the base text direction via the "dir" parameter
so add handling of that parameter in cool.html. TODO: check if the
Android and GTK apps need to implement the "dir" parameter to handle
RTL layout.
Signed-off-by: Patrick Luby <patrick.luby@collabora.com>
Change-Id: Ied8268ec256011281961ef610d53baeee0efe9cd
The iOS app saves directly to local disk so, other than for
"view file extension" document types or other cases that
I am missing, we can assume the document is writable until
a write failure occurs.
Signed-off-by: Patrick Luby <patrick.luby@collabora.com>
Change-Id: Iacb1589eded18f0cb21a5dd8e4d91d295ae697fe
Limit escaping of non-ASCII text and splitting on the first newline to
only certain message types on iOS.
Also, fix mangled UTF-8 text on iOS in jsdialogs when using languages
like Greek and Japanese by only setting the image bytes for only the
same set of message types.
Signed-off-by: Patrick Luby <patrick.luby@collabora.com>
Change-Id: I9cd088509ba9724108da3c9457cd3d098b45723f
Previously we waited at least as long as
it took to process the last request before
issuing a new one. This can be unnecessarily
long, especially when unloading. Now we half
that time.
We should consider a more sophisticated logic,
especially during unloading, where it's best
to upload quickly.
Change-Id: Id903b8a064bd8431578221dc9386ab08d46dd2dd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This corrects the reported upload duration
at the end of uploading.
Change-Id: I9d3af4d3dce5aff0c3526ba009fc0b27150bc070
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
It seems more complex to have #ifdef guarded logic
around a function call to pass or not pass an argument
when we that same argument is already defaulted in
that function.
If the difference between the two paths is primarily
the argument, then we can always pass it, making sure
that in the case that defaulting would have been used
that we pass the same default value. This is now done
with assertions.
Change-Id: I333eb3f42cb51dfab8584ae8c5aa52ee45c5a9a1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We could still have session instances in the
_sessions container in DocBroker by the time
we destroy it, what counts is that they aren't
live at that point.
We could still have sessions because we may
be waiting for the kit to confirm disconnection.
But if that was the last session, the kit will
instead exit and that would trigger the
destruction as the PrisonerRequestDispatcher
will have to clean up the DocBroker instance,
hence destroying us.
Change-Id: I8ce103d38edc355d09da046e1b875f0e62768adc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
After unloading a document, the ChildProcess instance
may be destroyed by the time that we process the
internal prisoner connection. In that case, we
can't find the ChildProcess so we assume it was
a premature death and issue a warning.
By tracking whether or not a PrisonerRequestDispatcher
had an associated DocBroker, we can supress warnings.
Change-Id: I8bab882283f27f7d5f724e878aae19837445a2fe
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
