And just disable them when engine is not present
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6504197f096b4e48d075ee0d631217cb576f4a22
- Move menu entries (that are exclusively related to references)
to References menu
- Add Missing menu entries to References menu so it has 1 to 1
parity with References tab (tabbed view)
- Update text in some menu entries so it follows what has changes
in the tabbed view
- Add separators
Note: Footnote and endnote action were also kept under insert
menu because it seems user are already very used to that. So,
now they can be found both under Insert and References menus
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icde47f88f60c8423b9af3f6f3793bb8da056adde
There is no reason to print the test name
explicitly when each log entry is already
prefixed by the test name.
Change-Id: I72c0a0f2989a65f477902b97e6be816446fba5c3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
After failing a test, any assertion will simply
pile-on and add noise. There is little benefit
in seeing assertion failures (and especially
core-dumps) after a test has failed.
This change silently suppresses assertions if
a test has failed already.
Change-Id: I5146f12692c0275579510dfac7ef7b37d5af86d0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Now that we may have multiple tests in a
given Test Suite (i.e. a since unit-test
.so module), it is important to calculate
the timeout not from the total elapsed
time, but form the start of the *current*
test.
To that end, we capture the start time
on the first checkTimeout call, which
gives us the elapsed time from the very
start of the Test Suite. Using this, we
offset the elapsed time to arrive at
the time the current test consumed.
Change-Id: I01ebc3572bc147a3dabac7e1fb3237ea6d479116
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This decodes strings encoded using
encodeURIComponent.
For now, it wraps Poco::URI::decode,
which should be replaced in the future.
Change-Id: I608b327be81aeda37d2afc4dfd29828658e92dc8
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Housekeeping assertions in tests can be noisy
and unhelpful. There is little advantage to
logging them on passing as, unlike the
assertions in tests, they don't represent
any particular progress in a given test,
nor are they specific to any test either.
Change-Id: Id1005264b7c75f01c241e36a53f24f2c656406f8
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
note: Ideally we would always add the buttons,
but when the extra capabilities are not available we would
switch the trigger for all of those buttons to be a warning
dialog
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7359fe222eff31920b78116e69b45aa60cb15790
Use keyword citation in multiple buttons so they can be
easily understood and grouped
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4104bdcbb555ee3f4a2b446ad70583e00727cab1
Thus, Remove Zotero dedicated tab and menu
- Add instead to existing references tab
Also remove dedicated top menu (compact)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8b056ac17fceb0bad2c9a864faeaf3ed2eec8d9d
Also make sure that new menu is only visible if zotero is
available
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0893515dbc5495aa8251fc9ca795fea357400e6c
Also rename the current testing button (Citation Style) to be used
temporarily as doc pref.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I70c434a42034a1ee0d729e4aa855b37e5d195950
When we have 2 users:
A is typing on the page 0
B is at the bottom of the document
We scrolled view B when page overflow happened what caused
"flickering". This patch prevents us from scrolling when
cursor is still on the screen and visible.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id8f3a12ba566a4b2fd03bf3ab5aa618f8e00c263
- Prefer to show zotero related actions within a dedicated tab (instead
of adding those within references tab as it was previously). This,
hopefully is more familiar to user using similar interface elsewhere
- Show this new tab conditionally (if zotero is enabled)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1690295724d54693aca68ade567e9d1076f26876
Avoid using `Current Index` (uno text) and instead set custom
string that is easier to understand
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5057b7c974a5bd33f8af5b93f5bf6a85af916f98
Messages are high-frequency events and logging
them at debug level is too noisy. Increase the
level to trace.
Debug level should produce legible entries that
outline the main activities, rather than log
each message. That is best done at trace level.
Change-Id: I722ab8b58e0adcab6ecb2f8c571966af0d952051
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
In some cases mounting fails on /tmp, which
should be writable. This results in Poco
exception when trying to write to it during
mounting.
This catches exceptions and fails gracefully
to enable falling back to copying.
Change-Id: I38c8db4f452767ee43bb20a98d13bd5cc36fdba2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
With the latest gcc and Core, debug builds load
and save is substantially slower. The size of
the test document for UnitWOPISlow was 100s
of pages, which took minutes to load and save.
This reduces the size and re-sorts the tests
to minimize the total run time.
Change-Id: Id1ca10d882c5ffcd1ea894279b21fedb06f287f7
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Capture the save result early and log how
long it took to save, for informational
reasons.
Change-Id: I0ca04a5b62a2dda38a058f8fa5ca62df33cc0555
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The autogen.sh script is not supposed to be sourced ("source
autogen.sh"), but run as a command ("./autogen.sh"). After all, it has
the executable bit set. Also, the function called "failed" in it does
an "exit" at the end. That would be a rather rude thing to do as soon
as something goes wrong if the script is sourced.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ia0e4bbb2b9bed93fb4dba5c0f46a1760ec6e50d7
And move the validation of rename sessionId
where it belongs.
Change-Id: I3fb16ff7b648accaa20b041bf3fd6b82f516cb9b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
