Otherwise, there is no way to know which connection
a given log belongs to, when websrv_poll handles
multiple simultaneous connections.
Also removed a duplicate log entry.
Change-Id: Id74e6e7b66062daf15a716b9fea8e7995fd75af0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
For some reason, assertions do not work properly
in afterEach hook after a test failure. So in case
of test failure we don't check the admin page,
whether the test file was actually closed, but we
just wait a constant time.
Change-Id: If2eb927b0383816639689ec67eef7e3cd1142366
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
To reuse as much code as we can. We can use the same
method on mobile and on desktop.
Change-Id: I15b1038313145db6cb6ea07489c0d30a0fc2ce64
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
To make them more stable. I used tc tool to
simulate network delay to find issues with
the test code.
Change-Id: I9a67a2650fc08e573323b1df96b940318b4a45cb
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
instead of the current author and date,
it showed the date and author of the original comment we are replying to.
It caused many problems in the development of comment wizard.
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Iad3cc8dd8b3053c73ce1f575ff5d50ba3c666c70
Simplified getTextPosForFirstCell() method and
renamed to better match with the function.
Also modified getCursorPos() method. Sometimes
we have an additional hidden text cursor for
formulabar.
Change-Id: Ia8adc645ef3f20426dd509803fcfc4f35662a779
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
size_t in C and in C++ are not necessarily the same
type. The C++ size_t is in the std namespace. Since
we do include many C headers, and indeed some C++
runtime headers do define size_t for backwards
compatibility, it's easy to mix and match the two
types.
Also, 'using std::size_t;' isn't a great practice,
so removed.
This is not exhaustive, just some low-hanging cases.
Change-Id: I85a36b6fd1acd204274b1869de9bcb94c8b3cf13
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We now log the test assertion failure and exception (if any) details
with file and line number to assist in faster troubleshooting.
Change-Id: I3217458f30383cd24f3cbbe15431f2b9151744d4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This makes the code self-documenting and avoids accidental
comparison or assignment of Result variables/values.
Change-Id: I84b8e36aa999191c8704938552b73ddc1c3dc3fc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This replaces Util::getFileTimestamp with
FileUtil::Stat::modifiedTimepoint() and fixes a potential bug:
getFileTimestamp had only 1 second precision (it simply dropped
sub-second data). This could mean that any modifications to a file
within a second could not be detected.
Minor simplifications done where possible and overly long lines
have been reformatted.
This is a non-functional change (except that file modified-time
now supports microsecond precision).
Change-Id: I3606638a86fc3e00c0ad5cb602bdbb2b4651867b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Often loleaflet.html is loaded via POST requests. This
new sample demonstrates and exercises this approach and
is a handy way to load documents.
Change-Id: I065a946413ab08d399ac5704c67f6f1ba37bdd9e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This should make this sample much more useful by documenting
the proper usage and helping the user avoid common pitfalls.
Change-Id: I965bed0e4ab685dd2a68f7b246dd9a409d296337
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Confusion arose due to separate creation of session, and watermark
property fetch from CheckFileInfo which happens in DocumentBroker::load
which doesn't do a load. This happens in a subsequent 'load url='
message cf. global.js which can then race vs. the session creation.
This causes mis-ordering of another unhelpfully shared Session,
letting the view canonicalization list to get out of sync between
the two processes.
So instead - tell the view it's canonical id. An example of the
problems of trying to share some unclear subset of the Session
class between kit and wsd perhaps.
Change-Id: I63dc30f9a047e3f889fd339b6aaf392b9fef37b9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
The issue was fixed triggered by this test case.
Change-Id: I00522835c25ca18aa374958c5b33b13f35e79563
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's duplicated now. It was one of the first
prototype tests.
Change-Id: I6a63644713189c8f56a77cc21df0c2a42d724547
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
After a test failure, it's common, that the afterAll
method also fails which covers the right error
message and also makes the following tests to be ignored.
Change-Id: I5c1bbc5dd8b1b48dd2a8f1fc20a8ca3b8ecd8462
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
1033 means en-US locale. It can be different in an
NC environment for example.
Change-Id: I929a7308b9f0d4a102f836d1ec66c5c98a6eb9c6
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In NC environment it does not work properly.
Change-Id: I9adbb01b450103a6ac2aa211eb933a5ab3f5fcd2
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
