This is needed so 584aa5b8f6
is also applied on tabbed view.
Until now we were just adding that class when on compact view
(Control.TopToolbar.js)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8c0ac3d909f64025f301651564b3c2b1ae130e1c
Currently translated at 62.5% (286 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (462 of 462 strings)
Translated using Weblate (Russian)
Currently translated at 99.7% (461 of 462 strings)
Co-authored-by: Егор Ермаков <eg.ermakov2016@yandex.ru>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ru/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ru/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I821ed266d54f8802e747aa5c558799851d93121e
Use a dark solid background color - with a shadow (already existent)
- to stand out against content.
Make sure button is blue similar to test selection handles or some
icons etc. So it is visible at 1st sight what's the action
Remove unnecessary or duplicated rules
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I53a291f762c4ed40f5b39230fad8246fa280d050
It is not a normal dialog as in jsdialog or lodialog,
no need to add border
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib7a4d3d1a89f1c69df8e7a374d4283d48b66e42b
Avoid odd number by stop relying on a division by 2.
Instead, use the same already existent border radius.
-----
In the future if we end up deciding on something else,
we should probably create a new var for that and apply
it to all dialogs
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If0e53f0b2a965587c33156536f74fcc0a223a43a
Since the row height spinner is the 1st element in the row,
there is no need for margin.
Note: in the future wuld be good to have the spinner coming from the
builder with additional class or style when they are the first
element being positioned
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I2396ab662fcb4a12762b4a6e2b38582f1df7c59b
Remove unnecessary rules targetting minimalrowheight and
minimalcolumnwidth. These rules were
1. Not being apply always (sometimes jsbuilder was
setting them with different id, e.g.: with suffix 1)
2. Even when apply this rules were forcing these two btns
to go up, looking like they are mere icon for the spinner.
This is wrong. They are buttons that trigger the set to the
minimal sizes of that particular row or columns
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I53e81c69cdcc3aafd2ca5ab0f8e196d912b86608
Before this change the spinner were getting unnecessary additional
padding.
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I43b8bffc8bacc13dfc633cee4cd8f7823834d402
Adjust the drop-down dialog to the #map element
to show the correct position sent by the server.
Change-Id: I74a6d7402438241aae77a18699c3297d64b34098
Signed-off-by: Henry Castro <hcastro@collabora.com>
This was affecting how we perceive padding around formulabar
- Making it look uneven (with more space at the bottom)
- Making toolbar-wrapper's bg visible at the bottom
Remove bottom padding when in presence of spreadsheet so to
avoid affecting the other apps
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icce34ecb64781221428130f4a11420b5546003ad
Using unitless values will be automatically
multiply by the element's font size
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ice4b56c5da7e47aae83347c1bf6b6ac377a51518
Make sure every element between item address parent and the
item address itself is place at the top
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib883f6659788f4ec42ae6d953fa2d857038fc815
- Set heights to even numbers so we don't end up with uneven
surrounding vertical spaces
- Remove individual top margins (margin-block-start) from btns
- Instead fix underlying issue with formulabar
- Fix text-area padding inconsistencies between being expanded
and collapsed. Problem: text area becomes taller, ending up
occupying the top and bottom white space left from its parent
- Leverage new css class added to the main parent #formulabar
and add vertical padding so text-area forces parent to increase
in size
- Remove sub parent's (#tb_formulabar_item_formula)
individual top padding
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I380af6cf70c0e879224329fbf9093e0778a38d8d
Avoid setting elements, located on the edges, with margin
in the hopes we get an overall padding:
- Remove it
- Add instead a true padding to the main parent
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie1690c9cc3c58f59387cb6aa73df20d42f5cc1fb
When editing formulabar using keyboard - try to use shift + arrow
to make selection from the end in backward direction.
This patch makes it possible (visible).
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I48073214545892d98be097b38c60251ff95082f3
eg. Chrome setups selection only if element has focus
it prevents us from stealing focus by formulabar when
switching cells
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I46cbd4d04615478a95a36dd8bcda22d732e74d3e
check infobar data when the server send
the user info data.
Change-Id: I0ba1da488f9b3d03dc7e3f42cea718273e6939b1
Signed-off-by: Henry Castro <hcastro@collabora.com>
if there is no more paragraphs: exit the loop
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7075ff5454e1ddcc11155867f835e85117bdea15
Improve performance by not looking up endIdx that may be over the end
of the range. Ensure we still have valid data for the pieces we do
know about.
Playing with a complex 1m row spreadsheet and re-sizing rows by
typing multi-line text into them would provoke row header problems
otherwise.
Change-Id: I5a110137e6d26e2c4b272210cf41883abb02c3af
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
When we use API call InsertButton and we add custom buttons
we want to keep them when we switch between compact/tabbed view.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If03520f52422ac41aa40432f068e5bc011ed2596
use sendContentControlEvent to set picture instead of InsertGraphic uno command
since InsertGraphic is not allowed for a protected content control (like picture),
only sendContentControlEvent();
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I5f70919d995c51456056a8be2aa1e596df7bedc2
and thus avoid cropping it altogether
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If959c617c6036daa353dc8185668aeb99d515497
Before not only it was not vertically aligned but it was difficult
to read
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3790d51f4a90dd9bdb5158cfa16ed92de1ebfca5
Set it to 24px, fix stroke and make it a path
- Result same size, smaller visual indicator
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic41b7a1d8e798998ea9399cd68c9fc6b46e73725
Decrease number of visual differences between the two while
by using similar style. Add border radius already in use
in other components such as drop-down menus.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I09b51f0817d35641cfc7d028e281ae3ba362a663
The rules found in toolbar-mobile.css seem to no longer be needed
in any shape or form on desktop (even on FF). Remove file and
insert those changes within device-mobile (so it is loaded only
when on mobile)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I58a3d52fc6313a8e32916fa2b5dd4796dd1c1cef
And make them less "shouting" by default
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I69306cbe6107ce1f7306291fe55d7f54f7fdfe8b
- Make it clear that it is a menu button
- Remove extra space between triangle and image
- Fix icon size, before it was overshadowing the function icon
- Redo icon, so it is more legible, less tall and less flimsy
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I95c635b9a39aaa4dd470372018c63c9f45385b25
ported from:
PR: https://github.com/CollaboraOnline/online/pull/4976
In cases when the button text is too long
or when using CO in, for example, DE language and when
the length of the parent dialog was not enough the btns
would not stack up, instead that would overlap. This would
make reading those btns impossible.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I801ea330db21add35d0a81466a1fba9501a61899
Currently translated at 100.0% (462 of 462 strings)
Translated using Weblate (Italian)
Currently translated at 93.0% (430 of 462 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (457 of 457 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (22 of 22 strings)
Co-authored-by: AbsurdUsername <sgso@pm.me>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/it/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/it/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/it/
Translation: Collabora Online/Android lib
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I41053824fbb7040c79820dd95e503fe7dcf00f1b
This helps us to be in sync with core especially with
problematic dropdowns like:
Sidebar in shape context -> Line Panel -> Line Width
This will close and not reopen the popup when we click outside.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4daf90f2611f6caa922022e1cc6e248f6a62d02f
User a darker background for on mouseover items
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib6dc6d2ed434d21765ab3d6bf3988dc918261281
Use the same padding as the user names and thus fixing the
alignment (vertical: checkbox vs avatars)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1acb8cf5e3e5dc8aad083151c9c54b38aa552d6c
Until now user was reporting not fully understanding all the
features that user userListPopover offers. Namely, not knowing
that not only is possible to follow the editor (checkbox) but
that it is also possible to follow a specific user from the list
Make it easier to understand what's the current following status
by adding "Following" under the selected user name in the list
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0beba5df06f2cc7a9a349ef8f93db6b403befb9b
Get rid of the popover once the user completes the action
Probably better to avoid having hanging popover (that have no
close btn) and instead close them, specially because this
one can always be re-opened at anytime from omnipresent
toolbar and without risk of triggering any additional change
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id7946512e6c54622e3ed20b28d56178c05b18b5c
Make sure the avatar list popover automatically gets out of the
way once the user selects an entry (follow user)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie83a587e4f9900ffb0d70cadbfb13cfe81d8b849
Before the triangle was getting a different bg when compared
to #userListPopover
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If110d9e1178bedb7e858804e169689ee97a5a385
Instead of trying to re-position #userListPopover for every case
(compact view, tabbed view and rtl), use flex to align the elements
- This also fixes the positioning discrepancy of both the popover
but also the arrow (triangle)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I32ed3e05efc51001db106f5baaf18012e87965fe
When spreadsheet was opened after few seconds we received CellCursor
message.
If comment was opened end edited at that time - it dissapeared
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I15804bfa0bf9ccac03c2858184db327a978061b3
Don't add multiple overlays with the same id.
Remove overlay always when it exists and we close.
Close dropdown entires by dropdown click - specific to 21.11
where popups in the core are handled differently.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia1652434f38571defb817bfb29491ed0bd246e73
For toolitems with dropdowns we should toggle the button.
Use correct parent so we don't use button from other component.
Later we send toggle event to properly close the popup on the server.
example: Calc sidebar, Underline popup
Before this patch when we clicked in outside the popup it dissapeared
but app was completly blocked.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I124a41361df305931c66047a8799ce03393b67de
Currently translated at 100.0% (457 of 457 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (455 of 455 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (5 of 5 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (457 of 457 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (455 of 455 strings)
Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/nl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ios-app/nl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Translation: Collabora Online/iOS app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4ad42f81a439d04a053b18b5669ba6f42f116d7b
Currently translated at 100.0% (455 of 455 strings)
Translated using Weblate (Hebrew)
Currently translated at 99.7% (454 of 455 strings)
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I492efa1e1594cb3aeb663818a61dd26f9f2dbf95
Keep in sync colors in sidebar and notebookbar when
we change one of them.
Followup for
commit 13ef21aa1e
notebookbar: unify color control with core
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia8af727c6ba6b5b32a644ff070954c9ada584a24
unclutter formula bar surrouding elements by removing the visual
break and instead add padding. Plus: we can now remove CSS
rules that were targetting that break's id
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4a9990a5709918d7cacfac2ef41b91281f9af54a
This fixes a odd behaviour present on chrome based browsers
where the adress input (current cell) was being rendered
with a thicker border and with emboss style due to browsers'
default values
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib5ab745ab45415e86a2976d537b5766a72a136d3
Just after we opened spreadsheet and opened font list - it was
closed after some seconds due to focus change caused by
.uno:CellCursor update.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifabde00163567ab7d4f3f8359d58b4251fff5ec3
in desktop case color widget should show the latest selected
color not current one. split the button into arrow with dropdown
and "last color" button (icon)
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I07fcc94d69e14b030cf9f1bfe3ae50f0df333ec7
the css rule for #fontsizecombobox at file
mobilewizard.css
change also the behaviour at desktop sidebar
so added .mobile-wizard and than the rule
was for mobile only.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I704857bca49556abebca018ef7a284c7b2159530
Be sure we focus active part of a widget. We also require
active eleme3nts to have unique ids assigned so we don't
lose focus after we update the widget.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf741f4753022b7f4da92184d576623dd0300adc
This helps to keep id unique and process events correctly.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I35997ed40d09de73a7451b54243c54b041fd9c34
fix: after switching to Notebookbar view and back again to Classic View; the Save icon reappears.
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I8fda18a9148c679209f0de99b80526393a965720
Bug
- pushbuttons with images get misaligned. Namely the inner image that
it's position well. Visible in some places within the sidebar
impress, calc:
https://archive.org/download/bug-pushbutton-with-img-alignments/bug-pushbutton-with-img-alignments.png
Fix
- Pushbuttons with images are now classified with .has-img and inherit
the respective global flexbox CSS classes.
- Add global flex box CSS classes so we can avoid code duplication
- Also make sure other pushbuttons with image don't butchered with this
change (e.g. calc > pivot table dialog)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie37680eb02c15417c505402074bbe01d302910cb
add: form icon in insert menu
fix: datecontentcontrol icon in form menu, jsdialog: options for all content control types were shown
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Id3f425f3a80cb09f58b3f83224bb19ebb365e8f3
This will allow to create multiline cell content using Shift+Enter
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie1b8497063fc59e29d010c62724b88c4ad8972a0
Content control properties is not always an active button, it only
takes affect once a content control is selected thus best to place it
at the end.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie13bdc81a84730380d8462241661775d1abd1699
Currently there is no plans of adding more content controls. In total
there are 5 content controls toolitems and one for accessing its
properties.
- Make it easier to pick content controls by increase toolitem size
(bigtoolitem)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I86d8c1025cb4ff82fe45654076800057e17e9ea6
No need to duplicate the icon, use the existent one.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I22ad3f99778051d6b663207ad229e808a34c0e3e
add uno command to insert date in form tab
renamed 'Content Control Properties' -> 'Properties'
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib4a439cd349bb79430d590e0b80c825372c629d3
Don't generate spam in the console log with warnings about not
activated notebookbar in apps where we don't use any welded widgets.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I48c2d843752058923242d6678f08ec0791d08e4c
We automatically send notebookbar activation command in some cases.
Allow this command when dialog is opened and don't blink.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iac068cfca49ce6dbfe241bde752a475560d3445e
Fix#4808 by add SlideMasterPage to impress view tab
and add a context related MasterPage tab.
Update the icons to use the master*.svg colibre icons from core
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ibbd24d1c20a48e26591d217311c5989794aa841e
when other view moved cursor outside out view - all of
them were hidden because we used selector for all the
elements matching cursor class - instead of current
instance
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If97606f33e44ce59f747ad0b015048deacbe8657
add combobox to list of non-containers and cleanup
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I657038c960d7c606a0e437b0c24e74e83f2c2b00
Compact View is separate in the menubar from Sidebar and Statusbar
So it shouldn't be between them in the View Tab.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ib46e9c4a4df24432eae5a7fef335e7cde68b1766
Signed-off-by: andreas kainz <kainz.a@gmail.com>
In the insert tab there is the command uno:BasicShapes
by select BasicShapes the user can insert shapes
at least Basic Shapes, Symbol Shapes, Block Arrows,
Stars and Banners, Callouts, Flowchart, ...
So uno:BasicShapes will let you insert all available type of shapes
therefore the text label should be Shapes instead of Basic Shapes.
fix#4672
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I692b7a5b03b905599648c7af4a016684b12b335a
This reverts commit dd83984896.
The logo style already exists and to avoid override rule.
Change-Id: Idf59f1acbc427ea8a33147398057de1883731830
Signed-off-by: Henry Castro <hcastro@collabora.com>
So we can type after we closed popup in the sidebar.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib4164cfa0b7b25b0a3aeeccdd9d0ac8c9bf7f280
- Only visible when macros is switched on (coolwsd.xml)
- Added to the File tab because:
- We do not have Tools tab and it seems we do not have a need or
more > 1 action that justifies an yet another new tab
- Run Macro could fall into Review or insert category but and
since the icon when pressed Runs a Macro, best to place it
within File tab since it affects the file. Plus user that is used
to operate within classic view it's more likely to go to File tab
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I8110fc259860d285f0c911b9b553bdc67235f4e2
if comment is selected but is not in editing,
proceed to normal pasting in document
problem:
while pasting content multiple times with comment,
previously pasted comment stays selected and can't further normally
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ia594c725f4fe7108d6aea1591d88b2c306202be3
Currently translated at 100.0% (447 of 447 strings)
Translated using Weblate (Hebrew)
Currently translated at 99.7% (446 of 447 strings)
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib31ef778fdf841f6c5d98c2b3112b052dcf053d2
- added a new menu button 'form' in classic and tab button in notebookbar for content control
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ibe06667de39199fd2541fa70ced3ff879274366d
we should do the same for other modifiers: shift, alt
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I75933194aee82589c787c8c31cc47b66e96e2066
problem solved:
some times when cell cursor is moved using keyboard,
comments were not unselected,
which caused problems when copying cell which contains comment.
i.e: comments were pasted inside the cell as plain text
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I318c850c25956d210ef9acfa631a689a4d1a71c6
This added begin and end mark to the popup so we can detect
we are leaving the popup and we should close.
This prevents us from blocking the whole UI by focusing
map and typing before popup was closed.
Also close popup when server confirmed it should be closed.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1a290e27dd7a14eca2cd3bb8368fee27255f51a8
Before the expander button was detached from input this in turn was:
- Making it hard to understand what that button will do
- Affecting the overall look and feel of the formulabar (different border-radius etc)
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Id17742aae8b09acd3bdcbffd05fe17181492322d
Add expand toggle class to parent and use it to align unotoolbuttons
Before, there was no way to know if the input was expanded or not by just looking at container
or any parent. thus, no way to fix alignments per MultiLine status
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Idddefc32812a3aab29ddb72c4d09bacd43b03287
some unotoolbutton was being set with the same same size as it's img child
- There is not need to do this only for :not(.has-dropdown)
- Make sure img has correct size, let parent element to adapt, no need to
single out this case
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I1c3734a81cb01a0d15604a2b88148a0f883a59d1
Formula input window (textarea) had different height from address input
- Set it at the same height as seen in toolbar.css:211
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Id0fc3dfb0335183050eedc00036b85dbafe2d0b4
Avoid using percentages when we can already use the grow property
(it avoids different results across browsers)
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I262cfdf5d72313296620e3e522bfa97ab2b00ca5
In order to get the list users and identify if it
is a guest user to not show the welcome dialog.
Change-Id: I439f46dcfd3ea5b307059952f98f49a387158e24
Signed-off-by: Henry Castro <hcastro@collabora.com>
Reset document info on idle
resetting document info will force to use new status of the document
problem:
reconnecting after idle, user could not type anything in document,
this was due to some properties were to set assuming they existed from last session (i.e: clientzoom)
resetting document info will force to use new status message and set all the properties again correctly
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ibcf395eee3a4e0b99413de0178331d42a1354253
Don't use strings coming from uno commands as they include
"Insert":
1. There is no need to say that these actions will "Insert", they
are already in the Insert tab
2. All other actions do not have Insert so it would be not consistent
3. On top of that with Insert in each icon the labels look quite long
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I286e95187d5df08cdf2d71bd99f3b77a17ef12ad
Cleanup some debugging, distinguish wsd/viewport delta fetches from
client-side tilecombines.
Update tests for deltas where they are expected.
Change-Id: I3dca09e4ceb094abf03db2aed2618f19351f3e28
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
We concatenate several deflated streams back to back, and need to
decompress and apply each one by one.
Change-Id: Ic31f0eae27906f7817a877c98f4cd1e5ca4ee7f3
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Squashed from feature/deltas-expanded.
TileCache changes:
+ add montonic sequence (wid) numbers to TileData
+ account for sizes of TileData with multiple blobs
+ simplify saving and notifying of tiles
Sends updates (via appendChanges) based on the sequence the
right mix of keyframes and/or deltas required as a single
message, and parse and apply those on the JS side.
We continue to use PNG for slide previews and dialogs,
but remove PngCache - used by document tiles only.
Annotates delta: properly as a binary package for the websocket.
Distinguishes between deltas and keyframes we get from
the Kit based on an initial un-compressed prefix
character which we then discard.
kit can be forced to render a keyframe by oldWid=0
Track invalidity on tiles themselves - to keep the keyframe around.
We need to be able to track that a tile is invalid, and so subscribe
to the updated version as/when it is ready - but we also want to
store the keyframe underneath any deltas.
force rendering of a keyframe for an empty slot in the TileCache.
force tile sequence to be zero for combinedtiles - so the client can
always request standalone tiles with explicit combinedtiles, or tile
requests.
move Blob to Common.hpp
use zero size for un-changed tiles.
remove obsolete render-id, and color deltas in debug mode.
cleanup unit tests for non-png tile results.
Change-Id: I987f84ac4e58004758a243c233b19a6f0d60f8c2
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
It seems at least some storage hosts report disk-full
errors via 413. This logic of handling 413 error as
disk-full was introduced in
f8e0b8c11e.
Here we handle 413 as it is defined, as Entity Too Large.
Change-Id: I61297c2fab9de663643336a6eba47949f82d1737
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Read the print ranges for the current sheet from
LOK_CALLBACK_PRINT_RANGES message and draw dashed grid lines for the
rows/columns bordering the range.
Caveats:
* Desktop calc does not draw print ranges on document load if there are
print ranges set previously on save. Cool also has the same behaviour.
* If there are multiple print ranges in the same sheet desktop calc does
not show any dashed lines indicating the ranges. Cool also adopts this
behaviour for now.
* Styling of the dashed lines was not investigated much for writing this
patch hence it uses the same drawing style as normal grids.
Signed-off-by: Dennis Francis <dennisfrancis.in@gmail.com>
Change-Id: I318b679a232f2a6834d6e23278b24a9a96b70194
(cherry picked from commit eb94d9a864a37499e21dbd064e78e40fc20b2415)
Currently translated at 59.9% (274 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 59.7% (273 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 58.8% (269 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 58.2% (266 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 57.9% (265 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 57.7% (264 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 57.3% (262 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 57.1% (261 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 57.1% (261 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 56.8% (260 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (444 of 444 strings)
Co-authored-by: Mikhail Pershin <mikhail@frcdr.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ru/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ru/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I301ef881c66e494d98bfc113af731797bb824bf0
Currently translated at 96.9% (443 of 457 strings)
Translated using Weblate (Basque)
Currently translated at 93.2% (426 of 457 strings)
Co-authored-by: Alexander Gabilondo <alexgabi@openmailbox.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/eu/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If3e9602bbdcd5e5a6c82f7770b77f99bfab7ccf5
added unocommand to enter rich text in classic, NB and mobile
created a new section to draw rich text rectangles
handle the callback for content control
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: If9912b3598729c26014519c4e1c3c65000b973a4
switch to ffffff instead of 222222 when the prefers-color-scheme is dark
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I3e3c68879c6b6a831d5fbf095597ddae6eb51f77
browsers having different themes make it hard to read the logs
this will help make logs more readable irrespective of themes
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I9e48f75d0f1ed20221c969db6d4a6ea00910717e
previously when used formulabar to type: "=SUM("
then selecting some range using mouse and "ENTER"
- referenced range was still visible
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I357b1ef51ad4d46e3e332decda0332ac4f9ad1d7
also color deltas as yellow when debugging.
Change-Id: I75e7f92708937adb31106e46e9771115320fb8d6
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Includes a horrible inlining of minified zlib de-compression (MIT)
Change-Id: Iaf5f9f5e1215458836e26d45e48e436ee52c48ef
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Makes rendering interactive again, and removes the async 'load'
from the delta application code-path.
Change-Id: Iaf95b24b299f6614b37f4188afcdbd95a4a8f673
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
jsdom requires that the tile is a HTMLCanvasElement element type
Receiver.dataMessage (private/mmeeks/deltas/browser/node_modules/ws/lib/receiver.js:51
7:14) TypeError: The first argument must be an object
at CanvasRenderingContext2D.ctx.<computed> [as drawImage] (private/mmeeks/deltas/browser/
node_modules/jsdom/lib/jsdom/living/nodes/HTMLCanvasElement-impl.js:124:17)
at TilesSection.paintSimple (private/mmeeks/deltas/browser/dist/bundle.js:1:136355
4)
at TilesSection.paint (private/mmeeks/deltas/browser/dist/bundle.js:1:1364132)
at TilesSection.<anonymous> (private/mmeeks/deltas/browser/dist/bundle.js:1:136981
2)
Change-Id: I55b77e3a9ae80afd519f1a6c6c5388070c85193e
Signed-off-by: Henry Castro <hcastro@collabora.com>
Should enable a multi-tile-processed optimization later.
For now lets us see which tiles are read & applied together easily.
Change-Id: I6e0bf13fc4df7b43503637d749753aaad828464e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Otherwise, if the user selects all the document,
the clipboard blocks Page Up or Page Down cursor jumps.
Change-Id: Ia9c432646c51063775bb7cca6a998e7d1cdcdbf2
Signed-off-by: Henry Castro <hcastro@collabora.com>
Subcontainer `root-container notebookbar` was not able to vertical align
contents even thought it has vertical-align: middle
- Fix it by removing parents' (notebookbar-options-section) height and
padding
The alignment is still off due to:
sub cell is inheriting automatic padding (useful in all other places)
- Fix it by remove padding for the cell under
.notebookbar-options-section
Display inline seems not be needed here, we can just inherit it.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iafb4f83acfff5ae0923afb972cefe1201080c79e
- prevent from multiple onDocLoaded calls
- use snackbar to ask user first before showing main dialog
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1afb67c7bb403aa05c8e33ef48c0d55fa57350dd
so we don't have to change 2 places
also I've noticed only one place had
proxy support
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I64af9dac9bd8449fba0de3b05e0c2102e440788b
which is the same color as other container elements inside of it. If
we want to use a "neutral" color that can either be light or dark (due
to future plans on dark mode) then better to just create another var
for dialog backgrounds. For now better to fix (so we can avoid dialogs
such as the pivot table to be with multiple background and with less
brightness then the document that seats behind)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I848392e3c1194963273f2950a22022eeaadbe8f0
radio buttons were being render with a border surrounding them, example:
insert pivot table, all disabled radio buttons have a border around it
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I003280ec929b49c8f8f0a1b9a4ca361c87a9224f
This was impacting alignments on dialogs. Example Find and replace,
checkbox were being pushed tot he side. Better to rely on parent
padding or table structure
also with 496256a96b -table is no longer
in use
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I60b29f818e8ec53f5c66a2772f4cda82de0011bf
Example: macro select dialog is getting set with multiple inner margins
- Simplify the CSS so we only target one sub element
- Remove unnecessary code (no need to add exception for sidebar and
formulabar)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibc35e6b8c37badbbe27b411c21986ddda0e27ef3
with 496256a96b we no longer need the
pre fix -table in the ids plus better to just remove any non essential
bits and share more CSS between places
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ica8ef3db2ed52a379cb75437d7b147c8b42bbd7b
from: 496256a96b
- let's not target absent ids on the CSS side
- Also better avoid target boxN (e.g.: box3)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I41bf1540c634dcde8111ae0192a70772153c592b
@media (prefers-color-scheme: dark) setting
is available by use color-scheme-dark.css
instead of color-scheme.css
sure the scheme need some update
but there are other open points like
use dark color for document
use dark colibre icons
this is only the .css change
so no full dark mode update
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I5c2adcbb75583a952f419af507d7cfe5c1343e3c
remove padding-top: 5px so there is no scrolling
needed for two rows.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I9a0450074cc55486d0f7de8a39b7edff8e66c752
border on left and right so it work also for RTL languages
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ic973cfee4c8fd563008477ab38a9e4e3e69c8300
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Currently translated at 100.0% (444 of 444 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (444 of 444 strings)
Co-authored-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Co-authored-by: Pedro Silva <pedro.silva@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt_BR/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I23cc55c918f72a8cc91429c03fa86f4e101a664c
Currently translated at 100.0% (444 of 444 strings)
Translated using Weblate (Slovenian)
Currently translated at 99.7% (443 of 444 strings)
Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie519a835e45d5308e3dac9eb19b879f19dc1b726
Currently translated at 68.4% (313 of 457 strings)
Translated using Weblate (Dutch)
Currently translated at 67.6% (309 of 457 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (444 of 444 strings)
Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Co-authored-by: sebastiaanveld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/nl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5690268d76c984a1920fc232c5b405b7e02a9806
