Commit graph

22190 commits

Author SHA1 Message Date
Marco Cecchetti
4dfe164f3f Make wsd aware of LOK_CALLBACK_CORE_LOG callback
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ief478ba97ac33f386d7b09aa551168e2c05259de
2023-11-14 13:16:30 +01:00
Caolán McNamara
ed8f95c1bc empty updates seen on first view of document
this is visible even with hello-world.odt in the debugging overlay where
I have 9 cols and 7 rows visible.

Load hello-world.odt and from the 4th row, 8th col onwards each tile has
a "upd: 1" of an additional empty delta update to the original tile

browser-side:
a) we have one OUTGOING: tilecombine request which which requests an
   initial 72 tiles (9 cols, 8 rows)
b) we then receive 72 tiles as requested
c) and browser sends back tileprocessed for each
d) but we then get a series of (38) delta: requests after that which are
   unexplained

server-side:
a) on the initial tilecombine, DocumentBroker::handleTileCombinedRequest
   sends the 72 requested tiles for rendering and registers to send each when
   ready.

    for (auto& tile : tileCombined.getTiles())
    {
        ...
        tilesNeedsRendering.push_back(tile);
        ...
        tileCache().subscribeToTileRendering(tile, session, now);
    }

    // Send rendering request, prerender before we actually send the tiles
    if (!tilesNeedsRendering.empty())
        sendTileCombine(TileCombined::create(tilesNeedsRendering));

    and stores what tiles it want to send in session->getRequestedTiles()

    before calling sendRequestedTiles(session);

b) at this sendRequestedTiles (also later when tileprocessed is seen from
   each tile response from the browser which also calls sendRequestedTiles), then:

c) DocumentBroker::sendRequestedTiles loops over existing requests and drops
   from session->getRequestedTiles() both the tiles that it can send immediately,
   and those that are queued to get rendered.

d) But it only does this for a max amount of tiles, based on beingRendered, up to
   a tilesOnFlyUpperLimit. beingRendered is bumped for each tile not ready yet,
   on the assumption that it needs to be rendered.

e) But we already have some getting rendered, and bump beingRendered anyway,
   so tilesOnFlyUpperLimit can easily get exceeded on a first page, typically this
   first sendRequestedTiles loop stops early, and stops dropping tiles from the
   request queue that are already queued to be rendered.

f) at some point we get a tileprocessed and sendRequestedTiles is called again,
   the request queue wasn't emptied, and by now it is likely the tile cache has
   results for them (which were already sent) and sendTileNow is used to send those,
   resulting in additional empty deltas sent for fulfilled queries.

logs will show "Redundant request to subscribe on tile" warnings in this case

Here as a conservative improvement only increase beingRendered if the sendRequestedTiles
subscribeToTileRendering actually does anything.

There is a mismatch in what handleTileCombinedRequest does vs what
sendRequestedTiles does. Maybe handleTileCombinedRequest should leave it
to sendRequestedTiles to do the sendTileCombine, or maybe
handleTileCombinedRequest shouldn't add those tiles to the session
requestedTiles.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I3044f4b3e47f00c680aa5b87dd7bdad2f27e8c73
2023-11-13 14:27:53 +00:00
Gabriel Masei
524e70eb47 fix language issue in datepicker control
It seems that datepicker control expects only a language input
in regional property (e.g. fr) instead of language-country (e.g. fr-FR).

Signed-off-by: Gabriel Masei <gabriel.masei@1and1.ro>
Change-Id: I7d5ac40cfa4a72cdc7862a8b4c4d14bdecad6c3b
2023-11-13 19:57:12 +05:30
Caolán McNamara
73a5b97b99 make this other test more robust if partial page 1 is still visible
when cursor is on page 2

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iae8d28ad54401fbbe78a2f2429f1a6912f1ea967
2023-11-13 13:39:23 +00:00
Marco Cecchetti
a5f56ce12d NC: Accessibility toggle button not set to the right state on doc load
When a document is loaded the Accessibility Support toggle button was
not set to the right state.
The problem affeced Online when integrated in Nextcloud.

Moreover the button label has been renamed to 'Voice Over' in
accordance with what suggested by NGI audit

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I5bc7d8348397691f469b6274af58e18a8d6d603c
2023-11-13 14:34:42 +01:00
Andras Timar
95815d385e helm: update appVersion
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5ea432e2409213ea204639651244c2fef4f4a8d2
2023-11-12 23:32:42 +01:00
Skyler Grey
ff1e4eeb57 Add a ui_defaults hint for touchscreens
At the moment, we try to detect whether the browser is running with a
touchscreen, however this is very imperfect. It's possible an integrator
may have more information about whether COOL is running on a device with
a touchscreen, so this ui_defaults option allows us to specify. Touch
mode binds inputs for touchscreen devices (long press for menu, pinch to
zoom, etc.) and does not bind the normal inputs (right click for menu,
etc.), so it's crucial to get it on all touch devices and no desktop
devices, as input is severely hampered if they are the wrong way round.

The option is called TouchscreenHint. Setting it to 'true' will enable
touchscreen mode, setting it to 'false' will disable touchscreen mode.
Leaving it undefined will keep our detection active.

This option must be set at page load so we can register the right
events at creation time. Therefore, ui_defaults is perfect as a method
to override this.

This is not a long-term solution. Instead, "The right thing" is to look
specifically for touch events and specifically for mouse events, rather
than using the default hammer.js behavior which is to look for both...
that should be an eventual followup to this. However, this was a lot
faster to implement and helps with the most pressing issue: not being
able to override our detection when it goes wrong.

Change-Id: Id28a156fe352fe6565ce6b472b7aa54d0869c48e
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
2023-11-10 23:20:22 +00:00
Andras Timar
82162e5c54 Bump version to 23.05.5.4
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I260232a287acbcc3585ac0dbd23f4a5b560dfd48
2023-11-10 18:19:27 +01:00
TUCAOEVER5023416dba724da7
f5d6bd2962 Translated using Weblate (Chinese (Simplified))
Currently translated at 75.3% (406 of 539 strings)

Co-authored-by: TUCAOEVER5023416dba724da7 <814697582@qq.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/zh_Hans/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If303e554b778aed38694f3c5e454e18655d3656a
2023-11-10 17:40:43 +01:00
Matthaiks
5be9424948 Translated using Weblate (Polish)
Currently translated at 100.0% (539 of 539 strings)

Co-authored-by: Matthaiks <kitynska@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I580cc2809510dd71cea487491d3addb5eb06b22c
2023-11-10 17:40:43 +01:00
Milo Ivir
b37063e1a7 Translated using Weblate (Croatian)
Currently translated at 100.0% (539 of 539 strings)

Co-authored-by: Milo Ivir <mail@milotype.de>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iff1ff65a4c1adc06a76a54b27b45965257c527ff
2023-11-10 17:40:43 +01:00
Louis Chance
32ffd98655 Translated using Weblate (French)
Currently translated at 100.0% (539 of 539 strings)

Co-authored-by: Louis Chance <contact@louischance.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib0962d3f1e9ce7e24aac63e9d76faa31e089a1ab
2023-11-10 17:40:43 +01:00
gallegonovato
2c75ad9e00 Translated using Weblate (Spanish)
Currently translated at 100.0% (539 of 539 strings)

Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I064cfeff7ab8c59373d3e7a5149f87c52ffc8a21
2023-11-10 17:40:43 +01:00
Miklos Vajna
83f2d1aaf6 context menu: allow frame properties for Writer text frames
This is now safe to show, as it'll trigger the frame insert/properties
dialog, which was converted to jsdialog in core.git commit
355681eead2411d70caf4f52f1b802cf8c61a981 (sw floattable: make Insert
Frame dialog async and mark it as a jsdialog, 2023-11-06).

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I910012286416231d607cf79cc9b3811803c52768
2023-11-10 13:49:25 +00:00
Caolán McNamara
55901bc15a 'Tileprocessed message did not arrive in time' for slide preview
A slide preview tile falls into the special case with early return and
no tileprocessed is sent back to the server, so eventually a
'Tileprocessed message did not arrive in time' will be reported

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iab85e5eca535ce377508e91cf67f1435e9242bc4
2023-11-10 13:20:03 +00:00
Pranam Lashkari
b05390fc94 clipboard: do not put formulas into client clipboard
problem:
when user copy cell with formula and paste it outside of online,
formulas are pasted instead of values.

Ideally we should always put real value in client clipboard

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I93af2fffa501c3cdc3d8ecc78d3c44121784d3e8
2023-11-09 21:35:21 +05:30
Andras Timar
381bc95773 Update uno command translations (InsertFrame)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I76ef379fe8a7082c64c48297bda804000e3a1c6b
2023-11-09 15:33:05 +01:00
Andras Timar
0e2e1cc769 Translated using Weblate (Hungarian)
Currently translated at 100.0% (539 of 539 strings)

Translated using Weblate (German)

Currently translated at 100.0% (539 of 539 strings)

Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hu/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie3f8f1ff8623a3f753aa4e25b06959c5908f9686
2023-11-09 13:50:07 +01:00
Andras Timar
d94d4ddbbd Update l10n files for Weblate
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I6f116c02e5691fd13ef6c4bd10e740ac1e72925d
2023-11-09 13:43:03 +01:00
Andras Timar
23574cd6b6 missing continue keyword
Caused log ERR on startup:
[ websrv_poll ] ERR  unknown UI default's component UITheme| wsd/FileServerUtil.cpp:99

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I82f036e393cfb271e2dec2c52c5dc512aed265c8
2023-11-09 13:36:45 +01:00
Andras Timar
78d4fe22b3 fix log date, tm.tm_mon is 0-11
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I93f7ac7a83c9724537b9b214cd8b54e5132c54e4
2023-11-09 13:20:07 +01:00
Andras Timar
ee48dc7451 src/docstate.js contains localizable UI strings
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I3a09891900ff0c22e9f133d9032a2625ef47e6a8
2023-11-09 13:19:44 +01:00
Gökay Şatır
c9616f8d54 Provide better tracking of focus in-out events for comment containers.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If27a60d73454ec69912b91b17128aa62b209cf6d
2023-11-09 15:10:33 +03:00
Miklos Vajna
a605e53716 notebookbar: add Insert Frame to the Insert tab
This allows the creation of floating tables when an entire table is
selected by the time we dispatch .uno:InsertFrame.

Also add a matching entry in the menubar.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ia0614d47275eb8d9127c496a0b06a8993c5f9989
2023-11-09 12:43:58 +01:00
Szymon Kłos
cafdf447fa Avoid TypeError in getCorePxDocBounds
It was reported on some iOS devices that we fail with TypeError
in getCorePxDocBounds - missing this.options.docBounds.

getCorePxDocBounds is used in Cursor class, check if we have
docBounds before use so we don't try to update without valid
data

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia48738edac33ab272e338e23f0d71f7ec4f54086
2023-11-09 13:42:10 +03:00
DPE
bbb05dcff4 Translated using Weblate (Norwegian Bokmål)
Currently translated at 63.3% (340 of 537 strings)

Translated using Weblate (Norwegian Bokmål)

Currently translated at 61.6% (331 of 537 strings)

Translated using Weblate (Norwegian Bokmål)

Currently translated at 100.0% (5 of 5 strings)

Translated using Weblate (Norwegian Bokmål)

Currently translated at 59.4% (319 of 537 strings)

Translated using Weblate (Norwegian Bokmål)

Currently translated at 100.0% (22 of 22 strings)

Co-authored-by: DPE <danpe_jobo@hotmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/nb_NO/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ios-app/nb_NO/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nb_NO/
Translation: Collabora Online/Android lib
Translation: Collabora Online/UI
Translation: Collabora Online/iOS app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iaabb7ffb88433e624d58dad43f3fbadd5aacd681
2023-11-09 10:56:54 +01:00
Ihor Hordiichuk
33e32d288d Translated using Weblate (Ukrainian)
Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/uk/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I86f136461963c0e242acc0befd0daa158390a812
2023-11-09 10:56:54 +01:00
Besnik Bleta
4ed5ad8f21 Translated using Weblate (Albanian)
Currently translated at 99.0% (109 of 110 strings)

Co-authored-by: Besnik Bleta <besnik@programeshqip.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/sq/
Translation: Collabora Online/Android app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If11e2026ad132aa9311b74b32605c470cad2c06e
2023-11-09 10:56:54 +01:00
Sebastiaan Veld
c25fa9ab7f Translated using Weblate (Dutch)
Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I55319ad8576563b0a695ec40c154294c03de784a
2023-11-09 10:56:54 +01:00
Martin Srebotnjak
4fe1f6bb56 Translated using Weblate (Slovenian)
Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8f3a15b9509f674ab4ee5a38b743d7806a12b606
2023-11-09 10:56:32 +01:00
m4skedbyte
7260c93c22 Translated using Weblate (German)
Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: m4skedbyte <weblate@m4skedbyte.xyz>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I870f9d717ddf6fdb49db4b8eed0fd14ee37e14da
2023-11-09 10:56:32 +01:00
Ettore Atalan
f0aad101be Translated using Weblate (German)
Currently translated at 100.0% (467 of 467 strings)

Translated using Weblate (German)

Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: Ettore Atalan <atalanttore@googlemail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/de/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I403a775bd520f801a20067ea3b7a6872562adadd
2023-11-09 10:56:32 +01:00
Qiao Yifeng
3f48891dd1 Translated using Weblate (Chinese (Simplified))
Currently translated at 67.8% (317 of 467 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 68.7% (369 of 537 strings)

Co-authored-by: Qiao Yifeng <qiaoyifeng@promc.cn>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/zh_Hans/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0fcc83324100e94a3676ccaa14755c9013866ecd
2023-11-09 10:56:32 +01:00
Ayhan Yalçınsoy
19f73c5d1d Translated using Weblate (Turkish)
Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: Ayhan Yalçınsoy <ayhanyalcinsoy@pisilinux.org>
Co-authored-by: PhD. Ayhan YALÇINSOY <ayhanyalcinsoy@pisilinux.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I08a9229f7bb55d8fddcc4dca4d5541dab4ae234f
2023-11-09 10:56:32 +01:00
bittin1ddc447d824349b2
56dd007741 Translated using Weblate (Swedish)
Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: bittin1ddc447d824349b2 <bittin@reimu.nl>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sv/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9a4c500dfe3a4dc7ca2ce8901127caa51698baa4
2023-11-09 10:56:32 +01:00
SC
c971e44a48 Translated using Weblate (Portuguese)
Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: SC <lalocas@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Idd62203324365bc656e3a2e85b062bb12b7813ac
2023-11-09 10:56:32 +01:00
Milo Ivir
fea63dba29 Translated using Weblate (Croatian)
Currently translated at 100.0% (537 of 537 strings)

Translated using Weblate (Croatian)

Currently translated at 99.8% (536 of 537 strings)

Co-authored-by: Milo Ivir <mail@milotype.de>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I72997ea8388b0047305b9b77ca73cf29b0333f27
2023-11-09 10:56:32 +01:00
Rob Pearson
90f7ebba89 Translated using Weblate (English (South Africa))
Currently translated at 100.0% (537 of 537 strings)

Translated using Weblate (English (New Zealand))

Currently translated at 100.0% (537 of 537 strings)

Translated using Weblate (English (United Kingdom))

Currently translated at 100.0% (537 of 537 strings)

Translated using Weblate (English (Australia))

Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: Rob Pearson <rob.dunedin@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_AU/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_GB/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_NZ/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_ZA/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia684a12a100ea15712373246cb66a7629d2de191
2023-11-09 10:56:31 +01:00
Stanislav Horáček
24035cfcf7 Translated using Weblate (Czech)
Currently translated at 100.0% (537 of 537 strings)

Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/cs/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0c3db6b7251224b112e858e14cee4519f319d2c6
2023-11-09 10:56:31 +01:00
Darshan-upadhyay1110
2aa28a324c Fix Format > Columns Menu Has Dark Icons
- Added missing data-theme = dark for #valueset-img
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: Ibddeaa28089ba21250753f121af4746e3947cf38
2023-11-09 07:41:49 +01:00
Darshan-upadhyay1110
924ff4213d do not allow check uncheck for disabled checkbox
- This will fix not to check or uncheck if a checkbox is disabled by clicking on a lable of a checkbox
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I3c6f770058ae1409f56d6bd12f5e7a8cd2441941
2023-11-09 12:07:49 +05:30
Darshan-upadhyay1110
ff3761aa57 Change border color of ContentControlSection when theme changes
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Idd080e20370648623a4d01cecde69914addeecfc
2023-11-09 11:19:54 +05:30
Darshan-upadhyay1110
10d1c946af Fix Content control "down arrow" cannot be recognized in dark mode
- add missing image path for data-them dark
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: If6850770548d35eb95125ce0be1c52a557f5b344
2023-11-09 11:19:54 +05:30
Hubert Figuière
00050a59c2 browser: Add ui_default to hide the toolbar
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I189224581451c9f5d534593696b060c8efb23414
2023-11-08 23:34:17 +00:00
Pranam Lashkari
7ab2938761 cypres: enable impress comment autosave tests
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I2197b1d485c612cbf1dd3ab712181d75c0f6ae98
2023-11-09 04:20:28 +05:30
Pranam Lashkari
d7e07b773f annotation: fixed impress disappearing comments on autosave
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I8feba6907b2899a19dcda3ecf56c673801e27487
2023-11-09 04:20:28 +05:30
Gökay Şatır
d2ec258837 Copying the hyperlink issue:
* Add a paragraph.
* Select the whole paragraph and add comment.
* Add hyperlink to a word in the paragraph.
* Try to copy the hyperlink via its menu.
* It sometimes doesn't copy the hyperlink.

We are checking if a comment has focus or not before doing the copy operation. This check is for another issue.
I changed the check with "app.view.commentHasFocus" which seems reliable.
Then tested the previous fix.

Also commented out code is removed.
White space change is automatic.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ibc2c5e550eb8a3e24b734e0371c87dac44b2ff6d
2023-11-08 23:06:58 +01:00
Skyler Grey
7175c7841b Add a ui_defaults option for onscreen keyboards
The new ui_defaults option OnscreenKeyboardHint is a tristate denoting
whether the device accessing Collabora Online has an onscreen keyboard

If unset, Collabora Online will do its best to guess. At time of
writing, this is the same as checking if the device is a mobile phone
or a tablet (note: only tablets which have the browser registered as a
"mobile" browser will be detected, e.g. the Microsoft Surface tablets
would not be detected)

If "true", Collabora will assume the device has an onscreen keyboard.
This will change when we trigger the keyboard, for example in calc if we
know of an onscreen keyboard we will not automatically focus a cell for
editing when it is selected, as this would pop up the keyboard.

If "false", Collabora will assume the device does not have an onscreen
keyboard, effectively doing the inverse of the "true" option above.

This is a followup to #7580 (0bf054c9a3)
which had Hint_OnscreenKeyboard and Hint_NoOnscreenKeyboard as
postmessage IDs to do the same thing.

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I5deeb87a410c135d4cabda7ed24dc37e791800cd
2023-11-08 16:20:49 +00:00
Caolán McNamara
41d78e5fd2 fix; error TS2304: Cannot find name 'TilesSection'
doesn't happen in ci, but is happening in tinderbox and for some
users.

Seeing as ScrollSection doesn't have the problem, follow the export
and namespace pattern used there.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4c4916ba7a3ad19275bd8b0f5bc53111b3b30cd5
2023-11-08 15:32:59 +00:00
Hubert Figuière
1114af585a default-ui: Allow skipping the UI state saved in local storage.
Pass SavedUIState=false to the ui_defaults

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I2cceffed338440d1fee5b0818e072ecc02379468
2023-11-08 10:12:42 -05:00