Fix silly mistake in my previous commit. Had put code in #if 0 that
should be in #ifdef IOS.
Change-Id: I72f4dc3867bd070a01a4ba5625baba0eea3c2d73
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Normally (ideally), tiles (.bmp files) are removed as soon as the JS
has displayed them. But occasionally something goes wrong and they are
left behind. (For instance, it seems to happen if the user closes the
document immediately when it shows up.)
Do not leave them on disk until the app starts the next time.
Change-Id: I0c764280a69a16ad3b7b67c329832fd5331c2e1e
Signed-off-by: Tor Lillqvist <tml@collabora.com>
The worker threads can be running and have not yet responded
to the last _cond.wait() by the time we start compressing again
- at least under valgrind:
loolforkit-nocaps: ./common/RenderTiles.hpp:304: void ThreadPool::run(): Assertion `_working == 0' failed.
==240379== Process terminating with default action of signal 6 (SIGABRT): dumping core
==240379== at 0x5505322: raise (raise.c:50)
==240379== by 0x54EE863: abort (abort.c:79)
==240379== by 0x54EE748: __assert_fail_base.cold (assert.c:92)
==240379== by 0x54FD9D5: __assert_fail (assert.c:101)
==240379== by 0x5886BB: ThreadPool::run() (RenderTiles.hpp:304)
==240379== by 0x56DC02: RenderTiles::doRender(std::shared_ptr<lok::Document>, TileCombined&, PngCache&, ThreadPool&, bool, std::function<void (unsigned char*, int, int, unsigned long, unsigned long, int, int, LibreOfficeKitTileMode)> const&, std::function<void (char const*, unsigned long)> const&) (RenderTiles.hpp:711)
==240379== by 0x5A0104: Document::renderTiles(TileCombined&, bool) (Kit.cpp:762)
==240379== by 0x59CF1A: Document::renderCombinedTiles(StringVector const&) (Kit.cpp:719)
==240379== by 0x59AEC8: Document::drainQueue(std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (Kit.cpp:1570)
That means our queue starts processing work as we do the unlocked
queue push - causing some potential badness.
Change-Id: Ib0578dac009376c0676da73a8c1d8960304dc072
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Why pass a dozen empty arguments each time: someone bitten
again by the default vector constructor.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I31bc6f23f0b5d7352b85d3df4b7b5298199044a1
Since all of the menu items under "Insert" are disabled for
the readonly mode we can safely remove it.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic84dedd8d76a3db69a0bff7932052f944e42b959
Extend Status bar information to display in which mode the user is
currently in.
Context:
When using Collabora Online to preview documents (readonly mode)
the user might not noticed at the first glance what is different
and why he cannot edit
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id148fc73ad4f46673170c2372d4ba16a390bbd4f
also make sure (since there are less menu items)
that we use a bit more space for that (width)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7642e5fd6ee68d9738f8c2ede4854758a437df25
Removal of top pixels between that are no longer needed
due to the latest changes on neighboring elements.
Plus Make sure that even on readonly mode we do have a
bezel delimiting the bar and the document container
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I799fc099697e0b238cd55e53b91471cbd59da742
Make sure we only check the ruler state when in
edit mode.
Context:
Show ruler (menu action) has been always disabled when on readonly mode
but we seem to do checks on the ruler state and ultimately
show it even on readonly mode.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7987e1c54bed4117f221aac37b7fbd184ce954e2
Currently translated at 100.0% (393 of 393 strings)
Translated using Weblate (Turkish)
Currently translated at 99.4% (391 of 393 strings)
Co-authored-by: Oğuz Ersen <oguzersen@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I03c3cad2c28407a763965c3ed46fd65d2e49e196
Currently translated at 100.0% (22 of 22 strings)
Translated using Weblate (Russian)
Currently translated at 99.7% (392 of 393 strings)
Translated using Weblate (Russian)
Currently translated at 95.4% (21 of 22 strings)
Translated using Weblate (Russian)
Currently translated at 99.2% (390 of 393 strings)
Co-authored-by: Artem <Localizer_in_Russian@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/ru/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ru/
Translation: Collabora Online/Android lib
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id6151817f1bbc480839e544fae781ba7cd4f61b7
Currently translated at 99.4% (391 of 393 strings)
Translated using Weblate (Turkish)
Currently translated at 98.7% (388 of 393 strings)
Co-authored-by: Mehmet Sait Gülmez <cenggulmez.65@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I34bf314644f812894a4dd75ae8345e31946ed2ba
_firstLine must be assigned before _data is
changed, as it is used to check _data's
first line hasn't changed
Signed-off-by: NickWingate <nicholas.wingate03@gmail.com>
Change-Id: I79dfd0a64d53fc8503709015bbe7ab6875a58204
And make return const to prevent _firstLine being
mutable.
Signed-off-by: NickWingate <nicholas.wingate03@gmail.com>
Change-Id: I1a6e391cd128704b67ec5cc99a4ed4d105f64e29
_firstLine is no assigned when firstLine() is called
and _firstLine is empty.
Signed-off-by: NickWingate <nicholas.wingate03@gmail.com>
Change-Id: Ie6d86abd1f9db7a4f05e95e41f6b791f5923729f
There is one EndSession record for each session that edited the same
document. That is not an error.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I9042411ad465fe07a8f88a29923f0dc051c755aa
Signed-off-by: Tor Lillqvist <tml@collabora.com>
"default installs currently don't use proof keys"
Change-Id: I43b6c5ed6633b35e58ec3e1b1cc222756a9a47d8
Signed-off-by: Henry Castro <hcastro@collabora.com>
Use the lc variant everywhere instead of having a mix of
icon types for the same component
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icc0bc0e9cc5e1e7d53444a9b7e33f8e02bc784fe
I otherwise get values like this:
epochFile=18682409
deltaCurrent=34
rec.getTimestampNs()=18682409
deltaFile=0
delay=4294967262
Leading to the idiotic:
Sleeping for 4294967 ms
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I06530c31bc70bb7dcf3cd34c4684aa9f1f8036cb
Remove the app's copy of the document after core has saved it and we
have stored the edited version at its real location.
Remove possible leftover tile bitmaps when the app starts.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ibc41be38c2cfb689c532640d148116bc06a248ab
