Document has to be final: its constructor calls sendTextFrame(), which
calls the virtual sendFrame(). So the only situation where this code
works correctly is when Document is never subclassed.
Change-Id: I7c13abdae57d9e1ba3416ec1963b58bce0d42e6f
instead of just having a label displaying the current language.
Change-Id: Ib3068e6001fc86cc129f7817300de4e8a991c8c6
Reviewed-on: https://gerrit.libreoffice.org/73086
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Also add some space between the ruler and the document frame
Change-Id: I75a3e4668d03cf44b235082cd7d8c24672209262
Reviewed-on: https://gerrit.libreoffice.org/72339
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
The entries in the native edit menus appeared underlined for me
because I had turned on “Button Shapes” in Settings > General >
Accessibility. They are not supposed to be underlined normally.
Change-Id: I9b85774f3c8300e014092f6ea08953a404156899
Not icons, but white text on black background, etc. This is how the
native context toolbar (whatever it actually is called in iOS) looks
in Notes and Pages and in text input fields in general.
Change-Id: Ibfa149fa8a951046de25c71022ea5c5684cfcc02
For some operations like printing to PDF, we need to have access to the
LOK API to perform eg. saveAs(). iOS is using an extern for that, but
given that it is needed for Android too, let's introduce a proper getter
for that.
Change-Id: Ie2340a4ee0bdf9dc46e799e2567a828172d9a67d
For a touchend event, the touches property will be a zero-length
array. At least in WebKit on iOS or Safari. Work around that. The
proper fix would probably be to not even call the getMousePosition()
function for touchend events?
Change-Id: I1c4cdb26b293e551c3c6f51208f73ee5a8044ecb
Fail-fast when a file cannot be converted, using convertTo REST API, if the file is password protected and the password wasn't received.
Change-Id: I32d807bcecbbe72a38a70fec74caf13638803e1d
Reviewed-on: https://gerrit.libreoffice.org/72891
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
This helps avoiding the situation when the state in the Online and in
the integration get out of sync.
The integration should always get the most current state via Views_List,
and if they want to implement eg. notification what view has joined or
has left, they should just compare the old and the new state.
Change-Id: I841f77419bf86a57f77e16f8c0bd08063f31f68a
Reviewed-on: https://gerrit.libreoffice.org/73103
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
This is needed to compile the tests without undefined references when
using sanitizers. Previously it was possible to run loolwsd, but
building the tests failed.
Change-Id: I6babd1c43816cb2387c82316cc1bf9ff14d7a068
No reason to show the warn-copy-paste message in a mobile app. The
native code of the app has access to the system clipboard just fine.
This does not at such make the Edit>Copy etc menu entries work in the
iOS app (the LibreOffice core code does not yet have system clipboard
functionality for iOS, I am working on that), but this is one
necessary step.
This is a bit complicated, I don't like how the 'mobileappuno'
properties have to be "manually" propagated from one data structure to
another in the _createMenu function, but OTOH it's the same for the
'id' properties.
Change-Id: I0ebe964e6eb6e4a902118714c1779451004c751f
Reviewed-on: https://gerrit.libreoffice.org/72888
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
The user should be able to access these even in the initial View mode on
Android.
Change-Id: Id0631b7560c1ed0fda5f228f0c621cfa989b4cf7
Reviewed-on: https://gerrit.libreoffice.org/73038
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Checks if messages are coming from the parent only (the frame which
opened the editor) to avoid unwanted commands from 3rd parties.
Change-Id: Ieffe36169dcefbe130869596672c1628c76b6799
Reviewed-on: https://gerrit.libreoffice.org/72340
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
The change causes problems for people on various sad distros. Oh well,
whatever.
This reverts commit bd00d9fd05.
This reverts commit 054a9cdb04.
Change-Id: Ie439e4c655d02b6f34bdd1a9c1c5b6db6048b653
Uses the newly added parameter to insert it directly, instead of using
the mouse to define the bounds first.
Change-Id: I3c10f379151b6789908585af02a8a18f3103e001
Don't include the net/Ssl.cpp in the same WsdSources.cpp as the
others, as our CRYPTO_dynlock_value definition is different from
Poco's.
Change-Id: I0fffcec09bcda387e8d7c3ba973a1681b11309fd
It is is complicated enough to build the iOS app. Requiring GNU
libtool brings with it the risk of polluting the command environment
as there already is a completely different command in macOS with the
same name, /usr/bin/libtool. And as GNU libtool was used only to build
the unit tests for the "normal" server-based Online that are built and
run only on Linux anyway, we don't really need any of the
"portability" that GNU libtool brings.
Without GNU libtool, we compile all the $(wsd_sources) (see
test/Makefile.am) that the unit-* tests use into a single object file,
WsdSources.o. (Because they need to be compiled as PIC we can't use
the already compiled object files for the Online server programs.)
This required some additional minor changes to a few source files.
Change-Id: I20a2c523170376fa4c1a0d9d8d6b693a9779376f
Reviewed-on: https://gerrit.libreoffice.org/72840
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
if the file name has '%' character it throws
exception "Bad URI syntax", so use the encoded
file name string
Change-Id: I6a8d841761b46ac49a6c79956ba215e1affa53e5
Reviewed-on: https://gerrit.libreoffice.org/72385
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit b934c70f4f1f9f3ee4f873570633a3b1ec931652)
Reviewed-on: https://gerrit.libreoffice.org/72890
