Commit graph

24086 commits

Author SHA1 Message Date
Bayram Çiçek
56ae33dd34 make instance.isAutofilter false for autoFillPopup
- create instance.isAutoFillPopup
- change closeAutoFilterDialogsOnTabChange() to closePopupsOnTabChange()

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I32c5d26f8567a156ff0e94bc6ff1ff5bdf7be8b3
2024-05-28 14:07:09 +02:00
Bayram Çiçek
03bee87129 remove undo call and refactoring
- undo uno calls are removed: no need
- unified the popup operations with _handleKeyDownForPopup()
- make popup entries translatable
- add explanation for AutoFill

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I69935150597c90851c3d731b42b1adf072ae29cd
2024-05-28 14:07:09 +02:00
Bayram Çiçek
b7da4e5a9d close AutoFill popup on contextmenu operations
- remove unnecessary "this._map.fire('closeautofillpopup')" calls
- refactoring
- close AutoFill popup on some contextmenu entries from sheet tabs
  - insert sheet before/after
  - delete / hide / show sheet

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: Ie5d28addd00985f7b0335a66457da2451250e057
(cherry picked from commit 63827dcd32acef312ad82697a1329aa02350b629)
2024-05-28 14:07:09 +02:00
Bayram Çiçek
b8c55589b4 add Esc and ArrowDown key support
- Esc key to close AutoFillPopup
- ArrowDown to focus elements inside AutoFillPopup
- ArrowDown/Up to cycle inside the popup

- also remove "this._map.fire('closeautofillpopup')" from
"Ctrl + Alt + PageUp/Down" since we don't need to close
AutoFill popup anymore here as we close the popup immediately
after pressing "Ctrl" key

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: Iac4bbd1104f3140bd47842daaae2eb3bfa87daef
(cherry picked from commit 6ab88d7bf32e6fcb64d891fe0458c21f12b7da87)
2024-05-28 14:07:09 +02:00
Bayram Çiçek
0d87c761fc make AutoFill work with .uno:AutoFill
requires: https://gerrit.libreoffice.org/c/core/+/167726
5ab9b63e6624947a6076a01f9bab0d7a925e0e40

Copy cells
- this.map.sendUnoCommand('.uno:AutoFill?Copy:bool=true');

Fill series
- this.map.sendUnoCommand('.uno:AutoFill?Copy:bool=false');

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I40551e4323997c8de6997483b0cff239cb8d2ec4
(cherry picked from commit fad20b12a666e9358d2f2de012431a60c7af8204)
2024-05-28 14:07:09 +02:00
Bayram Çiçek
378c27b998 add functionality for AutoFill Options
Added functionalities for "Copy cells" and "Fill series".

- Copy cells
this.map.sendUnoCommand('.uno:FillSeries?FillStep:string=0')

- Fill series
this.map.sendUnoCommand('.uno:FillSeries?FillStep:string=1')

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I77a3512627e35f2a176b147d3f54f08c7f5f7b08
(cherry picked from commit 77c1764fb399f48f18482ceec2d91c561af8d334)
2024-05-28 14:07:09 +02:00
Bayram Çiçek
2e4caadd05 close AutoFill popup on tab change
close AutoFill popup when
- sheet tab is clicked
- new sheet is inserted
- sheet tab is switched using Ctrl+Alt+PageUp/PageDown
keyboard shortcuts

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I03711d202b47813d101bd066db1a3e8e106430e3
(cherry picked from commit 852906337810fc12d55be4e30c8c3467c407efed)
2024-05-28 14:07:09 +02:00
Bayram Çiçek
5b7f27f1e4 add auto fill popup UI
AutoFill popup has two options:
- Copy cells
- Fill series

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I08ad88afad1bb6bd2d746a9a8964f1b4446ae7c7
(cherry picked from commit 91f080976f4c1d643db1b217b605f59742f13bd0)
2024-05-28 14:07:09 +02:00
Miklos Vajna
454bcc42e5 common: avoid adding too large ints in the Rectangle ctor
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I17b5793c6a0d8a285f41af3846e7aacfc84f3c8c
2024-05-28 13:41:14 +02:00
Darshan-upadhyay1110
74f0979880 Add cypress test to verify input element state after update message
- this test will check input element getting set to it's right state after update on jsDialog
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ib22dd0c5d6c6ab95650617480c137b306b8a6e80
2024-05-28 13:28:18 +02:00
Darshan-upadhyay1110
3591fba03e Fix state update of input element
- Input elements in jsDialog does not change state after CORE update message
- this is because in previous commits we changed input element structure.
- we should Synchronize the child elements with parent.
- this patch will Synchronize disable state of parent with it's child elements

Change-Id: Ice94de732dc7392f3c79100e6a2d60480294eb0e
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-28 13:28:18 +02:00
Darshan-upadhyay1110
bb15a1d05a Close mobile icon should be hidden in desktop
- if we switch to compact mode & server get reconnected some icons are visible in desktop which should be only visible in mobile view.
- in control.toolbar.js we call updateItem method for icon in mobile
    - `toolbar.updateItem({id: 'closemobile', type: 'customtoolitem', w2icon: 'editmode'});`
- after this updateItem call we should also check all condition about that item like
        - item should be visible in mobile or not
        - item should be available in tablet or not etc etc
- this patch will do that checks
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: I11adc3d94cacd4afe85e177d050ccc73f3112872
2024-05-28 13:19:49 +02:00
Szymon Kłos
f8a64d5407 cypress: quick fix for rounding error
unblock CI from:
cy:command ✘  assert	expected **<tspan.TextPosition>** to have attribute **y** with the value **'3286'**, but the value was **'3285'**

error

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0ccb209c12e15a829f99f8323bf7b1ee8ca39aa0
2024-05-28 12:17:42 +02:00
Pedro Pinto Silva
449b35b64c Color pickers: Fix image size and alignment
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib4391a2dce205928309c94b86ad7c8e759eaffa1
2024-05-27 15:01:10 +01:00
Pedro Pinto Silva
429070a224 Notebookbar: Home: Remove unnecessary CSS and fix fontnamecombobox
- Remove all the rules that are not longer active (better solutions
were implemented)
- Remove also #fontnamecombobox.notebookbar declaration. Not only top
and padding were not applicable but we were setting the width which in
turn was creating a different gap (bigger than the grid gap) and
moving icons out of place

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibf608f41d25beb3120b5b6d9f032673697f018b8
2024-05-27 15:01:10 +01:00
Pedro Pinto Silva
da051e2178 CharBackColor: Remove legacy CSS rule, no need for extra margin
- This has no effect anymore since the id has changed
- Furthermore, the fix is not needed anymore since meanwhile impress
and draw has seen new button additions (shadow, fontwork) that renders
this obsolete.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id1990e9c6e227cf2f2567b18e7826fee81865a69
2024-05-27 15:01:10 +01:00
Szymon Kłos
0dd2c55adc jsdialog: add queue for snackbars
Snackbars will appear one after other now.
Add forgotten SnackbarController to Makefile.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf5ed98f8384c2688adc9653948137f23fb0ce3e
2024-05-27 13:45:08 +02:00
Poe Mon
97ec41c0f2 Translated using Weblate (Japanese)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Poe Mon <p.poemon.awitd@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ja/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I558b81c08e65f2a58eaf8d8581813f3c237fc81a
2024-05-27 10:04:39 +02:00
Sabri Ünal
e2b238aba9 Translated using Weblate (Turkish)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Sabri Ünal <yakushabb@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id4337eac79282f315de7ced849ae686d906a5778
2024-05-27 10:04:39 +02:00
Yaron Shahrabani
7962411b5f Translated using Weblate (Hebrew)
Currently translated at 70.2% (336 of 478 strings)

Translated using Weblate (Hebrew)

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/he/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Icc48a9c6f488090a1a03e3704053ff26a41f3cd4
2024-05-27 10:04:39 +02:00
bittin1ddc447d824349b2
f322995c59 Translated using Weblate (Swedish)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: bittin1ddc447d824349b2 <bittin@reimu.nl>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sv/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5a6fa8532f559069b07e7fb4cb4802e21c9220c4
2024-05-27 10:04:39 +02:00
Ali
fe1de9cbf7 Translated using Weblate (Arabic)
Currently translated at 100.0% (478 of 478 strings)

Translated using Weblate (Arabic)

Currently translated at 100.0% (110 of 110 strings)

Co-authored-by: Ali <alimahwer@yahoo.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ar/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ar/
Translation: Collabora Online/Android app
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7a63416359b15bd99dde457b06a1912e6d434b75
2024-05-27 10:04:39 +02:00
Caolán McNamara
f8a79af294 cid#318827 COPY_INSTEAD_OF_MOVE
and

cid#318828 COPY_INSTEAD_OF_MOVE
cid#318832 COPY_INSTEAD_OF_MOVE
cid#318861 COPY_INSTEAD_OF_MOVE
cid#318888 COPY_INSTEAD_OF_MOVE
cid#318889 COPY_INSTEAD_OF_MOVE
cid#318898 COPY_INSTEAD_OF_MOVE

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I1022fcb7437ebf7ef4c9d6f49e1c6b9a73ea6837
2024-05-27 08:36:18 +02:00
Caolán McNamara
6638f4a059 cid#368709 Improper use of negative value
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ic13d6cb836deb9612990ab40e0b5ad6b27b5d7a8
2024-05-27 08:36:18 +02:00
Caolán McNamara
c2aaf2edd1 cid#368707 Unchecked return value from library
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ifb47d264a91a55d8bd565b1251a95973ddb8f5ec
2024-05-27 08:36:18 +02:00
Michael Meeks
a6678b554a Cleanup and shorten tilecombine descriptor lists.
If we have all default values of imgSize, wid, old-wid then we
should simply not serialize these out to save space and improve
readability.

Unfortunately, this means that we need to catch the mutation of
the TileCombined's content in two places; now just one. Building
the queue of rendered tiles to send back is now moved and
wrapped into a TileCombinedBuilder class - this also lets us
stop serialize taking a random vectors of TileDescs. However
the DocumentBroker::handleTileCombinedRequest method needs to
set the force-keyframe oldWid=0 flag on individual tiles and
then update the TileCombined.

Ideally we would have a nice visitor API and drop the non-const
getTiles() method that returns a reference to our internal vector.

Update tests, to not have redundant attributes, and add more tests
to ensure redundant attributes are removed.

Change-Id: Id76d3ae14d459d73bbae8112d840dea27f66588b
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-05-26 19:28:30 +01:00
Andras Timar
90a72c6baa Update Helm Chart with new release 24.04.3.1
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5cd3cf80874a99dd84f62ae6877ee202d8a43163
2024-05-26 15:48:01 +02:00
Darshan-upadhyay1110
5c7ee9e0c3 Replace ruler height hard coded value with css-variable
- Replacing the height value with the CSS variable will help maintain better consistency.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0627778919885c8ee0a989f0b47b976304892585
2024-05-24 21:10:52 +05:30
Szymon Kłos
34850e7bbd jsdialog: create separate controller for snackbar
Reduce size of UIManager and also it will make it possible
to add queue of snackbars to show.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I221049f48f471d85795ede7922a668eef4c7f0df
2024-05-24 16:20:39 +02:00
Szymon Kłos
500997fdd9 jsdialog: move types into single file
To deduplicate definitions

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3c542e192f31ece69cff08cae5dd61e32b478420
2024-05-24 16:20:39 +02:00
Aron Budea
8846578d38 Move hello-world.odg to hello.odg
So it behaves similar to other hello/hello-world documents.

Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I529b5bec81c1bf5085300f8c52311db023c6b09a
2024-05-24 14:26:09 +02:00
Darshan-upadhyay1110
0a9968a074 Handle case for items only available in dark mode
- we have now some uno item present only in dark mode.
- so there is no resone to check image exist or not for light mode.
- we will set dummy url for those image elements.
- this patch will consider those items and will not throw error if icons are not present light mode
- Example: please see `invertbackground` item in view tab after change to dark mode
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: I6aa2fc9d7bdd356617a808f17d14f77bc8453496
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 11:48:27 +01:00
Darshan-upadhyay1110
8396afa1af Statusbar: Set image to false for zoom menubutton
- `zoom` menubutton is not a image to represent so we will make `image: false`
- this pathc will fix image not found error for `lc_zoom.svg`
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I39c2d68f4b0afc7b3831c2082be2ae1a315b2d8e
2024-05-24 11:48:27 +01:00
Darshan-upadhyay1110
6dfeffd53a Add missing dark mode icons for 24.04
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ibf42fc04f953769790e9bc4145d8fe4f6e994298
2024-05-24 11:48:27 +01:00
Pedro Pinto Silva
9c766bb9ee Comment: Add missing icon alias and remove unnecessary duplicates
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie1ea6e5be762ee5d1650cf8ccb0a408ce6340c08
2024-05-24 11:48:27 +01:00
Rashesh Padia
b9ef48310e mobile: add save progress bar on top toolbar
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: I14c8a715e922d00b2cfd8f67afd7fc2df2dd9d38
2024-05-24 09:16:39 +01:00
Pedro Pinto Silva
7fad9a6a44 Formula Wizard: list view: use smaller icons
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I84076a6a3b85fe3d61e849946bd8f9f8e7638985
2024-05-24 08:44:41 +01:00
Pedro Pinto Silva
1340fdcdcb Formula Wizard: Fix search input field width
Before this commit the search field wouldn't fill the available space.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If079942b1e594a0461835e52ad65827a639c6173
2024-05-24 08:44:41 +01:00
Pedro Pinto Silva
701422de3e Formula Wizard: Tabs: Make tree view transparent
Make those transparent since color would just look odd within tab
background and more importantly because they offer no interactivity.

----

Currently the treeview accepts clicks (not just the expanding and
collapsing) but also children accept clicks but do nothing. Probably
we should fix this.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ifc53d0099a19103b15895dc8b76127034b05f3c1
2024-05-24 08:44:41 +01:00
Pedro Pinto Silva
dba0e711b5 Formula Wizard: Tabs content should extend all the available space
- Use all the available space on both tabs' content
- Fix Structure tab's content
  - make the tree view extent the available space (1fr)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib1c9e852a3a292f795675365040318c1d5602f35
2024-05-24 08:44:41 +01:00
Pedro Pinto Silva
567f6def33 Formula Wizard: Tabs: make it clear that this is tab group
Before this commit the tabs in this dialog were being rendered as top
level dialog navigational tabs. However, this is not the case. Add
background and border to clear separate one and the other.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I158ee1e1d4d163417f5055459adfeac47b6ab437
2024-05-24 08:44:41 +01:00
Darshan-upadhyay1110
b9bef83487 Change vertical ruler code to typscript
- remove use of Leaflet's
- change working js code to ts
- please check above commit messages for understanding of implementation.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Iee222bbdb343730014260c1785a90e68c6dedfd1
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
c25e8d78cc Reset Top/Bottom values of page margin if view section changes
- we are string previous response values of top/bottom margin
- resone is because we need that values to pass after dragEnd.
- but if we change section foucs from Header to Footer or Text area to Shape then we need to reset that old values with the incoming response
- this patch will do that.
- for `table` we will hide the marker as we do not need that. table already have there marker to resize.

- added some edge cases like if start marker goes beyond end marker
- start and end marker should not cross limit beyond page top/bottom

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: Iffd3cbf08806666b858d9c3da7ca6362085223dd
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
c3c7caaf0b Set upper and lower margin after drag in vertical ruler
- Send Upeer and Lower space value for header and footer according to drag
- we need to send both values in core.
- even if we drag either upper or lower we will send values accordingly but both values should be updated

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I4ef3287c5afe6e1eef5aac225d3c06ca9d1fd9e5
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
4a13987fdd Add markers to vertical ruler.
- As we do for horizontal ruler we need marker that will change margin of Header and Footer of the document
- current patch will have design where user can see markers in vertical ruler
- you can drag and change potition of marker.

Improvments that still need to do:
- user can drag but it will not change size/margin of header/Footer
- next we will pass info to CORE according to corrdinates we got from drag
- it will update text potition on document

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: I9663a75d5c84eace784266c76be12abd762434bb
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
d41d73382d Add pageoffset calculation for vertical ruler
- Before this commit vertical ruler stays only in first page
- if we jum to page 2,3 so and so ruler won't change it's possition
- but i have added some calculation based data we recevice from CORE
- calculation:
    - we need to consider pageoffset for vertical ruler
    - check if cursor moves to other page
    - then add total Height of previous pages.
    - for Ex: if we are at page 3 then ruler.marginInlineStart should additionally have total height ( page1Height + page2Height)
    - this will place ruler to exact possition where we want
- next : add Top and Bottom margin drag
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: Ie2a2d4e5f0cfd627bcafd81230ad33b7aec280a2
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
d3d7f48225 Add vertical ruler for writer
- add new LOK callback for vertical & horizontal ruler update

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I3c0e26f22072de4612e128d58ac41b629be82807

Add vertical ruler and implement margin calculation

- Added new vertical ruler file to separate it from horizontal ruler calculation
- For vertical ruler we do not need tab stops so removed it.
- next stpe will be to implement add top and bottom margin by drag

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I8186c874ff59571db7a75ec4c31f81fc655ef301
2024-05-24 08:56:03 +02:00
Michael Meeks
69c6739e47 cool#9145 - KitQueue: re-work _tileQueue to use TileDesc.
This stops a huge amount of parsing, re-parsing and conversion
from strings and back, making our few N^2 loops over the tiles
much more efficient.

Retain queue tests with the same strings via using a helper
to convert back to something expected.

Replace TileDesc::getId() with isPreview().

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: If40fc45f1fb474d37371e4b949da5fdfc594fdc8
2024-05-23 19:50:09 +01:00
Michael Meeks
9eae552049 Split tile requests from the main incoming message stream.
Leave them as strings for now; this should be a pure re-factor.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibad2bc343afe3fe32ea729623f6b03575c7b0121
2024-05-23 19:50:09 +01:00
Michael Meeks
bdc2041797 Remove un-necessary distinction between pop and get.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I2870a646f1e16cc138978dd84251bec1939aba13
2024-05-23 19:50:09 +01:00