Conflicts:
cypress_test/integration_tests/common/helper.js
loleaflet/src/layer/tile/CanvasSectionContainer.ts
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I9aeb06f1b137ec15061dfa18c40e54a2324703d8
(cherry picked from commit cea7112d29775c4c7c42876a4c3638aad524fe24)
Issue fixed
===========
* In a spreadsheet with at least two sheets, on the first sheet, select A1,
* Switch to the second sheet, and select a cell way down, eg. A100, Switch back to the first sheet.
=> The view on the first sheet jumps, and will show a range of cells much lower than the originally shown A1.
Fix description
===============
We already have logic in place to switch view area based on the cell
cursor position. But in L.CanvasTileLayer._updateOnChangePart() it sets
the view area to hardcoded (0, 0) using 'updatescrolloffset',
map.scrollTop(0) and map.scrollLeft(0) which does not update the UI
(which is a different problem). So when the cursor message for A1
arrives, the view shift logic does not do anything because the view area
is already covering A1 even though the UI area is not. Removing this
arbitrary "scroll to (0, 0)" code enables the "view shift based on cell
cursor" logic work correctly.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I42e89691338403e60a82b5a535eff50c1c18ea12
(cherry picked from commit 9bc49385ddac7f1dc28b27c4e77539c2e14f4341)
This makes up most of the trace, and we have to simulate it anyway.
Change-Id: I3820e1d2281e696c119edb9ce989fda5ca4170e6
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
From co-2021, we have information about page-area coordinates for writer
from core. Use them to conditionally allow preservation of document
position where the mouse is.
* Preserve the y coordinate (unconditionally).
* Preserve x coordinate if the current view does not have margins. This
is neccesary to avoid a jump at the end as writer will eventually
re-adjust the page to the view's center after setting map zoom.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I9540d176198f1853de4051c5c3d7a964806f7c1b
example: when chart editing mode is active and in sidebar
Title of a chart is typed. Before this patch focus was lost
after typing was started.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I26fd1bc5be2798edc671aed9a546e5bbeb17108e
when user enters edit mode with cursor visible inside table
we cannot drag the table
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iff44d6b67015638f7e65bc18cdc53e5ff666d023
Code from old implementation was forgotten to update.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I4d5090ebf6ac5fa0e9746e542c47c0e682160ba5
Use sheetGeometry to transform the view coordinates for the chosen
zoom-level for the frame. However this is not done for the indivdual
tiles. As a result there could be small alignment descrepancies between
tiles and other stuff we draw using sheetGeometry such as grids and
overlays.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: If839997dda012f48e2c524643b5fd860e075320d
...missing to reduce error due to page-margins.
The error in score calculation can be made accurate if we use page
margins data into account. This is currently unavailable for
impress/draw apps.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I1a324766dddbd93b4a4f60089a81638357d242e8
Move the zoom frame painting to tile-section.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I12590809fe80b32d3630b7fdbaeeb9d8f703f041
Be sure to only do that when on mobile
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0a4f803ce50ceb950b4d9f0bbc38f5629218393b
Our permissions change callback modifies the UI so
first we have to create the UI when reconnecting.
This fixes the bug when on pdf renaming notebookbar appeared
above menubar.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I37e462e240fe7dc7eba349c9f9fbcf01679b8fe9
When on mobile we hide keyboard it was visible that
content "under the keyboard" wasn't refreshed.
So be sure we draw everything after we detected resized view
and we did all the view position setup keeping cursor on the screen.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If9dc449415b14f5d71035bae190a16d85b3118c1
