Commit graph

17642 commits

Author SHA1 Message Date
andreas kainz
587317ac96 Sidebar Chart layout
if Sidebar last-child is first-child flex-end was not the rule

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I9e7a744cf9b4d703bec33e39a30f4ab31d2160f9
2022-03-06 01:12:00 +01:00
andreas kainz
37c73d0c44 Sidebar Shadow Section fix width
define the width of the shadow sidebar section
to make the widgets right aligned.

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ifd371e15f78fb62434a71367943d554c8a10a92c
2022-03-06 01:12:00 +01:00
andreas kainz
d2dbca7ec1 Sidebar Calc Number Format align widgets reduce hardcoded stuff
Align widgets to the right
add some left positioning for some widgets
and done

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I64936c644ed1bcba47c0a12f9a2df45b56abce6e
2022-03-06 01:12:00 +01:00
andreas kainz
1f9a1cb59b Sidebar Table Paragraph vertical align commands one row
with additional 2px .sidebar.jsdialog.cell width
the vertical alignment cell and paragraph commands
can stay within one row and no new table-row is needed

result no jumping UI

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ibd543d0c35778485ff07b013af52e2c6aa401457
2022-03-06 01:12:00 +01:00
andreas kainz
33b38a3b2a Sidebar Table css Fixes
Sidebar Writer Table
- first column width was defined to fix vertical alignment
- Row height / Column width widget was moved to be vertical aligned
  with indent paragraph widgets
- buttons moved up to have a similar layout than in paragraph
  spacing / indent

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I6f41b25c79650781087821473d15edac253a47ab
2022-03-06 01:12:00 +01:00
andreas kainz
c0f09ea369 Sidebar css Fixes
Paragraph Section
- add justify-content: space-between;
- remove hardcoded position: relative
- remote hardcoded margin-top

perfect horizontal and vertical alignment
for spacing and indent

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: If6182bf5a4d46f9936dc260707e9ae12988fc8da
2022-03-06 01:12:00 +01:00
andreas kainz
0e5f7b531d Contextmenu add Dialog commands
the following commands will popup an dialog:
- CompressGraphic
- GraphicDialog
- InsertCaptionDialog
- FontDialog
- FontDialogForParagraph
- TableDialog

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I824e883f2ea8979edf7a752e267acf76c0e29d4b
2022-03-04 16:57:36 +01:00
Andras Timar
fd7726b6eb fix -Werror=unused-parameter
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I38ec47a4011c27674a527f69242ebf0c333db503
2022-03-04 13:07:37 +01:00
Szymon Kłos
c49d0d594f autofilter: dont scale header width
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9abe2f4711b3369e04c4dca3092ede6667cd9f16
2022-03-04 12:29:55 +01:00
Szymon Kłos
682683a14a autofilter: fix RTL spreadsheet case (lating lang)
in this case we have headers on the right so no need
to offset horizontally from left

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8beeef2e1e67804c90277046ef19a453318d2d92
2022-03-04 12:29:55 +01:00
Szymon Kłos
d5f9e622a9 autofilter: use gridwindow instead of screen offset
core is adjusted to send offset for autofilter popup
related to gridwindow (spreadsheet area) instead of
absolute screen coordinates - what helps to simplify
code.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If011451513c80902fc436116528e2e21a929b42c
2022-03-04 12:29:55 +01:00
Michael Meeks
6548759fde replay: re-connect after a timeout for various errors.
Change-Id: I06cb01a0ab826b5723e634bb03e1bca6d99c4db2
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-03-04 10:06:33 +00:00
Michael Meeks
42f565faf7 add $ make stress
Change-Id: I7da764b711f1a143ee67ef7a2f48fc34e3d17487
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-03-04 10:06:33 +00:00
Rash419
3fab3a1b52 wsd: remote-config: handle null pointer exception when JSON format is not proper
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia3a8aa6340fde13b5d73c69b187b3333b6df88e0
2022-03-04 15:02:41 +05:30
andreas kainz
8ab19d63dc Sidebar Left Text Alignment
Header Text and Section Text are left aligned
so each String start with the same space from the left
sidebar border

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I99841388f23bdb7f7493611c96689f3455999a5a
2022-03-04 07:16:16 +01:00
andreas kainz
9e14d06443 Sidebar Global Layout update
Sidebar section header use
- header-font-size
- header-height

Sidebar section labels use
- default-font-size
- default-height

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I6011b686a5d72159b87db0f70c99d14001d73356
2022-03-04 07:16:16 +01:00
Yunusemre Şentürk
774324c2e4 android: fix typescript files dont make it to apk
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ic9788141c398600cc2fd6d69e49d557019d8cbd6
2022-03-03 16:54:26 +03:00
Michael Meeks
f91e0349d8 Admin: shutdown cleanly to avoid races during close.
Suspect cause for SEGV in:

    std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<DocumentBroker> >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<DocumentBroker> > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<DocumentBroker> > > >::find(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
    COOLWSD::closeDocument(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
    Admin::triggerMemoryCleanup(unsigned long)
    Admin::pollingThread()

Change-Id: Id09e4db4b21cb7a11dddb867758aded4b28ff3ec
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-03-03 09:04:06 +00:00
Michael Meeks
019913666d Replay: log which client a message is from / for; and improve errors.
Change-Id: Id9e7d9680a0c33d79c8f691222829406754eaf94
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-03-03 09:04:06 +00:00
Pedro Pinto Silva
273d29c42c AccessibilityCheckBox: Fix paragraph style
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1aabb241ca986bd8e8f81405819aa270b45dac6d
2022-03-03 09:40:19 +01:00
Michael Meeks
8c6720cb5a Unit test for &lang=es-419 style code, disliked by boost gettext.
Change-Id: I2f1c39d03d61ef2074fe6e946a79fc2f07ffd27b
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-03-02 16:26:36 +00:00
Pedro Pinto Silva
faeb5530ee NB: Increase text contrast for selected tab label
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8468f6deb8f4e02f38d3cfad3b0d6a72b247ffdc
2022-03-02 16:59:56 +01:00
Andras Timar
7e724aa5ab Bump package version to 21.11.2.4
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2726ea5155c08eabeeddde4f68b6c4a200210985
2022-03-01 22:49:00 +01:00
Szymon Kłos
bf47bf4b60 jsdialog: Accessibility check dialog fixes for Firefox
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Icd169d74dca37e7e3b04bc7283f50d27cf9d4252
2022-03-01 20:32:15 +01:00
Szymon Kłos
57d997955b jsdialog: Accessibility check dialog fixes
- update pos on invalidate
- implement scrollwindow

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic1b133a8657abce1957a31e7c80c29ca7bf40976
2022-03-01 20:32:15 +01:00
Andras Timar
c71a845cd2 Updated UNO command translations (added Accessibility Check)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0e1cf8fe0539fc3ff60d9b635eb2eafbaa0fb9dd
2022-03-01 12:54:58 +01:00
Mert Tumer
e93e476503 fix copy annotations on shared-view doc causes uncaught exception
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I281fcb3a613166bc9be4b3bc09dbe0b28fdca6bc
2022-03-01 14:34:52 +03:00
Bayram Çiçek
24da346a53 update cypress_test/README
Signed-off-by: Bayram Çiçek <bayram.cicek@libreoffice.org>
Change-Id: I2c03535d5f27cffeffc75a0f101d0280cc6e50ae
2022-03-01 10:32:49 +01:00
Pedro Pinto Silva
29264b8561 NB: stylesview: fix hover bg and shadows
Make sure gray background or any bg for that matter is used on hover
 - It shouldn't be used because each style is an image with white bg

Decrease hover status prominence so it's still visible which style is
selected

Also do not add hover status for the selected style, as clicking on it
would not change the selected style

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie66abada24a7c6491987d9052dc94bba920d5a7f
2022-03-01 10:32:35 +01:00
Dennis Francis
fdaf0fec7e calc: misaligned selection if sheet geometry changed while idle
Steps to reproduce the issue:

1. Set per_document / idle_timeout_secs to something small, like 30,
2. Open a spreadsheet with various row heights,
3. Wait until you idle out of the session,
4. Open the same file from another browser tab/window, add an empty row near the top, then close it,
5. Wait a little bit (let's say ~5s), and click into the original session, then select various cells.

-> Note how the selection is misaligned.

Root cause:

When a session becomes idle (at least for the current use-case) the
corresponding lok-view is terminated and when the js-view is resumed a
new lok view is created! In this case there is no one to one
correspondence between a js-view and lok-view. So there is no
remembering of events or replaying of events.

Fix:
Ask for sheetgeometry whenever the cool-client resumes.

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: If445cf28f8add46ce478e3a87e2ad8ada6cf2eb0
2022-03-01 11:00:18 +03:00
Andras Timar
5c0f255a6e Bump package version to 21.11.2.3
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I3d5ddfd48f79146538daf057163fdd801551f412
2022-02-28 16:42:21 +01:00
Bayram Çiçek
9e2629b072 Use make's -C argument instead of cd in cypress_test/run_parallel.sh
Signed-off-by: Bayram Çiçek <bayram.cicek@libreoffice.org>
Change-Id: I781070c32d89c329effbc233cf356fe983b85c1e
2022-02-28 15:42:28 +01:00
andreas kainz
bdb24f6ff0 Color Scheme add Descriptions to var's
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ic4588709f02ae25db8823db40ed50632b4165b45
2022-02-28 15:10:39 +01:00
Tor Lillqvist
cdc783ec0e Don't require https when ENABLE_DEBUG for the remote config thing
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I8b71d4e5a06e2c0a7fcd7dedc370cc4810a204fd
2022-02-28 15:57:51 +02:00
Pedro Pinto Silva
7e248d89db Sidebar: Fix border for NB, set it properly for RTL
No need to have border when using Notebookbar mode
 - Now the nb tabs are buttons and the goal is to make NB mode with less
 decorative elements (since it has more buttons)
   - Except for Calc where formula bar is there and a border increases
   helps with the difference between cells and sidebar
   - It also looks beter when the tabs are collapsed
 - Border was being wrongly set twice
  - Fix that and use CSS logical properties instead

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1e81007c9075f384d8be47d3ad2947d936a8f6b7
2022-02-28 13:46:09 +01:00
Pedro Pinto Silva
30e6538453 NB: collpasing tabs: hide container instead of child
We can hid the whole container and avoid the background of that
container to be visible (when collpased)
 - This was useful in the before when the tabs were visually "connected"
 to the content
 - Also it was done like that before to give a "clue" to the user that
 something is there and can be expanded but probably by now it's not
 needed and if the user actively collpased them then he/she would know
 how to expand them

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib586f4aa3e83e650276b25c2ac13d45f475816e3
2022-02-28 13:46:09 +01:00
Pedro Pinto Silva
725c0dc582 JSDialog: remove duplicated shadow
Content parent was being set with shadow while the main parent element
also has shadow

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4f8f13f579e5b1205433801e95cc482c63f1fcc7
2022-02-28 13:18:40 +01:00
Kristopher Maxwell
cb6a5fd4ad Remove unused parameters in ChildSession
The buffer and length parameters were unused in methods in ChildSession.

Signed-off-by: Kristopher Maxwell <kristophermaxwellc@gmail.com>
Change-Id: I6aff3c92a5d787db84bbe64aa13f2f0160340f7f
2022-02-28 07:13:11 -05:00
Tor Lillqvist
9bd427235e Add a generic class to fetch a remote JSON file between RemoteConfigPoll and SocketPoll
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I991b60044a431fe5aff48617d3f0852c119da095
2022-02-28 12:32:01 +02:00
Pedro Pinto Silva
65a9dea3a7 NB: File tab: Fix savemodified indicator
Re-align indicator and make sure indicator has white space
around it (on top of the save icon) so to increase its
readability

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ieaf4258c3dc594aa47904a1066deaee11417053d
2022-02-28 10:34:18 +01:00
Rizal Muttaqin
439228d83d Update icons in sidebar
Signed-off-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
Change-Id: I4d44746709049ced93fba5e163b5446546f56fd2
2022-02-28 10:22:43 +01:00
Rizal Muttaqin
ccfab757da Update chart design to sync Colibre in LO
Signed-off-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
Change-Id: Ie3acb8c078ecf035dbd3c3442e985010ef9226ec
2022-02-28 08:38:51 +07:00
andreas kainz
bf7d0b7873 Color var: partsPreviewControl.css use var colors
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: If76ac63e7c1ecdbc0ec6ed3aa04070abb1cc9893
2022-02-27 23:30:00 +01:00
andreas kainz
34b00ec634 Color var: searchControl.css use var colors
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: If475ebf90c935a354b09a5133e84a253e8458288
2022-02-27 23:30:00 +01:00
andreas kainz
b7f8c39c59 Color Var: btns.css use var colors
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I7af79aeafd53039227d6aa8ad6f837c92b7f4a34
2022-02-27 23:30:00 +01:00
andreas kainz
314e29a9fb css vars use header-font-size and default-font-size
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I0388e2b38cc13920eb5c2de74ad34fde56f4d417
2022-02-27 23:30:00 +01:00
andreas kainz
bbf8d27e30 CSS Vars: idle Dialog use var colors
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ic0ca5860f67d4d0299e5d33c73c973db462a147d
2022-02-27 09:35:59 +01:00
andreas kainz
3af32a598c Color-Scheme add header-font-size and default-height
--header-font-size is for the user of font in header sections
--default-height is used for the height of --default-font-size elements

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I16b7f0b5755cb54ceb26b6af66d13a8411fa0d84
2022-02-26 12:04:42 +01:00
andreas kainz
8540cfa9e3 Annotation dialog use css var's
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I0b90a53e7cbe1e1f271ede0a342103e7f1db29c4
2022-02-26 11:58:10 +01:00
andreas kainz
8bc1060a6b Use var(--border-radius) instead of 3px 4px 5px
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: If7d5221bb4a51d04bcf2e28f6864fcd0abddebaf
2022-02-26 11:58:10 +01:00