This is a combination of 3 commits.
This is the 1st commit:
leaflet: focus the editor after loading
We might not have the input focus after
loading the document, so we make sure we
do grab it so the user can type immediately
into the document without clicking in it.
This is the commit #2:
leaflet: focus the editor after loading - fixing recursion.
Grim recursion causing stack overflow and worse:
_activate (Map.js:1092)
_onGotFocus (Map.js:1253)
(anonymous) (Map.js:256)
fire (Events.js:146)
close (Socket.js:106)
connect (Socket.js:45)
loadDocument (Map.js:261)
_activate (Map.js:1092)
Makes re-connection when server re-cycles work again.
This is the commit #3:
leaflet: focus the editor after loading - fixing madness.
(cherry picked from commit 983005ff5763e78cdd5400df60e3bc9600a3e961)
Change-Id: I875750e85063101853fc65c75f322e82e09c3320
Reviewed-on: https://gerrit.libreoffice.org/82149
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Even though we don't use the uno command (as the type action, because
this entry doesn't exist in Core), we need it so the statechange
notification updates the check state of the menu.
(cherry picked from commit b536707f1708b24201fdeb721cdd1c83a4326aef)
Change-Id: Ia24d94f146ca4a0a557a2e2557f8cc34cc2dc20e
Reviewed-on: https://gerrit.libreoffice.org/82148
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Incomplete. This is a stub hinting at what needs to be done.
The menu entry should toggle between Master Slide and
Close Master.
(cherry picked from commit b7cc9a909d5b1d97d6a8f8268ffa8d3e47074f9d)
Change-Id: I1ce7e15e72483eae520bf4914e03609446a6c71d
Reviewed-on: https://gerrit.libreoffice.org/82146
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I3d96b4b24890bf73eb14f2ebc3c6cba9ab54adc1
Reviewed-on: https://gerrit.libreoffice.org/82191
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
(It is, sadly, apparently possible to set breakpoints in advance
(before the code has reached that file) only in files that are listed
in the project.)
Also drop the nonexistent "filter" directory in Resources. (It is
config/filter.)
Change-Id: I96ec9dd8dc4591db9d640b01fb07e807565670cb
Reduce confusion between whether to use "jsdialog" (also known as
"mobile wizard") or the sidebar.
Make core's comphelper::LibreOfficeKit::isMobile() equivalent to
window.mode.isMobile(). Decide whether to send the .uno:LOKSetMobile
message using the same condition that the function _inMobileMode()
uses, i.e. (L.Browser.mobile && screen.width < 768).
(window.mode.isMobile() is the same as _inMobileMode().)
Previously, on iPad, comphelper::LibreOfficeKit::isMobile() returned
true so the code in SidebarNotifyIdle::Invoke() in
sfx2/source/sidebar/SidebarDockingWindow.cxx did the jsdialog thing,
but the loleaflet code still did not handle the jsdialog message in
_onJSDialogMsg() in loleaflet/src/layer/tile/TileLayer.js.
Change-Id: Id7633ad3dd2dc79f1d845e07b0bf89f07ddd2625
Reviewed-on: https://gerrit.libreoffice.org/82157
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Instead of adding one entry per image into the
css, just adding the image of a valueset element
into the loleaflet/images directory is enough now.
Change-Id: I5deff7c9537ede713120f581f96bfb2aefb11fa0
Reviewed-on: https://gerrit.libreoffice.org/82162
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: I9eecf18bfff03a7040dd7ca006be77f4d3fb2810
Reviewed-on: https://gerrit.libreoffice.org/82141
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
from colibre on cp-6.2
Change-Id: Ibc0599bbbf1245fce72a6257421158ff0521cdb0
Reviewed-on: https://gerrit.libreoffice.org/82156
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: I0f1882ca785b211ffd18bdbc972c1152cfa3d275
Reviewed-on: https://gerrit.libreoffice.org/82126
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I5c7d1be30fcbdecefe894c27c46bce29a0f082c2
Reviewed-on: https://gerrit.libreoffice.org/82081
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4384bc1c29b5081ed5c1b40bad68567c208aa574
Reviewed-on: https://gerrit.libreoffice.org/82080
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
This adds a label 'Served by:' before the server-id in the
about box, and opens the discovery page in a new page to
preserve the document page.
Change-Id: I3f934f7e25743e400f9e38f7604b5cc7d0c850ca
Reviewed-on: https://gerrit.libreoffice.org/82022
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
The following flags are affected:
ShutdownRequestFlag
TerminationFlag
DumpGlobalState
Since it's common to grep for all places
that set or reset these global flags, it
makes more sense to have explicit functions
for each operation. Now we have set and reset
accessors where appropriate and get is reserved
for read-only access.
This changes the getters to only return
the boolean value of these flags rather than
a reference to the atomic object, now that
they are read-only.
Also, a few Mobile-specific cases were folded
either with other Mobile-specific sections, or
they were now identical to the non-Mobile case
and therefore deduplicated, making the code
cleaner and more readable.
Change-Id: Icc852aa43e86695d4e7d5962040a9b5086d9d08c
Reviewed-on: https://gerrit.libreoffice.org/81978
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
Saving the document on exit is not enough, we also need
to send it to the storage. We now force doing that,
even when there is no modifiction to the document
(i.e. a new version wasn't really saved).
Reviewed-on: https://gerrit.libreoffice.org/81336
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit f2913f20b03e916ce8a70f927ca3f5655a3768a8)
Change-Id: Ic4e1b1424f32d3141e98c936a51e47c9e4b9f753
Reviewed-on: https://gerrit.libreoffice.org/81576
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
This reverts commit 8211e9058e.
It is no longer needed as we now have the actual chart type
side bar panel.
Change-Id: I5c36fad1684f799bd85645008bb0177a2e9ba6bb
Reviewed-on: https://gerrit.libreoffice.org/82101
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
Some actions do not have UNO commands, they require two step operation
like the 'fullscreen' action.
Change-Id: I657ffca0356853ced10eb20f7ad072e0ac96751e
Reviewed-on: https://gerrit.libreoffice.org/82100
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Also add them into the mobilewizard.css so that _valuesetControl
inside Control.JSDialogBuilder.js picks them up.
Will be adding more images in follow-up patches related to
the chart type panel. Might also be a good idea to generalize
the _valuesetControl function and add divs with proper/different
naming later.
Change-Id: Id8c48ae96664c11ea0e7d4f3e607f6c60903abf1
Reviewed-on: https://gerrit.libreoffice.org/82087
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
I have no understanding of what this code does and how it works but
this seems to fix the problem described in the bug.
Change-Id: I7188745b5c77d9e065828336b7dd6524aedc1dce
Reviewed-on: https://gerrit.libreoffice.org/81079
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit b95a22a740bccbd50d6cf49ad0b5fdbd1d489a90)
Auto-generated by GNOME Builder
Change-Id: I4112f751ee45df3000dbab0aa00151eaaf803cb7
Reviewed-on: https://gerrit.libreoffice.org/82070
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: Id768d33e7267a17b25664a880333195fe28ce0ba
Reviewed-on: https://gerrit.libreoffice.org/82033
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
- add different class to vex overlay
- add different css rules
Change-Id: I89c971bd160a05a1c1fae20bbdecbf171c47f8ca
Reviewed-on: https://gerrit.libreoffice.org/82061
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: I283282928ac73c32bbb62a017b0c4eeec52b47c3
Reviewed-on: https://gerrit.libreoffice.org/82009
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: Id889caf21de00b8bf6620a37066c4e40793226c6
Reviewed-on: https://gerrit.libreoffice.org/81994
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: I83e5fbfd3377335b87a8d06b8570012e6c337ff2
Reviewed-on: https://gerrit.libreoffice.org/81986
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: Ib0c989e5467b1f6fa9b0ed1d21281e14f75015ae
Reviewed-on: https://gerrit.libreoffice.org/81984
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
- replace free text "Search:" with a proper label element
- give class to input group parent
- style search toolbar
- change font size to 16px so to avoid auto zooms from iOS devices
Change-Id: Iccbae8f7a932786acfde936e2002bd36b1fc564b
Reviewed-on: https://gerrit.libreoffice.org/81883
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
undefined".
ImpressTileLayer.js:686 Uncaught TypeError: Cannot set property
'invalid' of undefined
at NewClass._onInvalidateTilesMsg (ImpressTileLayer.js:686)
at NewClass._onMessage (TileLayer.js:553)
at NewClass._onMessage (ImpressTileLayer.js:604)
at NewClass._onMessage (Socket.js:806)
Change-Id: Iea1272d8239a56731685597d022f63eb663bd6ea
Reviewed-on: https://gerrit.libreoffice.org/82044
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
The "mCustomScrollbar" was created the scrollbar dynamically, so when
the user change the orientation, it is necessary to destroy the scrollbar and
create again with the new respective axis.
Change-Id: Ic4d90de6e9989478f5d60254692b287c76368385
Reviewed-on: https://gerrit.libreoffice.org/82016
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
