This is a follow up on f9ad2ea3c3
with Change-Id: I1c200f2208b4f762d01dc6dd85459dbedce7b03e . It
leverages the flex added there to align and justify items.
What it fixes: Radio buttons not being aligned from the "left"
side and behaving slightly different in terms of alignment
if anything else changes around
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9cb6f24c16603f40acf797c6b68d4305f38cdc58
to make some space between elements in grid
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5379a1a7fd96cb1fe351cb5b52ce1433eaa7eb53
they will be aligned to the grid size so look more unified
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4900e7d4005d172226c23919505702f6926260b7
Interestingly, we've been sending the wrong length, resulting in
[ docbroker_003 ] ERR #-1: Missing final newline| wsd/ProxyProtocol.cpp:158
type errors, as we read that back in coolwsd.
Change-Id: Iff7d1d38b0ed3e99c1d6903e2663c4335a36aaa3
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
sheets[i].href can be null. Seen with proxy.php.
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I3d774ace869d141973a92abab8ef9ac83e1e0018
Target .ui-tab instead of .ui-tab-content
.ui-tab-content doesn't exist anymore, we can safely remove it
from CSS
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I17df0fb9de73ffe8665291d9dded8715bed9963c
- Don't create empty parent button just to have a another button
inside
- Update CSS so the text rules are applied to the button's text
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7f3a54a131a7a44109789a6612af8047963d8e7b
previously when using tab key we focused drawingarea
it wasn't possible to focus other widgets
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Icf23905dfbf04ff46cf8766212a645b962fba98e
This changes tabs into button elements so they can
be switched using keyboard Enter key. It's also better
from a11y point of view
Styles has to be !important to override button styling
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia4ced59544be18ae79d41b4f837eeb31ab80b8ef
Refactored TextInput implementation. A content editable <div> is used
in place of <textarea>.
<img> elements are used as pre/post spaces.
Minimal changes to FormulaBarJSDialog, since some code was
dependendent on
TextInput details.
Refactored some cypress helper funcions, too, since cypress tests
expected a <textarea> element.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I2141d7769588bb5bf8a0fbb62f036cb78f914966
Otherwise, the toolbar re-layout half the size.
Change-Id: I492a98f822a829d814b4c6e6b4765ec14a65cc98
Signed-off-by: Henry Castro <hcastro@collabora.com>
On iOS, the "export*" commands cause a file to be saved to the Online
server, not locally. So, to save locally on iOS, set the commmand to
"downloadas-*".
Signed-off-by: Patrick Luby <patrick.luby@collabora.com>
Change-Id: I4da2614d20af7ae6977dd94713ba16e6eebe1b9e
Responses have to be handled even in top level widget.
After rework we sometimes didn't handle responses
because we didn't call container handler.
Put it in a build function also.
Bug was in find & replace dialog, help didn't work
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I07a69c071b65c6574a1656c71aa7eab361f7e729
We don't need the first one and we don't use the latter one.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I1f48ff5487621781eb38dd8e4e8e2a389a3059d6
'trimIfInactive' overrides a member function but was not marked 'override'.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I25b0033652a3362118a77b7ef5ef7a511ce492ea
the commit 51bb1d3 with the following change-id
I16a5df46bced608952c22bf979808bc735645366 introduced incomplete
CSS rule, rendering the whole css file invalid
So we should add back the rules and just remove the vex classes
but and upon further investigation button are already inheriting
font-family from jsdialogs.css: .jsdialog-container .ui-dialog-content
so we can just remove it altogether.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iab42230efc7341e8967ce776f0d3decf41655ba6
After reading Rizmut's commets, we should probably revert this for now
at least until we decide on the icon size while avoiding bluriness
This reverts commit e6782d6b5d.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
This is fix for regression from:
commit a2d666d53a
JSDialog overlay: Use CSS rules for positioning.
When switching a tab in Format -> Characters dialog,
update message was received and dialog got request to
update position. Even when we had nothing to update
we did modification to dialog position causing jump.
This patch makes updates less agressive and does update
only when calculated value is really different.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I27364e5ccb60a0391ddc9fb9e22078d559518f69
The following commit caused a regression with
PDFs which are read-only, but may allow comments.
commit cca0a561ed
Author: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Date: Sun Jan 15 18:29:18 2023 -0500
wsd: never upload using a session that is read-only
Change-Id: I9bf1fde21b47a4f119b99cc58f76cd683c2152a9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Tabs were changed to buttons and thus we need to readjust the CSS
so text color and others are correctly applied to the text
Also add :not exception so the tabs are not styles as regular buttons
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1bc1681e86f17ee7afb435f7c3fc099b80abac2e
