Commit graph

9425 commits

Author SHA1 Message Date
Henry Castro
62b8e9b307 loleaflet: remove dead code in loleaflet/build folder
The file loleaflet/build/build.html it will not work and
the exported function test no longer is used anymore.

Change-Id: I8f5898d38798f22987598f05a7415d81342abec5
Reviewed-on: https://gerrit.libreoffice.org/81802
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-31 17:12:41 +01:00
Henry Castro
3a06166bee loleaflet: move the plugins documentation to loleaflet/docs/plugins
The only plugin that was merged into the source code was
https://github.com/leaflet/leaflet

The file "L.Path.Drag.js" was renamed and modified to be adapted to
desktop or mobile case.

Change-Id: I7026ca9cb882c01d1453b9157401e0bf692193fb
Reviewed-on: https://gerrit.libreoffice.org/81800
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-31 17:12:24 +01:00
Henry Castro
253d72e09a loleaflet: mobile: slide preview remains on top of wizard container
Create a new instance of the class "L.Control.PartsPreview" and append
the contents as a header on the mobile wizard container.

Change-Id: Ieb7bfd920087ebc06e4127f26cfc59cf1b2c70b2
Reviewed-on: https://gerrit.libreoffice.org/81795
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-31 17:12:07 +01:00
Henry Castro
bbf31520fa loleaflet: mobile: avoid fetches thumbnail preview when second instance
is created

This is a small optimization, the first instance will fetch the
thumbnail preview, then the second instance, will be a listener only
when it is created.

Change-Id: I883d4260a5ab3dc6dc7d0388969623b9af762fb8
Reviewed-on: https://gerrit.libreoffice.org/81857
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-31 17:11:52 +01:00
Henry Castro
97573d57c2 mobileWizard: set a new "maxHeight" option
Add a new option to the class L.Control.MobileWizard with the
purpose to define a maximum height of the mobile wizard container.

Change-Id: I7af5f4d087d10442b281002b57c9d0f43c4385e5
Reviewed-on: https://gerrit.libreoffice.org/81794
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-31 17:11:32 +01:00
Henry Castro
bea95e329b mobileWizard: avoid setting the CSS top property
It is better that browser sets the normal CSS Box layout, otherwise I
have to count pixel for a new box added to the mobile wizard container.

Change-Id: Iec378cfc630be5f8e2419ee22ae074704a9ebc82
Reviewed-on: https://gerrit.libreoffice.org/81793
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-31 17:11:16 +01:00
Henry Castro
74adf2f61a loleaflet: parameterize the slide preview control in Impress document
The initial design of the preview control was singleton object, but now
there are new requirements to add a new instance of the preview control
to show in dialog wizard.

Change-Id: Ieec9dca244a87dd067e6c9e51408258b0f528e74
Reviewed-on: https://gerrit.libreoffice.org/81724
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-31 17:10:52 +01:00
Andras Timar
5a0e357f78 add -lssl and -lcrypto to LIBS, if SSL is enabled
Without this the linking with static poco libs failed on Ubuntu
16.04 and 18.04. Interestingly on other distros, including Debian
8, 9, 10, and CentOS 7, 8, and openSUSE, this patch was not necessary.

Change-Id: I96c90ab5e960e8843db9b835f6e1a0417c7b48f8
Reviewed-on: https://gerrit.libreoffice.org/81836
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-10-31 14:28:19 +01:00
Grzegorz Araminowicz
058398ee1b hyperlink dialog: load existing text and link under cursor
Change-Id: Icf5a9e9bce01e311e745845b738e333ee3c5954c
Reviewed-on: https://gerrit.libreoffice.org/81231
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-10-31 12:43:31 +01:00
Szymon Kłos
6abd096824 jsdialog: set correct windowId
Change-Id: Ic58e82b027ee33d86cb6e8e7afe5a457a5ef5e5f
Reviewed-on: https://gerrit.libreoffice.org/81790
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-10-31 11:54:47 +01:00
Pedro
832f65788f mobileWizard: switch sinfieldcontrols from +,- to -,+
Change-Id: I673bbac255872acd037d4c7302ff4a7fe2e1dbce
Reviewed-on: https://gerrit.libreoffice.org/81787
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31 11:53:32 +01:00
Pedro
0e59b9be7d mobileWizard: input number: disable firefox specific controls
Change-Id: I18a4705560088fc2aacd4e82dd685f43a1aac61f
Reviewed-on: https://gerrit.libreoffice.org/81824
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31 11:52:52 +01:00
Pedro
5c312db13d mobileWizard: image: add icons and fix position settings
Change-Id: Iffd3e491a0444118da29315d847a00267873232f
Reviewed-on: https://gerrit.libreoffice.org/81781
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31 11:52:27 +01:00
Miklos Vajna
3ba17824e3 Fix TileCacheTests::testUnresponsiveClient()
This started to reliably fail for me recently.

I think the problem was that deleteAll() also listened for incoming
messages, so while waiting for textselection:, perhaps it processed (and
ignored) invalidatetiles:.

As a consequence, once deleteAll() returned and testUnresponsiveClient()
started to wait for invalidatetiles:, the test may or may not failed,
depending on the order of messages.

Fix the problem by just dispatching the SelectAll and Delete commands,
then waiting for invalidatetiles:.

Change-Id: I33f096e7dcb7f9daf1968dcb50d8a5f53824f5bd
2019-10-31 09:39:45 +01:00
Tor Lillqvist
6ca47a7ab0 For a mobile app, call window.postMobileError() in window.onerror()
Sadly it doesn't seem to work, though, at least on iOS, if I as a test
re-introduce the error that was fixed by
2ddd8d7c81. But maybe it will work for
other uncaught errors. Clearly it is better than letting the code
attempt do the XMLHttpRequest thing which is totally wrong and
pointless in an app.

Change-Id: I7b6e95556603b680527a0516f54e24dc10e96b21
2019-10-31 10:24:01 +02:00
Andras Timar
e0f8001e3a typo
Change-Id: Iaa986b700fecb10561d03008c291c9a7bf9df244
2019-10-30 19:16:11 +01:00
Andras Timar
4a589e90b2 Use Python 3 for loleaflet/util/po2json.py, too
Change-Id: I8f7aec078fba975eb516a497c1a287ed6a37e9e1
2019-10-30 19:12:40 +01:00
Jan Holesovsky
2ddd8d7c81 android: Fix 'Uncaught ReferenceError: reuseCookies is not defined' on mobile
Change-Id: I9b1f0be023d41c4f3a63373d2fe892c800e5e466
Reviewed-on: https://gerrit.libreoffice.org/81784
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-10-30 15:57:39 +01:00
Michael Weghorn
2a795c5ac2 Add required python3 libs to debian/control
Those are needed since commit
c1e04e4069
("scripts/unocommands.py: Switch to python3").

This makes sure the required packages are
present when building the Debian packages.

Change-Id: I345805d0776a3ea2c43345ed1f40a32f391ba055
Reviewed-on: https://gerrit.libreoffice.org/81507
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-30 15:44:26 +01:00
Pedro
123880c013 mobileWizard: Image properties: Add missing icons
Change-Id: I8a42c3511ffc806880c45379a77601e786b4b385
Reviewed-on: https://gerrit.libreoffice.org/81774
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-30 14:51:17 +01:00
Szymon Kłos
c04970548b jsdialogs: use gridHandler for grids
Change-Id: I5775d6f24199a23bdfd635c362a9035a044b1f44
2019-10-30 13:55:14 +01:00
Andras Timar
5e4c9db5de fix configure check 'If we need to link with -lpcre'
The test program did not compile because of
error: unused parameter 'argc' [-Werror=unused-parameter]
As result, we always linked with -lpcre.

Change-Id: I7557025cc56fb72fc2a9f8de6142de93cfed2335
2019-10-30 13:51:48 +01:00
Miklos Vajna
91d3f5da26 loleaflet: isTablet -> isTablet()
The other references called this function object, so probably the rest
of the cases just forgot to call the function, resulting in an
always-true boolean expression.

Change-Id: I409f3ef5a927cd5d5c6aaf8e354045f5ca8c427e
Reviewed-on: https://gerrit.libreoffice.org/81732
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-30 11:30:30 +01:00
Yunusemre Şentürk
3c4f900b45 change linking order of poco libs in order to make static linking possible
Change-Id: I8de3f454f9174d78777303779acdb6c9c1ba2c7c
2019-10-30 10:03:49 +01:00
Jan Holesovsky
9830000feb android: Copy stuff from assets/unpack with every git commit change.
I've just spent many hours debugging why a type is not known to the
cppuhelper and is throwing a "cannot get type description for type ...".
It turned out it was just a stale .rdb on the device that avoided being
updated.

So this change will help developers (much lower risk of stale rdb
files), while not a problem for the releases (each version bump has to
update the rdb's anyway).

Change-Id: Ie73245cfc78da8faf97f08ef52e6358a8e71218d
Reviewed-on: https://gerrit.libreoffice.org/81707
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-10-29 20:51:08 +01:00
Jan Holesovsky
1813c272f2 android: Add hint about using pretty-printers.
Change-Id: Iffb53d4c4c8b78042840b99d54b28ce2b29c27ed
Reviewed-on: https://gerrit.libreoffice.org/81706
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-10-29 20:50:17 +01:00
Szymon Kłos
bb61033475 Use vex in comment modification
Change-Id: Ifbd5516b6c40813931356377fad224c3f67d7936
2019-10-29 20:41:44 +01:00
Szymon Kłos
be2b0e2f6f Use vex annotation dialog also on tablet
Change-Id: Id16c86c423b3aa3585a840ec068ed563c0d1221e
2019-10-29 20:36:57 +01:00
Szymon Kłos
a7ee73344e Allow to use scrollbars in dialogs
Change-Id: I95d54100040670aa5f30130eebdf03b8e6cc5dcc
2019-10-29 20:13:19 +01:00
Szymon Kłos
3799d72bd8 Use separate handlers for titlebar and content
Fix needed for touch devices.

Change-Id: Iffc0e7fe1303b7a0e4aae88ba7649bda0677320f
2019-10-29 20:11:31 +01:00
Szymon Kłos
9dab231984 Don't use jQuery Draggable class for dialogs
Using Draggable interface it was possible to introduce window
in the dragging state where it was impossible to exit.
Use hammer.js instead.

Change-Id: Ic4128db0199034bd328223881eaaeb1e7f649618
2019-10-29 20:07:03 +01:00
Szymon Kłos
fc61f42807 Constraints for dialogs moving
Change-Id: I94bdaf4f220bfcc246df26ba95e86d3ae7521640
2019-10-29 20:06:40 +01:00
Szymon Kłos
c43a6fb0c4 Set a threshold for a pan gesture
Change-Id: I98dd3eb31e3c70e6018dbfba3c1b5fbcc109c3d0
2019-10-29 19:59:17 +01:00
Szymon Kłos
cb95e25d69 Allow to show/hide toolbar buttons on mobile
Change-Id: I7fdc68be5da3442cf4ac20cbd6e080d9b38a83b8
2019-10-29 19:57:29 +01:00
Pedro
43249febef Toolbar-down: space-out icons and restyle dividers for mobile
Change-Id: I927f1ae0e2cd10985c8b5a5720b3a967eefcde22
Reviewed-on: https://gerrit.libreoffice.org/81692
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29 19:43:42 +01:00
Pedro
943ab1126a mobileWizard: Decrease paddings and margins; position labels more near to their elements and increase text contrast
Change-Id: I04fdfca8d769a68b650aa441b30e62c749922473
Reviewed-on: https://gerrit.libreoffice.org/81675
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29 19:43:28 +01:00
Pedro
b552ffbf2b mobileWizard: Fix misalignments
Change-Id: I961073b513652567aa0f2d4b430a603de7cacac6
Reviewed-on: https://gerrit.libreoffice.org/81664
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29 19:42:59 +01:00
Henry Castro
97b6782ee5 loleaflet: mobile: slide sorter is visible in view mode.
Adjust the CSS property readonly at the bottom and change dynamically
the document size dynamically to show the slide sorter in view mode.

Change-Id: If49d682bcd1eed94443a5d8f8b20420744ba60f4
Reviewed-on: https://gerrit.libreoffice.org/81691
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-29 16:17:32 +01:00
Henry Castro
6942ee012e loleaflet: remove unused loleaflet/debug folder
Long time ago, the leaflet project was imported to be
reused for document tile rending instead of map tiles.
During that time they were added so many commit and the
leaflet source code suffer modifications and mutations like:
new functions are removed dead code (related to map Geo locations).
Now if you try to open some of the files, it will not work,
and to not confuse new contributors, it is preferable to remove all this
unused files.

But if you still interested in how to use all these files,
please go to the original repository
https://github.com/Leaflet/Leaflet.git
and checkout the branch version 0.8.0-dev, you will be happy how all
this file works very well.

However, if you want to debug the new changes, I strongly recommend you
to add

./configure --enable-debug  /* other parameters */

to debug Collabora Online.

Any objections?

Change-Id: I38c85f5716f608390e79edbffecacb3561fda97a
Reviewed-on: https://gerrit.libreoffice.org/81508
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-10-29 16:17:12 +01:00
Pedro
96c268cc44 mobileWizard: Image properties>‘Wrap’: fix alignments and enable countour row problems
Change-Id: Iec7a7c4cd11b49e086c7b63f5f8a7bef7ee9330b
Reviewed-on: https://gerrit.libreoffice.org/81666
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29 14:04:02 +01:00
Andras Timar
b813ed61b6 add copyright notice to About Box
Change-Id: I51c2c5e7c2b0cf232b8a2f2dbcb3b9f3f04737ea
Reviewed-on: https://gerrit.libreoffice.org/70205
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-29 13:24:33 +01:00
Pedro
5e035078d6 Impress: Mobile: Toolbar-up: Remove next and previous record buttons, add fullscreen-presentation and icon
couldn't find the uno action/command for fullscreen-presentation (it seems there is already a function for that action in the hamburger menu item

Change-Id: I4e25f8f9ceaee15656e44775185cc8ed3856b7f7
Reviewed-on: https://gerrit.libreoffice.org/81510
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29 12:09:00 +01:00
Pedro
4d377c47bf mobilewizard: improved lists (style selected vs unseleced items)
Change-Id: Id1f3bf534a7f3769949cdf868e4ae8fcc3d08662
Reviewed-on: https://gerrit.libreoffice.org/81511
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29 12:07:20 +01:00
Pedro
1e5c87692a Fix alignment of icons in the table context
Change-Id: I85ed5662b46bec49b0bf7369eeeb9482c2a3bb69
Reviewed-on: https://gerrit.libreoffice.org/81658
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29 11:54:43 +01:00
Szymon Kłos
5f0bf2bb69 jsdialogs: use color control also for .uno:FillColor
Change-Id: I0939e152b1350968f3f33a4b5889f4da5063d373
2019-10-29 11:47:38 +01:00
Andras Timar
c0b1606c7b German translation of "Export as" menu
Change-Id: I4a19d5a063202345846fd3538da882fe8c0ecb3b
2019-10-29 11:23:08 +01:00
Andras Timar
c463a61e5f loleaflet: updated pot files
Change-Id: I87713f48cfd04302cebc75d5d2d45da179b12170
2019-10-29 11:15:12 +01:00
Michael Meeks
74c4cf1161 Fix mis-merge around testLargePaste.
Change-Id: I2a24219a54a9b454ef5c5de558046a9bcc993873
2019-10-29 09:36:25 +00:00
Ashod Nakashian
1cf79e639f leaflet: initialize before use
(cherry picked from commit 1fe1d765dfe8a7ff3fb89ecf437afccbea684d71)

Change-Id: Ib8eee6e50092950016ebb889f7dbe10674e9cbc7
Reviewed-on: https://gerrit.libreoffice.org/81580
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-10-29 02:40:55 +01:00
Ashod Nakashian
0106ab24f6 test: improve TileCacheTests::testUnresponsiveClient
Change-Id: Ib08c4675c9477cb925b5d42545cdc2cdae780fbe
Reviewed-on: https://gerrit.libreoffice.org/81579
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-10-29 02:40:34 +01:00