Commit graph

674 commits

Author SHA1 Message Date
Pedro Pinto Silva
64315f510a Don't apply duplicated border + shadow to all modalpopups
Better to make it more generic so it not only includes:
Busypopup: c26bed9
About dialog: bed76f1
but also any other similar dialog (warning dialogs, e.g.: copy/paste etc)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If56e36d5429472f255d94bfaa087a32309903257
2023-06-12 13:13:44 +02:00
Pedro Pinto Silva
5cc813b453 Calc: conditional formatting: icons, do not override bg img
Before, we needed this white background.
Now, we don't.
  - After HTML and dialog rework the background is inherit from the
  wui overlay and the images are set directly to the td elements using
  bg img

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I30826e17c502b0369fd337699d93f648d41846aa
2023-06-12 13:09:25 +02:00
Darshan-upadhyay1110
ecb1d6fd0d 23.05: Dark Mode - Texts on Comments dialog on Dark mode is not visible during edit
Add color property for annotation-textarea to get correct font color in comment box.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I74d5e83641982acc1b0b328c707c09d06d68c56d
2023-06-12 11:27:34 +02:00
Pedro Pinto Silva
53b94c7f0c Navigator: for now let's not communicate that is possible to drag
Since we have disable the functionality until it works as expected

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0a99680d79ffb44a653c32edb25aafded35c7712
2023-06-10 09:02:25 +02:00
Pedro Pinto Silva
c26bed969f Busypopup: don't inherit duplicated styles and fix label
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If37fb7cc924fc9d1b8bf1a86708d4382e9639f8f
2023-06-09 12:24:00 +02:00
Pedro Pinto Silva
bed92fccf7 Mobile: Fix busypopup label alignment
Tested using:
`map.fire('blockUI', {message: 'Saving document, please wait...'});`

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4e1bd87d512287fd346964a5b81a7b79df1ed78a
2023-06-09 12:24:00 +02:00
Pedro Pinto Silva
a3f4858f67 Mobile: popups should not have height: 100%;
Otherwise they (their contents) will not be scrollable

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idf121b6164dbb43a473e07e2ca70962bedb10ebb
2023-06-09 12:24:00 +02:00
Gülşah Köse
89ee7239ee Dark mode: make readable the links in About dialog
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I64bc99145943e98a6548d682917a120c0d8a33f4
2023-06-08 15:24:11 +02:00
Pedro Pinto Silva
45f400c7a5 Dark mode: add select state for buttons
Do not re-use light mode values.
Increase color contrast

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I514d4be5468dd3df50ab5256b64d0a22e659ad97
2023-06-08 14:44:50 +02:00
Pedro Pinto Silva
a1860a1463 Dark mode: lc_morebutton.svg: Increate container brightness
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6e371a9777215db482b89c05b07acdf06a15c44a
2023-06-08 13:53:57 +02:00
Pedro Pinto Silva
468ca99820 Navigator: Fix and improve the selected item
- Categories (listview with icon) get highlight but not indicator
  - So it's understandable that they can be dragged
- Categories: change cursor so user understands that they can be grabbed
- All other treeview (even exapandable) get highlight and indicator
  - To help user's orientation

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8c275c81503787c60c4527a3cee63be8323686ef
2023-06-08 11:58:14 +02:00
Pedro Pinto Silva
09511d5116 Start navigator from the top
This is a follow up on the revert f4f95b2 since the scroll logic depends on the
absolute position

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5659701c2236dc89f764f45008e6e92c47a3f101
2023-06-08 11:58:14 +02:00
Pedro Pinto Silva
a0820fa9ca Revert "Navigator: do not resort to absolute position to set deck"
This reverts commit f4f95b27cf.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iff99928855684252cc6b48977940f8ddd827a865
2023-06-08 11:58:14 +02:00
Gülşah Köse
32f0c658c9 Expand the Page style and Character dialogs #6493
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I5442d6a99bb202ad2a850ac42baf2140adc4d1a2
2023-06-07 17:47:37 +02:00
Pedro Pinto Silva
d4a4a84b13 Tunneled dialogs shouldn't have grey title bar
- Tunneled dialog was missing title bar color (was inheriting from
jquery ui library defaults)
- Also use the main background (lighter than bg-darker) for JSDialog containers

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If6db5ee2edad88b2785096eb746f291a07b46d70
2023-06-07 17:27:36 +02:00
Pedro Pinto Silva
573ed1bb0b Revert "Tabbed view: Fix save modified icon being cropped"
Better to move this elsewhere otherwise we get huge save icon

This reverts commit 247bc9192d.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
2023-06-07 17:15:19 +02:00
Pedro Pinto Silva
9057c705f7 Dark mode toggle: fix flimsy selected state
I have noticed that sometimes the toggle doesn't get assigned with
selected css class. We could just rely on this line and avoid add and
removing css class to the DOM every time the mode changes

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7c19f626d60c761a1ebe2509e7ab7aa8031403ad
2023-06-07 07:57:28 +02:00
Gökay Şatır
6c5f8f3a48 Add a button to color dialog for setting the color to auto.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5a4b4b5a3c2960d21cdb894faa9e2cb488f66abf
2023-06-07 07:45:45 +03:00
Pedro Pinto Silva
6f34bc03c1 Mobile: About dialog: remove unnecessary elements
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id929475af828f6bddf4abaadea443dd3f707af4c
2023-06-06 09:50:45 +02:00
Pedro Pinto Silva
cd5326c012 About dialog: make it wider
now that about dialog is not a vex it is inheriting width from
generic .jsdialog-window.modalpopup. Overwrite that and make it wider.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I830f57cc9fda9bea8e377d53e72af92c4804cf8d
2023-06-06 09:17:47 +02:00
Pedro Pinto Silva
bed76f1156 About dialog: don't apply duplicated border and shadow
About dialog is already inheriting those from
.jsdialog-window.modalpopup

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3f49284f3d818eccc62b1f49cc330267d1163319
2023-06-06 09:17:47 +02:00
Pedro Pinto Silva
60e7b72f48 JSDialogs: modalpopup use CSS var for border and shadow
And use the same values as .lokdialog_container.ui-dialog.ui-widget-content

This is a follow up from
- PR: https://github.com/CollaboraOnline/online/pull/6343
- Commit: a65de18694

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id2661cd4eec021305c6af6c26cfc184cc9968956
2023-06-06 09:17:47 +02:00
Andreas-Kainz
ee5b5d8878 Sidebar writer Paragraph Section BackgroundColor justify-content: end
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I23a5690b0b33dae426914ebef30fae6d97d598c7
2023-06-05 14:42:06 +02:00
Andreas-Kainz
cd5115aa8d jsdialogs radio button use same margin than checkboxes
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I3d9611595819d505632fc58686f1ee9355228524
2023-06-05 14:21:58 +02:00
Gülşah Köse
07bbf1d38f Fit the images into the sidebar.
Without patch image sizes are 336px and seems cropped in sidebar.
We should use same width with sidebar width.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I617a4e79e15d1d49ca95aec8f5a20f95734160a2
2023-06-05 12:32:41 +02:00
Pedro Pinto Silva
f09f743636 Dark mode: Canvas, get directly the css var property value
- Get directly the particular css var that we want instead of on relying on a container
  - This makes things easier to maintain in the future
- Use a new --color-canvas instead of relying on --color-main-background
  - color-main-background is used in many other places which means
  that if we want to have some particular UI brighter or darker it
  would affect the canvas. Better to use a different/new css var for that

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3d7d3ba188e96080d9f6f814a5c46f85ea378142
2023-06-05 12:13:47 +02:00
Pedro Pinto Silva
9010d0125e Navigator: Fix alignment to coincide w/sidebar properties expanders
Zeroing margin and padding otherwise we inherit px

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1dedb755b3fb16ac2da6af95b4a0c4d5e5910715
2023-06-02 18:52:31 +02:00
Pedro Pinto Silva
f4f95b27cf Navigator: do not resort to absolute position to set deck
- No element should have border
- Reset max-height otherwise it will inherit 150px

This is a follow up on:
navigator: hide panel title in sidebar 56ca9b6

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I908468f0cb9a494acd7785d76e1882c3a8673de3
2023-06-02 18:52:31 +02:00
Pedro Pinto Silva
6a370193a5 Mobile: Add "Read-only" label to toptoolbar
Affected user flows:
- User opens read-only file
  - Before this commit, there was no indication that the current mode
  is read-only.
- User opens file
  - Before this commit, the only indication about the current read
  mode was the pencil Floating Action Button.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7cc3982b0c0f827a96e144ee339d8f0e601bf03e
2023-06-02 18:49:40 +02:00
Darshan-upadhyay1110
9e39495994 add minus,plus and search icon for bottom toolbar
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ia675cf4c1607d4ef5f19268647a40ea701109d76
2023-06-02 18:35:48 +02:00
Pedro Pinto Silva
247bc9192d Tabbed view: Fix save modified icon being cropped
Before this, save icon's dot was being cropped due to height rule

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id7b16b3fcd05d169c1206b9b7c3dbe615f0e8141
2023-06-02 16:25:25 +02:00
Pedro Pinto Silva
34c07e5f9c Status bar: add missing focus state for search input field
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7417f5052e7a2d167469b2ff8b94918229614ceb
2023-06-02 14:33:38 +02:00
Pedro Pinto Silva
46e3a917f0 Status bar: increase search width
Before this search input field was quite narrow
- Too narrow for some content
- Too discreet due to its width

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ifef703f6cf75d5807494d4bbf01db16dbddb9e16
2023-06-02 14:33:38 +02:00
Parth Raiyani
058c96954a fixed cursor background in dark mode
Signed-off-by: Parth Raiyani <pmr642001@gmail.com>
Change-Id: Ie545ef51462b23a5abb3c389b5acf4cd6d118e45
2023-06-02 09:16:36 +02:00
Gülşah Köse
1f91a454c7 Set the width of the effects buttons #6378
Impress -> Sidebar -> Animation tab -> Effects
Unset the hardcoded  min-width and use fit-content instead.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: If524533997e33037d669055fd5479ddcbba80d71
2023-06-02 09:07:49 +02:00
Szymon Kłos
940ba4a4f8 function text area is not extended properly
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I69d3ceeff07f71c6f004686eb2dbae723ddbbec0
2023-06-01 15:01:02 +02:00
Pedro Pinto Silva
69405e2d66 jsdialog: style Formula Wizard
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I919b9699d0d0785b6938dd691245458bd00d1bae
2023-06-01 15:01:02 +02:00
Pedro Pinto Silva
25e6b30cf4 Checkbox need to be vertically centered
Specially important when checkbox belongs to a parent that is bigger
Example : Using Calc inside of Alignment section, vertical stacked
checkbox

https://archive.org/download/checkbox-need-vertical-center/checkbox-need-vertical-center.png

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie54611006c5c11c39938e97358e3dfa9891f069f
2023-06-01 10:47:37 +02:00
Szymon Kłos
53877cfda3 jsdialog: don't waste space for hidden elements
result visible for example in sidebar in impress

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idb11d288a91775f432592aec6458bf31dbecf778
2023-06-01 10:47:37 +02:00
Szymon Kłos
ed401659e2 jsdialog: don't vertically center by default grids
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0e1e1839f6cf4cf133b7a1a125b35cc6bad3b03b
2023-06-01 10:47:37 +02:00
Szymon Kłos
f99ce57b48 jsdialog: simplify css for button box
this fixes layout of 2 rows of button boxes,
example: manage names in Calc

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7fbafa4ab3a234e8406e25167ca533195fee51ba
2023-05-31 15:28:58 +02:00
Julius Härtl
1471ea6d9b fix: Avoid important property on all classic toolbar w2ui icons
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Change-Id: I2a2ace9ffc2a31d500b6819f790a07e5762a5f6a
2023-05-29 18:34:58 +02:00
andreas kainz
35a48c8c34 Sidebar.ParaPropertyPanel css class merged
identfieldbox and box3 use the same css class see #6392

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I7a95fdd8ae3a9bfffbe676917cb412a99cb40818
2023-05-26 11:06:22 +02:00
Pedro Pinto Silva
6b7cb803b2 Fixes: Sidebar icons are cut off
This hard coded width is not needed and was imposing that width value
to #indentfieldbox even if there is other elements present resulting
in the whole container being bigger than the sidebar itself

This issue became more evident with
27fddae9c6 (even
though it's not related to the bug but rather exposed it even more)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I90e684b395b950e4cc25a96a9875d4702016411d
2023-05-25 16:04:27 +02:00
Darshan-upadhyay1110
5548d062c8 Added image path for icons when toggle to dark theme
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I14a99df7cf10bf73f898f15d3aaa5a32c9cd51af
2023-05-25 11:13:18 +02:00
Pedro Pinto Silva
0408fd62c3 Sidebar: Align everything to start and remove unnecessary css
Better to align everything to start so if the components differ in
width they will still be aligned (as opposed to be laid out in a staircase)

This is a follow up from 1bfbdf8072 coming with
the following PR https://github.com/CollaboraOnline/online/pull/6389

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic607567d30656cc122f9cbfd71bd3d910ebfe9bf
2023-05-25 09:09:47 +02:00
Pedro Pinto Silva
262669a237 Dark mode: fix shadow color
Use dark shadow

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0f8bc58470d3c0e5842a4bd293920775da187399
2023-05-24 10:29:29 +02:00
Pedro Pinto Silva
fffa61337a Fix menubutton tooltip, pos and style
- Do not appear above color
- Re-use tooltip styles

This fixes https://github.com/CollaboraOnline/online/issues/6293

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idf67c23b2263e5eeabc70a7128087333856aa465
2023-05-24 10:29:29 +02:00
Pedro Pinto Silva
e0c752b4f8 Tooltip: increase text color contrast
Follow up from 1ffb35d18d

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I203b4af8818f282bf18c405790e016fd4a6369fe
2023-05-24 10:29:29 +02:00
Pedro Pinto Silva
71c4bb392d Fix borderless buttons on desktop
It seems the following commit
be04111173
had a typo 0px should have been 1px

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibf3b92964efd8a1a147abc853042fd70a406abaf
2023-05-24 10:29:29 +02:00