This already worked for normal save, but not for convert-to.
Depends on core.git commit 0518bb5c3a98d973c3675fdd4cb8c52a669a3507
(desktop lok: handle NoFileSync in saveAs(), 2018-03-26).
Change-Id: Iec1a92fba2094f3954cc1a4ed6ee3372076fddc5
It's not possible otherwise to focus the <input> html element in Safari.
Unfortunately, making the input field 1x1 has the disadvantage that on
IE 11, a very small blinking artifact appears on bigger font size. There
doesn't seem to be any other solution to hide the cursor on IE without
messing up with IME candidate window position.
Without this patch, typing doesn't work on Safari at all which is much
much bigger of an issue than some artifact appearing on IE.
Change-Id: Ib618a96ba2ec3aa621ed448ffbf410113d8975b8
Reviewed-on: https://gerrit.libreoffice.org/51579
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
So, we need to ignore the key event in the start of the handler.
Otherwise, in the case of firefox, us ignoring it in 'keydown' gets it
handled in 'keypress' which does double copy/paste.
Change-Id: I93f0e5c7db8817fab42764d0f0d3b12b50d62f81
Reviewed-on: https://gerrit.libreoffice.org/51134
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
Build will fail for nodejs 4 anyway, so fail early in configure.
Change-Id: I0be746454cd21401195f8bf72a4eb107a3433fd7
Reviewed-on: https://gerrit.libreoffice.org/50889
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Otherwise saving is bound to fail, causing other
errors, which is nonsensical since there is nothing
to save to begin with.
Change-Id: Icb65a4a3b277b3175aadbe5107b294b24a399e7b
Reviewed-on: https://gerrit.libreoffice.org/50148
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
Better logging during wopi info parsing,
especially upon failures.
Refactored the code from Storage.cpp into
JsonUtil.hpp.
Minor optimizations.
Add unit-tests for the parsing logic.
Change-Id: Ifebc3f6b7030a6c7b3b399786633f6b5e8737478
Reviewed-on: https://gerrit.libreoffice.org/49927
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
This resolves the erroneous warnings of pinging
on a non-upgraded (i.e. HTTP) socket.
This was due to the fact that we moved the socket
from one SocketHandlerInterface to a WebSocketHandler
after upgrading and since the WSState was a property
of the handler, the WebSocketHandler didn't know
that the socket had already been upgraded.
Also other cosmetics and cleanups.
Change-Id: I1a88edef750117ed551d23245e49380371561422
Reviewed-on: https://gerrit.libreoffice.org/49911
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
not when it is reached
Change-Id: I802f839e49f4c8ed9e423b093e7306b5480a1812
Reviewed-on: https://gerrit.libreoffice.org/50188
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Should be backwards compatible with npm 2,3 and 4
Change-Id: Ie40f39af4b6fb618916df33d9cdd2fc62e4bc592
Reviewed-on: https://gerrit.libreoffice.org/50191
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
This reuses the vex dialogs and pushes notifications to the bottom right area.
Converted the limit reached notification to this new type.
Change-Id: I20f0c1202eecde028e70156f02ba31497ef2f9b9
