Since we track active sessions in removeSession,
it's possible that the last session is not active.
In that case, we should set the unload flag while
saving. If we've removed it, we should mark to
destroy. And finally, we should only assert
that mark to destroy is set with active session,
not when we are left with disconnected ones.
Change-Id: I275aeafe67875fa75e0fad5438928f2f77b79a9a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
By waiting at most 2 seconds, we improve the chances
of getting the ModifiedStatus=false before we termiante
the document. This minimizes the noise of warning
of potentially lost data on exit and similarly reduces
the test failures, which test for clear termination.
Change-Id: I284693d1cdd91b1224581fdc29e6e5438ab4c0b2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We no store the origina modified time of the document
as we receive from the storage server in string
form and send it back as-is. This avoids any
potential issues with the roundtrip of conversion
to and from a timestamp.
Change-Id: I524bea8f36c3ce62dcd00c4fe6a1e7e083287ed1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The expected shortcuts are documented in
https://support.apple.com/en-us/HT201236 . This patch handles a small
subset of those:
Command–Up Arrow: Move the insertion point to the beginning of the
document.
Command–Down Arrow: Move the insertion point to the end of the
document.
Command–Left Arrow: Move the insertion point to the beginning of the
current line.
Command–Right Arrow: Move the insertion point to the end of the
current line.
Option–Left Arrow: Move the insertion point to the beginning of the
previous word.
Option–Right Arrow: This should move the insertion point to the end of
the next word. But I don't think LO has such a shortcut so we move to
the beginning of the next word instead.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I6b0d36b0842388f0d49adf9b75fa9480df79c805
on ios case, there is no device back button available
so it is impossible to go back before the document load
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ifce5e4777b8dd014cbdc527fb65f0d0be21f2cd2
So it's easy to create ideas for GSoC projects
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I465f7b8876a4f43262fae52cf88ceacd89248517
There was a bug:
1. insert very big image
2. rotate and quickly after that rotate again but hold
mouse click so you will still see the preview
result: before patch preview was disappearing
after patch preview is updated
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ieb343a371816fe14e4c65f862abf1e55bf36de1b
Uncaught TypeError: Cannot read properties of null (reading 'getMaxZoom')
at NewClass._transformPoints (Path.Transform.js:577:18)
at NewClass._transformGeometries (Path.Transform.js:513:9)
at NewClass._apply (Path.Transform.js:419:8)
at NewClass._onRotateEnd (Path.Transform.js:1145:8)
at NewClass.fire (Events.js:152:22)
at NewClass._propagateEvent (Events.js:215:27)
at NewClass.fire (Events.js:158:9)
at NewClass._fireDOMEvent (Map.js:1719:10)
at NewClass._handleDOMEvent (Map.js:1689:8)
at HTMLDivElement.handler (DomEvent.js:51:14)
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic6f0c808c744636f7b8b4b6a683307b74824d2fa
Probably the last remaining incorrectly labelled
helper that checks for in-progress uploads, but
had retained the old and misleading label of 'save'.
Change-Id: I693275b1559f3dae4e9e3ab2408d997f56ff86e3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This reduces some logs from debug to trace,
especially in Socket where the amount of
activity is high, but the logs in question
don't add value in debug level.
Also supressed an error when superfluous.
This makes debug-level logs much more readable
and relevant to the main events.
Change-Id: Ie2698b56f320d15a09060cf2877477d9da0e1582
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Transitioning the state must happen before
fiting the events that require the new state.
This was a source of random failures.
Also, improved other aspects and added
more assertions and logs.
Change-Id: I55d5a7d5f13eeedaff7f309402baaae37b0134d6
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
First Group app specific commands
Second Group Zoom commands
Third Group visibility toggle
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I822d1ea8ef3460bea9869235b039749dad028c17
after switching to master view previews would remain unchanged
this patch will invalidate tiles for all the previews
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ie7320d625bd95fe80fc76a459b576d6148b39276
there are 4 type of color sections:
1. text
2. background
3. border
4. primary
and for each section there are
1. without extension for default color usage
2. -dark suffix for selected
3. -darker suffix for hover
4. -lighter for non available
with this setting the developer can choose
easy the section and the -suffix.
In addition there is primary color
which bring color the the apps and should depend
on the app so
- writer = LibO brand color blue,
- calc = LibO brand color green,
- ...
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I668b5505abd5d70345221bc79d921071c4a49cd7
In the past there was a padding which was removed
now padding was added again.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I52f11aa3e36e331e47bee345212d103f2ebf1b65
Avoid doubled PNG generation when graphic is selected.
We only need 'rendershapeselection' request to get preview.
'gettextselection' will only setup '_selectionContent' in
the Clipboard code but it will be never used as
`_getHtmlForClipboard` will ignore it for complex selection
with graphic.
Change-Id: Ic185aa3cb222ea97cf4c69fc65b5db350e568e42
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
To be safe, we can ignore the idea of this.map.isPermissionReadOnly()
control would always return true for PDF views and add
additional check for app.file.fileBasedView which is always
true and readonly true for PDF view
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I8f0a4401087c735508534404ee987bb35c3bb0fd
- Remove extra left padding of input field parent
- Increase input field's height
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic2b862cf2e6ad3bdc03504d5550b4deddd15d59b
and move everything related to view application to that tab
Without this change items related with document layout and
interface view were mixed together within the same "layout" tab. This
makes it harder to scan and find the desired action.
- Split Document layout commands and interface commands by creating a
new tab.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9d9d7fe88ceae8bc057946e20628132ee63577a0
similar to what has been done with fullscreen command:
8db1fc9bc8
The current is noW present within the notebookbar tabs
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I30822df1a84d62f7c000a3a39df95e84640ffebc
- Make sure a trigger is fired no matter the UI mode
- Handle it (do anything) just from withing the NB widget
(get proper css classes)
Note: similar to what we did with statusbar in:
e384c561798e7616f10e763788e92acec6caff9c
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6c8a38f2e426f20cc5b7a06241f7a92fa4d938e4
Without this change items related with document layout and
interface view were mixed together within the same "layout" tab. This
makes it harder to scan and find the desired action.
- Split Document layout commands and interface commands by creating a
new tab.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I625bb48a6c135d390f595511ddc8639ea5bdd2a8
Fullscreen is not present within the notebookbar tabs and since it's a
not so frequent user interaction is better to remove it from the other
places
note: keeping the presentation mode present in the impress since it's
different command and it's not present in the NB at the moment
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7f59387c32d71fddae0fb4001b0b098e71a1545b
Fullscreen is not present within the notebookbar tabs and since it's a
not so frequent user interaction is better to remove it from the other
places
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9f1d95ab30a8168471fe78a4590268f9338bcf81
Make sure the toggle also reacts not only to the user interaction¹ but
also at the startup time
1 Which is already done with:
- e384c561798e7616f10e763788e92acec6caff9c
- from PR: https://github.com/CollaboraOnline/online/pull/4088/
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I29e401eede4fc11c821da91b66430ba99d1ec1aa
- Make sure a trigger is fired no matter the UI mode
- Handle it (do anything) just from withing the NB widget
(get proper css classes)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ifdf18dc34a3b7d09e8224695ee0e72908b2166d8
They are toggles and not just on switchers
ref: 71831e2733
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If3b1af0097723ba0caf66804dbb4e4e219f79abc
If you hover at the classic toolbar at the menubar,
a border was shown and the string jump at 1px size.
Signed-off-by: Andreas_K <andreas_k@abwesend.de>
Change-Id: I5d03a380c2bfa34bd169bb12295d535875e54a5f
In the layout tab there are the object related stuff like
align and front/back. So I add there SelectAll command.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I4cdd9fbb0351cede9cd78dd1edd50e0612d895f0
if you hover over the last-mod string the color switch from
var(--color-text-lighter) to var(--color-text-accent).
In addition the text-decoration: underline was removed
cause it use text-lighter the focus shouldn't be there
with an underline.
Signed-off-by: Andreas_K <andreas_k@abwesend.de>
Change-Id: I750981730b6daa8605f8d70ebd3df4029f990e36
2px thick lines same as other icons in the statusbar
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I08d493038047be16af4c8f4a12cdb22684decf11
