This prevents the kit from becoming a zombie
when it has an early failure to connect to WSD.
Change-Id: I4e8203b2cc3d80822308236e5b47be0c0c96e9ae
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This may happen due to various reasons and
is most commonly observed during heavy testing.
We now detect when our parent has exited and
we exit forkit as well, since otherwise it
would be a zombie consuming resources.
Change-Id: I71de0315fe7bee419a9e7d0b564630ff75ae15eb
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
In 'debug' log-level we expect a detailed, but
still readable output. Having one area with
disproportionately large number of logs reduces
the overall utility of the log output.
This patch reduces a number of redundant log
entries, including errors that are already
logged. It also reduces the level of some
others from 'information' to 'debug' and
from 'debug' to 'trace'.
The goal is to make 'debug' level as useful as
possible to read the progress and be able to
understand what was going on, such that one is
able to decide which area to dig deeper into.
Then, trace level could be used to get more
insight into that area, if necessary. For
example, when investigating a test failure,
one first enables 'debug' logs and reads through.
Once a section between two debug entries is
identified as being of interest, enabling 'trace'
level logs becomes more productive as it's
now possible to easily reach the first DBG
entry and read through until the second one.
It's unfortunate that we don't have per-area
control for enabling/disabling logs, so it
is common to see more and more 'debug' log
entries added all around, making logs
less and less readable.
It is also a limitation of the levels we have
that we really only have 3 usable levels:
one, two, many. That is, 'information' for
the most important events, 'debug' for
technical details needed to investigate issues,
and 'trace' for everything else. ('warning'
and 'error' aren't really 'levels'; they have
semantics that makes them special-cases.)
So we have to avoid degrading one into the
other, or have differences without distinction.
If any of these entries are needed to be
displayed more frequently, changing them
back to 'debug' or even 'information' should
be done. Though for me they seem special
cases that don't benefit most log readings.
Change-Id: Id2c6a9dc027483b81a066b0b4b50a298c5eff449
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This adds dumpState to DocumentState, SaveManager,
and StorageManager classes, and dumps all the
missing members.
Also, normalize the format and make it symmetric
and consistent.
Change-Id: Ie0cc8e07d13de60c33d64cd621abf4e815a4ef94
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
we need to add preserveAspectRatio none attribute
for shape/image selection previews
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I8611d9ac79caa86a39f9773f5e44e53fdc8a8c00
the following vars were added
- header-height
- default-font-size
- color-box-shadow
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I05a081d5b27f6e9d8102002805c9194062f8ea0f
In all apps the sidebar widgets are justified: flex-end
only in impress the rule wasn't selected. But than the
alignment didn't work in impress.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I5f44496bb570f64a0b21d14fb4493665dbd31d07
separators are nice, but didn't bring that much for visual separation.
it's more visual noise than help for separation
compare to separators margins are a good idea for separation
so the frame-label get an margin which make also the label
layout better.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I402591327e6cdd5328bd95e5e2c342a56b66471d
spinfield and dropdown widget have the same width
(when possible) so there is no jumping widget alignment
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I0148295285a4174464de5ccea6bfa11a387de9a6
- color-main-background LibO document background was used
- color-main-backgroud was used for all elements
- only select, hover and toolbar's use other background colors
- color-background-lighter is the color for toolbars
- better contrast for select stuff
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I1e8be68aa1f6e73fb03994dac0ad634725e2aef0
Now that both classic and notebookbar mode have the document header
without background color and effects, we can safely remove the initial
margin that is not needed anymore
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id3f653c42d6099753bc852ac75f454698b6ffdc2
Google chrome doesn't render white spaces correctly
This is a set of tests for the core fix
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I7edb0490f1b56ac2c5ab2d60fa5cf25ab7946745
same than for the classic toolbar
hover use the correct border color and no outline needed
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I11859150009603afa93876496509d40f6d88b117
menubar padding: 3px 3px 3px 0;
so toolbar padding: 3px 0; similar to what menubar use
harmonize padding. Fit's also well when menubar was shrinked.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Iaced9d5a647267139eca26daa4793e83732f969e
search-input use --color-background-lighter color
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I4dfaabb9771ac4a128e5bab0ffeed5d99c9b0087
Make sure we do not add additional uncesseray styles for those
smartmenus that are converted into unobutton (NB dropdowns),
example LanguageMenu.
Do not inherit from styles from SmartMenus (for the first top anchor)
- hover styles (already have those from nb styles)
- borders
- Font size or font family
- line-height (that would also result in misalignments)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7bb3a7cf588c60677fd7a6899c74fbdab8000779
Make sure the default position (relative) and z-index (9999) are not set
for new Language dropdown (unotoolbutton), otherwise it will always be
on top of everything
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1ea3ba4d521a5caffb499473554fc4e5cfd336b8
The LanguageMenu from the Hamburger Menu was
now added also the Review Tab.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I927ec425c0e63ca4fe420369439eb96c80b41bb8
