During parallel build.
Change-Id: I18d78250650e5d16ff9a4ff8588a2e955a934f44
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90721
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In some use cases this time was too long and hammerjs
recognized a pan end by 'pointerup' event. We have
500 ms time set for long press in loleaflet code,
so use the exact value here.
Change-Id: Iab47c668ffa591ccfd7d2eeed10f2c3ec5664b89
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90723
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
There is no assertInTextEditMode() in calc_helper.js.
This reverts commit bc5bf2eb2a.
Change-Id: I97526eb8ea0297a2ea28080f09c85e4284d70932
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90719
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The issue comes up when we get a drag-end event
without a drag-start event.
Not sure wether this error can happen in real life
or it's just the cypress test framework mobile emulation
which can lead to this issue, but an additional check
won't hurt.
Change-Id: I352a5b523e8400ffc5e77ebefd91166e40517019
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90724
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This sometimes causes unit-integration to fail and now is consistent
with other member functions of Session that handle missing protocol.
Change-Id: I43c7fcae964cfcb5911ff57d63bd4cb569e6b97c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90732
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Id479cb6f1623630b84583c6d2ddd89c9779db7dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90737
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- adjust lc_wrapthrough.svg so it's visible the diference between that and the new icon option lc_wrapthroughtransparencytoggle.svg
- create and add first paragraph option
Change-Id: I224284e973340a15d60fa705117dd33ebb7b1450
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90734
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
The next translation update will kill the extra string anyway.
Change-Id: Ieda2ea51837e12fe40d2c85ff2d99afc65a2989b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90731
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This should never happen, since the _onMessage is re-assigned when
loadDocument is called, but it is better to ensure to forward all
messages.
Change-Id: I9a792bc077b26f2f92c30c4e7851c9d2b2637bfb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90449
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
The changes only populate the font list when the data
is received by the client, the other approach iterates
all toolbar items to refresh each one.
Change-Id: I837b52275b49e025fa353dcf088f97c19779bc79
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90450
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
When the cursor has a large width due to full merged row cell
it has an undesired effect that scroll to last columns
Change-Id: Ic939b8d9c3007faa46897893cc462cf3dbbee563
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90671
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Which indicates that the application stepped into edit mode.
Change-Id: I196851c618fd3b6c670b26184e6bbca8050f2f5a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90711
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Using CTRL+A is simpler, but with using the Hamburger menu we can
make sure that menu item is working. CTRL+A is not an actual
feature on mobile. Also it's good that we use hamburger menu, so
we can check interaction of hamburger menu and other wizards
using the same bottom panel.
Change-Id: I640e515070046ad18b00be69509ed895844962a0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90710
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It is hard have a determinate circular progress bar, so let's use
horizontal progress bar for both determinate & indeterminate.
They both look a bit different (the indeterminate is vertically
narrower), but there was no simple trick to make them look the same, so
I gave up for the moment.
Change-Id: Ife3690204a8abd8bf17afe5c7d749a3ac2730c20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90691
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Ideally, perhaps, we should avoid relying on CSS media queries to
detect mobile phones. Here I just add a placeholder to remember where
is a good (?) place to add such in JS instead.
Sadly cannot use the more elegant template literal syntax for
multi-line string literals, as some of the Jenkins builders don't seem
to like it.
Change-Id: I718f86f41cae461abbca3d7cd2751de3236bff18
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90705
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Remove grim duplicate dialog, consolidate clipboard warnings
in the clipboard code, and only show them after attempting the
copy/cut/paste and failing - rather than unconditionally.
Switch back items to use UNO commands, since we filterExecCopyPaste
in the existing _sendCommand anyway and warn suitably.
Add existing l10n hacks to the clipboard code itself.
Change-Id: Ia8befcdea3cce1934cbb9352174ba95b04eced07
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90651
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
With this change we can have "In Background" option in Wrap context menu,
that puts the image behind the text.
Change-Id: Ibd652bb593dd5a737bed3b4447be5b4bee7d4b70
Change-Id: I7652a5382b4a828ae21e8ce1cf6da21b7ce78b91
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90652
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I63408cdd8b693445a358050abee03044617c7287
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90702
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I5208a74d4806b7b661e213db0a314b944be797de
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90684
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Ieadca0bdb5668d0bdc8ee9356879b652b540ab3c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90659
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Once unit-bad-doc-load completes (with success in exitTest()), sometimes
we have an error during shutdown.
The reason seems to be that ClientSession::onDisconnect() calls
DocumentBroker::removeSession(), which may delete the ClientSession, so
by time time isCloseFrame() is called, we have trouble.
Fix the problem by keeping a reference to self before calling
removeSession().
Change-Id: If5b409822563ba5a45d453329516671065d8f054
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90681
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This is incredibly quicker, JSON serialization was the bulk of the
performance issue, and took handful of seconds for a chart.
Change-Id: I51bebae6324c3d466f843ee737b051b911cd5fff
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90673
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
This makes it easier to compare them.
Change-Id: If25f4c4dd3ee8a2a9d88d21521df6308857703a5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90674
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Previously we supressed the keyboard after toolbar
actions, but that is problematic because then the
user is unable to delete/replace selected text,
because the keyboard is hidden and there is no way
of showing keyboard without changing the selection.
Now we maintain the keyboard state, which is likely
visible, since a selection shows the keyboard.
This might not be ideal, because the user might
hide the keyboard on the device and we will restore
it after invoking a toolbar action, but at least
it's more usable now. Unfortunately, there is no
API to track the keyboard visibility.
New Cypress tests added to validate the above.
The tests depend on checking the last keyboard
visibility state in Map, because there is no
reliable (or any?) way to know whether the keyboard
is visible or not. There are many cases where we
actually hide the keyboard, while having the input
focus on the textarea element, so that is no indication
that the keyboard is visible. We do this for usability
purposes. For example, during zooming, when selecting
cells and graphics/shapes, etc.
The purpose of the cell is to validate that we restored
the keyboard visibility or we changed it, depending
on which is expected after each operation.
Change-Id: If0f2e96909ff20753043734789397d190cedb502
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90663
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
We should only show the cursor without the keyboard
when the focus is not in the document, and even
that is highly suspecious.
Change-Id: Ibbddf24464b0b41bb0206a8d28f31aa26779fbb8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90525
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
It needs support in the core that is currently missing...
Change-Id: I417172bca0c7d32dfda0a11bd8a9894ec33d72fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90653
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
and delegate it to L.Map.TouchGesture's swipe handlers
which does 'ergonomic' scrolling (added in
7338e3d818). With this we get
better/smoother swipe response when the swipe starts at the
right edge of the sheet (where the scroll widgets are).
This is a follow-up improvement of :
commit 0ca8e3b639
Author: Dennis Francis <dennis.francis@collabora.com>
Date: Fri Feb 14 18:11:37 2020 +0530
Lets have Hammer pan listeners on scroll-container...
Change-Id: Ib5260f540434ae6af649102a1f6d6eae57e4659e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89728
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
These options had to be removed from Calc, because sending shape to background
created multiple copies of the shape (a bug in tiled rendering?) and it was
not possible to select the shape in the backround and to bring it again to
foreground.
Change-Id: I8293ca857978e2b0b2574a9f3b420407e35c82f2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90675
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Single- and double-click starts editing
text-boxes in Impress. Single-clicking works
only on text, not in the white-space.
Merges an existing test with a new one to
minimize redundancy where there is overlap.
Improved helpers to minimize duplication
and update a single place when there are changes
to the common operations/checks.
ESLint version set to 6 to support the inline
closure syntax that 5 doesn't support. This is
only used for tests, so perhaps we should have
a different ESLint config for leaflet to avoid
breaking IE11, which is pre-6.
Change-Id: I14ee65b18e310f4ff6b93ce81580b3d6aba0fa03
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90360
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
In context menu of shape -> arrange -> to foreground
This option allows user to put shape infront of the text
Change-Id: Ifb8690d8f9aae92dc15b6bb643222113b1755a3c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90672
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
In context menu of shape -> arrange -> to background
This option allows user to put shape behind the text
Change-Id: I2af69dc9198de8aee087f5893b84dca92aecc03b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90670
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Specifically, for the context menu you get when you have selected one
bar of data in a chart, those items that would open a tunneled dialog.
Change-Id: I5406018b63233e7e936494a956ace3dfcdce310d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90660
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Will do this in batches. These are the menu items that showed up in
the context menu for the "internal" chart in a chart object (when you
have selected the chart and "opened" it, so that the rest of the sheet
is darkened). (Unclear about terminology here, the terms in quotes are
ad-hoc.)
Change-Id: I138f992e1b9cc0b4e31a2c0b64bea2e9c160ce4f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90609
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
