Compile-time constants are far superior
to hard-coded magic numbers and they
make changing them trivial. We need that
when we enable profiling.
Change-Id: I9ee42fabf3feb1feecb9b76ebca663007e263680
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We now use our http::Socket and SocketPoll
instead of Poco.
Change-Id: I728f9c975b67da76dbbc78e94f1fb5f224c9bc57
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
And disable it, since it's empty and has
no functional tests in it at all (it just
loads a document and exits the test, without
even waiting for the loading to finish).
We modernize, even though we also disable it,
because otherwise it wouldn't build.
Change-Id: I3735f28fa27af1d00e764f4e0070a25ff36b32d5
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This avoids the case where we fail to
create the jail completely, get killed,
or crash. All of which might leave the
jail unremoved.
Change-Id: I4c6b6a038110186af7be9f358a42902b224188e0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Explicit is always better. We also need to
terminate more gracefully when profiling.
Change-Id: I7145cb59583c5d7c6362bbf9c74e9d21799eaa33
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We need to flush and shutdown logging before exiting,
so we can't use _exit/_Exit directly.
In addition, with profiling (e.g. code-coverage) we
must flush the profile data, lest it's all for naught.
Change-Id: I726c5a2f4e699c17dd0d7d5b1c86d856e0118b3c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
- coolwsd.xml.in is the file copied to coolwsd.xml to become the
configuration file for COOL
- this PR fixes a typo in the languagetool section
Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I945d6d8257df34437092ac9f9c3f395cf5c759b1
Currently translated at 34.9% (162 of 463 strings)
Translated using Weblate (Hindi)
Currently translated at 33.2% (154 of 463 strings)
Co-authored-by: Pranam Lashkari <plashkari628@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hi/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ica85e9bf83bd2d05613c876c80c8b383a25955d9
Currently translated at 70.0% (320 of 457 strings)
Translated using Weblate (Hebrew)
Currently translated at 69.8% (319 of 457 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (457 of 457 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (463 of 463 strings)
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ar/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/he/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If507f0e03897d8580d9d8eb06050f4c5ef49ec56
With changes from 4e07514
Some elements without id were being listed (using their CSS classes)
and their corresponding SVG files were removed
This reverts those lines making sure that icons within insert shapes
menu or fontwork are not missing anymore.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4d1ad6a0f2124867ea47c8ca5c0c636aa5646143
With changes from 4e075146b9
4 problems were introduced, this fixes it:
- Writer > Form controls > insert date form control
- We were trying to alias with an already inexistent SVG
- Impress > layout tab > Master slides sidebar
- Typo: missing s in slides (masterslidespanel)
- Impress > top toolbar > Master slide sidebar
- Same as the previous one
- Calc > style apply (next to conditional)
- Typo: lc_ and .svg was being used
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I794dd0bbcb0593909a950e31413823a30f79bfad
We get stuck on exitting the app progressbar on mobile
with the interactive dialogs such as csv import or macro security
dialog, we have a different use case for killing the document
as in the normal case. We are not running a separate process
but a thread and we dont trigger regular killing use case.
This piece is not relevant for android because we always have
one connection through fakesocket until the main thread is killed
and it is waiting on the mutex to finish before we finally exit the
document activity.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I99bd333152d40a04f95d4747705a721112317bb2
This fix the follow issue
https://archive.org/download/mobile-wizard-generating-spans/mobile-wizard-generating-spans.png
but it also removes unnecessary css block related to all those span
elements associated with unotoolbutton. Better to avoid creating
the HTML element instead of creating and then hiding it.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4e9ea01456370f1f7f877de00cf1a57e15337f45
- This commit fixes#5052
- Files which were directly in `/browser/images` were the only ones I
considered in-scope for this (not files in `/browser/images/dark` as I
did not want any aliasing there to influence light theme)
- Files which weren't named `lc_*.svg` were not considered for this, as
the function with the alias list transformed the names into that
format
- Dupes were found with `find . ! -empty -type f -exec md5sum {} + | sort | uniq -w32 -d --all-repeated=separate`
It is possible (although unlikely) that there was a hash collision and
I incorrectly aliased an image. The names I was aliasing seemed sane
though, so I doubt this was the case.
- I changed the behavior of the aliases object such that it is *after*
the lowercasing of the name and not before; this was so that I didn't
have to worry about if capitals were used (as there were some SVGs
with different combinations of underscores etc. and I didn't want to
assume they all always needed to be in CamelCase)
Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I4d7972900195edeaa8f5f8941d18ab556319a7f7
- allow to use auto scrolling feature by event propagation
- it required to create new modified event which will
contain coordinates of the autofill marker
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic7fe236833f5e1747d0d72e9560d3c9ecdccde51
- Previously going into Help > About > View widgets would show a window
where the close button was rendered slightly out of the top of the
window
- This was because without the title taking up a line, the title bar
shrunk to be too small to contain the close button
- This commit makes sure that the title can never take up less than a
line in height
Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I9ead59711e3db3cde6af485ebcccf0b8a3ea57a5
When in interactive mode, the user has a dialog
to interact with. The issue is that the user may
dismiss said dialog, the Kit process may stop,
crash, or otherwise exit. This basically leaves
DocBroker in a deadlocked state, expecting
input from the interactive document, which
will never materialize.
Here, we rely on the machinery already in place
for flagging such a DocBroker that has no Kit.
We check for said flag and stop DocBroker if
such a case is detected, exiting clearly.
Change-Id: Iecb91c49226da08567cdd2c5d050d458e2f0fc9b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
