Commit graph

6662 commits

Author SHA1 Message Date
Tor Lillqvist
72dfbc9594 Our zoom step factor is 1.2, not 2 as in upstream
This change makes the zooming animation of the document while doing a
pinch gesture (closing and/or opening) match the finger movement much
better.

(But sure, there is till lots of weird jumping around after finishing
the pinch gesture.)

Change-Id: I9d5affe653c1a0ebaebced54629bc9e8d9de5854
Reviewed-on: https://gerrit.libreoffice.org/57089
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-07-07 00:01:28 +02:00
Tor Lillqvist
ed69ecf81f Add Emacs mode lines to get the indent level right
It's irritating to have to manually align lines even when just adding
temporary console.debug() calls. Sure, these mode lines should be
added in all .js files; these are just some I happened to be touching
now.

Change-Id: I13b3a62e66e4430878713fd64a459c72c014ded1
2018-07-05 16:05:31 +03:00
Tor Lillqvist
26b5a3745e Better and more dynamic way to show ruler conditionally
Use conditional CSS, setting the ruler height to zero if it would be
too high. Now the ruler even shows up and disappears dynamically as
the window height changes, for instance when turning a mobile device
between landscape and portrait orientation. No JS conditional needed
after all.

Change-Id: Iebfbd182d1675f4d6abd2f252389fdcdf46ed4d3
2018-07-04 16:44:46 +03:00
Tor Lillqvist
1800a8ee17 Decide whether to display a ruler based on ruler percentage of window height
If the ruler would be over 5% of the window height, don't display it.

Change-Id: Ieed55318fc76dfe0f9248985b816e306b6654dee
2018-07-04 16:00:58 +03:00
Tor Lillqvist
23c7c7d2a9 Don't show the ruler if the window has too small height
Of course, for this to really be worthy of being called "responsive"
web design, we should update this decision also if the window is
re-sized dynamically, like when a desktop browser's window is
arbitrarily re-sized by the user, or a mobile device is rotated
between portrait and landscape orientation, or a mobile device enters
or leaves some kind of split-screen mode where another application
than the browser shares the display.

Also, it would be nice if the window height limit used here, 1280, was
some kind of global variable. (For width limits used to detect mobile
devices, we use 768 or 768px here and there in our JS code. (And,
interestingly, 767px, too.) Ideally this 1280 and those 768s should be
defined in some common place. No idea how to do that correctly in
JavaScript.

Change-Id: I02bb54f309bc116ae1a0b5264e72b9ba674f56e4
Reviewed-on: https://gerrit.libreoffice.org/56936
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-07-04 13:29:46 +02:00
Andras Timar
3f0f2c671c loleaflet: no fill or automatic color handling in color picker
Change-Id: Iab98aadf54f0c1b041fe46eb2be1a798662d935b
2018-07-02 16:53:16 +02:00
Henry Castro
68ce5cac97 loleaflet: disable default context menu, part 2
Change-Id: I92548bffdfd96811155560b77ff28e49f3289ba4
2018-07-01 17:49:34 -04:00
Henry Castro
43a7b465bf lolefalet: mobile mode, hide tooltips
Change-Id: I0bc1f10184f63318c483b590139d570380a47222
Reviewed-on: https://gerrit.libreoffice.org/56421
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-07-01 17:47:13 -04:00
Henry Castro
276e367977 loleaflet: set bottom position of tooltip
Change-Id: I2ff39ce70df1f87788b7d5a1233cd97d2d0af5d7
Reviewed-on: https://gerrit.libreoffice.org/56392
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-07-01 17:43:36 -04:00
Henry Castro
22416fc45c loleaflet: disable the overflow buttons on the formula toolbar
Change-Id: I788625dd5c7fbd96372a19f3cdbcbefdddeb51c8
Reviewed-on: https://gerrit.libreoffice.org/56059
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/56783
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2018-07-01 23:41:05 +02:00
Jérémie Lesage
238b754f2b add docKey in documents response 2018-06-29 18:10:25 +01:00
Jérémie Lesage
f084ea53f6 Ensure all sessions have a sessionId and are subscribed.
Simplify constructors, and factor out subscription code.

Change-Id: I4f3ed1eb06abec193d6db1f7c78815ffe1e1b5aa
2018-06-29 18:10:03 +01:00
Jan Holesovsky
46b4c62139 Cell borders: Implement the 'More...' button.
Change-Id: I3551cec69cf1e4dca02c0fcdbee23a4e06b1e36a
2018-06-28 21:39:46 +02:00
Pranav Kant
8156c2a8f1 wsd: in case of multiple query param, handle &attachment= correctly
In case of integration with OC/NC, we have WOPISrc= as query param used
for load balancing. So, the earlier approach failed with integration.

Change-Id: Ib73f4f18eaec870dd53b67886b1b6016416a2e78
Reviewed-on: https://gerrit.libreoffice.org/56531
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-06-28 18:45:57 +02:00
Marco Cecchetti
1580639831 On-demand loading of the page previews in the Online Draw/Impress
Change-Id: I56b1febd7f57324e878f06d417d2f58754e850fc
Reviewed-on: https://gerrit.libreoffice.org/56275
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2018-06-28 18:01:01 +02:00
Jan Holesovsky
9d4469a79b borders: This has to be global in order to have the event working.
Change-Id: I7a1f52c825905f4fe0ba33fdfd16cf979e3d378d
2018-06-20 13:31:04 +02:00
Andras Timar
a2a6c5990c fix indentation issues
Change-Id: I565fe5e46daa5c41d7ee0dc6921fd7d2039c4287
2018-06-20 13:31:04 +02:00
Jan Holesovsky
314164fa39 borders: Send .uno:SetBorderStyle with the appropriate params to the core.
Change-Id: I703dda35d3b412ff60602a6802b260d8709762fd
Reviewed-on: https://gerrit.libreoffice.org/56093
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-20 13:31:04 +02:00
Jan Holesovsky
8309734edd borders: Improve the look.
Change-Id: Ib7ca90285bb012a09f5fd2d867a3d588e831ec3a
Reviewed-on: https://gerrit.libreoffice.org/56092
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-20 13:31:04 +02:00
Henry Castro
77e913e46a loleaflet: add cell borders in Calc
Change-Id: I0105ee6c98b0eb043b60b56ea80007bae967df90
Reviewed-on: https://gerrit.libreoffice.org/56091
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-20 13:31:04 +02:00
Andras Timar
62a547cf52 loleaflet: updated UI pot file
Change-Id: Ia6c570b4d65d19e6fc3a0bfbcfd2c3479433030b
2018-06-19 09:42:59 +02:00
Adolfo Jayme Barrientos
f17a2d5f50 tdf#117496 Drop the word “Microsoft” per design team decision
Change-Id: I53206c0c2e94d2620b62e980ae9b90d9933bef1c
Reviewed-on: https://gerrit.libreoffice.org/54407
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-06-19 09:40:35 +02:00
Michael Meeks
a521527777 Fix logging a little.
Change-Id: I858ffb40e071eae3907eeff9c2d6291fd805dc02
2018-06-15 17:38:12 +01:00
Tamás Zolnai
30e4f586ec Hide text cursor while performing the zoom
Change-Id: Ic358b2f345ba4e1e1d826b6e2cc96b3cc53269d6
Reviewed-on: https://gerrit.libreoffice.org/55881
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-06-15 17:38:20 +02:00
Michael Meeks
7e6e81eb46 Implement client websocket masking.
Disable this for easy strace debugging and a bit of perf. to the forkit.

Change-Id: Ia330582817481410d26df50db5eb42b4692ad01c
2018-06-15 14:54:19 +01:00
Michael Meeks
5741d76a5d Outgoing websocket - remove silly stuff.
Change-Id: I53d763158007221e9df327ec9d3b07ad2029cbfd
2018-06-15 14:54:19 +01:00
Andras Timar
1fd5dbd787 Do not use the word 'Error' here (tinderbox)
Change-Id: If5bbfceb624974801ffb84e52e6aa1b7e599a7ae
2018-06-15 15:14:14 +02:00
Andras Timar
6c42c2bc91 redirect stderr of find to /dev/null, non existing search paths can be ignored
Change-Id: Icf2a77f8cd78da2f9d4ff7adc11308cb96464e65
2018-06-15 15:04:25 +02:00
Andras Timar
3984206b69 No need to load l10n framework for a page that appears for fragment of a second
Change-Id: Id23ab66fadb714316cdf73e93501b0cea870880d
Reviewed-on: https://gerrit.libreoffice.org/55850
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-06-15 12:34:16 +02:00
Andras Timar
bf0e286cc9 Use absolute path to load unitlibs
I had a scenario when they were not found (tinderbox).

Change-Id: I48f40b62f74a1ffbab64ad9a9b677f8cf66a1232
2018-06-15 08:34:06 +02:00
Andras Timar
b88b7d3aff typo fix
Change-Id: I6a7cc26ff19ece8e2711062bd9a732ebab7b764f
2018-06-14 23:35:53 +02:00
Andras Timar
fc7f9f212b typo fixes
Change-Id: I5f932db7e7d615d98ff569b3cb2f2d4e3fcc63f1
2018-06-14 19:43:47 +02:00
Ashod Nakashian
b9db83518b wsd: warn when we have no kits and we are not exiting just yet
Change-Id: I8c19dcea3eb900a989aebac7ef96793af31bdce8
Reviewed-on: https://gerrit.libreoffice.org/55576
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-14 17:05:46 +02:00
Jan Holesovsky
b65894b287 Avoid crash in the non-wopi case.
Change-Id: I87aff462dab4abca0235622493f720eacbc39f03
Reviewed-on: https://gerrit.libreoffice.org/53448
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-14 17:01:02 +02:00
Ashod Nakashian
b3bdd5786d wsd: support optional forcing tracking changes at load
Since changing the tracking state is done by toggling,
we need to wait to get the current state at load time
before we can tell whether we need to toggle it or not.

Change-Id: Ib5a2639b2acf3874c191971eedf9a3bebcefebad
Reviewed-on: https://gerrit.libreoffice.org/53415
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-14 17:00:39 +02:00
Ashod Nakashian
d3d4812583 wsd: localize variables
Change-Id: I411e435fa2360423b4c48d087eb501b942cc637d
Reviewed-on: https://gerrit.libreoffice.org/52419
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-14 16:52:49 +02:00
Ashod Nakashian
fbc8681406 wsd: refactor diskpace and session limit checks
Checks are now done after adding new sessions
to DocBroker rather than before, so the current
session being added doesn't need special handling.

The checks for diskspace is separated from that
of the number of sessions as they are unrelated.

Also, no reason to do the checks for convert-to
requests, since these don't have interactive
clients, rather the connections are closed after
the conversion.

Change-Id: Idc50cd38263e6779acdeed72d5eb876a3228c96e
Reviewed-on: https://gerrit.libreoffice.org/52418
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-14 16:08:47 +02:00
Aron Budea
945930efdf Admin console: correct network graph colors
Change-Id: I24c700c29998a15c7b25d06ba228d191de26c26c
Reviewed-on: https://gerrit.libreoffice.org/55701
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2018-06-12 16:44:51 +02:00
Ashod Nakashian
93b41638a5 wsd: reduce indentation
Change-Id: Id8cda0980d332eb751fbb2708b9075296bf15a0b
Reviewed-on: https://gerrit.libreoffice.org/52417
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-11 22:17:49 +02:00
Ashod Nakashian
18750d2d39 wsd: warn for invalid file requests by clients instead of error
Also, logs append new-line automatically.

Change-Id: Ie5b09e454236cab2cdaa14d6f8be7b67e8fb1000
Reviewed-on: https://gerrit.libreoffice.org/52416
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-11 22:17:04 +02:00
Ashod Nakashian
3d6e373992 wsd: reduce lock scope and log diskspace checks
Change-Id: If093670ae83de5596a86a116ba6224aa0badbcbe
Reviewed-on: https://gerrit.libreoffice.org/52415
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-11 22:15:57 +02:00
Tamás Zolnai
d35fb55511 Zooming in for the first time shows tiles appearing instead of interpolation
Drop only those tiles which are not part of the new visible area.

Change-Id: I4cf86266b4f51cd7e96b9db10da108f644ecdceb
Reviewed-on: https://gerrit.libreoffice.org/55467
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-06-08 17:24:25 +02:00
Tor Lillqvist
72baaa231c We seemed to have just two minor ASCII art instances, actually
Change-Id: I308cda537c26b1a9976e7bcf7634c67917a30163
2018-06-08 08:42:31 +03:00
Jan Holesovsky
814d266eca Make sure we have enough space for the insert table grid.
Change-Id: I9c6cf2b038663bc68098b6abf4c7c69599ebe070
2018-06-07 22:10:11 +02:00
Henry Castro
76ce2ffe4f loleaflet: disable context menu on toolbar
Change-Id: If1161ec2725ec1bb4d8dd1b497fc3f4662ba7cc9
2018-06-07 08:48:05 -04:00
Jan Holesovsky
ed3739c8f1 Don't use colons here.
Change-Id: If838a44d766ab70ac5c7efc904eec37a8131554c
2018-06-07 13:20:33 +02:00
Adolfo Jayme Barrientos
659f014c9b Favicon refresh
From Andreas’ shiny new icons, generated with icotool.
16 × 16 and 32 × 32.

Change-Id: Id44e97d698fd37bfdcbecd536de4c1b07d644949
2018-06-06 03:18:13 -05:00
Jan Holesovsky
ce5fefcb5d Need a way to test the branding even in the debug mode.
Change-Id: Ia1d082a05393b298cd009a256b1a708e924097b9
Reviewed-on: https://gerrit.libreoffice.org/55290
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-04 20:15:23 +02:00
Jan Holesovsky
daf2915ab5 Align the first toolbar item with the text of the File menu.
Change-Id: I5abe99f2394f95c60274e274c5470899b0d77172
Reviewed-on: https://gerrit.libreoffice.org/55292
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2018-06-04 20:11:26 +02:00
Tor Lillqvist
b7de2865dc Fix warning: private field '_isSSL' is not used [-Werror,-Wunused-private-field]
Change-Id: Iddf8ac7f0afa85559b03b980a558d9a4fd058473
2018-06-01 16:42:37 +03:00